Re: [patch v2 1/6] tty: export tty_open_by_driver

2017-05-20 Thread Christoph Hellwig
On Mon, May 15, 2017 at 06:45:32PM +0100, Okash Khawaja wrote: > This exports tty_open_by_driver so that it can be called from other places > inside the kernel. The checks for null file pointer are based on Alan Cox's > patch here: > http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg12

Re: [PATCH v3 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-20 Thread Andy Lutomirski
On 05/19/2017 07:09 AM, Vitaly Kuznetsov wrote: Hyper-V host can suggest us to use hypercall for doing remote TLB flush, this is supposed to work faster than IPIs. Implementation details: to do HvFlushVirtualAddress{Space,List} hypercalls we need to put the input somewhere in memory and we don't

Re: [PATCH v3 04/10] x86/hyper-v: fast hypercall implementation

2017-05-20 Thread Andy Lutomirski
On 05/19/2017 07:09 AM, Vitaly Kuznetsov wrote: Hyper-V supports 'fast' hypercalls when all parameters are passed through registers. Implement an inline version of a simpliest of these calls: hypercall with one 8-byte input and no output. Proper hypercall input interface (struct hv_hypercall_inp

Re: [PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

2017-05-20 Thread Stefan Wahren
> Stefan Wahren hat am 20. Mai 2017 um 14:22 > geschrieben: > > > Since the ARM side of VCHIQ support only 1 state, we could simplify > the init code. This makes it possible to avoid BUG_ON and a theoretical > overflow of id. > > Signed-off-by: Stefan Wahren It should be Stefan Wahren ___

Re: [PATCH 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

2017-05-20 Thread Stefan Wahren
> Stefan Wahren hat am 20. Mai 2017 um 14:22 > geschrieben: > > > Use the PAGE_MASK instead of open code it. > > Signed-off-by: Stefan Wahren Sorry, for the typo in the mail address. ___ devel mailing list de...@linuxdriverproject.org http://drive

[PATCH] staging-next: wlan-ng: resolve checkpatch issues

2017-05-20 Thread Ranjit W
fixing following checkpatch warning wherever possible: WARNING: line over 80 characters Signed-off-by: Ranjit W --- drivers/staging/wlan-ng/cfg80211.c | 11 --- drivers/staging/wlan-ng/hfa384x.h | 21 ++--- drivers/staging/wlan-ng/p80211netdev.c | 3 ++- 3 files

Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-20 Thread Brian Masney
On Sat, May 20, 2017 at 06:55:02PM +0100, Jonathan Cameron wrote: > On 19/05/17 10:37, surenderpols...@gmail.com wrote: > >From: Surender Polsani > > > >Fixed the following checkpatch.pl warnings: > >octal permissions are more preferable than symbolic permissions > > > >Replaced DEVICE_ATTR family

[PATCH 6/6] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

2017-05-20 Thread Jaya Durga
Fixed coding style issue Renamed cap_Privacy to cap_privacy Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- drivers/staging/rtl8712/wifi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging

[PATCH 5/5] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

2017-05-20 Thread Jaya Durga
Fixed coding style issue Renamed cap_ShortPremble to cap_short_premble Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 2 +- drivers/staging/rtl8712/wifi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/driv

Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as per coding style

2017-05-20 Thread Jonathan Cameron
On 19/05/17 10:37, surenderpols...@gmail.com wrote: From: Surender Polsani Fixed the following checkpatch.pl warnings: octal permissions are more preferable than symbolic permissions Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family as suggested by Greg K-H. Changed attributes and

[PATCH] staging: vt6655: add spaces around '%' operator

2017-05-20 Thread Marko Stankovic
Fix checkpatch issue by adding spaces around the '%' operator Signed-off-by: Marko Stankovic --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 5463cf869d1b..f5db2b3d9045 100644

[GIT PULL] Staging driver fixes for 4.12-rc2

2017-05-20 Thread Greg KH
The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.12-rc2 for you to fetch changes up to 66ea5974b36

[PATCH 12/16] staging: vchiq_core: Bail out if service is NULL

2017-05-20 Thread Stefan Wahren
In the unlikely case that service is NULL we should bail out instead of calling BUG_ON(). The other BUG_ON calls will be fixed in separate patches. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 38 ++ 1 file changed, 24 insertions(+), 1

[PATCH 00/16] staging: vchiq_arm: several cleanups

2017-05-20 Thread Stefan Wahren
This patch series addresses mostly minor issues. It based on top of the latest vchiq bugfix [1]. [1] - https://lkml.org/lkml/2017/5/4/228 Stefan Wahren (16): staging: vchiq_core: Use return value of mutex_lock_killable directly staging: vchiq_2835_arm: Reduce scope of i in free_pagelist sta

[PATCH 13/16] staging: vchiq_core: Bail out if ref_count is unexpected

2017-05-20 Thread Stefan Wahren
If the ref counter of service has an unexpected value then we better bail out. Signed-off-by: Stefan Wahren --- .../vc04_services/interface/vchiq_arm/vchiq_core.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vc04_services/interface/v

[PATCH 09/16] staging: vchiq_core: Simplify VCHIQ init

2017-05-20 Thread Stefan Wahren
Since the ARM side of VCHIQ support only 1 state, we could simplify the init code. This makes it possible to avoid BUG_ON and a theoretical overflow of id. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 06/16] staging: vchiq_2835_arm: Fix function name cleaup_pagelistinfo

2017-05-20 Thread Stefan Wahren
Assuming the intension of the function is to clean up, so fix the function name accordingly. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vc04_service

[PATCH 11/16] staging: vchiq_core: Don't BUG if sending RESUME fails

2017-05-20 Thread Stefan Wahren
VCHIQ suspend and resume isn't implemented, but even it was there is no need to call BUG(). Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_c

[PATCH 16/16] staging: vchiq_core: Replace remaining BUG_ON with WARN_ON

2017-05-20 Thread Stefan Wahren
This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vc

[PATCH 15/16] staging: vchiq_core: Bail out in case of invalid tx_pos

2017-05-20 Thread Stefan Wahren
Properly handle the error case in case of an invalid tx_pos. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b

[PATCH 14/16] staging: vchiq_core: Don't BUG if process is unexpected

2017-05-20 Thread Stefan Wahren
Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 11 +++

[PATCH 10/16] staging: vchiq_core: Bailout if VCHIQ state is already initialized

2017-05-20 Thread Stefan Wahren
In case VCHIQ state is already initialized we need to bailout in order to aovid a memory leak. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_ar

[PATCH 04/16] staging: vchiq_arm: Fix variable names in comment

2017-05-20 Thread Stefan Wahren
This comment was apparently forgotten in the correction of CamelCase. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

[PATCH 05/16] staging: vchiq_arm: Avoid multiline dereference

2017-05-20 Thread Stefan Wahren
Reduce the indentation within vchiq_dump_service_use_state in order to avoid a multiline dereference. Signed-off-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc0

[PATCH 03/16] staging: vchiq_2835_arm: Remove unnecessary assignment to slot_mem_size

2017-05-20 Thread Stefan Wahren
The variable slot_mem_size is assigned a value which is never used. This issue has been found by CppCheck. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interfac

[PATCH 07/16] staging: vchiq_2835_arm: Handle vmalloc_to_page error case

2017-05-20 Thread Stefan Wahren
In case vmalloc_to_page returns NULL create_pagelist must abort immediately. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_a

[PATCH 08/16] staging: vchiq_2835_arm: Use PAGE_MASK macro

2017-05-20 Thread Stefan Wahren
Use the PAGE_MASK instead of open code it. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging

[PATCH 02/16] staging: vchiq_2835_arm: Reduce scope of i in free_pagelist

2017-05-20 Thread Stefan Wahren
We can reduce the scope of the counting variable i. This has been found by CppCheck. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/v

[PATCH 01/16] staging: vchiq_core: Use return value of mutex_lock_killable directly

2017-05-20 Thread Stefan Wahren
Instead of saving the return value of mutex_lock_killable in a local variable we could use the value directly. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vc