Fix warning issued by sparse:
incorrect type in assignment (different address spaces).
Signed-off-by: Paolo Cretaro
---
drivers/staging/lustre/lnet/lnet/lib-socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c
b/drivers/stagi
Fix warnings issued by sparse:
symbol 'gmin_v1p2_ctrl' was not declared. Should it be static?
symbol 'gmin_v1p8_ctrl' was not declared. Should it be static?
symbol 'gmin_v2p8_ctrl' was not declared. Should it be static?
symbol 'gmin_flisclk_ctrl' was not declared. Should it be static?
Signed-off-b
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki
---
drivers/staging/ks7010/ks_hostif.c | 26 +-
drivers/staging/ks7010/ks_hostif.h | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging
Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Janusz Lisiecki
Conflicts:
drivers/staging/ks7010/ks_hostif.h
---
drivers/staging/ks7010/ks_hostif.c | 26 +-
drivers/staging/ks7010/ks_hostif.h | 2
This patchset fix CamelCases in ks7010 driver except michael_mic
which will be replaced by kernel implementation in the future.
---
v2:
- Rebased all patches to next-20170512. 2 and 8 should apply cleanly now
v3:
- Rebased all not yet applied patched to staging-testing branch
of gregkh/staging
On 15/05/17 05:38, harinath Nampally wrote:
Jonathan,
Thank you for letting me know about correct iio git tree.
I checked out 'togreg' branch, and noticed that
latest ade7758_core.c still has checkpatch.pl warnings.
Actually Quentin Swain fixed the similar warnings in the ade7854.c,
and my pat
On Tue, May 16, 2017 at 2:45 PM, Greg KH wrote:
> On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
>> Fixed a warning : struct comedi_lrange is generally constant.
>>
>> Signed-off-by: Srishti Sharma
>
> As Dan pointed out, you _HAVE_ to test-build your changes.
>
> Also, your "From:" lin
From: Laurentiu Tudor
On 32-bit book-e machines, hugepd_ok() does not take
into account null hugepd values, causing this crash at boot:
Unable to handle kernel paging request for data at address 0x8000
Faulting instruction address: 0xc00182a8
Oops: Kernel access of bad area, sig: 11 [#1]
SMP
> On 16 May 2017, at 13:28, Greg Kroah-Hartman
> wrote:
>
>> On Tue, May 16, 2017 at 01:19:10PM +0100, Okash Khawaja wrote:
>> Hi,
>>
>> On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
>> wrote:
>>> On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
This patch fixes the i
Fix style in rxtx.c, removing extra empty blank lines.
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 24c7308..a44abcc 100644
--- a/drivers/stagin
Fix style in rxtx.c, breaking all multiple assignments in different
lines.
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rx
On Tue, May 16, 2017 at 02:18:13PM +0200, Karim Eshapa wrote:
> Change p80211_caphdr structure args types to __be.. to be
> compatible with byte ordering of the network.
> and in hfa384x_usb.c make calculations with respect to machine.
>
> Signed-off-by: Karim Eshapa
> ---
> drivers/staging/wlan
On Tue, May 16, 2017 at 01:19:10PM +0100, Okash Khawaja wrote:
> Hi,
>
> On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
> wrote:
> > On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
> >> This patch fixes the issue where TTY-migrated synths would take a while to
> >> shut up af
Hi,
On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman
wrote:
> On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
>> This patch fixes the issue where TTY-migrated synths would take a while to
>> shut up after hitting numpad enter key. When calling synth_flush, even
>> though XOFF
Change p80211_caphdr structure args types to __be.. to be
compatible with byte ordering of the network.
and in hfa384x_usb.c make calculations with respect to machine.
Signed-off-by: Karim Eshapa
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
drivers/staging/wlan-ng/p80211conv.h | 28 ++
On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote:
> This patch fixes the issue where TTY-migrated synths would take a while to
> shut up after hitting numpad enter key. When calling synth_flush, even though
> XOFF character is sent as high priority, data buffered in TTY layer is stil
On Mon, May 15, 2017 at 08:55:45PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase variable name with underscores to comply
> with the standard kernel coding style.
>
> Signed-off-by: Janusz Lisiecki
> ---
> drivers/staging/ks7010/ks_hostif.c | 26 +-
> drivers/staging/
On Mon, May 15, 2017 at 02:04:57PM +0200, Karim Eshapa wrote:
> Change p80211_caphdr structure args types to __be.. to be
> compatible with byte ordering of the network.
> and in hfa384x_usb.c make calculations with respect to machine.
>
> Signed-off-by: Karim Eshapa
> ---
> drivers/staging/wlan
On Mon, May 15, 2017 at 11:14:03PM +0900, Juan Manuel Torres Palma wrote:
> Fix coding style, including breaking too long lines, multiple
> assignments in same line and empty lines.
That's a lot of different things to be doing all in the same patch.
Please break this up into "one logical thing pe
On Tue, May 16, 2017 at 11:20:16AM +0200, Matej Dujava wrote:
> Folowing patch set cleans some warnings and checkups from checkpatch.pl
> and also fix code to better fot linux code style.
>
> Changes since v2 [1]:
>
> * staging: sm750fb: unifying macro usage and definitions
> * move definit
The new driver cannot link correctly when the netdevice infrastructure
is disabled:
ERROR: "netdev_info" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko]
undefined!
ERROR: "skb_to_sgvec" [drivers/staging/fsl-dpaa2/ethernet/fsl-dpaa2-eth.ko]
undefined!
ERROR: "napi_disable" [drivers/staging/
This patch removes typedefs from enum and renames it from "typedef enum
_disp_output_t" to "enum disp_output" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_display.c | 2 +-
drivers/staging/sm750fb/ddk750_display.h | 8
drivers/staging/sm
This patch removes typedefs from enum and renames it from "typedef enum
_sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel
coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_sii164.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.h | 4 ++--
2 file
This patch removes typedefs from enum and renames it from
"typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_power.c | 2 +-
drivers/staging/sm750fb/ddk750_power.h | 7 +++
2 files changed, 4 insertions(+), 5 d
This patch adds tabs into macro definitions so all rhs are on same column.
Move MHz macro from ddk_chip.c to ddk_chip.h.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c| 18
drivers/staging/sm750fb/ddk750_chip.h| 5 +-
drivers/staging/sm750fb/ddk750_displa
This patch removes typedefs from enum and renames it from "typedef enum
_clock_type_t" to "enum clock_type" as per kernel coding standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.h | 8
drivers/staging/sm750fb/ddk750_mode.c | 2 +-
drivers/staging/sm750fb/dd
This patch removes typedefs from enum and renames it from "typedef enum
_logical_chip_type_t" to "enum logical_chip_type" as per kernel coding
standards.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
drivers/staging/sm750fb/ddk750_chip.h | 8
2 files ch
This patch breaks lines that are longer than 80 characters and joins
together those, that are too short and can be placed at one.
Function calls and declarations are updated to fit kernel code style.
Signed-off-by: Matej Dujava
---
drivers/staging/sm750fb/ddk750_chip.c | 7 +++--
drivers/sta
Folowing patch set cleans some warnings and checkups from checkpatch.pl
and also fix code to better fot linux code style.
Changes since v2 [1]:
* staging: sm750fb: unifying macro usage and definitions
* move definition of MHZ macro from c file to header.
[1] https://lkml.org/lkml/2017/5/
On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
> Fixed a warning : struct comedi_lrange is generally constant.
>
> Signed-off-by: Srishti Sharma
As Dan pointed out, you _HAVE_ to test-build your changes.
Also, your "From:" line didn't match your signed-off-by line, so I
couldn't accep
Since this driver does no detection of hardware, it might be used with
a non-sir port. Escape out if we are spinning.
Signed-off-by: Sean Young
---
drivers/media/rc/sir_ir.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c
index e12e
Compile test your patches.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Fixing 'checkpatch.pl' ERROR: code indent should use tabs where possible
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_aead.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/stagin
Fixed a warning : struct comedi_lrange is generally constant.
Signed-off-by: Srishti Sharma
---
drivers/staging/comedi/comedidev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 1bb9986..82df090 1
fix the following sparse warning:
drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment
(different base types) drivers/staging/fbtft/fbtft-io.c:74:29:expected
unsigned long long [unsigned] [long] [long long] [usertype]
drivers/staging/fbtft/fbtft-io.c:74:29:got
On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote:
> Fixing coding guideline errors reported by 'checkpatch.pl'
That is very "vague", you are going to have to be specific here.
Also remember you can only do "one type of thing" per patch, and no,
"fix all warnings" is not one type
Fixing coding guideline errors reported by 'checkpatch.pl'
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ccree/ssi_cipher.c | 158 +++--
1 file changed, 80 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/c
Remove the remaining timesync bits that were left in the arche platform
driver and which prevented the driver from being compiled.
Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support")
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/arche-apb-ctrl.c | 11 +--
driver
Add Arche platform-driver config option and allow the driver to be
compile tested also without the out-of-tree usb3613 driver.
Signed-off-by: Johan Hovold
---
drivers/staging/greybus/Kconfig | 10 ++
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/arche
The arche driver currently depends on the out-of-tree usb3613 driver and
this prevented a recent compile breakage after removing the timesync
code from being detected.
These patches remove the remaining timesync bits, and enable compile
testing of the arche driver to avoid further unintended break
On Tue, May 16, 2017 at 03:42:27PM +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou
Your subject is a bit messed up :(
Please fix and resend.
No need for the 0/1 email for just a single patch.
thanks,
greg k-h
___
devel mailing list
de...@linuxdri
On Mon, May 15, 2017 at 05:10:18PM +0300, Haim Daniel wrote:
> -remove duplicate tty allocation code for serial and printer drivers.
> -add missing tty c_ispeed and c_ospeed initialization to 9600.
> -fix sparse warning: too long initializer-string for array of char.
This is a GCC warning and not
On Mon, May 15, 2017 at 04:49:16PM +0300, Haim Daniel wrote:
> me@haim-toshiba1 ~ $ dpkg -l sparse
> Desired=Unknown/Install/Remove/Purge/Hold
> |
> Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
> |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
> ||/ Name
On Mon, May 08, 2017 at 08:13:37PM +0800, kernel test robot wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> commit e66267161971155a8b4756b4e17f2f2f82b9f842
> Author
On Mon, May 15, 2017 at 10:22:15PM +0100, Bryan O'Donoghue wrote:
> On 15/05/17 17:10, Johan Hovold wrote:
> > On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote:
> >> On 15/05/17 15:26, Johan Hovold wrote:
> >>> Remove the remaining timesync bits that were left in the arche platform
fix the sparse warning:
drivers/staging/fbtft/fbtft-io.c:74:29:
warning: incorrect type in assignment (different base types)
drivers/staging/fbtft/fbtft-io.c:74:29:expected unsigned long
long [unsigned] [long] [long long] [usertype]
drivers/staging/fbtft/fbtft
Signed-off-by: Jandy Gou
---
drivers/staging/fbtft/fbtft-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index d868405..ffb9a3b 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fb
On Mon, May 15, 2017 at 09:49:51AM -0700, Randy Dunlap wrote:
> On 05/15/17 07:26, Johan Hovold wrote:
> > Add Arche platform-driver config option and allow the driver to be
> > compile tested also without the usb3613 driver.
> >
> > Signed-off-by: Johan Hovold
> > ---
> > drivers/staging/greybu
Signed-off-by: Jandy Gou
---
drivers/staging/fbtft/fbtft-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index d868405..ffb9a3b 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fb
50 matches
Mail list logo
