[PATCH] drivers/staging/ccree: Removing trailing whitespaces

2017-05-14 Thread Pushkar Jambhlekar
Fixing 'checkpatch.pl' warnings: Trailing whitespaces Signed-off-by: Pushkar Jambhlekar --- drivers/staging/ccree/ssi_cipher.c | 110 ++--- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/

Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

2017-05-14 Thread harinath Nampally
Jonathan, Thank you for letting me know about correct iio git tree. I checked out 'togreg' branch, and noticed that latest ade7758_core.c still has checkpatch.pl warnings. Actually Quentin Swain fixed the similar warnings in the ade7854.c, and my patch is fix for similar warnings but it is for d

Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

2017-05-14 Thread harinath Nampally
Jonathan, Thank you for letting me know about correct iio git tree. I checked out 'togreg' branch, and noticed that latest ade7758_core.c still has checkpatch.pl warnings. Actually Quentin Swain fixed the similar warnings in the ade7854.c, and my patch is fix for similar warnings but it is for d

Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.

2017-05-14 Thread harinath Nampally
Jonathan, Thank you for letting me know. In future I will work on 'togreg' branch of iio.git tree to send my patches. Thanks, Harinath On Sun, May 14, 2017 at 11:29 AM, Jonathan Cameron wrote: > On 10/05/17 00:41, Harinath Nampally wrote: >> >> This patch fixes below kind of warnings: >> WARNIN

[PATCH] staging: fsl-mc: Fix code alignment style issues

2017-05-14 Thread Brett Hitchcock
Fixing recommendation from checkpatch.pl: "CHECK: Alignment should match open parenthesis" Signed-off-by: Brett Hitchcock --- drivers/staging/fsl-mc/bus/dprc-driver.c | 4 ++-- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/d

linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966: cart before the horse ?

2017-05-14 Thread David Binderman
Hello there, linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966]: (style) Array index 'i' is used before limits check. Source code is while (szLine[i] != '{' && i < strlen(szLine)) i++; Regards David Binderman ___

linux-4.12-rc1/drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h:76: cart before the horse ?

2017-05-14 Thread David Binderman
Hello there, linux-4.12-rc1/drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h:76]: (style) Array index 'ix' is used before limits check. Source code is for (ix=0; ((src_str[ix] != '\0') && (ix< max_len)); ++ix) /*Nothing else to do*/;

[PATCH] drivers/staging: refactor dgnc tty registration.

2017-05-14 Thread Haim Daniel
-remove duplicate tty allocation code for serial and printer drivers. -fix sparse warning: too long initializer-string for array of char. Signed-off-by: Haim Daniel --- drivers/staging/dgnc/dgnc_driver.h | 13 drivers/staging/dgnc/dgnc_tty.c| 137 ++---

Re: [PATCH] staging: iio: meter: ade7854: Fix symbolic permissions to octal permissions

2017-05-14 Thread Jonathan Cameron
On 08/05/17 21:10, eddi1983 wrote: From: Christoph Fanelsa Fixed the checkpatch warnings (task #10 of eudyptula challenge) of prefered octal permissions over symbolic ones Signed-off-by: Christoph Fanelsa Cc: Michael Hennerich Cc: Jonathan Cameron Cc: Hartmut Knaack Cc: Peter Meerwald-Stad

Re: [PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions.

2017-05-14 Thread Jonathan Cameron
On 10/05/17 00:41, Harinath Nampally wrote: This patch fixes below kind of warnings: WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred. Below errors are false positives: ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal

Re: [PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments.

2017-05-14 Thread Jonathan Cameron
On 10/05/17 00:41, Harinath Nampally wrote: This patch fixes below checkpatch.pl kind of warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Harinath Nampally Good patch and well described. Applied this one (without patch 1) to the togreg branch of https://git.kernel.org/p

Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition.

2017-05-14 Thread Jonathan Cameron
On 10/05/17 00:41, Harinath Nampally wrote: This patch fixes below checkpatch.pl warning: CHECK: struct mutex definition without comment Signed-off-by: Harinath Nampally They description is no longer correct. This moves a comment rather than adding one. J --- Changes in v2: - Removed the e

Re: [PATCH v2 0/3] coding style warnings fixes

2017-05-14 Thread Jonathan Cameron
On 10/05/17 00:41, Harinath Nampally wrote: This revised patchset is for improvement in [PATCH v2 1/3] as per the code review comment from Dan Carpenter. Other two patches [PATCH v2 2/3] and [PATCH v2 3/3] are unchanged, so they are same as [PATCH 2/3] and [PATCH 3/3] respectively. Please find

Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

2017-05-14 Thread Jonathan Cameron
On 12/05/17 22:19, Harinath Nampally wrote: This patch fixes below kind of warnings: WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred. Issue found and fixed by checkpatch.pl Signed-off-by: Harinath Nampally Already done by Quentin Swain last month... For IIO related patches

Re: [PATCH 12622/12622] Staging: ccree: ssi_cipher: fix brace coding style issue

2017-05-14 Thread Greg KH
On Sat, May 13, 2017 at 02:45:03PM +0300, Ammly Fredrick wrote: > Fixed some coding style issues after running scripts/checkpatch.pl > > Fixed spelling in ssi_blkcipher_complete(), should be counter not couter. > > Signed-off-by: Ammly Fredrick I don't see the 12621 other patches in this series