[PATCH v2] staging: rtl8188eu: fix indentation error

2017-05-12 Thread Remco Verhoef
Fixes a 'code indent should use tabs where possible' checkpatch code style error by changing whitespace into tabs. Signed-off-by: Remco Verhoef --- Changes in v2: - More expressive commit message and subject drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- 1 file changed, 1 insertion(+

[PATCH] staging: vt6656: Break too long lines

2017-05-12 Thread Juan Manuel Torres Palma
Fix style in rxtx.c splitting lines into 80 characters or less. Signed-off-by: Juan Manuel Torres Palma --- drivers/staging/vt6656/rxtx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index

[PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

2017-05-12 Thread Harinath Nampally
This patch fixes below kind of warnings: WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred. Issue found and fixed by checkpatch.pl Signed-off-by: Harinath Nampally --- drivers/staging/iio/meter/ade7758_core.c | 50 1 file changed, 25 insertions(+

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-12 Thread Alan Cox
On Fri, 12 May 2017 20:35:18 +0100 Okash Khawaja wrote: > On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote: > > On Thu, 11 May 2017 09:29:14 +0100 > > Okash Khawaja wrote: > > > > > Hi Alan, > > > > > > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > > > > + if (!

[PATCH v3 2/3] staging: typec: fusb302: reset i2c_busy state in error

2017-05-12 Thread Rui Miguel Silva
Fix reset of i2c_busy flag if an error occurs during the i2c block read. Signed-off-by: Rui Miguel Silva --- drivers/staging/typec/fusb302/fusb302.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/

[PATCH v3 1/3] staging: typec: fusb302: do not free gpio from managed resource

2017-05-12 Thread Rui Miguel Silva
When allocating a gpio using the managed resource devm_, we can avoid freeing it manually. But even if we did it we should use devm_gpio_free. So, just remove the free of the gpio in the error path. Signed-off-by: Rui Miguel Silva Acked-by: Yueyao Zhu Reviewed-by: Guenter Roeck --- drivers/st

[PATCH v3 3/3] staging: typec: fusb302: refactor resume retry mechanism

2017-05-12 Thread Rui Miguel Silva
The i2c functions need to test the pm_suspend state and do, if needed, some retry before i2c operations. This code was repeated 4x. To isolate this, create a new function to check suspend state and call it in every need place. As at it, move the error message from pr_err to dev_err. Signed-off-b

[PATCH v3 0/3] staging: typec: fusb302: some fixes and cleanups

2017-05-12 Thread Rui Miguel Silva
This series fixes some bugs in the error paths and do some refactoring in the resume retry mechanism. No new functionality is added and I do *not* have the hw to test it. So, if you have the hw give it a try. v2->v3: add tags to patch 1/3 Yueyao Zhu: - fix patch 2/3 that got broken from v1->v2

Re: [PATCH v2 2/3] staging: typec: fusb302: reset i2c_busy state in error

2017-05-12 Thread Rui Miguel Silva
Hi Yueyao, On Fri, May 12, 2017 at 12:22:44PM -0700, Yueyao Zhu wrote: Thanks for the catch! With the fix, should the `done` label be added before atomic_set(&chip->i2c_busy, 0); ? Urgh, yeh, it was correct in v1 but on the revert of the logging patch something got broken. Thanks, v3 in the wa

Re: [PATCH] staging: rtl8192u: Convert __le16 to cpu before casting to u32

2017-05-12 Thread Guillaume Brogi
> > Since there was no news for a while, I figured I'd ask what's the status > > of this patch. I hope that's OK. Has it simply been forgotten or is > > there something blocking/unacceptable? > > I don't see it in my queue, sorry. If you can't test this, or verify > that it is correct some other

[patch v2 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-12 Thread Okash Khawaja
This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synt

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

2017-05-12 Thread Okash Khawaja
On Thu, May 11, 2017 at 02:33:14PM +0100, Alan Cox wrote: > On Thu, 11 May 2017 09:29:14 +0100 > Okash Khawaja wrote: > > > Hi Alan, > > > > On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > > > + if (!(tmp_termios.c_cflag & CRTSCTS)) { > > > > + tmp_termios.c_cfl

Re: [PATCH v2 1/3] staging: typec: fusb302: do not free gpio from managed resource

2017-05-12 Thread Guenter Roeck
On Fri, May 12, 2017 at 10:38:16AM +0100, Rui Miguel Silva wrote: > When allocating a gpio using the managed resource devm_, we can avoid freeing > it > manually. But even if we did it we should use devm_gpio_free. > > So, just remove the free of the gpio in the error path. > > Signed-off-by: Ru

Re: [PATCH v2 2/3] staging: typec: fusb302: reset i2c_busy state in error

2017-05-12 Thread Yueyao Zhu
Thanks for the catch! With the fix, should the `done` label be added before atomic_set(&chip->i2c_busy, 0); ? On Fri, May 12, 2017 at 2:38 AM, Rui Miguel Silva wrote: > Fix reset of i2c_busy flag if an error occurs during the i2c block read. > > Signed-off-by: Rui Miguel Silva > --- > drivers/s

[PATCH v2 2/2] staging: ccree: remove trailing whitespace

2017-05-12 Thread Connor Kelleher
ssi_fips.c: fixing checkpatch.pl errors: ERROR: trailing whitespace + * $ ERROR: trailing whitespace + * $ ERROR: trailing whitespace + * $ ERROR: trailing whitespace +This function returns the REE FIPS state. $ ERROR: trailing whitespace +It should be called by kernel module. $ ERROR: trai

[PATCH v2 1/2] staging: ccree: switch spaces to tabs

2017-05-12 Thread Connor Kelleher
ssi_fips.c: fixing checkpatch.pl errors: ERROR: code indent should use tabs where possible +int rc = 0;$ ERROR: code indent should use tabs where possible +int rc = 0;$ Signed-off-by: Connor Kelleher --- drivers/staging/ccree/ssi_fips.c | 4 ++-- 1 file changed, 2 insertions(+

[PATCH] staging: rtl8712: use octal permissions

2017-05-12 Thread Aleksey Kurbatov
Using octal permissions instead of symbolic ones is preferred. Signed-off-by: Aleksey Kurbatov --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 8836b31b4ef8..e

Re: [PATCH] staging: vt6656: Break too long lines

2017-05-12 Thread kbuild test robot
Hi Juan, [auto build test ERROR on next-20170512] [cannot apply to staging/staging-testing v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Juan-Manuel-Torres

[PATCH v2] staging: rtl8192u: Fix type mismatch warnings reported by sparse

2017-05-12 Thread suniel . spartan
From: Suniel Mahesh Mk16_le() is an inline function returning le16_to_cpu() which is causing type mismatch warnings. Removed Mk16_le() and replaced it with le16_to_cpu() with appropriate argument type as suggested by Greg K-H. Signed-off-by: Suniel Mahesh --- Changes for v2: - Modified commit

[PATCH] staging: vt6656: Break too long lines

2017-05-12 Thread Juan Manuel Torres Palma
Fix style in rxtx.c splitting lines into 80 characters or less. Signed-off-by: Juan Manuel Torres Palma --- drivers/staging/vt6656/rxtx.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c inde

Re: [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

2017-05-12 Thread Janusz Lisiecki
W dniu 2017-05-07 o 05:37, Greg Kroah-Hartman pisze: On Sat, Apr 29, 2017 at 10:58:41PM +0200, Janusz Lisiecki wrote: Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki Reviewed-by: Tobin C. Harding Not all of th

[PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase association_request_t and association_response_t struct field names with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 10 +- drivers/staging/ks7010/ks_hostif.h | 6 +++--- 2 files c

[PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - maxDuration - durRemaining Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 6 +++--- drivers/staging/ks7010/ks_wlan.h | 8 drivers/staging/ks7010/ks_wlan_net.c | 20 ++---

[PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 33

[PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010

[PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-)

[PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - FhParms_t - DsParms_t - CfParms_t - IbssParms_t - ErpParams_t Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 20 ++-- 1 file changed, 10 inse

[PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields

2017-05-12 Thread Janusz Lisiecki
Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - dwellTime - hopSet - hopPattern - hopIndex Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH v2 0/8] Avoid CamelCases in ks7010 driver

2017-05-12 Thread Janusz Lisiecki
This patchset fix CamelCases in ks7010 driver except michael_mic which will be replaced by kernel implementation in the future. --- v2: - Rebased all patches to next-20170512. 2 and 8 should apply cleanly now Janusz Lisiecki (8): staging: ks7010: avoid CamelCase in fields of struct

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

2017-05-12 Thread Matthew Giassa
* Greg KH [2017-05-12 11:30:08 +0200]: On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: +#defineREG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ +#defineREG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address +

[PATCH 13/13] staging: most: dim2: replace function parameter with the expression

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This replaces the function parameter sync_mfe with the expression (ch_type == CAT_CT_VAL_SYNC) what is the same. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_hal.c | 15 --- 1 file changed, 8 insertions(

[PATCH 07/13] staging: most: use unsafe version of list traversing

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov The function get_net_dev_context does not remove elements of the list. Hence, list traversing does not need to be secured. This patch replaces list_for_each_entry_safe with the list_for_each_entry. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- driver

[PATCH 09/13] staging: most: net: prefer __func__ over the function name

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This replaces the function names in the print messages with the __func__ macro. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 11/13] staging: most: net: fix race between create/destroy device

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This introduces the kref for the net_dev_context to prevent the destruction of the network devices that are in use. Each get_net_dev_context is completed with the put_net_dev_context, except the function aim_probe_channel that calls one more get_net_dev_context or kref_get

[PATCH 05/13] staging: most: i2c: remove empty callback request_netinfo

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov Since the networking-aim checks the availability of the callback request_netinfo, this patch removes the empty callback request_netinfo from the i2c-hdm. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-i2c/hdm_i2c.c | 7 ---

[PATCH 02/13] staging: most: net: use dormant state

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This replaces the call of wait_for_completion in case of an invalid MAC address in the function most_nd_open() with the dormant state of the network device. As a side effect, opening the network device cannot fail anymore. Signed-off-by: Andrey Shvetsov Signed-off-by: Chr

[PATCH 08/13] staging: most: net: remove redundant cleanup code

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This removes redundant cleanup code that is executed anyway when the most_deregister_aim() is called. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c | 19 +-- 1 file changed, 1 insertion(+),

[PATCH 10/13] staging: most: allocate private net_dev_context with the alloc_netdev

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This moves the allocation of the net_dev to the aim_probe_channel() and uses the parameter sizeof_priv of the function alloc_netdev to reserve the space for the struct net_dev_context. As a side effect, the nd->dev always points to the existing net_dev. Signed-off-by: Andr

[PATCH 12/13] staging: most: dim2: enable flow control for isoc channels

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This patch enables the flow control feature for the isochronous channels of the DIM2 macro. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 ++ drivers/staging/most/hdm-dim2/dim2_reg.h | 1 + 2 files changed,

[PATCH 06/13] staging: most: remove dependency on networking-aim

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov The modules hdm-usb and hdm-dim2 depend on the module aim-network, because they use the function most_deliver_netinfo that it exports. To remove this dependency, this patch replaces the call of the function most_deliver_netinfo with the call of the function that is the para

[PATCH 03/13] staging: most: net: add carrier information

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov This adds the carrier information for the network devices based on the INIC controllers. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/stag

[PATCH 04/13] staging: most: check availability of the callback request_netinfo

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov Since not all HDMs implement the callback request_netinfo, this patch adds checking of its availability. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

[PATCH 01/13] staging: most: net: remove useless variable channels_opened

2017-05-12 Thread Christian Gromm
From: Andrey Shvetsov The function most_nd_stop is only called by successful return from the function most_nd_open, so the channels_opened is always true in the function most_nd_stop. The functions aim_resume_tx_channel and aim_rx_data are only called after successful most_start_channel in the f

Re: [PATCH v2] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-12 Thread Riccardo Marotti
On 05/12/2017 11:07 AM, Greg KH wrote: > On Sun, May 07, 2017 at 11:01:07AM +0200, Riccardo Marotti wrote: >> Fixed a brace coding style issue, found via checkpatch. >> >> Signed-off-by: Riccardo Marotti >> --- >> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- >> 1 file changed, 1

[PATCH] staging: wlan-ng: convert endianness in situ for prism2sta

2017-05-12 Thread Thibaut SAUTEREAU
Fix several sparse warnings about casts to restricted little-endian by using in situ conversions. Signed-off-by: Thibaut SAUTEREAU --- drivers/staging/wlan-ng/prism2sta.c | 100 ++-- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/w

[PATCH v3] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-12 Thread Riccardo Marotti
Fixed a brace coding style issue, found via checkpatch. Signed-off-by: Riccardo Marotti --- Changes in v2: - Fix mismatch between "Signed-off-by:" and "From:" names. Changes in v3: - Fix missing summary of changes in version 2. drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +--

[PATCH v2 2/3] staging: typec: fusb302: reset i2c_busy state in error

2017-05-12 Thread Rui Miguel Silva
Fix reset of i2c_busy flag if an error occurs during the i2c block read. Signed-off-by: Rui Miguel Silva --- drivers/staging/typec/fusb302/fusb302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/f

[PATCH v2 3/3] staging: typec: fusb302: refactor resume retry mechanism

2017-05-12 Thread Rui Miguel Silva
The i2c functions need to test the pm_suspend state and do, if needed, some retry before i2c operations. This code was repeated 4x. To isolate this, create a new function to check suspend state and call it in every need place. As at it, move the error message from pr_err to dev_err. Signed-off-b

[PATCH] staging: wlan-ng: convert endianness in situ for prism2fw

2017-05-12 Thread Thibaut SAUTEREAU
Fix several sparse warnings about casts to restricted little-endian. Signed-off-by: Thibaut SAUTEREAU --- drivers/staging/wlan-ng/prism2fw.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-n

[PATCH v2 1/3] staging: typec: fusb302: do not free gpio from managed resource

2017-05-12 Thread Rui Miguel Silva
When allocating a gpio using the managed resource devm_, we can avoid freeing it manually. But even if we did it we should use devm_gpio_free. So, just remove the free of the gpio in the error path. Signed-off-by: Rui Miguel Silva --- drivers/staging/typec/fusb302/fusb302.c | 2 -- 1 file chang

[PATCH v2 0/3] staging: typec: fusb302: some fixes and cleanups

2017-05-12 Thread Rui Miguel Silva
This series fixes some bugs in the error paths and do some refactoring in the resume retry mechanism. No new functionality is added and I do *not* have the hw to test it. So, if you have the hw give it a try. v1->v2: Guenter Roeck: - drop patch that removed debugfs logging - reorder patches

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

2017-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2017 at 11:28:37AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman > wrote: > > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > >> Closing braces should match the first characters of the opening. > >> > >>

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

2017-05-12 Thread Greg KH
On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: > +#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration > */ > +#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor > Address > + */ > +#def

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

2017-05-12 Thread Geert Uytterhoeven
Hi Greg, On Fri, May 12, 2017 at 10:57 AM, Greg Kroah-Hartman wrote: > On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: >> Closing braces should match the first characters of the opening. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/staging/ccree/ssi_hash.c | 28

Re: [PATCH] staging: wlan-ng: convert endianness in situ

2017-05-12 Thread Greg KH
On Thu, May 11, 2017 at 09:20:50PM +0200, Thibaut SAUTEREAU wrote: > Fix several sparse warnings about casts to restricted > little-endian by using in situ conversions. > > Signed-off-by: Thibaut SAUTEREAU You sent two different patches with the identical subject line, which isn't ok. Please fi

Re: [PATCH v2 1/2] staging: vt6656: Fix indentation style

2017-05-12 Thread Greg KH
On Wed, May 10, 2017 at 12:06:12AM +0900, Juan Manuel Torres Palma wrote: > Fix indentation to tabs instead of spaces. > > Signed-off-by: Juan Manuel Torres Palma > --- > drivers/staging/vt6656/rxtx.c | 34 +- > 1 file changed, 17 insertions(+), 17 deletions(-) P

Re: [PATCH] media: fix one code style problem

2017-05-12 Thread Greg Kroah-Hartman
On Fri, May 05, 2017 at 01:18:24PM -0700, Remco wrote: > From: Remco Verhoef > > this patch will fix one code style problem (ctx:WxE), space > prohibited before that Your subject needs work :) And why just one issue, is that the only place this type of problem is needed in this file? thanks,

Re: [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs

2017-05-12 Thread Greg Kroah-Hartman
On Sun, May 07, 2017 at 09:03:19AM +0200, Janusz Lisiecki wrote: > Replace CamelCase variable name with underscores to comply > with the standard kernel coding style. > > Signed-off-by: Janusz Lisiecki > --- > drivers/staging/ks7010/ks_hostif.c | 26 +- > drivers/staging/

Re: [PATCH] staging: rtl8188eu: Fix one coding style problem

2017-05-12 Thread Greg Kroah-Hartman
On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote: > Fix code indent should use tabs where possible coding style > error. Your subject should be a bit better, why, "one"? please fix and resend. thanks, greg k-h ___ devel mailing list de...

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() > internally. le16_to_cpu() takes an argument of type (__le *) > but the argument passed is of type (u16 *). Fixed it by passing > the correct argume

Re: [PATCH v2] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-12 Thread Greg KH
On Sun, May 07, 2017 at 11:01:07AM +0200, Riccardo Marotti wrote: > Fixed a brace coding style issue, found via checkpatch. > > Signed-off-by: Riccardo Marotti > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) What changed fr

Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

2017-05-12 Thread Greg KH
On Mon, May 01, 2017 at 01:19:24PM +0530, suniel.spar...@gmail.com wrote: > From: Suniel Mahesh > > The function Mk16_le() is calling le16_to_cpu() internally. > le16_to_cpu() takes an argument of type (__le *) but the argument > passed is of type (u16 *). Fixed it by passing the correct argument

Re: [PATCH] staging: media: cxd2099: Use __func__ macro in messages

2017-05-12 Thread Alex Ghiti
This patch should be dropped as Jasmin is updating this driver. Thanks, On 05/09/2017 02:27 PM, Alexandre Ghiti wrote: Replace hardcoded function names in print info with __func__. Signed-off-by: Alexandre Ghiti --- drivers/staging/media/cxd2099/cxd2099.c | 6 +++--- 1 file changed, 3 insert

Re: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 11:39:56AM -0700, Connor Kelleher wrote: > ssi_fips.c: > > fixing checkpatch.pl errors: > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > + * $ > > ERROR: trailing whitespace > +This function returns the REE F

Re: [PATCH] staging: ccree: ssi_aead.c: Fix blank lines coding style issue

2017-05-12 Thread Greg KH
On Tue, May 09, 2017 at 07:53:30PM +0300, Alex wrote: > Checkpatch emits CHECK: Please don't use multiple blank lines. > > Remove multiple blank lines. > > Signed-off-by: Alexander Mazyrin This name doesn't match your "From:" name :( ___ devel mailin

Re: [PATCH 1/2] staging: ccree: Fix indentation of driver_hash[] initializers

2017-05-12 Thread Greg Kroah-Hartman
On Sun, May 07, 2017 at 09:53:29PM +0200, Geert Uytterhoeven wrote: > Closing braces should match the first characters of the opening. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/staging/ccree/ssi_hash.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletion

Re: staging: most: allocate private net_dev_context with the alloc_netdev

2017-05-12 Thread Greg KH
On Wed, May 10, 2017 at 05:33:14PM +0200, Christian Gromm wrote: > From: Andrey Shvetsov > > This moves the allocation of the net_dev to the aim_probe_channel() and > uses the parameter sizeof_priv of the function alloc_netdev to reserve > the space for the struct net_dev_context. > > As a side

Re: [PATCH] staging: fbtft: fix unbalanced parenthesis

2017-05-12 Thread Greg KH
On Fri, May 12, 2017 at 08:10:42AM +0200, Alexis Lothoré wrote: > Add missing parenthesis around if/else statement to comply with checkpatch.pl > following check : > > Unbalanced braces around else statement > #288: FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:288: > + else { >

Re: Clarification for general change acceptance

2017-05-12 Thread SF Markus Elfring
> When you make a patch, you are not obliged to eliminate all of the other > checkpatch warnings on the file. Your view is generally fine. > I don't know where you got this idea from. I got used as a professional software developer to some approaches for reducing development warnings to some de

Re: Clarification for general change acceptance

2017-05-12 Thread Julia Lawall
> But I will come along source code places where I am going to update details > which are also trivial. When you make a patch, you are not obliged to eliminate all of the other checkpatch warnings on the file. I don't know where you got this idea from. The submitting patch guidelines don't say t

Re: Clarification for general change acceptance

2017-05-12 Thread SF Markus Elfring
> Developer reputation matters for somewhat controversial > patches being applied as well as non-controversial and > obviously correct patches being ignored. I am aware that there are more factors involved. > Your reputation means most all of your patches fall into > the latter category. I hope

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-12 Thread Greg KH
On Sun, May 07, 2017 at 06:23:14PM +0800, Jamie Huang wrote: > On Sat, 6 May 2017 20:20:57 -0700 > Greg KH wrote: > > > On Fri, May 05, 2017 at 02:00:43AM +0800, Jamie Huang wrote: > > > ERROR: Macros with multiple statements should be enclosed in a do - > > > while loop Detected by scripts/check

Re: [PATCH] staging: rtl8192u: Convert __le16 to cpu before casting to u32

2017-05-12 Thread Greg Kroah-Hartman
On Sun, May 07, 2017 at 02:56:36PM +0200, Guillaume Brogi wrote: > On Sat, Apr 08, 2017 at 08:32:36PM +0200, Guillaume Brogi wrote: > > On Sat, Apr 08, 2017 at 12:31:25PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Mar 26, 2017 at 12:24:14AM +0100, Guillaume Brogi wrote: > > > > > > > > This pa

Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread Joe Perches
On Fri, 2017-05-12 at 09:32 +0200, SF Markus Elfring wrote: > Will patches be picked up also from contributors who got a special > development reputation anyhow? Yes. Developer reputation matters for somewhat controversial patches being applied as well as non-controversial and obviously correct p

Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread SF Markus Elfring
>> Just because an automated tool says that this needs to change does not >> mean it has to. > > Checkpatch.pl is correct here. This message is useless. It's during > init so it's unlikely to fail ever. In current kernels small kmallocs > are quaranteed to succeed so it can't actually fail curr

Re: [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

2017-05-12 Thread Dan Carpenter
On Thu, May 11, 2017 at 09:30:15AM -0700, Stephen Hemminger wrote: > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > > index 6802d74f162c..96328aebae5a 100644 > > --- a/drivers/hv/vmbus_drv.c > > +++ b/drivers/hv/vmbus_drv.c > > @@ -1149,7 +1149,5 @@ struct hv_device *vmbus_device_