Fix the following sparse warnings about incorrect type usage:
tcpci.c:290:38: warning: incorrect type in argument 1 (different base types)
tcpci.c:290:38:expected unsigned short [unsigned] [usertype] header
tcpci.c:290:38:got restricted __le16 const [usertype] header
tcpci.c:295:16: warnin
You have been nominated for the charity program to support Prince Alwaleed Bin
Tala, please contact:
http://bit.do/23awsa
for more information.
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
___
You have been nominated for the charity program to support Prince Alwaleed Bin
Tala, please contact:
http://bit.do/23awsa
for more information.
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
___
Changed include of to be
Complies, but I don't have hardware.
Found using checkpatch.
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U.h
b/drivers/staging/rtl8192u/r8192U.h
ind
Resolving a minor checkpatch/indentation issue in ion_carveout_heap.c,
ie:
drivers/staging/android/ion/ion_carveout_heap.c
---
CHECK: Alignment should match open parenthesis
+static phys_addr_t ion_carveout_allocate(struct ion_heap *heap,
+
Fix code indent should use tabs where possible coding style
error.
Signed-off-by: Remco Verhoef
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
b/drivers/staging/rtl8188eu/hal
This revised patchset is for improvement in [PATCH v2 1/3]
as per the code review comment from Dan Carpenter.
Other two patches [PATCH v2 2/3] and [PATCH v2 3/3] are unchanged,
so they are same as [PATCH 2/3] and [PATCH 3/3] respectively.
Please find the following related patches:
[PATCH v2 1/3]
This patch fixes below kind of warnings:
WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
Below errors are false positives:
ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions
ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions
Signed-off-by
This patch fixes below checkpatch.pl warning:
CHECK: struct mutex definition without comment
Signed-off-by: Harinath Nampally
---
Changes in v2:
- Removed the extra comment for mutex in the struct.
drivers/staging/iio/meter/ade7753.c | 3 ++-
1 file changed, 1 insertions(+), 1 deletion
This patch fixes below checkpatch.pl kind of warnings:
CHECK: Alignment should match open parenthesis
Signed-off-by: Harinath Nampally
---
Changes in v2:
- None because only [PATCH v2 1/3] has improvement
drivers/staging/iio/meter/ade7753.c | 55 ++---
1 file ch
On Tue, May 09, 2017 at 07:46:17PM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 09, 2017 at 09:04:53AM -0700, Guenter Roeck wrote:
> > From: Olivier Leveque
> >
> > This fixes a sparse warning regarding an undeclared symbol. Since the
> > structure tcpci_tcpc_config is private to tcpci.c, it sh
Current HEAD did not pass the checkpatch script with --strict option, mainly
because of Camel Case names and long lines. As an exception, I have left the
defines nested in the "#if 0" in the header, since I am not sure it is a real
issue and it will probably be reused in the future, but please let
Current HEAD for emxx_udc driver did not pass checkpatch script, mainly because
of Camel Case naming
and long lines.
Signed-off-by: Alexis Lothoré
---
drivers/staging/emxx_udc/emxx_udc.c | 394 ++--
drivers/staging/emxx_udc/emxx_udc.h | 170
2 fi
ssi_fips.c:
fixing checkpatch.pl errors:
ERROR: trailing whitespace
+ * $
ERROR: trailing whitespace
+ * $
ERROR: trailing whitespace
+ * $
ERROR: trailing whitespace
+This function returns the REE FIPS state. $
ERROR: trailing whitespace
+It should be called by kernel module. $
ERROR: code
On Tue, May 09, 2017 at 09:04:53AM -0700, Guenter Roeck wrote:
> From: Olivier Leveque
>
> This fixes a sparse warning regarding an undeclared symbol. Since the
> structure tcpci_tcpc_config is private to tcpci.c, it should be declared as
> static.
>
> Signed-off-by: Olivier Leveque
> Signed-of
Hi Alexandre!
The current cxd2099 driver is an old version. DD provides a newer variant.
Please see my patch series
http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html
Especially this patch
http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html
where I remov
Checkpatch emits CHECK: Please don't use multiple blank lines.
Remove multiple blank lines.
Signed-off-by: Alexander Mazyrin
---
drivers/staging/ccree/ssi_aead.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 03829
If the lower level driver provided a list of VDOs in its configuration
data, send it to the partner as response to a Discover Identity command
if in device mode (UFP).
Cc: Yueyao Zhu
Originally-from: Puma Hsu
Signed-off-by: Guenter Roeck
---
drivers/staging/typec/pd_vdo.h | 4 +++-
drivers/st
We do support USB PD communication, and devices supported by this driver
typically use USB power for purposes other than USB communication.
Originally-from: Puma Hsu
Cc: Yueyao Zhu
Signed-off-by: Guenter Roeck
---
drivers/staging/typec/tcpm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletion
Per USB PD standard, we have to drop duplicate PD messages.
We can not expect lower protocol layers to drop such messages,
since lower layers don't know if a message was dropped somewhere
else in the stack.
Originally-from: Puma Hsu
Cc: Yueyao Zhu
Signed-off-by: Guenter Roeck
---
drivers/stagi
PS_RDY messages sent during power swap sequences are expected to reflect
the new power role.
Signed-off-by: Guenter Roeck
---
drivers/staging/typec/tcpm.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/
From: Javier Martinez Canillas
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the OF and I2C device ID table entries as module aliases, using the
MOD
From: Yueyao Zhu
FUSB_REG_STATUS0 & FUSB_REG_STATUS0_VBUSOK = 0x40 & 0x80 is always
zero. Fix the code to what it is intended to be: check the VBUSOK
bit of the value read from address FUSB_REG_STATUS0.
Reported-by: Dan Carpenter
Cc: Guenter Roeck
Signed-off-by: Yueyao Zhu
Signed-off-by: Guen
On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote:
> Fix sparse warning:
> drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
> was not declared. Should it be static?
>
> Signed-off-by: Guru Das Srinagesh
Olivier Leveque already sent a similar patch la
From: Olivier Leveque
This fixes a sparse warning regarding an undeclared symbol. Since the
structure tcpci_tcpc_config is private to tcpci.c, it should be declared as
static.
Signed-off-by: Olivier Leveque
Signed-off-by: Guenter Roeck
---
drivers/staging/typec/tcpci.c | 2 +-
1 file changed,
On Tue, 2017-05-09 at 01:03 +0530, Jaya Durga wrote:
> Fixed coding style issue
Do please strive to do more than shut up checkpatch
messages. It's _far_ more important to use sensible
coding mechanisms and reuse existing code utilities.
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.
On Tue, 2017-05-09 at 00:52 +0530, Jaya Durga wrote:
> fixed warning line over 80 characters coding style issue
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/rtl8712/ieee80211.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/ieee80211
Fix indentation to tabs instead of spaces.
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 1835cd
Split long lines into several to match coding style.
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 7af27ea..3d70eb
On Tue, May 09, 2017 at 09:45:43PM +0900, Juan Manuel Torres Palma wrote:
> Cleanup all style warnings and errors in rxtx.c
That's really vague...
Please be very specific, and remember, you can only fix one "type of
thing" per patch, and no, "all style warnings and errors" is not a
single type of
Replace hardcoded function names in print info with __func__.
Signed-off-by: Alexandre Ghiti
---
drivers/staging/media/cxd2099/cxd2099.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
in
Cleanup all style warnings and errors in rxtx.c
Signed-off-by: Juan Manuel Torres Palma
---
drivers/staging/vt6656/rxtx.c | 50 +++
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.
Hi,
This patch applies on top of previous patchset which migrates synths to TTY
[1]. It fixes couple of issues and tries to ensure hardware flow control is
enabled.
Thanks,
Okash
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1387738.html
_
This patch fixes the issue where TTY-migrated synths would take a while to shut
up after hitting numpad enter key. When calling synth_flush, even though XOFF
character is sent as high priority, data buffered in TTY layer is still sent to
the synth. This patch flushes that buffered data when synt
staging: wlan-ng: prism2mgmt.c: This patches fixes a double endian conversion.
cpu_to_le16() was called twice first in prism2mgmt_scan and again inside
hfa384x_drvr_setconfig16() for the same variable, hence it was swapped
twice. Incidentally, it also fixed the following sparse warning:
drivers/st
Hi,
On Sun, May 7, 2017 at 10:53 PM, Geert Uytterhoeven
wrote:
> With gcc 4.1.2:
>
> drivers/staging/ccree/ssi_hash.c:1990: error: unknown field
> ‘template_ahash’ specified in initializer
> drivers/staging/ccree/ssi_hash.c:1991: error: unknown field ‘init’
> specified in initializer
>
From: Suniel Mahesh
The function Mk16_le() is calling le16_to_cpu()
internally. le16_to_cpu() takes an argument of type (__le *)
but the argument passed is of type (u16 *). Fixed it by passing
the correct argument type.
Signed-off-by: Suniel Mahesh
---
.../rtl8192u/ieee80211/ieee80211_crypt_tk
On Tue, May 09, 2017 at 11:31:36AM +0300, Dan Carpenter wrote:
> Just ignore the warning.
>
Thank you for your comments on this patch.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-
Fix sparse warning:
drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
was not declared. Should it be static?
Signed-off-by: Guru Das Srinagesh
---
drivers/staging/typec/tcpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/t
This patch introduces tons of memory leaks so we can't apply it.
Just ignore the warning. The size is small enough that it won't
overflow the stack. The other reason to avoid these types of
declarations is that in olden times (5 years ago at least) there was a
GCC for an arch where if you declar
On Mon, May 08, 2017 at 02:13:00PM +0530, Surender Polsani wrote:
> according to coding style else is not generally
> useful after a break or return
>
> Signed-off-by: Surender Polsani
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
On Mon, May 08, 2017 at 10:00:37PM -0400, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl warning:
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Harinath Nampally
> ---
> drivers/staging/iio/meter/ade7753.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 delet
42 matches
Mail list logo
