kernel coding style doesn't allow the return statement
in void function.
Signed-off-by: Surender Polsani
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
---
drivers/staging/rtl81
The following commit fixes the following sparse report:
drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
restricted __le64
by casting readq (which is unsigned long on x86) to u64, as expected by the
seq_printf call.
Signed-off-by: Marcos Paulo de Souza
---
Just compi
checkpatch.pl reported errors for use of extra whitespaces
in the function prototypes.
Removed extra spaces to meet the coding standards.
Signed-off-by: Adheer Chandravanshi
---
drivers/staging/rtl8723bs/include/rtl8192c_rf.h | 23 ++-
1 file changed, 10 insertions(+), 13 de
Patch v2 addresses review comments from Greg KH.
Following is a single patch with only one type of coding style issues fixed.
Adheer Chandravanshi (1):
staging: rtl8723bs: Fix coding style issues
drivers/staging/rtl8723bs/include/rtl8192c_rf.h | 23 ++-
1 file changed, 10 i
Fixed checkpatch.pl issue
ERROR: that open brace { should be on the previous line
Signed-off-by: Fabrizio Perria
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
b/dr
On Tue, May 02, 2017 at 04:18:39PM +0200, Vincent Siles wrote:
> Removing empty line at the end of the file
Hi Vincent,
Small comment on your patch series. You may have more success if your
summary phrase is in imperative mood i.e sounds like you are
commanding changes to be made to the code base
This function is not used anywhere in current code.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 56 --
include/linux/hyperv.h | 6 --
2 files changed, 62 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
Split struct definition across multiple line to fit in the 80 characters
limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wi
Splitting function calls across multiple lines to fit in the 80
characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/
Removing some '-' comments to fit in the 80 characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index
Removing empty line at the end of the file
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wilc1000/wilc_debugfs.c
index 7d32de9..5c93c7c 100644
--- a/drivers/st
v1:
Fixing coding style of the file drivers/staging/wilc1000/wilc_debugfs.c
v2:
Correctly split pr_info string across multiple lines
Splitting the patch: one patch per modification
Better commit message
Vincent Siles (5):
staging: wilc1000: Last line is empty
staging: wilc1000: Stripp
Splitting functions signature across several lines to fin in the
80 characters limit
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/drivers/staging/wil
On Tue, May 02, 2017 at 03:34:05PM +0200, Vincent Siles wrote:
> Here is the full patch after your review:
> Fixing coding style issues in drivers/staging/wilc1000/wilc_debugfs.c
>
> Thank you about the information for split strings, I didn't find the
> right way to do it.
>
> Best,
> V.
That is
Here is the full patch after your review:
Fixing coding style issues in drivers/staging/wilc1000/wilc_debugfs.c
Thank you about the information for split strings, I didn't find the
right way to do it.
Best,
V.
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 27 ++
On Tue, May 02, 2017 at 09:49:29AM +0200, Vincent Siles wrote:
> Most of them were easily fixed. The only invasive fix was the split
> of the info string line 63 because:
> - it was too long
> - checkpath doesn't like 'quoted string split across lines'
Please fix up your subject line to look more
Most of them were easily fixed. The only invasive fix was the split
of the info string line 63 because:
- it was too long
- checkpath doesn't like 'quoted string split across lines'
Signed-off-by: Vincent Siles
---
drivers/staging/wilc1000/wilc_debugfs.c | 28 +++-
1 file
17 matches
Mail list logo