Re: [PATCH] Added paranthesis around complex define statements

2017-04-20 Thread Greg KH
On Fri, Apr 21, 2017 at 05:15:46AM +, Andriy Gelman wrote: > This is a patch to the ks_wlan_ioctl.h file that fixes paranthesis error > found by the checkpatch.pl tool No, it also does other things :( Also, please fix up the subject to look like other patches done for this file/driver. And f

[PATCH] Added paranthesis around complex define statements

2017-04-20 Thread Andriy Gelman
This is a patch to the ks_wlan_ioctl.h file that fixes paranthesis error found by the checkpatch.pl tool Signed-off-by: Andriy Gelman --- drivers/staging/ks7010/ks_wlan_ioctl.h | 53 +- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/drivers/stagin

[PATCH] staging : rtl8188eu : remove void function return

2017-04-20 Thread surenderpolsani
kernel coding style doesn't allow the return statement in void function. Signed-off-by: Surenderp --- Changes for v2: corrected subject line as suggested Changes for v3: modified from line as suggested by Greg KH placed a semicolon in label for fixing build error --- drivers/staging/rtl8188eu/ha

Order

2017-04-20 Thread Damian Colins
Hi , I would like to place an order for some items which I want to know the below : Do you ship to Liechtenstein ? Do you accept Credit Card payment Also send me your current product price list. Thanks ___ devel mailing list de...@linuxdriverproje

Re: [PATCH] staging: comedi: support vm_access_process for mmap'd buffer

2017-04-20 Thread Ian Abbott
On 20/04/17 18:39, Ian Abbott wrote: If a process that has mmap'd a COMEDI buffer is being run under a debugger such as GDB, the buffer contents are inaccessible from the debugger. Support the `access()` VM operation to allow the buffer contents to be accessed by another process. Signed-off-by:

[PATCH v2] staging: android: ion: Remove whitespace before quoted newline

2017-04-20 Thread Paolo Cretaro
Fix checkpatch.pl warning about unnecessary whitespace before a quoted newline. Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion_chunk_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/andro

Re: [PATCH] staging: android: ion: Remove whitespace before quoted newline

2017-04-20 Thread Paolo Cretaro
nc__, chunk_heap->base, heap_data->size); return &chunk_heap->heap; Ah! I missed that in the meanwhile another commit changed that line, so my patch doesn't cleanly apply anymore. Resending v2 rebased against next-20170420

Re: [Bug] VCHIQ functional test broken

2017-04-20 Thread Eric Anholt
Rabin Vincent writes: > On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote: >> I'm confused by what you're saying here. The driver has already been >> converted to not use dmac_map_area (commit >> cf9caf1929882b66922aee698e99e6c8f357bee5), and uses dma_map_sg instead, >> matching the ra

Re: [Bug] VCHIQ functional test broken

2017-04-20 Thread Rabin Vincent
On Thu, Apr 20, 2017 at 11:27:38AM -0700, Eric Anholt wrote: > I'm confused by what you're saying here. The driver has already been > converted to not use dmac_map_area (commit > cf9caf1929882b66922aee698e99e6c8f357bee5), and uses dma_map_sg instead, > matching the radeon driver you give as a mode

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Christoph Hellwig
On Thu, Apr 20, 2017 at 06:37:35PM +, Haiyang Zhang wrote: > It's Nvidia driver. Which of the many nvidia drivers in the tree? Just fix it instead of coming up with stupid workarounds like this. ___ devel mailing list de...@linuxdriverproject.org ht

Re: [PATCH] staging: ks7010: Change capability field to __le16

2017-04-20 Thread Johan Svensson
On 2017-04-18 20:38, Greg KH wrote: > On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote: >> Change capability field to __le16 in struct ap_info_t, >> struct link_ap_info_t, and struct local_ap_t. >> This fixes a sparse warning. > What warning is it fixing? And are you sure this is th

Re: [PATCH v2 5/9] staging: ccree: add AEAD support

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

RE: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Haiyang Zhang
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Thursday, April 20, 2017 2:33 PM > To: Haiyang Zhang > Cc: linux-...@vger.kernel.org; KY Srinivasan ; > Stephen Hemminger ; o...@aepfle.de; > vkuzn...@redhat.com; driverdev-devel@linuxdriverproject.org; linux-

Re: [PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Bjorn Helgaas
On Thu, Apr 20, 2017 at 11:35 AM, Haiyang Zhang wrote: > From: Haiyang Zhang > > This patch uses the lower 16 bits of the serial number as PCI > domain, otherwise some drivers may not be able to handle it. Can you give any more details about this? Which drivers, for instance? Why do drivers ca

Re: [Bug] VCHIQ functional test broken

2017-04-20 Thread Eric Anholt
Rabin Vincent writes: > On Thu, Apr 13, 2017 at 11:29:15PM +0100, Russell King - ARM Linux wrote: >> > 00a19f3e25c0c40e0ec77f52d4841d23ad269169 is the first bad commit >> > commit 00a19f3e25c0c40e0ec77f52d4841d23ad269169 >> > Author: Rabin Vincent >> > Date: Tue Nov 8 09:21:19 2016 +0100 >> >

Re: [PATCH v2 2/9] staging: ccree: add ahash support

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] staging: ccree: fix ifnullfree.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_hash.c:317:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/staging/ccree/ssi_hash.c:320:2-7: WARNING: NU

[PATCH v2] staging: comedi: support vm_access_process for mmap'd buffer

2017-04-20 Thread Ian Abbott
If a process that has mmap'd a COMEDI buffer is being run under a debugger such as GDB, the buffer contents are inaccessible from the debugger. Support the `access()` VM operation to allow the buffer contents to be accessed by another process. Signed-off-by: Ian Abbott --- v2: correct maximum le

[PATCH] staging: comedi: support vm_access_process for mmap'd buffer

2017-04-20 Thread Ian Abbott
If a process that has mmap'd a COMEDI buffer is being run under a debugger such as GDB, the buffer contents are inaccessible from the debugger. Support the `access()` VM operation to allow the buffer contents to be accessed by another process. Signed-off-by: Ian Abbott --- drivers/staging/comed

[PATCH] staging: ccree: fix semicolon.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_request_mgr.c:623:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Gilad Ben-Yossef Signed-off-by: Fengguang Wu --- ssi_request_mgr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/driver

[PATCH] staging: ccree: fix platform_no_drv_owner.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_driver.c:484:6-11: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Gilad Ben-Yossef Signed-off-by: Fengguang Wu --- ssi_driver.c

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] staging: ccree: fix array_size.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_sysfs.c:319:34-35: WARNING: Use ARRAY_SIZE drivers/staging/ccree/ssi_sysfs.c:429:34-35: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be

[PATCH] staging: ccree: fix ifnullfree.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_buffer_mgr.c:530:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is

[PATCH] pci-hyperv: Use only 16 bit integer for PCI domain

2017-04-20 Thread Haiyang Zhang
From: Haiyang Zhang This patch uses the lower 16 bits of the serial number as PCI domain, otherwise some drivers may not be able to handle it. Signed-off-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/pci/

Re: [PATCH] staging: most: core: add autoconf ability

2017-04-20 Thread Greg KH
On Thu, Apr 20, 2017 at 05:01:49PM +0200, Christian Gromm wrote: > This patch extends the driver with the possibility of automatic > configuration. This covers channel settings and connection establishing of > a MOST device interface while it is registered with the core. > > Making use of auto con

[PATCH] staging: most: core: add autoconf ability

2017-04-20 Thread Christian Gromm
This patch extends the driver with the possibility of automatic configuration. This covers channel settings and connection establishing of a MOST device interface while it is registered with the core. Making use of auto configuration will significantly cut the start-up overhead and the duration un

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccree/bsp.h > >> @@ -0,0 +1,21 @@ > >> +/* > >> + * Copyright (C) 2012-2

Re: [PATCH v2 6/9] staging: ccree: add FIPS support

2017-04-20 Thread Stephan Müller
Am Donnerstag, 20. April 2017, 15:13:00 CEST schrieb Gilad Ben-Yossef: Hi Gilad, > +/* The function verifies that tdes keys are not weak.*/ > +static int ssi_fips_verify_3des_keys(const u8 *key, unsigned int keylen) > +{ > +#ifdef CCREE_FIPS_SUPPORT > +tdes_keys_t *tdes_key = (tdes_keys_t

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Gilad Ben-Yossef
On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: >> +++ b/drivers/staging/ccree/bsp.h >> @@ -0,0 +1,21 @@ >> +/* >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. >> + * >> + * This program is free software;

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Gilad Ben-Yossef
On Thu, Apr 20, 2017 at 4:30 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware >> accelerators. It is supported by a long lived series of out of tree >> drivers, which I am now in

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of t

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first drop

[PATCH v2 9/9] MAINTAINERS: add Gilad BY as ccree maintainer

2017-04-20 Thread Gilad Ben-Yossef
I work for Arm on maintaining the TrustZone CryptoCell driver. Signed-off-by: Gilad Ben-Yossef --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 676c139..f21caa1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3066,6 +3066,13 @@ F: dr

[PATCH v2 8/9] staging: ccree: add DT bindings for Arm CryptoCell

2017-04-20 Thread Gilad Ben-Yossef
This adds DT bindings for the Arm TrustZone CryptoCell cryptographic accelerator IP. Signed-off-by: Gilad Ben-Yossef --- .../devicetree/bindings/crypto/arm-cryptocell.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 drivers/staging/ccree/Documentation/devic

[PATCH v2 6/9] staging: ccree: add FIPS support

2017-04-20 Thread Gilad Ben-Yossef
Add FIPS mode support to CryptoCell driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |9 + drivers/staging/ccree/Makefile |1 + drivers/staging/ccree/ssi_aead.c|6 + drivers/staging/ccree/ssi_cipher.c | 52 + drivers/staging/c

[PATCH v2 5/9] staging: ccree: add AEAD support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell AEAD support Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |1 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 21 + drivers/staging/ccree/ssi_aead.c | 2826 driv

[PATCH v2 7/9] staging: ccree: add TODO list

2017-04-20 Thread Gilad Ben-Yossef
Add TODO list for moving out of staging tree for ccree crypto driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/TODO | 28 1 file changed, 28 insertions(+) create mode 100644 drivers/staging/ccree/TODO diff --git a/drivers/staging/ccree/TODO b/driver

[PATCH v2 4/9] staging: ccree: add IV generation support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell IV hardware generation support. This patch adds the needed support to drive the HW but does not expose the ability via the kernel crypto API yet. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 2 +- drivers/staging/ccree/ssi_buffer_mgr.c | 2 +

[PATCH v2 2/9] staging: ccree: add ahash support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell async. hash and HMAC support. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |6 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 22 + drivers/staging/ccree/hash_defs.h | 78 + drivers/staging/cc

[PATCH v2 3/9] staging: ccree: add skcipher support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell skcipher support Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |8 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 21 + drivers/staging/ccree/ssi_buffer_mgr.c | 147 drivers/staging/ccree/ssi_bu

[PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Gilad Ben-Yossef
Arm TrustZone CryptoCell 700 is a family of cryptographic hardware accelerators. It is supported by a long lived series of out of tree drivers, which I am now in the process of unifying and upstreaming. This is the first drop, supporting the new CryptoCell 712 REE. The code still needs some cleanu

RE: [PATCH v2 8/9] staging: fsl-dpaa2/eth: Add TODO file

2017-04-20 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuyo...@gmail.com] > Sent: Wednesday, April 19, 2017 6:44 AM > To: Ruxandra Ioana Radulescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Alexander Graf ; Arnd Bergmann > ; linux-arm-ker...@

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Marek Szyprowski
Hi All, On 2017-04-20 09:51, Daniel Vetter wrote: On Wed, Apr 19, 2017 at 01:36:10PM -0600, Logan Gunthorpe wrote: Seeing the kunmap_atomic dma_buf_ops share the same name with a macro in highmem.h, the former can be aliased if any dma-buf user includes that header. I'm personally trying to in

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Sumit Semwal
Hi Marek, Thanks! On 20 April 2017 at 13:36, Marek Szyprowski wrote: > Hi All, > > On 2017-04-20 09:51, Daniel Vetter wrote: >> >> On Wed, Apr 19, 2017 at 01:36:10PM -0600, Logan Gunthorpe wrote: >>> >>> Seeing the kunmap_atomic dma_buf_ops share the same name with a macro >>> in highmem.h, the

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Sumit Semwal
Hi Logan, Thanks for the patch. On 20 April 2017 at 13:21, Daniel Vetter wrote: > On Wed, Apr 19, 2017 at 01:36:10PM -0600, Logan Gunthorpe wrote: >> Seeing the kunmap_atomic dma_buf_ops share the same name with a macro >> in highmem.h, the former can be aliased if any dma-buf user includes >> t

Re: [Intel-gfx] [PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-20 Thread Daniel Vetter
On Wed, Apr 19, 2017 at 01:36:10PM -0600, Logan Gunthorpe wrote: > Seeing the kunmap_atomic dma_buf_ops share the same name with a macro > in highmem.h, the former can be aliased if any dma-buf user includes > that header. > > I'm personally trying to include highmem.h inside scatterlist.h and thi