[PATCH 3/3] staging: atomisp: move mipi_info assignment to next line in __get_asd_from_port()

2017-04-06 Thread Daeseok Youn
The line which is initializing mipi_info variable is too long to read. It would be placed in next line. Signed-off-by: Daeseok Youn --- This series of patches are related to previous patches: [1] https://lkml.org/lkml/2017/3/27/159 [2] https://lkml.org/lkml/2017/3/30/1068 [3] https://lkml.org/lkm

[PATCH 2/3] staging: atomisp: replace "&isp->asd[i]" with "asd" in __get_asd_from_port()

2017-04-06 Thread Daeseok Youn
The address of isp->asd[i] is already assigned to local "asd" variable. "&isp->asd[i]" would be replaced with just "asd". Signed-off-by: Daeseok Youn --- This series of patches are related to previous patches: [1] https://lkml.org/lkml/2017/3/27/159 [2] https://lkml.org/lkml/2017/3/30/1068 [3] ht

[PATCH 1/3] staging: atomisp: remove enable_isp_irq function and add disable_isp_irq

2017-04-06 Thread Daeseok Youn
Enable/Disable ISP irq is switched with "enable" parameter of enable_isp_irq(). It would be better splited to two such as enable_isp_irq()/disable_isp_irq(). But the enable_isp_irq() is no use in atomisp_cmd.c file. So remove the enable_isp_irq() function and add disable_isp_irq function only. Si

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Kees Cook
On Thu, Apr 6, 2017 at 1:48 AM, Jani Nikula wrote: > On Thu, 06 Apr 2017, Kees Cook wrote: >> While examining output from trial builds with -Wformat-security enabled, >> many strings were found that should be defined as "const", or as a char >> array instead of char pointer. This makes some stati

[PATCH] staging: sm750fb: ddk750_display.c - fixed checkpatch warning: line over 80 chars

2017-04-06 Thread Andrea della Porta
staging: sm750fb: ddk750_display.c - fixed the following checkpatch warning: WARNING: line over 80 characters #149: FILE: drivers/staging/sm750fb/ddk750_display.c:149: + swPanelPowerSequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4); Signed-off-by: Andrea della Porta --- drive

[PATCH] staging: comedi: drivers: s626.c - fixed checkpatch issue about data type

2017-04-06 Thread Andrea della Porta
staging: comedi: drivers: s626.c - fixed the following checkpatch issue: CHECK: Prefer kernel type 's16' over 'int16_t' #1939: FILE: drivers/staging/comedi/drivers/s626.c:1939: + int16_t dacdata = (int16_t)data[i]; Signed-off-by: Andrea della Porta --- drivers/staging/comedi/driver

[PATCH] staging: rts5208: ms.c fixed checkpatch warning - using __func__ instead of hardcoded name

2017-04-06 Thread Andrea della Porta
staging: rts5208: ms.c Fixed checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names #2597: FILE: rts5208/ms.c:2597: + dev_dbg(rtsx_dev(chip), "ms_build_l2p_tbl: %d\n", seg_no); Signed-off-by: Andrea della Porta --- drivers/staging/rts5208/ms.c | 2 +- 1 file

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-06 Thread Steve Longerbeam
On 04/06/2017 02:43 AM, Philipp Zabel wrote: On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam [...] diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c new file m

Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.

2017-04-06 Thread Valerio G
Hi, Thanks for the feedback. I re-submitted the patch as v2. best Valerio Il 06/04/2017 01:57, Joe Perches ha scritto: > On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote: >> This was reported by checkpatch.pl: >> ERROR: space required after that close brace '}' >> >> Signed-off-by: Vale

[PATCH net-next 1/1] netvsc: Initialize all channel related state prior to opening the channel

2017-04-06 Thread kys
From: K. Y. Srinivasan Prior to opening the channel we should have all the state setup to handle interrupts. The current code does not do that; fix the bug. This bug can result in faults in the interrupt path. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc.c | 27 ++

[PATCH] staging: unisys: visornic: Replace symbolic perms with octal

2017-04-06 Thread Thomas Jespersen
Replace symbolic permissions S_IRUSR and S_IWUSR for their octal counterparts Signed-off-by: Thomas Jespersen Acked-by: David Kershner --- drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/visornic/viso

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-04-06 Thread Brijesh Singh
On 04/06/2017 12:25 PM, Borislav Petkov wrote: Hi Brijesh, On Thu, Apr 06, 2017 at 09:05:03AM -0500, Brijesh Singh wrote: I looked into arch/x86/mm/init_{32,64}.c and as you pointed the file contains routines to do basic page splitting. I think it sufficient for our usage. Good :) I shoul

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-04-06 Thread Borislav Petkov
Hi Brijesh, On Thu, Apr 06, 2017 at 09:05:03AM -0500, Brijesh Singh wrote: > I looked into arch/x86/mm/init_{32,64}.c and as you pointed the file contains > routines to do basic page splitting. I think it sufficient for our usage. Good :) > I should be able to drop the memblock patch from the se

Re: [PATCH] staging: android: ashmem: lseek failed due to no FMODE_LSEEK.

2017-04-06 Thread Greg KH
On Thu, Apr 06, 2017 at 08:30:40AM -0700, Greg Hackmann wrote: > On 04/06/2017 07:30 AM, zhangshuxia...@gmail.com wrote: > > From: zhangshuxiao > > > > vfs_llseek will check whether the file mode has > > FMODE_LSEEK, no return failure. But ashmem can be > > lseek, so add FMODE_LSEEK to ashmem fil

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 17:43 +0200, Hans Verkuil wrote: > On 04/06/2017 04:54 PM, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: > >>> If the the field order is set to ANY in set_fmt, choose the currently > >>> set fi

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Hans Verkuil
On 04/06/2017 04:54 PM, Philipp Zabel wrote: > On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: >> On 04/06/2017 03:55 PM, Philipp Zabel wrote: >>> If the the field order is set to ANY in set_fmt, choose the currently >>> set field order. If the colorspace is set to DEFAULT, choose the curren

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: > > On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > > > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > > > + > > > > + /

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace. If any of xfer_func, ycbcr_en

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Russell King - ARM Linux
On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: > On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > > + > > > + /* Retain current field setting as default */ > > > + if (sdformat->format.field ==

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: > On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > > + > > + /* Retain current field setting as default */ > > + if (sdformat->format.field == V4L2_FIELD_ANY) > > + sdformat->format.field = fmt->field;

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
On Thu, 2017-04-06 at 16:20 +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace. If any of xfer_func, ycbcr_en

[PATCH] staging: android: ashmem: lseek failed due to no FMODE_LSEEK.

2017-04-06 Thread zhangshuxiaomi
From: zhangshuxiao vfs_llseek will check whether the file mode has FMODE_LSEEK, no return failure. But ashmem can be lseek, so add FMODE_LSEEK to ashmem file. Signed-off-by: Shuxiao Zhang Tested-by: Greg Hackmann --- drivers/staging/android/ashmem.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Russell King - ARM Linux
On Thu, Apr 06, 2017 at 04:20:21PM +0200, Hans Verkuil wrote: > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt, choose the currently > > set field order. If the colorspace is set to DEFAULT, choose the current > > colorspace. If any of xfer_func, y

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Hans Verkuil
On 04/06/2017 03:55 PM, Philipp Zabel wrote: > If the the field order is set to ANY in set_fmt, choose the currently > set field order. If the colorspace is set to DEFAULT, choose the current > colorspace. If any of xfer_func, ycbcr_enc or quantization are set to > DEFAULT, either choose the curre

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Russell King - ARM Linux
On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote: > + > + /* Retain current field setting as default */ > + if (sdformat->format.field == V4L2_FIELD_ANY) > + sdformat->format.field = fmt->field; > + > + /* Retain current colorspace setting as default */ > +

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-04-06 Thread Brijesh Singh
Hi Boris, On 03/17/2017 05:17 AM, Borislav Petkov wrote: On Thu, Mar 16, 2017 at 11:25:36PM +0100, Paolo Bonzini wrote: The kvmclock memory is initially zero so there is no need for the hypervisor to allocate anything; the point of these patches is just to access the data in a natural way from

[PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-04-06 Thread Philipp Zabel
If the the field order is set to ANY in set_fmt, choose the currently set field order. If the colorspace is set to DEFAULT, choose the current colorspace. If any of xfer_func, ycbcr_enc or quantization are set to DEFAULT, either choose the current setting, or the default setting for the new colors

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-06 Thread Philipp Zabel
On Wed, 2017-04-05 at 11:53 -0300, Mauro Carvalho Chehab wrote: [...] > There are a number of drivers that can work with different > types of TV demodulators. Typical examples of such hardware can be > found at em28xx, saa7134, cx88 drivers (among lots of other drivers). > Those drivers don't use t

Re: [PATCH v6 19/39] media: Add i.MX media core driver

2017-04-06 Thread Philipp Zabel
On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam [...] > diff --git a/drivers/staging/media/imx/imx-media-of.c > b/drivers/staging/media/imx/imx-media-of.c > new file mode 100644 > index 000..b383be4 > --

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Jani Nikula
On Thu, 06 Apr 2017, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing fewer false positives.

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 02:47:11PM -0700, Kees Cook wrote: > While examining output from trial builds with -Wformat-security enabled, > many strings were found that should be defined as "const", or as a char > array instead of char pointer. This makes some static analysis easier, > by producing few

[PATCH v2] staging: rtl8192u: ieee80211: Fix space required after }.

2017-04-06 Thread Valerio Genovese
This was reported in checkpatch.pl: ERROR: space required after that close brace '}' Changes in v2: add space after close brace '}' also at line 35, before it was only for 34. Signed-off-by: Valerio Genovese --- drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 4 ++-- 1 file changed, 2 insert