Function contains extraneous newlines. Removing these lines aids
readability.
Remove extraneous newlines.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010
Function contains a block of code combined as a compound
statement. This would be better factored out into a separate function.
Factor compound statement out into a separate function.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 46 -
Function contains a large block of code that is guarded by an if
statement. There is some remaining code after block that does final
clean up of driver. If we add a goto label labeling the final cleanup
code we can invert the if statement and jump to goto label. This
allows the subsequent code to b
Function is a candidate for refactoring. None of the kernel static
analysis tools warn about this function but the function has a number
of code smells. There is a block of code separated into a anonymous
compound statement, this is not usual kernel code style and can easily
be factored into a sepa
Pick up your Western Union Funds $850,000 USD
Name...Country.. Phone Number
Mr Mike Morris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Function ks7010_upload_firmware() has two struct pointer parameters,
one of which is a member of the other. This is unnecessary.
Remove unnecessary function parameter.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 7 +++
1 file changed, 3 insertions(+), 4 deleti
Driver file ks7010_sdio.c contains a few function definition
anomalies. One function is defined with two parameters, one of which
is a struct member of the other. This is unnecessary.
A couple of functions with internal linkage take as input parameters
of type void *. All call sites then cast stru
Functions accept a parameter of type void *, this is then cast to a
ks_wlan_private pointer. All call sites have a ks_wlan_private pointer
and cast it to void *. We can remove the unnecessary casting by
changing the parameter type to match the usage.
Replace parameter of type void * with ks_wlan_p
Constant is used to allocate memory for a buffer, then buffer is
filled upto 'size' which is passed as a parameter. If 'size' is bigger
than the constant then the buffer will overflow. We could check the
'size' parameter and fail but better not to fail.
Use 'size' as the parameter to kmalloc() ins
I have tried to fix the endian issues in the mdc_request.c in the
lustre file system drivers in the staging area. Your feedback is
welcome.
CHECK drivers/staging/lustre/lustre/mdc/mdc_request.c
drivers/staging/lustre/lustre/mdc/mdc_request.c:958:42: warning: cast
to restricted __le64
drivers/sta
From: Vaibhav Kothari
Removed extra space before comma in memset() as a part of
checkpatch.pl fix-up.
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c
b/
On Tue, Mar 28, 2017 at 10:44:44AM +0530, vaibhavd...@gmail.com wrote:
> gc2235.c
Why is this file name here?
>
> Removed extra space before comma in memset() as a part of
> checkpatch.pl fix-up.
Why the extra space at the beginning of the line?
> Signed-off-by: Vaibhav Kothari
This doesn'
gc2235.c
Removed extra space before comma in memset() as a part of
checkpatch.pl fix-up.
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c
b/drivers/stag
From: Russell King
Add support for enumerating frame sizes and frame intervals from the
first subdev via the V4L2 interfaces.
Signed-off-by: Russell King
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-capture.c | 73 +++
1 file changed, 73 inse
Add __csi_get_fmt() and use it to return the correct mbus format
(active or try) in get_fmt. Use it in other places as well.
Signed-off-by: Steve Longerbeam
Suggested-by: Russell King
---
drivers/staging/media/imx/imx-media-csi.c | 61 ---
1 file changed, 47 insertio
From: Russell King
Add the bayer formats to imx-media's list of supported pixel and bus
formats.
Signed-off-by: Russell King
- added a bayer boolean to struct imx_media_pixfmt.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-utils.c | 68 +
This is a media entity subdevice driver for the i.MX Video De-Interlacing
or Combining Block. So far this entity does not implement the Combining
function but only motion compensated deinterlacing. Video frames are
received from the CSI and are routed to the IC PRPVF entity.
Signed-off-by: Steve L
From: Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle
to the currently set input format, not to the previous input format.
Signed-off-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 11 +--
1 file c
From: Philipp Zabel
Move the crop rectangle to the sink pad and add a sink compose rectangle
to configure scaling. Also propagate rectangles from sink pad to crop
rectangle, to compose rectangle, and to the source pads both in ACTIVE
and TRY variants of set_fmt/selection, and initialize the defau
From: Russell King
Add frame size and frame interval enumeration to CSI.
CSI can downscale the image independently horizontally and vertically by a
factor of two, which enumerates to four different frame sizes at the
output pads. The input pad supports a range of frame sizes.
CSI can also drop
As part of this, separate format try code from *_set_fmt() into
*_try_fmt(), so that the latter function can be used to propagate
a legal format from sink to source. This also reduces subsequent
bloat in *_set_fmt().
imx-ic-prp never needed separate formats for sink and source pads,
so propagation
Add frame size enumeration operation. The PRP ENC/VF subdevices
are scalers, so they can output a continuous range of widths/
heights on their source pads.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 40 +
1 file changed, 40 inser
If the attached sensor reports faulty frames at stream start via
g_skip_frames callback, add a delay to avoid them before enabling
the CSI hardware. Especially for sensors with a bt.656 interface,
any shifts in the SAV/EAV sync codes will cause the CSI to lose
vert/horiz sync.
Signed-off-by: Steve
From: Philipp Zabel
The CSI can skip any out of up to 6 input frames, allowing to reduce the
frame rate at the output pads by small fractions.
Signed-off-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
Signed-off-by: Russell King
---
drivers/staging/media/imx/imx-media-csi.c | 127
The previous API and negotiation of mbus codes and pixel formats
was broken, and has been completely redone.
The negotiation of media bus codes should be as follows:
CSI:
sink pad direct src pad IDMAC src pad
-
RGB (any)IPU RGB
From: Russell King
Bayer formats must be treated as generic data and passthrough mode must
be used. Add the correct setup for these formats.
Signed-off-by: Russell King
- added check to csi_link_validate() to verify that destination is
IDMAC output pad when passthrough conditions exist: bay
From: Russell King
Add support to CSI for negotiation of frame intervals, and use this
information to configure the frame interval monitor.
Signed-off-by: Russell King
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-csi.c | 46 +--
drivers/s
From: Philipp Zabel
The cropping rectangle was being modified by the output pad's
set_fmt, which is the wrong pad to do this. The crop rectangle
should not be modified by the output pad set_fmt. It instead
should be reset to the full input frame when the input pad format
is set.
The output pad s
Enable i.MX v4l2 media staging driver. For video capture on i.MX, the
video multiplexer subdev is required. On the SabreAuto, the ADV7180
video decoder is required along with i2c-mux-gpio. The Sabrelite
and SabreSD require the OV5640 and the SabreLite requires PWM clocks
for the OV5640.
Increase m
This is a set of three media entity subdevice drivers for the i.MX
Image Converter:
- Pre-process Router: Takes input frames from CSI0, CSI1, or VDIC.
Two output pads enable either or both of the preprocess tasks
below. If the input is from one of the CSIs, both proprocess task
links can be
Add the core media driver for i.MX SOC.
Signed-off-by: Steve Longerbeam
---
Documentation/media/v4l-drivers/imx.rst | 590 ++
drivers/staging/media/Kconfig | 2 +
drivers/staging/media/Makefile| 1 +
drivers/staging/media/imx/
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required
for sensors with a MIPI CSI2 interface.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/Makefile | 1 +
drivers/staging/media/imx/imx6-mipi-csi2.c | 673 +
2 files changed, 674 ins
Add pinctrl groups for both GPT input capture channels.
Signed-off-by: Steve Longerbeam
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 21dea5
This is a media entity subdevice for the i.MX Camera
Sensor Interface module.
Signed-off-by: Steve Longerbeam
---
drivers/staging/media/imx/Kconfig | 14 +
drivers/staging/media/imx/Makefile|2 +
drivers/staging/media/imx/imx-media-csi.c | 1318 +
This is the capture device interface driver that provides the v4l2
user interface. Frames can be received from various sources:
- directly from CSI for capturing unconverted images directly from
camera sensors.
- from the IC pre-process encode task.
- from the IC pre-process viewfinder task.
This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta
branch, modified heavily to bring forward to latest interfaces and code
cleanup.
Signed-off-by: Steve Longerbeam
---
drivers/media/i2c/Kconfig |7 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/ov5640.c |
Enables the ADV7180 decoder sensor. The ADV7180 connects to the
parallel-bus mux input on ipu1_csi0_mux.
The ADV7180 power pin is via max7310_b port expander.
Signed-off-by: Steve Longerbeam
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58
1 file changed, 58 i
This adds a header file for use by userspace programs wanting to interact
with the i.MX media driver. It defines custom events and v4l2 controls for
the i.MX v4l2 subdevices.
Signed-off-by: Steve Longerbeam
---
include/linux/imx-media.h | 27 +++
1 file changed, 27 insert
From: Philipp Zabel
Signed-off-by: Philipp Zabel
- renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX
Signed-off-by: Steve Longerbeam
---
Documentation/media/uapi/mediactl/media-types.rst | 22 ++
include/uapi/linux/media.h| 6 ++
2 files changed,
From: Philipp Zabel
This driver can handle SoC internal and external video bus multiplexers,
controlled either by register bit fields or by a GPIO. The subdevice
passes through frame interval and mbus configuration of the active input
to the output side.
Signed-off-by: Sascha Hauer
Signed-off-b
v4l2_pipeline_inherit_controls() will add the v4l2 controls from
all subdev entities in a pipeline to a given video device.
Signed-off-by: Steve Longerbeam
---
drivers/media/v4l2-core/v4l2-mc.c | 50 +++
include/media/v4l2-mc.h | 31 +
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor.
The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux.
The OV5640 connects to the input port on the MIPI CSI-2 receiver on
mipi_csi.
Until the OV5652 sensor module compatible with the SabreSD becomes
avai
Adds the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor.
Both hang off the same i2c2 bus, so they require different (and non-
default) i2c slave addresses.
The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux.
The OV5640 connects to the input port on the MIPI CSI-
The sabreauto uses a steering pin to select between the SDA signal on
i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control
this steering pin. Idle state of the i2cmux selects SPI NOR. This is not
a classic way to use i2cmux, since one side of the mux selects something
other than a
The reset pin to the port expander chip (MAX7310) is controlled by a gpio,
so define a reset-gpios property to control it. There are three MAX7310's
on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for
their reset. Since all can't acquire the same pin, assign it to max7310_b,
tha
From: Philipp Zabel
This patch adds the device tree graph connecting the input multiplexers
to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU
multiplexers are added as children of the iomuxc-gpr syscon device node.
On i.MX6Q/D two two-input multiplexers in front of IPU1 CSI0 and IPU
There is a pin conflict with GPIO_6. This pin functions as a power
input pin to the OV5642 camera sensor, but ENET uses it as the h/w
workaround for erratum ERR006687, to wake-up the ARM cores on normal
RX and TX packet done events. So we need to remove the h/w workaround
to support the OV5642. The
Signed-off-by: Steve Longerbeam
---
arch/arm/boot/dts/imx6dl.dtsi | 5 +
arch/arm/boot/dts/imx6q.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
index 8958c4a..a959c76 100644
--- a/arch/arm/boot/dts/imx6dl.dtsi
+++
Add to the MIPI CSI2 receiver node: compatible strings,
interrupt sources, and clocks.
Signed-off-by: Steve Longerbeam
---
arch/arm/boot/dts/imx6qdl.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 6d7bf64..d28a
Add bindings documentation for the i.MX media driver.
Signed-off-by: Steve Longerbeam
---
Documentation/devicetree/bindings/media/imx.txt | 74 +
1 file changed, 74 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/imx.txt
diff --git a/Documentati
Add device tree binding documentation for the OV5640 camera sensor.
Signed-off-by: Steve Longerbeam
---
.../devicetree/bindings/media/i2c/ov5640.txt | 45 ++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt
dif
From: Philipp Zabel
Add bindings documentation for the video multiplexer device.
Signed-off-by: Sascha Hauer
Signed-off-by: Philipp Zabel
Signed-off-by: Steve Longerbeam
---
.../bindings/media/video-multiplexer.txt | 59 ++
1 file changed, 59 insertions(+)
crea
In version 6:
- moved FIM error event back to a i.MX private event. I would like to
leave this as a (private) event rather than reporting a vb2 queue
error, for now. If and when the i.MX6 timer input capture patch is
accepted later, then this event can become a queue error.
- removed new-fr
On Sat, Mar 25, 2017 at 6:28 PM, Prasant Jalan wrote:
> On Sat, Mar 25, 2017 at 6:01 PM, Arushi Singhal
> wrote:
>>
>>
>> On Sat, Mar 25, 2017 at 5:40 PM, Prasant Jalan
>> wrote:
>>>
>>>
>>> Replacing spaces with tabs for indetation to fix checkpatch.pl error
>>> "code indent should use tabs whe
Driver contains dead code, guarded with #ifdef's. We can safely remove
this, it will be in the git history if it is later needed.
Remove dead code.
Signed-off-by: Tobin C. Harding
---
drivers/staging/dgnc/dgnc_neo.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgn
Driver uses magic number members within structs, this is an antiquated
method of catching data errors. We don't do things that way any more.
Remove magic number struct members. Remove all checks to magic
numbers.
Signed-off-by: Tobin C. Harding
---
drivers/staging/dgnc/dgnc_cls.c| 44 +
Pre-processor header guards use double underscore, typically kernel
code uses single underscore when defining header guards. 'endif'
statement should include what is ending as a comment string.
Remove double underscore, add comment string to 'endif'
Signed-off-by: Tobin C. Harding
---
drivers/s
TODO file lists task to remove unnecessary comments.
Make initial attempt at removing unnecessary comments. Choose not to
be to vicious in removal. We can remove more once the driver is
cleaned up/tested some more.
For functions with internal linkage, reduce the function comment where
possible. F
TODO file lists task to remove unnecessary error messages. There are
no unnecessary error messages in the driver, this must have been done
already.
Remove task from TODO file.
Signed-off-by: Tobin C. Harding
---
drivers/staging/dgnc/TODO | 2 --
1 file changed, 2 deletions(-)
diff --git a/driv
TODO file has task: remove unnecessary comments. Driver uses some
custom comment format. Driver would be better if it used kernel doc
format.
Audit header file comments. Replace struct comments with kernel doc
format comments. Remove unnecessary comments.
Signed-off-by: Tobin C. Harding
---
dri
Digi claims on their website that their cards (Neo and Classic)
have Linux driver support. These drivers have apparently not been
tested though since 2.6 kernel. Are these drivers on their way into
the kernel or out? If they are not on their way into the kernel then
this patch set seems like a wast
From: Haiyang Zhang
Date: Mon, 27 Mar 2017 00:50:27 +
>
>
>> -Original Message-
>> From: Colin King [mailto:colin.k...@canonical.com]
>> Sent: Saturday, March 25, 2017 10:27 AM
>> To: KY Srinivasan ; Haiyang Zhang
>> ; Stephen Hemminger ;
>> de...@linuxdriverproject.org; net...@vger
On 03/27/2017 06:14 PM, Stephen Hemminger wrote:
> Are you sure the real problem is not the one fixed by this commit?
>
> commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f
> Author: Stephen Hemminger
> Date: Tue Mar 7 09:15:53 2017 -0800
>
> scsi: storvsc: Workaround for virtual DVD SCSI versi
Are you sure the real problem is not the one fixed by this commit?
commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f
Author: Stephen Hemminger
Date: Tue Mar 7 09:15:53 2017 -0800
scsi: storvsc: Workaround for virtual DVD SCSI version
Hyper-V host emulation of SCSI for virtual DVD de
Hi Long Li,
A kernel bug report was opened against Ubuntu [0]. After a kernel
bisect, it was found that reverting the following commit resolved this bug:
commit 40630f462824ee24bc00d692865c86c3828094e0
Author: Long Li
Date: Wed Dec 14 18:46:03 2016 -0800
scsi: storvsc: properly set resid
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of k...@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helg...@kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of k...@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helg...@kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o
> > 2 --
> > 1 file changed, 2 deletions(-)
>
> Ugh, Alan, what's going on here, I thought you fixed this?
I sent you a patch that removed the arrays entirely and turned it into
a single string as well as removing the define. Not quite sure what
happened but I've resynched to -next and I'll send
Hi Boris,
On 03/24/2017 12:12 PM, Borislav Petkov wrote:
}
+static inline int __init early_set_memory_decrypted(void *addr,
+ unsigned long size)
+{
+ return 1;
return 1 when !CONFIG_AMD_MEM_ENCRYPT ?
The non-early var
This patch fix a minor coding style issue.
Signed-off-by: sfaragnaus
---
drivers/staging/xgifb/XGI_main_26.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index d938da3..b450c74 100644
--- a/drivers/staging/xgifb/XG
On Mon, Mar 27, 2017 at 5:12 PM, wrote:
> From: Vaibhav Kothari
"From: .." should not be included in the patch. The subject is still
incorrect, there should be a space after each colon. The subject
should give overview of changes made in the patch.
It is preferred to fix single checkpatch issue
On Mon, Mar 27, 2017 at 2:13 PM, aviyae wrote:
> I'll remove that eudyptula thing, although there are some patches that
> mention it
>
> (run git log --grep=eudyptula)
I haven't checked that and I think it's a shame it didn't get removed.
I don't think it adds value to the patch, as it's just fo
Fix coding style issues in macros:
1. Add parenthesis around macro arguments
2. Avoid arguments reuse in macro
Signed-off-by: Aviya Erenfeld
---
drivers/staging/goldfish/goldfish_audio.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/goldfish/goldfish
I'll remove that eudyptula thing, although there are some patches that mention
it
(run git log --grep=eudyptula)
On 27/03/17 15:05, Frans Klaver wrote:
> On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote:
>> From: Aviya Erenfeld
>>
>> staging: goldfish: Fix style issues in macros
>>
>> Fix coding
On Fri, Mar 24, 2017 at 03:02:45PM +0600, Anar Adilova wrote:
> This patch fixes the checkpatch.pl warning:
>
> EXPORT_SYMBOL(foo); should immediately follow its function/variable.
>
> The EXPORT_SYMBOL statements are placed inside if blocks, after both function
> implementations.
>
Please alwa
On Mon, Mar 27, 2017 at 1:52 PM, aviyae wrote:
> From: Aviya Erenfeld
>
> staging: goldfish: Fix style issues in macros
>
> Fix coding style issues in macros:
> 1. Add parenthesis around macros argument
> 2. Avoid arguments reuse in macros
>
> (For the eudyptula challenge)
How is that relevant?
From: Aviya Erenfeld
staging: goldfish: Fix style issues in macros
Fix coding style issues in macros:
1. Add parenthesis around macros argument
2. Avoid arguments reuse in macros
(For the eudyptula challenge)
Signed-off-by: Aviya Erenfeld
---
drivers/staging/goldfish/goldfish_audio.c | 8 +++
From: Vaibhav Kothari
- Fixing up check-patch error & Warnings
- Added blank line between declaration and defination
at various places
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff -
From: Vaibhav Kothari
- Removed white-space before comma in memset()
- Added blank line between declaration and defination
at various places
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
On Mon, Mar 27, 2017 at 4:01 PM, wrote:
> From: Vaibhav Kothari
>
> - Removed white-space before comma in memset()
> - Added blanck line between declaration and defination
> at various places
The patch subject is incorrect. It should specify what error are you
fixing and also to which driver.
From: Vaibhav Kothari
- Removed white-space before comma in memset()
- Added blanck line between declaration and defination
at various places
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
From: Vaibhav Kothari
- Removed white-space before comma in memset()
- Added blanck line between declaration and defination
at various places
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
On Mon, Mar 27, 2017 at 12:53:21PM +0300, aviyae wrote:
> fixing some coding style issues in goldfish audio driver
>
> >From 8368d1b6404d63da7d502f6cd2ce6b50c7ffa9b9 Mon Sep 17 00:00:00 2001
> From: Aviya Erenfeld
> Date: Tue, 21 Mar 2017 00:07:19 +0200
> Subject: [PATCH] staging: goldfish: Fix
fixing some coding style issues in goldfish audio driver
>From 8368d1b6404d63da7d502f6cd2ce6b50c7ffa9b9 Mon Sep 17 00:00:00 2001
From: Aviya Erenfeld
Date: Tue, 21 Mar 2017 00:07:19 +0200
Subject: [PATCH] staging: goldfish: Fix coding style issues
Fix the coding style issues that raised by check
The timeout variable could be zero even if the bits has expected result.
The checking expected bits again would be better instead whether
the timeout value is zero or not.
Signed-off-by: Daeseok Youn
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +++---
1 file changed, 3 inser
On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> > Thanks for this :) Could you also move the function higher in the same
> > file - above line 139 where all static functions are defined?
>
> I'd say no need for this. s
Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> Thanks for this :) Could you also move the function higher in the same
> file - above line 139 where all static functions are defined?
I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static v
Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva
Yes, indeed.
Reviewed-by: Samuel Thibault
Thanks
> ---
> drivers/staging/speakup/seria
Hi Gustavo,
On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/staging/speakup/serialio.c | 2 +-
> 1 file changed, 1 ins
Fix the following sparse warning:
symbol 'spk_serial_out' was not declared. Should it be static?
Signed-off-by: Gustavo A. R. Silva
---
drivers/staging/speakup/serialio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/serialio.c
b/drivers/staging/spe
90 matches
Mail list logo
