On Wed, Mar 22, 2017 at 08:19:42AM +0530, Arushi Singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/iio/adc/ad7816.c | 2 +-
> dri
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
.../staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 12 ++--
.../media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 6 +
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss_ipipe.c | 2 +-
drivers/staging/media/omap4is
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
drivers/staging
Replace a bit shift by a use of BIT in media driver.
Arushi Singhal (3):
staging: media: Replace a bit shift by a use of BIT.
staging: media: davinci_vpfe: Replace a bit shift by a use of BIT.
staging: media: omap4iss: Replace a bit shift by a use of BIT.
.../media/atomisp/pci/atomisp2/ato
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/octeon/ethernet-tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/eth
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/adc/ad7816.c | 2 +-
drivers/staging/iio/cdc/ad7150.c | 2 +-
drivers/staging/iio/cdc/ad7746.c | 22 +++--
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk75
Fixed checkpatch WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Eddie Youseph
---
Changes in v2:
- Added changelog
drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/dri
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c| 8
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 4 ++--
drivers/staging/fbtft/fb_ili9163.c | 2 +-
drivers/staging/fbtft/fb_ili9325.c
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rts
Function lends itself to being refactored. There are two checkpatch
issues generated from this function.
Patch 01 removes a redundant nested conditional check.
Patch 02 inverts two conditionals, and reduces the subsequent code
indentation.
Tobin C. Harding (2):
staging: ks7010: remove redundan
Function checks for condition inside a loop that checks the same
condition, this is redundant. Fix also removes checkpatch CHECK.
Remove redundant check.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/
Checkpatch emits WARNING: Avoid multiple line dereference.
Function uses if statement blocks to guard the body of the
function. If we invert these conditionals and return, then the code
becomes more readable and subsequent code is indented less. The
checkpatch fix then follows trivially.
Invert c
The addition of curly braces around single statements that span
multiple lines makes the code more readable in general.
Add curly braces to multi-line indented statement.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 18 ++
1 file changed, 10 insertion
When checking the value of a variable that holds a 0 an explicit check
is good style. i.e
-if (!size)
+if (size == 0)
Update checks on 'numerical' variables to use explicit checks.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
drivers/staging/ks
Review from previous (merged) patch set made comment on a couple of
style issues. In the same review a bug was reported. We start off
fixing the bug then move on to fix the style issues. None of these
issues are reported by checkpatch, Sparse, or Smatch. Some instances
were introduced by Tobin Hard
Calls to functions memcmp() and strcmp() are more clearly readable
when the return value is explicitly checked. i.e
if (memcmp(foo, bar, size) == 0)
Modify driver to use an explicit check on the value returned by
memcmp().
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c
Call site to memcmp() treats return value as if it were an error code,
it is not. If memcmp() finds inputs to be not the same, an error
return code should be set explicitly.
Correctly handle return value from call to memcmp(), set error code
explicitly.
Reported-by: Dan Carpenter
Signed-off-by:
Hello,
So Rob, how do you see this going? Shall we introduce a serdev_device
*tty_port_register_serdev_device(tty, device)? Will you work on it or
should I give it a try?
Samuel
Samuel Thibault, on mer. 15 mars 2017 16:03:23 +0100, wrote:
> Rob Herring, on mer. 15 mars 2017 09:45:59 -0500, wrot
On 03/21/2017 04:27 AM, Russell King - ARM Linux wrote:
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
@@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv,
incc = imx_media_find_mbus_format(infmt->code,
This gathers emitting the caps start string, space, spelled letter
string, space, and caps stop string, into one printf, to avoid
sending to the synth a space character alone, which the synth would
then pronounce.
Similarly, emit space along control-letter and letter spelling.
Signed-off-by: Samu
On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote:
> On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > > Fixed style of all block comments across whole driver
> > > Found by checkpatch
> > >
> > > Signed-off-by
Hi Philipp, Russell,
On 03/20/2017 10:23 AM, Philipp Zabel wrote:
Hi Steve, Russell,
What do you think of this:
--8<--
From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001
From: Philipp Zabel
Date: Mon, 20 Mar 2017 17:10:21 +0100
Subject: [PATCH] media: im
On Tue, Mar 21, 2017 at 03:53:46PM +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 01:37:12PM +1100, Tobin C. Harding wrote:
> > static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32
> > address,
> > unsigned char *data, unsigned int size)
> >
On Tue, Mar 21, 2017 at 03:49:22PM +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote:
> > Comparison, equal to zero, is redundant
> >
> > 'if (foo == 0)' is equal to 'if (!foo)'
> >
> > Typical kernel coding style is to use the shorter form.
> >
> >
On Tue, Mar 21, 2017 at 03:36:34PM +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote:
> > Checkpatch emits CHECK: Unbalanced braces around else
> > statement. Statements in question are single statements so we do not
> > need braces. Checkpatch also warn
Thanks for taking a look, Dan. Sorry if I missed the mark here.
Can you tell me a bit more about the bug this would introduce?
I see that ieee80211_is_action is defined like this: static inline bool
ieee80211_is_action(__le16 fc)
...and that buff[FRAME_TYPE_ID]is a u8 (since FRAME_TYPE_ID = 0).
Michael Zoran writes:
> On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote:
>> Michael Zoran writes:
>>
>> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> > > Michael Zoran writes:
>> > >
>> > > > > > Since the API is completely documented, I see no reason we
>> > > > > > or
>> >
On Tue, 2017-03-21 at 23:30 +0300, Dan Carpenter wrote:
> I've read Stefan's review comments and intervened where I didn't
> understand them. The recent ones are very specific and reasonable...
>
> Just send a v2. I don't get what the deal is...
Partly because Eric and Stefan have publically an
I've read Stefan's review comments and intervened where I didn't
understand them. The recent ones are very specific and reasonable...
Just send a v2. I don't get what the deal is...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproje
On Tue, Mar 21, 2017 at 01:55:40PM -0600, Perry Hooker wrote:
> This commit fixes the following sparse warnings:
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1473:45: warning: incorrect
> type in argument 1 (different base types)
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:
On Tue, 2017-03-21 at 12:09 -0700, Michael Zoran wrote:
> On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote:
> > Michael Zoran writes:
> >
> > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> > > > Michael Zoran writes:
> > > >
> > > > > > > Since the API is completely documented, I
This commit fixes the following sparse warnings:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1473:45: warning: incorrect
type in argument 1 (different base types)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect
type in assignment (different base types)
drivers/
On 20/03/17 12:53, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used to protect hardware stat
On 21/03/17 15:06, Arushi Singhal wrote:
> Typedefs are removed in sm750fb driver.
>
> Arushi Singhal (2):
> staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
> staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
>
> drivers/staging/sm750fb/ddk750_mode.c
On 21/03/17 15:05, SIMRAN SINGHAL wrote:
> On Tue, Mar 21, 2017 at 8:01 PM, kbuild test robot wrote:
>> Hi simran,
>>
>> [auto build test WARNING on iio/togreg]
>> [also build test WARNING on v4.11-rc3 next-20170321]
>> [if your patch is applied to the wrong g
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote:
> Michael Zoran writes:
>
> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
> > > Michael Zoran writes:
> > >
> > > > > > Since the API is completely documented, I see no reason we
> > > > > > or
> > > > > > anybody
> > > > > > could
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
On Tue, Mar 21, 2017 at 11:33:54PM +0530, simran singhal wrote:
> The patch series replaces mlock with a private lock for driver ad9834 and
> Fix coding style issues related to white spaces.
Hi Simran,
I'm getting lost. Patchset Subject Line needs subsystem and driver.
The comment above says a
On Wed, Mar 22, 2017 at 12:10:50AM +0530, Prasant Jalan wrote:
> This patch replaces spaces with tabs for indentation as per kernel
> coding standards.
>
> Signed-off-by: Prasant Jalan
> ---
> drivers/staging/vt6656/rf.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
Didn't
On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote:
> On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > > Fixed style of all block comments across whole driver
> > > Found by checkpatch
> > >
> > > Signed-off-by
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c
On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote:
> On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
>
> Hi Simran,
>
> I going to ask for a v7 without looking at the code ;)
> Subject line needs subsystem and driver.
> Subject and log message can be improved.
>
>> The IIO s
On Tue, Mar 21, 2017 at 10:25:40PM +0530, Prasant Jalan wrote:
> This patch replaces spaces with tabs for indentation as per kernel
> coding standards.
>
> Signed-off-by: Prasant Jalan
> ---
> drivers/staging/vt6656/rf.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> dif
On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote:
> On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote:
> > Fixed style of all block comments across whole driver
> > Found by checkpatch
> >
> > Signed-off-by: Derek Robson
> > ---
> > drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall wrote:
>
>
>On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>>
>>
>> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
>
>> wrote:
>> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>> >
>> >
>> > On Tue, 21 Ma
> -Original Message-
> From: Cathy Avery [mailto:cav...@redhat.com]
> Sent: Friday, March 17, 2017 8:18 AM
> To: KY Srinivasan ; h...@infradead.org; Haiyang Zhang
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com
> Cc: step...@networkplumber.org; dan.carpen...@oracle.com;
> de...@
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
This patch removes trailing whitespaces in order to follow the Linux
coding style.
Signed-off-by: simran singhal
---
drivers/staging/iio/meter/ade7753.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7753.c
b/drivers/staging/iio/meter/ad
The patch series replaces mlock with a private lock for driver ad9834 and
Fix coding style issues related to white spaces.
v3:
-Using new private "lock" instead of using "buf_lock"
as it can cause deadlock.
-Sending it as a series of two patches.
v2:
-Using the existing buf_lock instead
On Tue, Mar 21, 2017 at 10:34:01PM +0530, SIMRAN SINGHAL wrote:
> On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield
> wrote:
> > On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
> >
> > Hi Simran,
> >
> > I going to ask for a v7 without looking at the code ;)
> > Subject line need
On Tue, Mar 21, 2017 at 10:52:46PM +0530, Arushi Singhal wrote:
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
> wrote:
>
> > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> > >
> > > > On Tue, Mar 21, 2017 at 9:33
Michael Zoran writes:
> On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote:
>> Michael Zoran writes:
>>
>> > > > Since the API is completely documented, I see no reason we or
>> > > > anybody
>> > > > couldn't essentially rewrite the driver while it's in
>> > > > staging. I
>> > > > just
>>
On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
>
> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield
> wrote:
> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017
On Tue, 21 Mar 2017, Alison Schofield wrote:
> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 21 Mar 2017, Arushi Singhal wrote:
> >
> > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> > > wrote:
> > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arus
On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote:
> On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
>
> Hi Simran,
>
> I going to ask for a v7 without looking at the code ;)
> Subject line needs subsystem and driver.
> Subject and log message can be improved.
Hi Alison,
I
On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:
>
>
> On Tue, 21 Mar 2017, Arushi Singhal wrote:
>
> > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> > wrote:
> > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > > Patchseries of IIO coding tasks
This patch replaces spaces with tabs for indentation as per kernel
coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c8
On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote:
Hi Simran,
I going to ask for a v7 without looking at the code ;)
Subject line needs subsystem and driver.
Subject and log message can be improved.
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only
On Tue, 21 Mar 2017, Arushi Singhal wrote:
> On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield
> wrote:
> On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> > Patchseries of IIO coding tasks
>
> This wouldn't be a patchset. Although they touch the same
>
On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote:
> Patchseries of IIO coding tasks
This wouldn't be a patchset. Although they touch the same
driver, the changes are unrelated. See more below...
>
> Arushi Singhal (2):
> staging: ad7759: Replace mlock with driver private lock
T
This patch fixes the following:
- Replace spaces with tabs for indentation
- adds spaces around symbol '-'
- uses __func__ macro to print function name
- truncated the line such that it is within 80 char limit
as per kernel coding standards.
Signed-off-by: Prasant Jalan
---
drivers/staging/vt665
This patch removes typedefs from enum and renames it from "typedef enum
_spolarity_t" to "enum spolarity" as per kernel coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.h | 11 +--
1
This patch removes typedefs from struct and renames it from "typedef
struct _mode_parameter_t" to "struct mode_parameter" as per kernel
coding standards."
Signed-off-by: Arushi Singhal
---
changes in v2
-change the subject and commit message of PATCH.
drivers/staging/sm750fb/ddk750_mode.c | 8
Typedefs are removed in sm750fb driver.
Arushi Singhal (2):
staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t"
staging: sm750fb: Remove typedef from "typedef enum _spolarity_t"
drivers/staging/sm750fb/ddk750_mode.c | 8 +---
drivers/staging/sm750fb/ddk750_mode.h |
On Tue, Mar 21, 2017 at 8:01 PM, kbuild test robot wrote:
> Hi simran,
>
> [auto build test WARNING on iio/togreg]
> [also build test WARNING on v4.11-rc3 next-20170321]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
&g
Fixed coding style errors. No errors with checkpatch.pl
Signed-off-by: Prasant Jalan
---
drivers/staging/vt6656/rf.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 068c1c8..3a9d19a 100644
--
Hi simran,
[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.11-rc3 next-20170321]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/simran-singhal/staging-Use-buf_lock
* Dan Carpenter [2017-03-21 15:55:52 +0300]:
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
Resolving 2 checkpatch warnings generated due to:
CHECK: spaces preferred around that '-'
Signed-off-by: Matthew Giassa
---
drivers/staging/vt6656/rf.c | 6 +++---
1 file changed, 3
The contents of ade7759.h are only used in ade7759.c.
Move the header contents to the implemtation file,
and delete the header file.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 52 ++-
drivers/staging/iio/meter/ade7759.h | 54 --
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
Patchseries of IIO coding tasks
Arushi Singhal (2):
staging: ad7759: Replace mlock with driver private lock
staging: iio: ade7759: Move header content to implementation file
drivers/staging/iio/meter/ade7759.c | 56 +--
drivers/staging/iio/meter/ade7759.h
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
> Resolving 2 checkpatch warnings generated due to:
> CHECK: spaces preferred around that '-'
>
> Signed-off-by: Matthew Giassa
> ---
> drivers/staging/vt6656/rf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> d
On Tue, Mar 21, 2017 at 01:37:12PM +1100, Tobin C. Harding wrote:
> static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32
> address,
> unsigned char *data, unsigned int size)
> {
> - int rc;
> + int ret;
> unsigned char *read_buf;
>
On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote:
> Comparison, equal to zero, is redundant
>
> 'if (foo == 0)' is equal to 'if (!foo)'
>
> Typical kernel coding style is to use the shorter form.
>
> Remove unnecessary zero comparison.
Not exactly. If you're talking about the
Replace simple_strtoul with kstrtoint.
simple_strtoul is marked for obsoletion as reported by checkpatch.pl
Signed-off-by: Marcin Ciupak
---
v2:
-improving kstrtoint error handling
-updating commit message
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 16
On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote:
> Checkpatch emits CHECK: Unbalanced braces around else
> statement. Statements in question are single statements so we do not
> need braces. Checkpatch also warns about multiple line dereference for
> this code.
>
> Fix if/else/els
On Tue, Mar 21, 2017 at 04:51:03AM -0700, Michael Zoran wrote:
> The original version seems to have been applied at this point. The
> whole function looks like it could use some cleanup in general. Should
> I just submit those an independent patch when I get to it or should I
> submit a V2 the wa
On Tue, Mar 21, 2017 at 04:56:38PM +0530, Arushi Singhal wrote:
> This patch removes typedefs from structure and renames them as
> per kernel coding standards.
In the subject, and in the text, say _which_ typedef you changed, and
what you changed it to.
Same for your patch 2/2.
thanks,
greg k-h
On Tue, 2017-03-21 at 14:45 +0300, Dan Carpenter wrote:
> On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote:
> > On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> > > You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> > > that. Just
> > > fix Dave's patch and add a
On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote:
> On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> > You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> > that. Just
> > fix Dave's patch and add a note in the commit log.
> >
> > regards,
> > dan carpenter
> >
>
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 2 +-
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/serialio.c | 2 +-
drivers/staging/speakup/speakup_acntpc.c |
Unnecessary parentheses are removed to improve readability.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index afb61e153592..ca8547
Moved logical OR operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/sta
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions(+
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/main.c| 32 ++
Fixed the checkpatch.pl issues like:
CHECK: spaces preferred around that '&' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
etc.
Signed-off-by: Arushi Singhal
---
drivers/staging/spea
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 21e76b
This patch fixes the checks reported by checkpatch.pl
for braces {} should be used on all arms of this statement.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 35 +++-
drivers/staging/speakup/speakup_decext.c | 6 +++---
drivers/stagin
Moved logical operator to previous line to fix the following
checkpatch issue:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/s
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/selection.c | 2 +-
drivers/staging/speakup/varhandlers.c
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (11):
staging: speakup: Moved logical to previous line.
staging: speakup: Remove multiple assignments
staging: speakup: Simplify "NULL" comparisons
staging: speakup: fixes braces {} should be used
On Tue, Mar 21, 2017 at 11:59:02AM +0100, Hans Verkuil wrote:
> Ah, good to hear that -s works with MC. I was not sure about that.
> Thanks for the feedback!
Not soo good on iMX6:
$ v4l2-compliance -d /dev/video10 -s --expbuf-device=/dev/video0
...
Input ioctls:
test VIDIOC_G/S_TUNER/ENUM
On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote:
> You're fixing a bug you introduced in [PATCH 1/5]. Don't do
> that. Just
> fix Dave's patch and add a note in the commit log.
>
> regards,
> dan carpenter
>
OK, thanks I'm still learning about the whole process. It looks like
Dave's ve
On Mon, Mar 20, 2017 at 06:23:24PM +0100, Philipp Zabel wrote:
> @@ -1173,15 +1196,8 @@ static void csi_try_fmt(struct csi_priv *priv,
> incc = imx_media_find_mbus_format(infmt->code,
> CS_SEL_ANY, true);
>
> - if (sdformat
1 - 100 of 139 matches
Mail list logo
