Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread Michael Zoran
On Sun, 2017-03-19 at 13:27 +0800, kbuild test robot wrote: > Hi Michael, > > [auto build test WARNING on staging/staging-testing] > [also build test WARNING on next-20170310] > [cannot apply to linux-rpi/for-rpi-next v4.11-rc2] > [if your patch is applied to the wrong git tree, please drop us a >

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread kbuild test robot
Hi Michael, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20170310] [cannot apply to linux-rpi/for-rpi-next v4.11-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/li

[PATCH] staging: bcm2835-firmware-gpio: fix platform_no_drv_owner.cocci warnings

2017-03-18 Thread kbuild test robot
drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c:271:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Michael Zoran Signed-off-by: Fengg

[PATCH v2 2/3] staging: speakup: Remove multiple assignments

2017-03-18 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- changes in v2 - no change. drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.

[PATCH v2 3/3] staging: speakup: Simplify "NULL" comparisons

2017-03-18 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- changes in v2 - no change drivers/staging/speakup/selection.c | 2 +- drivers/st

[PATCH v2 1/3] staging: speakup: Moved logical to previous line.

2017-03-18 Thread Arushi Singhal
Moved logical AND operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- changes in v2 - Change the commit message. drivers/staging/speakup/main.c | 12 ++-- 1 file changed, 6 inse

[PATCH v2 0/3] staging: speakup: Multiple checkpatch issues

2017-03-18 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (3): staging: speakup: Moved logical to previous line. staging: speakup: Remove multiple assignments staging: speakup: Simplify "NULL" comparisons drivers/staging/speakup/main.c| 30 ++

[PATCH v2] vmbus: fix missed ring events on boot

2017-03-18 Thread Stephen Hemminger
During initialization, the channel initialization code schedules the tasklet to scan the VMBUS receive event page (i.e. simulates an interrupt). The problem was that it invokes the tasklet on a different CPU from where it normally runs and therefore if an event is present, it will clear the bit but

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 19, 2017, at 12:41 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace all the nasty fake proc

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Greg Kroah-Hartman
On Sun, Mar 19, 2017 at 12:41:20AM -0400, Oleg Drokin wrote: > > On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote: > > > On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: > >> > >> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > >> > >>> On Sat, Mar 18, 2017 at 02:24:0

[PATCH] staging: speakup: fix: braces {} should used on all arms of statement

2017-03-18 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 35 +++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/stagin

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread Michael Zoran
On Sat, 2017-03-18 at 14:25 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > This change adds the driver to the standard kernel build system. > > > > Signed-off-by: Michael Zoran > > --- > >  drivers/staging/vc04_services/Kconfig 

[PATCH] staging: speakup: Remove multiple assignments

2017-03-18 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 21e76b

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-18 Thread Michael Zoran
On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > From: Dave Stevenson > > > > Pi3 and Compute Module 3 have a GPIO expander that the > > VPU communicates with. > > There is a mailbox service that now allows con

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Greg Kroah-Hartman
On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: > Ever since sysfs migration, class_process_proc_param stopped working > correctly as all the useful params were no longer present as lvars. > Replace all the nasty fake proc writes with hopefully less nasty > kobject attribute search and

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 19, 2017, at 12:29 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: >> >> On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: >> >>> On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: Ever since sysfs migration, class_process_

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Greg Kroah-Hartman
On Sat, Mar 18, 2017 at 11:17:55AM -0400, Oleg Drokin wrote: > > On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > > > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: > >> Ever since sysfs migration, class_process_proc_param stopped working > >> correctly as all the useful par

[PATCH] Staging: rtl8192e - fixed style of block comments

2017-03-18 Thread Derek Robson
Fixed style of block comment across whole driver Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 +- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.h | 2 +- drivers/stag

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 08:41:14PM -0400, Nicolas Dufresne wrote: > Le samedi 18 mars 2017 à 20:43 +, Russell King - ARM Linux a > écrit : > > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > > Can you share your gstreamer pipeline? For now, until > > > VIDIOC_ENUM_FRAMESIZ

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Nicolas Dufresne
Le samedi 18 mars 2017 à 20:43 +, Russell King - ARM Linux a écrit : > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > Can you share your gstreamer pipeline? For now, until > > VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that > > does not attempt to specify a fra

[PATCH] Staging: ks7010 - fixed style block comments

2017-03-18 Thread Derek Robson
Fixed style of all block comments across whole driver Found by checkpatch Signed-off-by: Derek Robson --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- drivers/staging/ks7010/ks_hostif.h | 35 +- drivers/staging/ks7010/ks_wlan.h | 3 ++- drivers/staging/ks7010

[PATCH v2 2/6] staging: media: atomisp: add missing dependencies in Kconfig

2017-03-18 Thread Jérémy Lefaure
Two dependencies were missing to build atomisp drivers: _ MEDIA_CONTROLLER: to use the entity field of v4l2_subdev structure. Since every atomisp driver needs MEDIA_CONTROLLER has a dependency, let's add it to INTEL_ATOMISP _ EFI: to use efivar_entry_get: drivers/built-in.o: In function `gmin_get

[PATCH v2 3/6] staging: media: atomisp: select REGMAP_I2C needed by ap1302.c

2017-03-18 Thread Jérémy Lefaure
REGMAP_I2C should be enabled to build the driver ap1302 because it uses regmap functions. Signed-off-by: Jérémy Lefaure --- v2: rebase on staging-testing drivers/staging/media/atomisp/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/Kconfig b/dr

[PATCH] staging: speakup: fixes braces {} used on all arms of this statement

2017-03-18 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 35 +++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/stagin

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > Can you share your gstreamer pipeline? For now, until > VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that > does not attempt to specify a frame rate. I use the attached > script for testing, which works for me. It's nothi

Re: [Outreachy kernel] [PATCH 1/3] staging: speakup: Moved logical to previous line.

2017-03-18 Thread Julia Lawall
The subject appears to be missing some words. logical what? On Sun, 19 Mar 2017, Arushi Singhal wrote: > Moved logical OR operator to previous line to fix the following > checkpatch issue: All the instances appear to be && not || julia > CHECK: Logical continuations should be on the previous

[PATCH 3/3] staging: speakup: Simplify "NULL" comparisons

2017-03-18 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/varhandlers.c

[PATCH 1/3] staging: speakup: Moved logical to previous line.

2017-03-18 Thread Arushi Singhal
Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/driver

[PATCH 2/3] staging: speakup: Remove multiple assignments

2017-03-18 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m

[PATCH 0/3] staging: speakup: Multiple checkpatch issues

2017-03-18 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (3): staging: speakup: Moved logical to previous line. staging: speakup: Remove multiple assignments staging: speakup: Simplify "NULL" comparisons drivers/staging/speakup/main.c| 30 ++

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
Hi Russell, On 03/14/2017 10:29 AM, Steve Longerbeam wrote: On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is correc

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Steve Longerbeam
On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: Hi Steve, I've just been trying to get gstreamer to capture and h264 encode video from my camera at various frame rates, and what I've discovered does not look good. 1) when setting frame rates, media-ctl _always_ calls VIDIOC_SUBDEV

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Russell King - ARM Linux
Hi Steve, I've just been trying to get gstreamer to capture and h264 encode video from my camera at various frame rates, and what I've discovered does not look good. 1) when setting frame rates, media-ctl _always_ calls VIDIOC_SUBDEV_S_FRAME_INTERVAL with pad=0. 2) media-ctl never retrieves t

Re: [Outreachy kernel] [PATCH v2] staging: iio: ade7753: replace mlock with driver private lock

2017-03-18 Thread SIMRAN SINGHAL
On Sat, Mar 18, 2017 at 11:51 PM, Jonathan Cameron wrote: > On 18/03/17 17:34, SIMRAN SINGHAL wrote: >> On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote: >>> On 13/03/17 19:53, Alison Schofield wrote: On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote: > The IIO subsys

[PATCH v4] staging: Use buf_lock instead of mlock and Refactor code

2017-03-18 Thread simran singhal
The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with buf_lock in the devices

Re: [Outreachy kernel] [PATCH v2] staging: iio: ade7753: replace mlock with driver private lock

2017-03-18 Thread Jonathan Cameron
On 18/03/17 17:34, SIMRAN SINGHAL wrote: > On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote: >> On 13/03/17 19:53, Alison Schofield wrote: >>> On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote: The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core

Re: [Outreachy kernel] [PATCH v2] staging: iio: ade7753: replace mlock with driver private lock

2017-03-18 Thread SIMRAN SINGHAL
On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote: > On 13/03/17 19:53, Alison Schofield wrote: >> On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote: >>> The IIO subsystem is redefining iio_dev->mlock to be used by >>> the IIO core only for protecting device operating mode chang

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-18 Thread Borislav Petkov
On Fri, Mar 17, 2017 at 03:45:26PM +0100, Paolo Bonzini wrote: > Yes, and I'd like that to be done with a new data section rather than a > special KVM hook. Can you give more details about how pls? Or is there already an example for that somewhere in the kvm code? > I have no idea. SEV-ES seems

Re: [PATCH] vmbus: fix missed ring events on boot

2017-03-18 Thread Stephen Hemminger
On Sat, 18 Mar 2017 07:46:21 + Dexuan Cui wrote: > > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > > Behalf Of Stephen Hemminger > > @@ -609,7 +609,15 @@ static int vmbus_close_internal(struct > > @@ -480,20 +492,12 @@ static void vmbus_process_offer(struct > > H

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Oleg Drokin
On Mar 18, 2017, at 6:34 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: >> Ever since sysfs migration, class_process_proc_param stopped working >> correctly as all the useful params were no longer present as lvars. >> Replace all the nasty fake proc w

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread Stefan Wahren
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > This change adds the driver to the standard kernel build system. > > Signed-off-by: Michael Zoran > --- > drivers/staging/vc04_services/Kconfig| 2 ++ > drivers/staging/vc04_services/Makefile

Re: [PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

2017-03-18 Thread Stefan Wahren
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > This change adds the following optional DT properties: > > number-gpios: Number of GPIOs the device should expose > gpio-base: GPIO base that is registered with the kernel Please don't reinvent existing properties. Take a look a

Re: [PATCH 2/6] staging: bcm2835-firmware-gpio: Add needed mailbox defines to driver

2017-03-18 Thread Stefan Wahren
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > The original change this driver is based on adds the needed mailbox > defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not > appropriate at this time, so add the defines directly into the > driver source. > > This c

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-18 Thread Stefan Wahren
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > From: Dave Stevenson > > Pi3 and Compute Module 3 have a GPIO expander that the > VPU communicates with. > There is a mailbox service that now allows control of this > expander, so add a kernel driver that can make use of it. >

Re: [PATCH/RFC] staging/lustre: Rework class_process_proc_param

2017-03-18 Thread Greg Kroah-Hartman
On Sat, Mar 18, 2017 at 02:24:08AM -0400, Oleg Drokin wrote: > Ever since sysfs migration, class_process_proc_param stopped working > correctly as all the useful params were no longer present as lvars. > Replace all the nasty fake proc writes with hopefully less nasty > kobject attribute search and

[PATCH] staging: rtl8712: checkpatch: Avoid multiple line dereferences

2017-03-18 Thread Ding-Chi Wang
"WARNING: Avoid multiple line dereference - prefer 'poid_par_priv->information_buf_len'" "WARNING: Avoid multiple line dereference - prefer 'padapter->registrypriv.dev_network.Configuration'" "WARNING: Avoid multiple line dereference - prefer 'Adapter->mppriv.workparam.io_value'" Signed-off-by:

[PATCH] This patch fixes three minor checkpatch warning:

2017-03-18 Thread Ding-Chi Wang
"WARNING: Avoid multiple line dereference - prefer 'poid_par_priv->information_buf_len'" "WARNING: Avoid multiple line dereference - prefer 'padapter->registrypriv.dev_network.Configuration'" "WARNING: Avoid multiple line dereference - prefer 'Adapter->mppriv.workparam.io_value'" Signed-off-by:

[PATCH] staging: vchiq_arm: Fix MODULE_LICENSE

2017-03-18 Thread Stefan Wahren
Regarding to the header the driver is licensed under BSD and GPL. Signed-off-by: Stefan Wahren --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/dr

RE: [PATCH] vmbus: fix missed ring events on boot

2017-03-18 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Stephen Hemminger > @@ -609,7 +609,15 @@ static int vmbus_close_internal(struct > @@ -480,20 +492,12 @@ static void vmbus_process_offer(struct Hi Stephen, Thanks for the patch! hv_event_tasklet_enable() is called