Use kcalloc for allocating an array instead of kzalloc with multiply,
kcalloc is the preferred API.
Found with checkpatch.
Signed-off-by: Miguel Bernal Marin
---
drivers/scsi/storvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/s
On Thu, Mar 16, 2017 at 11:14:09AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 01:41:55PM +, Okash Khawaja wrote:
> > This moves spk_synth_immediate and spk_serial_synth_probe functions into
> > serialio.c. These functions do outgoing serial comms. The move is a step
> > towards
On Thu, Mar 16, 2017 at 11:01:38AM +0530, Pushkar Jambhlekar wrote:
> Any comment?
>
> On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
One day's response? Hah, give me a few weeks at best for trivial stuff
like this please.
Actually, I totally missed this in my last sweep of staging patche
On Thu, Mar 16, 2017 at 03:46:58PM +1100, Tobin C. Harding wrote:
> On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote:
> > On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote:
> > > Driver code is non-uniform in its use of error return codes, identical
> > > failures a
On Wed, Mar 15, 2017 at 10:47:19PM -0400, Jérémy Lefaure wrote:
> On Thu, 16 Mar 2017 11:25:37 +0900
> Greg Kroah-Hartman wrote:
>
> > On Wed, Mar 15, 2017 at 02:09:16PM -0400, Jérémy Lefaure wrote:
> > > To use IO functions like writel, readl, ioremap_nocache and iounmap,
> > > asm/io.h should b
On Wed, Mar 15, 2017 at 11:15:13PM -0400, Jérémy Lefaure wrote:
> On Thu, 16 Mar 2017 11:28:28 +0900
> Greg Kroah-Hartman wrote:
>
> > On Wed, Mar 15, 2017 at 02:09:18PM -0400, Jérémy Lefaure wrote:
> > > REGMAP_I2C should be enabled to build the driver ap1302 because it uses
> > > regmap functio
Any comment?
On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar
wrote:
> Fixing 'if' block coding style. '{' should follow 'if' for multiline block
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
> 1 file changed, 1 inserti
Greg KH writes:
> On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote:
>> You've got a reason. It's GPLv2 licenced code so I have no control
>> over what happens to it.
>> Everywhere I have worked, when a patch has issues it is better to "-1"
>> to stop/delay the merge even (or particu
On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote:
> > Driver code is non-uniform in its use of error return codes, identical
> > failures are returning different error codes. Return is on failure
> > when checking
On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> > Code uses identifiers retval, ret, and rc all for function return
> > values. It would be more readable if the whole driver used a single
> > identifier for th
Embedded function names are less appropriate to use when
refactoring, can cause function renaming. Prefer the use
of "%s", __func__ to embedded function names
Signed-off-by: Mohsin Shan
---
drivers/staging/goldfish/goldfish_nand.c | 16
1 file changed, 8 insertions(+), 8 deleti
On Thu, 16 Mar 2017 11:28:28 +0900
Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 02:09:18PM -0400, Jérémy Lefaure wrote:
> > REGMAP_I2C should be enabled to build the driver ap1302 because it uses
> > regmap functions.
> >
> > Signed-off-by: Jérémy Lefaure
> > ---
> > drivers/staging/med
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_io
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +--
Removing trailing white space characters in comments to resolve
a checkpatch warning.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_w
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/
The following patches address all outstanding checkpatch warnings/errors
present in drivers/staging/ks7010/ks_wlan_ioctl.h.
This change set has been rebased off of the current master
(69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request,
and the change log formatting has been slight
Hello,
Do you have an idea for a mobile application or is your business in need of
a mobile application?
We are India located. We have been developing mobile applications from last
6 years.
We are a team of 100+ web & mobile app development professionals who are
ready to serve you.
We have deve
On Thu, 16 Mar 2017 11:25:37 +0900
Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 02:09:16PM -0400, Jérémy Lefaure wrote:
> > To use IO functions like writel, readl, ioremap_nocache and iounmap,
> > asm/io.h should be included.
>
> Ok, but:
>
> >
> > Signed-off-by: Jérémy Lefaure
> > -
On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote:
> Driver code is non-uniform in its use of error return codes, identical
> failures are returning different error codes. Return is on failure
> when checking struct magic numbers. Error codes used include -ENODEV,
> -ENXIO, -EIO, and
On Tue, Mar 14, 2017 at 07:25:51PM -0700, Matthew Giassa wrote:
> Removing mixed spaces/hard-tabs used to create a "column alignment" of
> macro names and macro values.
>
> Signed-off-by: Matthew Giassa
> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Tue, Mar 14, 2017 at 09:20:14PM +1100, Tobin C. Harding wrote:
> Code uses identifier names ret, and rc for function return
> values. It would be more readable if the whole driver used a single
> identifier for this task. Lets use 'rc' since it is the shortest.
>
> Change ret -> rc
Again, retv
On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote:
> Code uses identifiers retval, ret, and rc all for function return
> values. It would be more readable if the whole driver used a single
> identifier for this task. Lets use 'rc' since it is the shortest.
>
> Change retval -> rc
I
On Wed, Mar 15, 2017 at 04:28:09PM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Fixed the following checkpatch.pl warning:
> Possible unnecessary 'out of memory' message
> If it is out of memory, function should return with an
> appropriate error code. Since this function is of ty
On Wed, Mar 15, 2017 at 02:09:18PM -0400, Jérémy Lefaure wrote:
> REGMAP_I2C should be enabled to build the driver ap1302 because it uses
> regmap functions.
>
> Signed-off-by: Jérémy Lefaure
> ---
> drivers/staging/media/atomisp/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
This also doe
On Wed, Mar 15, 2017 at 02:09:17PM -0400, Jérémy Lefaure wrote:
> Several dependencies were missing to build atomisp drivers:
> _ MEDIA_CONTROLLER: to use the entity field of v4l2_subdev structure
> _ ACPI: to use acpi_device structure and acpi_device_id structure
> _ VIDEO_V4L2_SUBDEV_API: to use
On Wed, Mar 15, 2017 at 02:09:19PM -0400, Jérémy Lefaure wrote:
> The function atomisp_restore_iumit_reg is unused when PM is disabled.
> Adding __maybe_unused to the function definition avoids a warning.
>
> During a reset (atomisp_reset), PM functions atomisp_runtime_suspend,
> atomisp_mrfld_pow
On Wed, Mar 15, 2017 at 02:09:16PM -0400, Jérémy Lefaure wrote:
> To use IO functions like writel, readl, ioremap_nocache and iounmap,
> asm/io.h should be included.
Ok, but:
>
> Signed-off-by: Jérémy Lefaure
> ---
> drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c | 1 +
> 1 fil
On Tue, Mar 14, 2017 at 10:46:43AM +0530, Arushi Singhal wrote:
> Alig arguments with open parenthesis.
>
> Signed-off-by: Arushi Singhal
> ---
> changes in v3
> - Improve the commit message.
Did not apply as I think someone else already did this same work.
thanks,
greg k-h
_
On Tue, Mar 14, 2017 at 01:41:55PM +, Okash Khawaja wrote:
> This moves spk_synth_immediate and spk_serial_synth_probe functions into
> serialio.c. These functions do outgoing serial comms. The move is a step
> towards collecting all serial comms in serialio.c. This also renames
> spk_synth_imm
On Wed, Mar 15, 2017 at 02:09:52AM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming. Prefer the use
> of "%s", __func__ to embedded function names
>
> Signed-off-by: Mohsin Shan
Your name in the From: line in your email do
On Wed, Mar 15, 2017 at 01:39:19AM -0700, Arushi Singhal wrote:
> Hi
> This Patch series is not yet added to the kernel tree.
I don't see these in my queue either. I think maybe they were rejected
due to the incorrect subject: line that I think someone said needed to
be fixed? I can't remember,
On Wed, Mar 15, 2017 at 01:40:10AM -0700, Arushi Singhal wrote:
> Hi
> This Patch is also not yet added to the kernel-tree.
I don't see it in my patch queue at all, so something must have gone
wrong. Please rebase and resend them if they are still applicable.
thanks,
greg k-h
__
On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote:
> No, I didn't. Thanks! Applied it but, unfortunately, didn't work.
> Perhaps I'm missing some other patch. I'm compiling it from
> the Greg's staging tree (branch staging-next):
> https://git.kernel.org/pub/scm/linux/kernel/git
On Wed, Mar 15, 2017 at 03:32:56PM +, Dave Stevenson wrote:
> You've got a reason. It's GPLv2 licenced code so I have no control
> over what happens to it.
> Everywhere I have worked, when a patch has issues it is better to "-1"
> to stop/delay the merge even (or particularly) on your own patch
Em Wed, 15 Mar 2017 15:01:29 -0700
Eric Anholt escreveu:
> Mauro Carvalho Chehab writes:
>
> > Em Fri, 27 Jan 2017 13:54:57 -0800
> > Eric Anholt escreveu:
> >
> >> Here's my first pass at importing the camera driver. There's a bunch
> >> of TODO left to it, most of which is documented, and
Hi Wolfram,
Is there some technical reason why module ks7010 includes a
implementation of Michael MIC instead of using the implementation in
crypto/?
Or is this covered by the statement from the TODO
- check what other upstream wireless mechanisms can be used instead of the
custom ones here
t
Mauro Carvalho Chehab writes:
> Em Fri, 27 Jan 2017 13:54:57 -0800
> Eric Anholt escreveu:
>
>> Here's my first pass at importing the camera driver. There's a bunch
>> of TODO left to it, most of which is documented, and the rest being
>> standard checkpatch fare.
>>
>> Unfortunately, when I t
On 13/03/17 19:53, Alison Schofield wrote:
> On Mon, Mar 13, 2017 at 10:01:07PM +0530, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* mo
Hi Mauro,
> Mauro Carvalho Chehab hat am 15. März 2017 um
> 15:01 geschrieben:
>
>
> Em Fri, 27 Jan 2017 13:54:57 -0800
> Eric Anholt escreveu:
>
> > Here's my first pass at importing the camera driver. There's a bunch
> > of TODO left to it, most of which is documented, and the rest being
Copied function argument names from definition to delcaration. This
fixes some checkpatch warnings.
Signed-off-by: Tuomo Rinne
---
drivers/staging/vt6655/rxtx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/r
Fixes the checkpatch.pl warning: Avoid CamelCase
Signed-off-by: Aya Mahfouz
---
drivers/staging/gdm724x/gdm_lte.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.h
b/drivers/staging/gdm724x/gdm_lte.h
index 7ddeabc..3ecaff1 100644
--- a/drivers
* Tobin C. Harding [2017-03-15 14:14:08 +1100]:
On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and erro
Em Wed, 15 Mar 2017 19:04:21 +0100
Pavel Machek escreveu:
> Hi!
>
> > > Well, I believe first question is: what applications would we want to
> > > run on complex devices? Will sending control from video to subdevs
> > > actually help?
> >
> > I would say: camorama, xawtv3, zbar, google talk,
Ah. Very good. Thanks.
I can understand why you're annoyed.
Part of the problem and miscommunication seems to have two email lists
and two upstreams. You're refering to the out of tree module as
downstream but really if we're applying fixes there instead of to the
kernel then it's an upstream.
Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit :
> > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs
> > with those, it will likely run with any other application.
> >
>
> I would like to add the 'v4l2src' plugin of gstreamer, and on the
> imx6 its
While i
On 03/10/2017 11:17 AM, Fabio Estevam wrote:
On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky
wrote:
On 3/9/2017 8:52 PM, Steve Longerbeam wrote:
There is a pin conflict with GPIO_6. This pin functions as a power
input pin to the OV5642 camera sensor, but ENET uses it as the h/w
workaround for er
To use IO functions like writel, readl, ioremap_nocache and iounmap,
asm/io.h should be included.
Signed-off-by: Jérémy Lefaure
---
drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/platform/clock/vlv2
Several dependencies were missing to build atomisp drivers:
_ MEDIA_CONTROLLER: to use the entity field of v4l2_subdev structure
_ ACPI: to use acpi_device structure and acpi_device_id structure
_ VIDEO_V4L2_SUBDEV_API: to use pad field of v4l2_subdev_fh structure
_ EFI: to use efivar_entry_get
Si
REGMAP_I2C should be enabled to build the driver ap1302 because it uses
regmap functions.
Signed-off-by: Jérémy Lefaure
---
drivers/staging/media/atomisp/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/i2c/Kconfig
b/drivers/staging/media/atomisp/i2c
Hello,
Here are 6 patches for drivers/staging/media/atomisp. Patches 1 to 5 fix
the build and patch 6 removes duplicate includes.
These patches are base on
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next.
I am not sure if I should split patch 2 (one patch per missing
When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i" should
not be added in hmm_bo_type_strings.
Signed-off-by: Jérémy Lefaure
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm
The function atomisp_restore_iumit_reg is unused when PM is disabled.
Adding __maybe_unused to the function definition avoids a warning.
During a reset (atomisp_reset), PM functions atomisp_runtime_suspend,
atomisp_mrfld_power_down, atomisp_mrfld_power_up and
atomisp_runtime_resume should be calle
These duplicate includes have been found with scripts/checkincludes.pl
but they have been removed manually to avoid removing false positives.
Signed-off-by: Jérémy Lefaure
---
drivers/staging/media/atomisp/i2c/ap1302.c | 1 -
drivers/staging/media/atomisp/i2c/mt9m11
Hi!
> > Well, I believe first question is: what applications would we want to
> > run on complex devices? Will sending control from video to subdevs
> > actually help?
>
> I would say: camorama, xawtv3, zbar, google talk, skype. If it runs
> with those, it will likely run with any other applicati
Hi Dave,
Am 15.03.2017 um 16:32 schrieb Dave Stevenson:
> Full description:
> mmal_vchiq is reimplementing parts of the userside MMAL library in kernel
> space.
> The expected behaviour of port_parameter_get is that it takes the size
> of storage for the parameter value, and returns the amount ac
On 15 March 2017 at 10:36, Dan Carpenter wrote:
> On Wed, Mar 15, 2017 at 10:06:11AM +, Dave Stevenson wrote:
>> On 15 March 2017 at 05:08, Greg KH wrote:
>> > On Tue, Mar 14, 2017 at 03:32:43PM +, Dave Stevenson wrote:
>> >> NACK.
>> >> Phil asked for a couple of changes, although functi
Rob Herring, on mer. 15 mars 2017 09:45:59 -0500, wrote:
> On Mon, Mar 13, 2017 at 8:18 PM, Samuel Thibault
> wrote:
> > Samuel Thibault, on mar. 14 mars 2017 01:47:01 +0100, wrote:
> >> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> >> > On Mon, Mar 13, 2017 at 10:05:51PM +, okash.kha
As Dan said, the original was better, but
it could still be improved.
There is only a single case used in the switch.
Perhaps better would be to reduce indentation
by removing the switch and using another goto
label for the memory allocation freeing like the
below.
Perhaps better still, if there
On Mon, Mar 13, 2017 at 8:18 PM, Samuel Thibault
wrote:
> Samuel Thibault, on mar. 14 mars 2017 01:47:01 +0100, wrote:
>> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
>> > On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
>> > > This patchset introduces a TTY-based w
Em Fri, 27 Jan 2017 13:54:57 -0800
Eric Anholt escreveu:
> Here's my first pass at importing the camera driver. There's a bunch
> of TODO left to it, most of which is documented, and the rest being
> standard checkpatch fare.
>
> Unfortunately, when I try modprobing it on my pi3, the USB networ
On Wed, Mar 15, 2017 at 04:39:20PM +0530, Suniel Mahesh wrote:
> On Wednesday 15 March 2017 03:44 PM, Dan Carpenter wrote:
> >On Wed, Mar 15, 2017 at 03:21:51PM +0530, suni...@techveda.org wrote:
> >>@@ -1796,7 +1796,7 @@ static short _rtl92e_alloc_rx_ring(struct net_device
> >>*dev)
> >>
> >>
On Wednesday 15 March 2017 03:44 PM, Dan Carpenter wrote:
On Wed, Mar 15, 2017 at 03:21:51PM +0530, suni...@techveda.org wrote:
@@ -1796,7 +1796,7 @@ static short _rtl92e_alloc_rx_ring(struct net_device *dev)
for (rx_queue_idx = 0; rx_queue_idx < MAX_RX_QUEUE; rx_queue_idx++) {
On Tue, Mar 14, 2017 at 09:54:31PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 14 Mar 2017 23:32:54 +0100
> Pavel Machek escreveu:
>
> >
> > Well, I believe first question is: what applications would we want to
> > run on complex devices? Will sending control from video to subdevs
> > actually
From: Suniel Mahesh
Fixed the following checkpatch.pl warning:
Possible unnecessary 'out of memory' message
If it is out of memory, function should return with an
appropriate error code. Since this function is of type void,
a return statement is used.
Signed-off-by: Suniel Mahesh
---
Changes fo
On Wed, Mar 15, 2017 at 10:06:11AM +, Dave Stevenson wrote:
> On 15 March 2017 at 05:08, Greg KH wrote:
> > On Tue, Mar 14, 2017 at 03:32:43PM +, Dave Stevenson wrote:
> >> NACK.
> >> Phil asked for a couple of changes, although functionally identical.
> >> I'll send a patch when I get a c
On Wed, Mar 15, 2017 at 03:21:54PM +0530, suni...@techveda.org wrote:
> @@ -2294,17 +2294,20 @@ static int _rtl92e_ioctl(struct net_device *dev,
> struct ifreq *rq, int cmd)
>
> if (ipw->cmd == IEEE_CMD_SET_ENCRYPTION) {
> if (ipw->u.crypt.set_tx) {
> -
On Wed, Mar 15, 2017 at 03:21:52PM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Fixed the following checkpatch.pl warning:
> Possible unnecessary 'out of memory' message
>
> Signed-off-by: Suniel Mahesh
> ---
> Changes for v3:
>
> - Split earlier patches into multiple commits f
Also the subject is too vague.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Mar 15, 2017 at 03:21:51PM +0530, suni...@techveda.org wrote:
> @@ -1796,7 +1796,7 @@ static short _rtl92e_alloc_rx_ring(struct net_device
> *dev)
>
> for (rx_queue_idx = 0; rx_queue_idx < MAX_RX_QUEUE; rx_queue_idx++) {
> priv->rx_ring[rx_queue_idx] = pci_zalloc_cons
On 15 March 2017 at 05:08, Greg KH wrote:
> On Tue, Mar 14, 2017 at 03:32:43PM +, Dave Stevenson wrote:
>> NACK.
>> Phil asked for a couple of changes, although functionally identical.
>> I'll send a patch when I get a chance.
>
> What do you mean, "when I get a chance"? What's wrong with thi
From: Suniel Mahesh
Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for easy review
as suggested by Greg K-H
- Modified description for better readability
- Rebased on top of
From: Suniel Mahesh
This patch simplifies code by replacing explicit NULL comparison
with ! or unmark operator
Reported by checkpatch.pl for comparison to NULL could be
written '!foo' or 'foo'
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for ea
From: Suniel Mahesh
Fixed the following checkpatch.pl checks:
Blank lines aren't necessary after an open brace '{'
and before a close brace '}', removed
No space is necessary after a cast, removed
Please don't use multiple blank lines, removed
Signed-off-by: Suniel Mahesh
---
Changes for v3:
-
From: Suniel Mahesh
Fixed the following checkpatch.pl warning:
line over 80 characters
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for easy review
as suggested by Greg K-H
- New patch addition to the series
- Rebased on top of next-20170310
From: Suniel Mahesh
Fixed the following checkpatch.pl checks:
spaces preferred around that 'operator', spacing provided
Logical continuations should be on the previous line, modified accordingly
Unnecessary parentheses around variables, removed
Please use a blank line after function/struct/union/
From: Suniel Mahesh
Fixed the following checkpatch.pl warning:
Possible unnecessary 'out of memory' message
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for easy review
as suggested by Greg K-H
- Modified subject and description for better re
From: Suniel Mahesh
Fixed unbalanced braces around else statement
Add braces on all arms of the if-else statements to comply with
kernel coding style.
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for easy review
as suggested by Greg K-H
- Mod
From: Suniel Mahesh
Fixed the following checkpatch.pl warnings:
Block comments should align the * on each line
Block comments use * on subsequent lines
Signed-off-by: Suniel Mahesh
---
Changes for v3:
- Split earlier patches into multiple commits for easy review
as suggested by Greg K-H
- Mo
From: Suniel Mahesh
Split earlier patches into multiple commits for easy review as
suggested by Dan Carpenter.
Modified subject, description and in few patches both for
better readability as suggested by Greg KH.
Fixed the following issues reported by checkpatch.pl:
Block comments should align t
On Wed, 15 Mar 2017, Arushi Singhal wrote:
> HiThis Patch series is not yet added to the kernel tree.
The normal process is to send it again, with RESEND inside the [PATCH]
box.
julia
> Thanks
> Arushi
>
> On Saturday, 11 March 2017 02:12:02 UTC+5:30, Arushi Singhal wrote:
> Improve reada
On Wed, Mar 15, 2017 at 09:00:24AM +0100, Wolfram Sang wrote:
> On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote:
> > Driver has dead code compiled out using preprocessor directives. TODO
> > file asks for these not to be removed - ignore this.
>
> Why?
>
I got bored reviewing ch
Embedded function names are less appropriate to use when
refactoring, can cause function renaming. Prefer the use
of "%s", __func__ to embedded function names
Signed-off-by: Mohsin Shan
---
drivers/staging/goldfish/goldfish_nand.c | 16
1 file changed, 8 insertions(+), 8 deleti
On Wed, Mar 15, 2017 at 09:00:24AM +0100, Wolfram Sang wrote:
> On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote:
> > Driver has dead code compiled out using preprocessor directives. TODO
> > file asks for these not to be removed - ignore this.
>
> Why?
>
It was suggested to me du
Fix the subject. The subsystem prefix is wrong and it's too vague.
Change it to:
[PATCH] Staging: goldfish: use __func__ instead of embedded function names
On Tue, Mar 14, 2017 at 08:53:50PM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause
On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote:
> Driver has dead code compiled out using preprocessor directives. TODO
> file asks for these not to be removed - ignore this.
Why?
signature.asc
Description: PGP signature
___
devel ma
86 matches
Mail list logo
