Fixing 'if' block coding style. '{' should follow 'if' for multiline block
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/
There is no reason to have "#ifdef ISP2401" condition
on top of atomisp_cmd.c file
Signed-off-by: Daeseok Youn
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
b/drivers/st
Fix checkpatch.pl issues in atomisp_cmd.c
: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Daeseok Youn
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 179 +++--
1 file changed, 90 insertions(+), 89 deletions(-)
diff --git a/drivers/staging/media/atom
Fix warnings from the smatch tool
atomisp_cmd.c:5698
atomisp_set_fmt_to_snr() warn: inconsistent indenting
atomisp_cmd.c:5714
atomisp_set_fmt_to_snr() warn: inconsistent indenting
Signed-off-by: Daeseok Youn
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 4 ++--
1 file cha
Fix warnings from the smatch tool
atomisp_cmd.c:2649
atomisp_set_array_res() warn:
unsigned 'config->width' is never less than zero.
atomisp_cmd.c:2650
atomisp_set_array_res() warn:
unsigned 'config->height' is never less than zero.
Signed-off-by: Daeseok Youn
---
drivers/staging/media
Checkpatch emits WARNING and CHECK for prototype declarations.
WARNING: function definition argument 'void *' should also have an identifier
name
CHECK: Alignment should match open parenthesis
Also prototype parameters wrap more than is necessary.
Tidy up function prototypes. Fix 5 error/warnin
Checkpatch emits WARNING: Block comments use a trailing */ on a
separate line.
Move comments to (kernel doc format) struct comment.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 50 ++
1 file changed, 40 insertions(+), 10 deletions(
Checkpatch emits WARNING: Unnecessary space before function pointer
arguments.
Remove unnecessary space before function pointer.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks
Checkpatch warns about various issues when parsing ks7010 headers. Some
of these require significant understanding of the driver to fix, however
there are also a bunch of trivial fixes required.
Remove all the low hanging fruit.
Patch 01 removes unnecessary whitespace.
Patch 02 adds kernel doc f
On Tue, Mar 14, 2017 at 03:32:43PM +, Dave Stevenson wrote:
> NACK.
> Phil asked for a couple of changes, although functionally identical.
> I'll send a patch when I get a chance.
What do you mean, "when I get a chance"? What's wrong with this one?
> Your existing workaround has removed the
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c',
On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
> Description:
No need for that line.
> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes
> to make code according to 'checkpath.pl'.
Why indent? Also, you need to be specific as to what type of chan
Hi mshan,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/mshan/Fixed-a-minor-coding-style-wa
Embedded function names are less appropriate to use when
refactoring, can cause function renaming. Prefer the use
of "%s", __func__ to embedded function names
Signed-off-by: mshan
---
drivers/staging/goldfish/goldfish_nand.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Description:
in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to
make code according to 'checkpath.pl'.
Also, fixing logical issue, i.e. removing break after goto statement.
Signed-off-by: Pushkar Jambhlekar
---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 33
On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
> Wrapping all complex macros with parentheses to resolve checkpatch
> errors. This change, along with the preceding changes in this change
> set, resolves all checkpatch warnings and errors for the file.
>
> Signed-off-by: Matthew Gi
Driver contains comments of form /**/. These do not add to the
clarity of the code, we should remove them.
Driver has preprocessor directives (#if 0/1). These are not considered
helpful. Checkpatch warns about them also.
Patch 01 removes superfluous function comments.
Patch 02 removes de
Driver uses custom function comment format. These comments are on
functions with internal likage. Comment string /*/* adds
nothing to the driver. Comment 'Wireless Handler' does not have allot
of meaning.
Remove superfluous function comments. Leave comments that add meaning.
Signed-off-by
Driver has dead code compiled out using preprocessor directives. TODO
file asks for these not to be removed - ignore this.
Remove dead code. Remove 'do not remove #if 0/1 ...' from TODO file.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/TODO | 2 -
drivers/staging/ks701
On Wed, Mar 15, 2017 at 09:48:55AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 09:48:14AM +0800, Greg Kroah-Hartman wrote:
> > On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> > > Bug introduced in commit 7676b72 by Tobin C. Harding.
> > >
> > > Remove equals sign
On Wed, Mar 15, 2017 at 09:48:14AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> > Bug introduced in commit 7676b72 by Tobin C. Harding.
> >
> > Remove equals sign from comparison, fixing off by one error.
> >
> > Signed-off-by: Tobin C. Ha
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +--
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_io
Removing trailing white space characters in comments to resolve
a checkpatch warning.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_w
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/
Laura Abbott wrote on 2017-03-15 오전 2:10:
> On 03/14/2017 12:51 AM, Junil Lee wrote:
>> Replace list into lock-less list of ion page pool.
>>
>> Measure how mutex lock contention latency on android.
>>
>> 1. the test is done under android 7.0
>> 2. startup many applications circularly
>> 3. find s
On Wed, Mar 15, 2017 at 09:48:14AM +0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> > Bug introduced in commit 7676b72 by Tobin C. Harding.
> >
> > Remove equals sign from comparison, fixing off by one error.
> >
> > Signed-off-by: Tobin C. Ha
On Wed, Mar 15, 2017 at 12:01:07PM +1100, Tobin C. Harding wrote:
> Bug introduced in commit 7676b72 by Tobin C. Harding.
>
> Remove equals sign from comparison, fixing off by one error.
>
> Signed-off-by: Tobin C. Harding
In the future, when you fix something, it's nice to add a tag saying so
From: K. Y. Srinivasan
Fix a typo in the macro.
Signed-off-by: K. Y. Srinivasan
---
arch/x86/include/uapi/asm/hyperv.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/include/uapi/asm/hyperv.h
b/arch/x86/include/uapi/asm/hyperv.h
index 3a20ccf..32ea7a3 10064
From: K. Y. Srinivasan
Enable autoeoi based on the hypervisor recommendations.
This is required to support vAPIC.
K. Y. Srinivasan (2):
Drivers: hv: Fix a typo
Drivers: hv: Base autoeoi enablement based on hypervisor hints
arch/x86/include/uapi/asm/hyperv.h |7 ++-
drivers/hv/hv.c
Bug introduced in commit 7676b72 by Tobin C. Harding.
Remove equals sign from comparison, fixing off by one error.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b
Em Tue, 14 Mar 2017 23:32:54 +0100
Pavel Machek escreveu:
> Hi!
>
> > > > Even if they were merged, if we keep the same mean time to develop a
> > > > libv4l plugin, that would mean that a plugin for i.MX6 could take 2-3
> > > > years to be developed.
> > > >
> > > > There's a clear message on
This is V3 of the change to enable simultanous HDMI and Headphone audio
Changes V2:
1. Convert to module parameters rather then compile time options
for configurating which virtual sound card should be loaded.
2. Remove unnecessary mutex acquire in snd_bcm2835_new_simple_p
The firmware for the Raspberry PI already supports simultanous output
of audio through both the HDMI and the Headphone jack. The current
implementation of ALSA doesn't expose this well to user mode since
the firmware audio is represented as a single card.
A newer approach is taken here and a virt
Return code from tty_check_change() should be being
preserved.
Preserve return code from call to tty_check_change().
Signed-off-by: Tobin C. Harding
---
drivers/staging/dgnc/dgnc_tty.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/dr
Review of a previously merged patch made a few comments that required
investigating.
Some function call errors were not being preserved across the function
call chain.
It was found that driver code was non-uniform in its use of error
return codes, identical failures are returning different error
Driver code is non-uniform in its use of error return codes, identical
failures are returning different error codes. Return is on failure
when checking struct magic numbers. Error codes used include -ENODEV,
-ENXIO, -EIO, and -EFAULT.
Use -ENXIO. Justification is that usual call includes a check t
Hi!
> > > Even if they were merged, if we keep the same mean time to develop a
> > > libv4l plugin, that would mean that a plugin for i.MX6 could take 2-3
> > > years to be developed.
> > >
> > > There's a clear message on it:
> > > - we shouldn't keep pushing for a solution via libv4l.
> >
> Jean-Baptiste Abbadie hat am 14. März 2017 um 20:14
> geschrieben:
>
>
> These four functions are not used and report errors with sparse.
>
> Signed-off-by: Jean-Baptiste Abbadie
Acked-by: Stefan Wahren
___
devel mailing list
de...@linuxdriverpr
On Tue, Mar 14, 2017 at 03:00:48PM +0300, Dan Carpenter wrote:
> On Mon, Mar 13, 2017 at 12:37:32PM +1100, Tobin C. Harding wrote:
> > if (!tty || tty->magic != TTY_MAGIC)
> > - return rc;
> > + return -EIO;
> >
>
> [ snip ]
>
> > if (!tty || tty->magic != TTY_MAGIC)
Le mardi 14 mars 2017 à 15:47 +0100, Benjamin Gaignard a écrit :
> Should we use /devi/ion/$heap instead of /dev/ion_$heap ?
> I think it would be easier for user to look into one directory rather
> then in whole /dev to find the heaps
>
> > is that we don't have to worry about a limit of 32 possi
On Tue, Mar 14, 2017 at 02:18:46PM +0300, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 09:54:22PM +1100, Tobin C. Harding wrote:
> > On the topic of "one thing per patch", so we are aiming to do one
> > thing per patch so it is easier to locate bugs if they get introduced
> > but also, and more i
On Tue, Mar 14, 2017 at 04:12:31PM +0100, Shiva Kerdel wrote:
> Hello Tobin,
>
> I missed the other files because they did not show up using the checkpatch
> script.
> Next time I will do a recursive search through the files before committing
> the changes to avoid this situation.
>
> Before I
Samuel Thibault writes:
> This supports spelling unicode characters by just passing them to
> the speech synthesis in direct mode.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
___
devel mailing list
de...@linuxdriverproject.org
http:
Samuel Thibault writes:
> commit 33590c185299 ("speakup: Support spelling unicode characters")
> mistakenly passed unicode characters to IS_CHAR(), which only
> supports latin1. Let's assume non-latin1 is lower case, like is done
> in spell_word().
Reviewed-by: Chris Brannon
__
Chris Brannon, on mar. 14 mars 2017 09:06:36 -0700, wrote:
> This is going to misidentify some Unicode characters >= 0x100 as
> capital. You probably want to add ch < 0x100 tests to the if
Indeed, I've submitted a correction, thanks!
Samuel
___
devel m
commit 33590c185299 ("speakup: Support spelling unicode characters")
mistakenly passed unicode characters to IS_CHAR(), which only
supports latin1. Let's assume non-latin1 is lower case, like is done
in spell_word().
Signed-off-by: Samuel Thibault
diff --git a/drivers/staging/speakup/main.c b/d
On 03/14/2017 07:47 AM, Benjamin Gaignard wrote:
> 2017-03-13 22:09 GMT+01:00 Laura Abbott :
>> On 03/12/2017 12:05 PM, Daniel Vetter wrote:
>>> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard
>>> wrote:
2017-03-09 18:38 GMT+01:00 Laura Abbott :
> On 03/09/2017 02:00 AM, Benjamin Gaign
These four functions are not used and report errors with sparse.
Signed-off-by: Jean-Baptiste Abbadie
---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 50 --
1 file changed, 50 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
On Tue, Mar 14, 2017 at 11:50:50AM -0700, Jessica Frazelle wrote:
> I can update the patch series, sorry haven't had much time to devote
> to this the past few weeks, but will update in the next day.
Thanks, Jessica! No problem, I know the feeling :)
Bjorn
___
I can update the patch series, sorry haven't had much time to devote
to this the past few weeks, but will update in the next day.
On Tue, Mar 7, 2017 at 11:07 AM, Bjorn Helgaas wrote:
> On Thu, Feb 16, 2017 at 03:38:05PM +0100, Thomas Gleixner wrote:
>> On Thu, 16 Feb 2017, Bjorn Helgaas wrote:
>
On Mon 2017-03-13 10:45:38, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
> > On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
> > > The event must be user visible, otherwise the user has no indication
> > > the error, and can't correct it by stream
Hi!
> > Mid-layer is difficult... there are _hundreds_ of possible
> > pipeline setups. If it should live in kernel or in userspace is a
> > question... but I don't think having it in kernel helps in any way.
>
> Mid-layer is difficult, because we either need to feed some
> library with knowledge
On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote:
But hold on, if my logic is correct, then why did the CSI power-off
get reached in your case, mul
Good catch. Thanks!
On 03/14/2017 12:42 PM, Stephen Hemminger wrote:
On Tue, 14 Mar 2017 12:01:03 -0400
Cathy Avery wrote:
#if IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
if (host->transportt == fc_transport_template) {
+ struct fc_rport_identifiers ids;
+
+ ids.nod
On 03/14/2017 12:51 AM, Junil Lee wrote:
> Replace list into lock-less list of ion page pool.
>
> Measure how mutex lock contention latency on android.
>
> 1. the test is done under android 7.0
> 2. startup many applications circularly
> 3. find sample in trace log as below
>
> cameraserver-
On 03/12/2017 03:10 PM, Mauro Carvalho Chehab wrote:
Em Sun, 12 Mar 2017 21:13:24 +
Russell King - ARM Linux escreveu:
On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote:
Yet, udev/systemd has some rules that provide an unique name for V4L
devices at /lib/udev/rules.d
On 03/14/2017 09:47 AM, Russell King - ARM Linux wrote:
On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote:
My main concern here based on what I'm reading, is that this driver is
not even able to notice immediately that a produced frame was corrupted
(because it's out of sync). F
On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote:
> My main concern here based on what I'm reading, is that this driver is
> not even able to notice immediately that a produced frame was corrupted
> (because it's out of sync). From usability perspective, this is really
> bad. Can't
On 03/14/2017 09:21 AM, Nicolas Dufresne wrote:
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit :
On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
The event must be user visible, otherwise the user has no indi
On Tue, 14 Mar 2017 12:01:03 -0400
Cathy Avery wrote:
> #if IS_ENABLED(CONFIG_SCSI_FC_ATTRS)
> if (host->transportt == fc_transport_template) {
> + struct fc_rport_identifiers ids;
> +
> + ids.node_name = 0;
> + ids.port_name = 0;
> + ids.por
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit :
> On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
> > On 03/11/2017 07:14 PM, Steve Longerbeam wrote:
> > > The event must be user visible, otherwise the user has no indication
> > > the error, and can't correct i
Samuel Thibault writes:
> This supports spelling unicode characters by just passing them to
> the speech synthesis in direct mode.
>
> Signed-off-by: Samuel Thibault
>
> Index: linux-4.10/drivers/staging/speakup/main.c
> ===
> --- l
Included in the current storvsc driver for Hyper-V is the ability
to access luns on an FC fabric via a virtualized fiber channel
adapter exposed by the Hyper-V host. The driver also attaches to the FC
transport to allow host and port names to be published under
/sys/class/fc_host/hostX. Current cus
NACK.
Phil asked for a couple of changes, although functionally identical.
I'll send a patch when I get a chance.
Your existing workaround has removed the immediate issue of the
overflow, this was only cleaning things up to actually match the
original API.
Dave
On 14 March 2017 at 15:10, Micha
Hello Tobin,
I missed the other files because they did not show up using the checkpatch
script.
Next time I will do a recursive search through the files before committing the
changes to avoid this situation.
Before I could replay on your message, I got notified of my patches already
been merg
From: Dave Stevenson
https://github.com/raspberrypi/linux/issues/1447
port_parameter_get() failed to account for the header
(u32 id and u32 size) in the size before memcpying
the response into the response buffer, so overrunning
the provided buffer by 8 bytes.
Account for those bytes, and also a
On Tue, 2017-03-14 at 12:29 +, Reshetova, Elena wrote:
> > Elena Reshetova writes:
> >
> > > refcount_t type and corresponding API should be
> > > used instead of atomic_t when the variable is used as
> > > a reference counter. This allows to avoid accidental
> > > refcounter overflows that m
2017-03-13 22:09 GMT+01:00 Laura Abbott :
> On 03/12/2017 12:05 PM, Daniel Vetter wrote:
>> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard
>> wrote:
>>> 2017-03-09 18:38 GMT+01:00 Laura Abbott :
On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
> 2017-03-06 17:04 GMT+01:00 Daniel Vette
> -Original Message-
> From: Dexuan Cui
> Sent: Tuesday, March 14, 2017 5:49 AM
> To: KY Srinivasan ; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com;
> leann.ogasaw..
Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singha
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
Changes since v4
-Added the changes done since v4.
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
Improve readability by fixing multiple checkpatch.pl
issues in drivers.
Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.
drivers/media/dvb-frontends/drxk_hard.c | 1 -
drivers/staging/speakup/speakup_dtlk.h | 10 +--
This moves call to spk_stop_serial_interrupt() function out of synth_release()
and into release() method of specific spk_synth instances. This is because
the spk_stop_serial_interrupt() call is specific to current serial i/o
implementation. Moving it into each synth's release() method gives the
dec
These two functions are always called from a context where spk_synth instance
is available. They also use the spk_synth instance but instead of taking it
as an argument, they rely on a global spk_synth instance inside synth.c which
points to the same synth as the one being passed in as argument.
S
This patch adds spk_io_ops struct which contain those methods whose job is to
communicate with synth device. Currently, all comms with external synth
device use raw serial i/o. The idea is to group all methods which do the
actual communication with external device into this new struct. Then migrati
Hi,
The following patches group together most of raw serial comms with external
synth and makes rest of the code agnostic to it, so that raw serial comms
can be easily replaced by an alternate way to communicate with external
synths. Plan is to follow these patches with alternate implementation
of
This moves spk_synth_immediate and spk_serial_synth_probe functions into
serialio.c. These functions do outgoing serial comms. The move is a step
towards collecting all serial comms in serialio.c. This also renames
spk_synth_immediate to spk_serial_synth_immediate.
Code inside those functions has
Hello Alan Cox,
The patch a49d25364dfb: "staging/atomisp: Add support for the Intel
IPU v2" from Feb 17, 2017, leads to the following static checker
warning:
drivers/staging/media/atomisp/i2c/imx/imx.c:498 imx_set_exposure_gain()
warn: inconsistent returns 'mutex:&dev->input_lock'
The firmware for the Raspberry PI already supports simultanous output
of audio through both the HDMI and the Headphone jack. The current
implementation of ALSA doesn't expose this well to user mode since
the firmware audio is represented as a single card.
A newer approach is taken here and a virt
This is V2 of the change to enable simultanous HDMI and Headphone audio
Changes V2:
1. Convert to module parameters rather then compile time options
for configurating which virtual sound card should be loaded.
2. Remove unnecessary mutex acquire in snd_bcm2835_new_simple_p
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
> ow...@vger.kernel.org] On Behalf Of k...@exchange.microsoft.com
>
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index e1a3ae4..0a85246 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgm
> Elena Reshetova writes:
>
> > refcount_t type and corresponding API should be
> > used instead of atomic_t when the variable is used as
> > a reference counter. This allows to avoid accidental
> > refcounter overflows that might lead to use-after-free
> > situations.
> >
> > Signed-off-by: Elen
Elena Reshetova writes:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
>
> Signed-off-by: Elena Reshetova
> Sig
I don't understand why we have any of these things under the
/* AES tables*/ comment. They don't seem to be used anywhere. Can't
we just delete them?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
Your concerns were valid. Since 'do' is defined on the new-line, git
did not include it in diff.
On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk
wrote:
> On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar
> wrote:
>> Hi Alexander,
>>
>> It is not needed for a macro. I am modifying do---while
On Mon, Mar 13, 2017 at 12:37:32PM +1100, Tobin C. Harding wrote:
> if (!tty || tty->magic != TTY_MAGIC)
> - return rc;
> + return -EIO;
>
[ snip ]
> if (!tty || tty->magic != TTY_MAGIC)
> - return rc;
> + return -EFAULT;
My recolecti
On Mon, Mar 13, 2017 at 01:17:13AM +0100, Samuel Thibault wrote:
> 9831013cbdbd3d06430a1db01d8c32d50c7d1c04 ('speakup: convert screen reading to
> 16bit characters') paved the way for handling unicode characters in speakup,
> but
> for the review mode, it missed actually getting unicode characters
On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar
wrote:
> Hi Alexander,
>
> It is not needed for a macro. I am modifying do---while() loop for ROUND
> macro.
>
> /**
> * Expand the cipher key into the encryption key schedule.
> *
> * @return the number of rounds for the given cipher ke
Hi Alexander,
It is not needed for a macro. I am modifying do---while() loop for ROUND macro.
/**
* Expand the cipher key into the encryption key schedule.
*
* @return the number of rounds for the given cipher key size.
*/
#define ROUND(i, d, s) \
do {
On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar
wrote:
> Description:
> There should not be ';' after do ... while(0) in macro defination
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Description:
There should not be ';' after do ... while(0) in macro defination
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/stag
On Tue, Mar 14, 2017 at 09:54:22PM +1100, Tobin C. Harding wrote:
> On the topic of "one thing per patch", so we are aiming to do one
> thing per patch so it is easier to locate bugs if they get introduced
> but also, and more importantly, to make review easier. So from this
> patch am I right in t
On Tue, 2017-03-14 at 14:05 +0300, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 01:55:01AM -0700, Michael Zoran wrote:
> > On Tue, 2017-03-14 at 09:17 +0100, Stefan Wahren wrote:
> > > Am 14.03.2017 um 07:45 schrieb Michael Zoran:
> > > > The extra virtual cards created for HDMI and Headphone out
On Tue, Mar 14, 2017 at 09:44:07PM +1100, Tobin C. Harding wrote:
> On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote:
> > This code is #ifdeffed out so you should just delete it instead of
> > fixing it.
>
> The TODO file specifically asks for ifdeffed code not to be removed unless
>
On Tue, Mar 14, 2017 at 01:55:01AM -0700, Michael Zoran wrote:
> On Tue, 2017-03-14 at 09:17 +0100, Stefan Wahren wrote:
> > Am 14.03.2017 um 07:45 schrieb Michael Zoran:
> > > The extra virtual cards created for HDMI and Headphone output
> > > may not be compatible with operating systems that expo
On Mon, Mar 13, 2017 at 11:45:08PM -0700, Michael Zoran wrote:
> +int snd_bcm2835_new_simple_pcm(struct bcm2835_chip *chip,
> +const char *name,
> +enum snd_bcm2835_route route,
> +u32 numchannels)
> +{
> + stru
On Tue, Mar 14, 2017 at 12:23:14PM +0300, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 09:54:06AM +1100, Tobin C. Harding wrote:
> > @@ -2196,20 +2195,21 @@ static int ks_wlan_set_pmksa(struct net_device *dev,
> > case IW_PMKSA_REMOVE:
> > if (list_empty(&priv->pmklist.head)) { /
On Tue, 2017-03-14 at 08:34 +0100, Hans Verkuil wrote:
> On 03/13/2017 10:03 PM, Sakari Ailus wrote:
> > Hi Steve,
> >
> > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote:
> >>
> >>
> >> On 03/13/2017 06:55 AM, Philipp Zabel wrote:
> >>> On Mon, 2017-03-13 at 13:27 +, Russell
On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote:
> This code is #ifdeffed out so you should just delete it instead of
> fixing it.
The TODO file specifically asks for ifdeffed code not to be removed unless
one knows exactly what is going on. I hope to get to that level but am
not the
1 - 100 of 134 matches
Mail list logo
