The firmware for the Raspberry PI already supports simultanous output
of audio through both the HDMI and the Headphone jack. The current
implementation of ALSA doesn't expose this well to user mode since
the firmware audio is represented as a single card.
A newer approach is taken here and a virt
The extra virtual cards created for HDMI and Headphone output
may not be compatible with operating systems that expose
very simple audio controls.
By default only enable the traditional mode that exposes a single
card for maximum compatibility.
Add options to the build configuration for enabling
Arguments in the macros should be coverd in brackets to aviod any
precedence issues. Fixed it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: mshan
---
drivers/staging/fwserial/fwserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index 41a49c8..d693c03 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging
On Mon, Mar 13, 2017 at 09:52:14PM -0700, mshan wrote:
> Signed-off-by: mshan
> ---
> drivers/staging/fwserial/fwserial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response
On Tue, 14 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
I thought you were going to take another approach to improve this code?
julia
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 79
> +++
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
around macro params.
Also, removing extra line.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/d
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
The actual report raises a bunch of issues, but I didn't receive any more
detail about them:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gr
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Add blank line after declarations
staging: speakup: fix "Alignment match open parenthesis"
drivers/staging/speakup/kobjects.c | 2 +-
drivers/staging/speakup/main.c
Alig arguments with open parenthesis.
Signed-off-by: Arushi Singhal
---
changes in v3
- Improve the commit message.
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
i
Patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Add a blank line after enum and struct declarations.
Signed-off-by: Arushi Singhal
---
changes in v3
- change the subject and commit message to make it more relevant.
Signed-off-by: mshan
---
drivers/staging/fwserial/fwserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index 41a49c8..d693c03 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging
Hi Sakari,
I started preparing a long argument about it, but gave up in favor of a
simpler one.
Em Mon, 13 Mar 2017 14:46:22 +0200
Sakari Ailus escreveu:
> Drivers are written to support hardware, not particular use case.
No, it is just the reverse: drivers and hardware are developed to
supp
> "Cathy" == Cathy Avery writes:
Hi Cathy,
Cathy> I haven't received any feedback yet.
Cathy> Should I resend?
You sent this right at the beginning of the merge window. That almost
guarantees that nobody will have time to look at it.
Whereas now is a good time to send submissions for 4.12
The dgnc_tty_send_break() has a switch-case condition for msec.
It is no use except case -1.
Signed-off-by: Daeseok Youn
---
V2: The two patches in previous series are merged into one patch.
drivers/staging/dgnc/dgnc_tty.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --
The bd variables in functions are already assigned from
ch->ch_bd but it is not used in those functions except checking NULL.
The ch->ch_bd could be replaced with bd variable.
Signed-off-by: Daeseok Youn
---
V2: Patches in previous series are splited but it could be merged into one.
There are li
2017-03-14 7:26 GMT+09:00 Greg KH :
> On Sun, Mar 12, 2017 at 11:47:28PM +0900, Daeseok Youn wrote:
>> The bd variable in dgnc_tty_digiseta() is assigned with
>> ch->ch_bd but it is not used in this function except checking NULL.
>> The ch->ch_bd could be replaced with bd variable in dgnc_tty_digis
On Tue, Mar 14, 2017 at 12:39:46PM +1100, Tobin C. Harding wrote:
> On Tue, Mar 14, 2017 at 08:06:18AM +0800, Greg Kroah-Hartman wrote:
> > On Tue, Mar 14, 2017 at 09:54:01AM +1100, Tobin C. Harding wrote:
> > > Function comments use a custom format. We have a standard function
> > > comment format
On Tue, Mar 14, 2017 at 08:07:15AM +0800, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:54:07AM +1100, Tobin C. Harding wrote:
> > Return value from kmalloc() does not require a cast.
> >
> > Remove unnecessary cast.
> >
> > Signed-off-by: Tobin C. Harding
> > ---
> > drivers/staging/k
On Tue, Mar 14, 2017 at 08:06:18AM +0800, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:54:01AM +1100, Tobin C. Harding wrote:
> > Function comments use a custom format. We have a standard function
> > comment format, kernel doc format. Using the standard format aids
> > readability and al
On 3/6/2017 6:03 PM, Bjorn Helgaas wrote:
On Fri, Mar 03, 2017 at 03:15:34PM -0600, Tom Lendacky wrote:
On 3/3/2017 2:42 PM, Bjorn Helgaas wrote:
On Thu, Mar 02, 2017 at 10:13:10AM -0500, Brijesh Singh wrote:
From: Tom Lendacky
The use of ioremap will force the setup data to be mapped decryp
Samuel Thibault, on mar. 14 mars 2017 01:47:01 +0100, wrote:
> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> > On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > > This patchset introduces a TTY-based way for the synths to communicate
> > > with devices as an alte
2017-03-14 2:54 GMT+09:00 Alan Cox :
>
> On Mon, 2017-03-13 at 19:54 +0900, Daeseok Youn wrote:
> > If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> > tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> > But using kzalloc is rather than kmalloc followed by mem
Hello,
Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > This patchset introduces a TTY-based way for the synths to communicate
> > with devices as an alternate for direct serial comms used by the synths
> > at the m
Hello Okash,
I'd say for a start already, rebase and submit patches 2-5, since they
are refactoring that makes sense anyway. And we can discuss about serdev
while that gets integrated, and thus serdev-equivalents of patches 1 and
6 will then be immediatetly applicable.
Samuel
On Tue, Mar 14, 2017 at 09:54:07AM +1100, Tobin C. Harding wrote:
> Return value from kmalloc() does not require a cast.
>
> Remove unnecessary cast.
>
> Signed-off-by: Tobin C. Harding
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
On Tue, Mar 14, 2017 at 09:54:01AM +1100, Tobin C. Harding wrote:
> Function comments use a custom format. We have a standard function
> comment format, kernel doc format. Using the standard format aids
> readability and allows documentation to be produced using kernel
> tools.
>
> Convert functio
On Mon, Mar 13, 2017 at 09:00:49AM +0200, Andrii wrote:
> Fix 'multiple blank lines' coding style problem reported by
> checkpatch.pl.
>
> Signed-off-by: Andrii Vladyka
Your From: name didn't match up with your signed-off-by: name here :(
Please fix up and resend.
thanks,
greg k-h
___
On Mon, Mar 13, 2017 at 02:14:25PM +0100, Gioh Kim wrote:
> read_u16 is wrapper of le16_to_cpu to read u16 variable,
> rather than __le16.
>
> Signed-off-by: Gioh Kim
> ---
> drivers/staging/wlan-ng/prism2mgmt.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng
On Sun, Mar 12, 2017 at 04:02:35PM -0600, Perry Hooker wrote:
> This patch fixes the following sparse warnings:
> drivers/staging/rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted
> __le16
> drivers/staging/rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted
> __le16
> drivers/s
Samuel Thibault, on lun. 13 mars 2017 23:26:08 +0100, wrote:
> > That should make this a lot easier than your patchset from what I can
> > see.
>
> Will serdev support modem line control? We need this for some devices.
"serdev: add serdev_device_set_rts" seems to be saying yes :)
Samuel
___
Greg KH, on mar. 14 mars 2017 07:43:03 +0800, wrote:
> > Well, for a start that didn't exist when Okash worked on the TTY part :)
>
> Fair enough, but it has been discussed for many months now on the
> linux-serial mailing list.
I have not had time for years to actually work on this subject, so I
Driver mixes spelling michael and michel in symbol names and
comments. Michael here references the IEEE 802.11i Message Integrity
Code. It is incorrect to spell it michel and confusing having two
spellings for the same thing.
Change michel -> micheal in both symbol names and comments.
Signed-off-
On Mon, Mar 13, 2017 at 11:26:08PM +0100, Samuel Thibault wrote:
> Hello,
>
> Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> > On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > > This patchset introduces a TTY-based way for the synths to communicate
> > > with de
er, I meant I will integrate this patch. And verify/fix
possible breakage for non-bayer passthrough.
Steve
On 03/13/2017 02:30 AM, Russell King - ARM Linux wrote:
On Mon, Mar 13, 2017 at 08:16:25AM +, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbe
On 03/13/2017 01:16 AM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote:
On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote:
What I had was this patch for your v3. I never got to testing your
v4 because of the LP-11 problem.
In v5, you've
Checkpatch emits WARNING: Comparisons should place the constant on the
right side of the test.
Move constant to right hand side of test, modify operator to ensure
logic is maintained.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+)
Code may be refactored to take advantage of previous patches which
reduced the level of indentation. Function parameter line breaks can
be adjusted in line with kernel coding standards.
Refactor layout of function call parameters. Make whitespace changes
only.
Signed-off-by: Tobin C. Harding
---
Checkpatch emits WARNING: Too many leading tabs - consider code
refactoring. One level of indentation may be removed by inverting an
if statement conditional (and returning if new conditional evaluates
to true). Code contains switch statement that also contains multiple
layers of indentation. Inden
Function comments use a custom format. We have a standard function
comment format, kernel doc format. Using the standard format aids
readability and allows documentation to be produced using kernel
tools.
Convert function comments to use kernel doc format.
Signed-off-by: Tobin C. Harding
---
dr
Checkpatch emits CHECK: Logical continuations should be on the
previous line.
Move logical continuation to previous line.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wl
Checkpatch emits WARNING: else is not generally useful after a break
or return. Two warnings of this type are emitted, both are the result
of a else statement after a return statement. The 'else' can safely be
removed.
Remove unnecessary else statement.
Signed-off-by: Tobin C. Harding
---
drive
Checkpatch emits WARNING: single byte memset is suspicious. Swapped
2nd/3rd argument? Call site in question is correct but is an unusual
use of memset() to zero a single byte. The same can be achieved by
assigning 0 directly to the memory location.
Dereference pointer and assign 0 to that memory l
Return value from kmalloc() does not require a cast.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/drivers/staging/ks7010/ks_wlan_net.c
Checkpatch emits CHECK: Alignment should match open parenthesis. This
is due to commented out code.
Remove commented out (dead) code.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.
Checkpatch emits block comments warnings.
Change comments blocks to be inline with kernel coding style for
networking code.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 51 ++--
1 file changed, 32 insertions(+), 19 deletions(-)
diff
Checkpatch emits over 100 instances of CHECK: No space is necessary
after a cast.
Remove unnecessary space.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 212 +--
1 file changed, 106 insertions(+), 106 deletions(-)
diff --git a/drive
Checkpatch emits various checks, warnings, and errors when parsing
ks_wlan_net.c.
Patch 01 fixes spacing issues.
Patch 02 converts block comments to use networking style block
comments.
Patch 03 converts function comments to use kernel doc format.
Patch 04 moves logical operators to the end of
Checkpatch emits CHECK: multiple assignments should be avoided.
Move multiple assignment onto separate lines. Fix comment to use more
natural English.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
On Tue, Mar 14, 2017 at 06:12:47AM +0800, Greg Kroah-Hartman wrote:
> On Mon, Mar 13, 2017 at 10:05:52PM +, okash.khaw...@gmail.com wrote:
> > Allow access to TTY device from kernel. This is based on Alan Cox's patch
> > (http://www.mail-archive.com/linux-kernel at
> > vger.kernel.org/msg12150
Hello,
Greg KH, on mar. 14 mars 2017 06:14:04 +0800, wrote:
> On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> > This patchset introduces a TTY-based way for the synths to communicate
> > with devices as an alternate for direct serial comms used by the synths
> > at the m
On Sun, Mar 12, 2017 at 11:47:28PM +0900, Daeseok Youn wrote:
> The bd variable in dgnc_tty_digiseta() is assigned with
> ch->ch_bd but it is not used in this function except checking NULL.
> The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()
>
> Signed-off-by: Daeseok Youn
>
On Mon, Mar 13, 2017 at 08:39:29PM +1100, Tobin C. Harding wrote:
> Driver mixes spelling michael and michel in symbol names and
> comments. Michael here references the IEEE 802.11i Message Integrity
> Code. It is incorrect to spell it michel and confusing having two
> spellings for the same thing.
On Tue, Mar 14, 2017 at 06:18:48AM +0800, Greg Kroah-Hartman wrote:
> On Tue, Mar 14, 2017 at 09:10:18AM +1100, Tobin C. Harding wrote:
> > On Mon, Mar 13, 2017 at 06:54:06PM +1100, Tobin C. Harding wrote:
> > > Simple patch set. Clears 29 checkpatch errors/warnings.
> > >
> > > Patch 01 does vari
On Mon, 13 Mar 2017, Arushi Singhal wrote:
> New variables are added to make the code more readable.
>
> Signed-off-by: Arushi Singhal
> ---
> changes in v2
> - removed the error.
>
> drivers/staging/sm750fb/ddk750_mode.c | 103
> --
> 1 file changed, 49 inse
On Tue, Mar 14, 2017 at 09:10:18AM +1100, Tobin C. Harding wrote:
> On Mon, Mar 13, 2017 at 06:54:06PM +1100, Tobin C. Harding wrote:
> > Simple patch set. Clears 29 checkpatch errors/warnings.
> >
> > Patch 01 does various fixes, all whitespace only changes.
> >
> > Is this ok putting multiple c
On Mon, Mar 13, 2017 at 10:05:51PM +, okash.khaw...@gmail.com wrote:
> Hi,
>
> This patchset introduces a TTY-based way for the synths to communicate
> with devices as an alternate for direct serial comms used by the synths
> at the moment. It then migrates some of the synths to the TTY-based
On Mon, Mar 13, 2017 at 10:05:52PM +, okash.khaw...@gmail.com wrote:
> Allow access to TTY device from kernel. This is based on Alan Cox's patch
> (http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1215095.html),
> with description quoted below.
>
> "tty_port: allow a port to be o
On Mon, Mar 13, 2017 at 06:54:06PM +1100, Tobin C. Harding wrote:
> Simple patch set. Clears 29 checkpatch errors/warnings.
>
> Patch 01 does various fixes, all whitespace only changes.
>
> Is this ok putting multiple checkpatch types in one patch if they are
> all whitespace? Please advise, I wo
This moves call to spk_stop_serial_interrupt() function out of synth_release()
and into release() method of specific spk_synth instances. This is because
a TTY-based synth implementation wouldn't need spk_stop_serial_interrupt()
call. Moving it into each synth's release() method gives the decision
These two functions are always called from a context where spk_synth instance
is available. They also use the spk_synth instance but instead of taking it
as an argument, they rely on a global spk_synth instance inside synth.c which
points to the same synth as the one being passed in as argument.
S
Hi,
This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.
As such,
This adds spk_ttyio.c file. It contains a set of functions which implement
those methods in spk_synth struct which relate to sending bytes out using
serial comms. Implementations in this file perform the same function but
using TTY subsystem instead. Currently synths access serial ports, directly
p
Allow access to TTY device from kernel. This is based on Alan Cox's patch
(http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1215095.html),
with description quoted below.
"tty_port: allow a port to be opened with a tty that has no file handle
Let us create tty objects entirely in ker
This patch adds spk_io_ops struct which contain those methods whose job is to
communicate with synth device. Currently, all comms with external synth
device use raw serial i/o. Starting with this patch set, an alternative
tty-based way of communication is being introduced. The idea is to group all
This moves spk_synth_immediate and spk_serial_synth_probe functions into
serialio.c. These functions do outgoing serial comms. The move is a step
towards collecting all serial comms in serialio.c. This also renames
spk_synth_immediate to spk_serial_synth_immediate.
Code inside those functions has
This changes the above five synths to TTY-based comms. They were chosen as a
first pass because their serial comms are straightforward, i.e. they don't use
serial input and don't do internal port knocking.
Signed-off-by: Okash Khawaja
Reviewed-by: Samuel Thibault
Index: linux-4.10.1/drivers/st
On Tue, Mar 14, 2017 at 01:49:52AM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl
> issues in drivers.
>
> Arushi Singhal (2):
> staging: speakup: identation should use tabs
> staging: dvb-frontends: removed code in comments.
What changed from v2?
thanks
On Tue, Mar 14, 2017 at 01:49:54AM +0530, Arushi Singhal wrote:
> Indentation should always use tabs and never spaces.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/speakup/speakup_dtlk.h | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
What changed from v2?
Alway
On 03/13/2017 02:29 PM, Rob Clark wrote:
> On Mon, Mar 13, 2017 at 5:09 PM, Laura Abbott wrote:
>>> Hm, we might want to expose all the heaps as individual
>>> /dev/ion_$heapname nodes? Should we do this from the start, since
>>> we're massively revamping the uapi anyway (imo not needed, current
>
On Sun, Mar 05, 2017 at 01:52:19PM -0800, Matthew Giassa wrote:
> Implementing some minor formatting changes to remove checkpatch warnings.
> Removing space-hardtab instances. Removing C++-style line comments in favor of
> C-style equivalent. Re-aligning function prototype arguments to remove relat
On 03/13/2017 10:10 AM, Hans Verkuil wrote:
On 03/13/2017 06:06 PM, Steve Longerbeam wrote:
On 03/13/2017 03:53 AM, Hans Verkuil wrote:
On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote:
On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote:
On 03/11/2017 07:14 PM, Steve Longe
On Tue, 14 Mar 2017, Arushi Singhal wrote:
> This patch removes typedefs from structures and renames them as per
> kernel coding standards.
Greg requested that typedef removing patches adjust only one patch at a
time.
The names of the types typically need to be adjusted as compared to what
is
On 03/13/2017 06:21 AM, Mark Brown wrote:
> On Mon, Mar 13, 2017 at 10:54:33AM +, Brian Starkey wrote:
>> On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote:
>
>>> Another point is how can we put secure rules (like selinux policy) on
>>> heaps since all the allocations
>>> go to
Hello,
On 3/13/17 2:40 PM, Arushi Singhal wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for please use a blank line after function/struct/union/enum
> declarations.
I haven't seen this pointed out by others before: starting a commit
message with "This patch..." is redundant (
From: Maciej Billewicz
Fix coding style issue.
Signed-off-by: Maciej Billewicz
---
drivers/staging/android/ion/ion_dummy_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/drivers/staging/android/ion/ion_dummy_driver.c
index cf5c010..c
On Mon, Mar 13, 2017 at 11:03:50PM +0200, Sakari Ailus wrote:
> Hi Steve,
>
> On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote:
> > I'm kinda in the middle on this topic. I agree with Sakari that
> > frame rate can fluctuate, but that should only be temporary. If
> > the frame rate
On Mon, Mar 13, 2017 at 5:09 PM, Laura Abbott wrote:
>> Hm, we might want to expose all the heaps as individual
>> /dev/ion_$heapname nodes? Should we do this from the start, since
>> we're massively revamping the uapi anyway (imo not needed, current
>> state seems to work too)?
>> -Daniel
>>
>
>
On 03/13/2017 03:54 AM, Brian Starkey wrote:
> On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote:
>> 2017-03-09 18:38 GMT+01:00 Laura Abbott :
>>> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
2017-03-06 17:04 GMT+01:00 Daniel Vetter :
> On Mon, Mar 06, 2017 at 11:58:05A
Fix coding style issue.
Signed-off-by: Maciej Billewicz
---
drivers/staging/android/ion/ion_dummy_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/drivers/staging/android/ion/ion_dummy_driver.c
index cf5c010..c1f9b83 100644
--- a/drive
Remember to use the imperative. "Add blank line...". You could just drop
function/struct/union/enum. Just declarations is fine.
On Tue, 14 Mar 2017, Arushi Singhal wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for please use a blank line after function/struct/union/enum
>
On Tue, 14 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
You don't have to send another revision just for this issue, but the
commit message would be better as "Align arguments with open parenthesis".
Something that explains what you
On Mon, Mar 13, 2017 at 10:56:46PM +0200, Sakari Ailus wrote:
> Hi Russell,
>
> On Mon, Mar 13, 2017 at 01:27:02PM +, Russell King - ARM Linux wrote:
> > On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> > > The vast majority of existing drivers do not implement them nor the user
On 03/12/2017 12:05 PM, Daniel Vetter wrote:
> On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard
> wrote:
>> 2017-03-09 18:38 GMT+01:00 Laura Abbott :
>>> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
2017-03-06 17:04 GMT+01:00 Daniel Vetter :
> On Mon, Mar 06, 2017 at 11:58:05AM +010
Hi Steve,
On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote:
>
>
> On 03/13/2017 06:55 AM, Philipp Zabel wrote:
> >On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote:
> >>On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> >>>The vast majority of existin
On 03/13/2017 06:56 AM, simran singhal wrote:
> All devm functions has a device structure as the first argument which is
> required by dev_{err,info,dbg} printing functions.
> This patch converts pr_err to dev_err as dev_* is preferred after calls
> to devm functions.
>
> Done using coccinelle:
>
Hi Russell,
On Mon, Mar 13, 2017 at 01:27:02PM +, Russell King - ARM Linux wrote:
> On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote:
> > The vast majority of existing drivers do not implement them nor the user
> > space expects having to set them. Making that mandatory would break
This patch removes typedefs from structures and renames them as per
kernel coding standards.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
drivers/staging/sm750fb/ddk750_mode.h | 20 +---
drivers/staging/sm750fb/sm750_hw.c| 2 +-
3 file
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal
---
changes in v3
- add the identifier name of one more prototype arguments.
drivers/staging/sm750fb/ddk750_display.h | 2 +-
drivers/staging/sm750fb/
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/ddk750_mode.c | 79 +--
1 file changed, 39 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c
b/driv
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
drivers/staging/sm750fb/sm750_cursor.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750_cursor.
Fix multiple code styling warnings issued by checkpatch on files
in sm750fb driver
Arushi Singhal (4):
staging: sm750fb: function prototype argument should have an
identifier name
staging: sm750fb: fixes add blank line after
function/struct/union/enum declarations
staging: sm750fb:
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/kobjects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/kobjects.c
b/drivers/staging/speakup/kobjects.c
index 8a58632
This patch fixes the warnings reported by checkpatch.pl
for please use a blank line after function/struct/union/enum
declarations.
Signed-off-by: Arushi Singhal
---
changes in v2
- change the subject to make it more relevant.
drivers/staging/speakup/main.c | 1 +
drivers/staging/speak
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Added blank line after function/struct/union/enum
declarations
staging: speakup: fix "Alignment match open parenthesis"
drivers/staging/speakup/kobjects.c | 2 +-
dri
Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singha
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index b3b3
Improve readability by fixing multiple checkpatch.pl
issues in drivers.
Arushi Singhal (2):
staging: speakup: identation should use tabs
staging: dvb-frontends: removed code in comments.
drivers/media/dvb-frontends/drxk_hard.c | 1 -
drivers/staging/speakup/speakup_dtlk.h | 10 +--
Commenting out Code is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singha
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/speakup_dtlk.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.h
b/drivers/staging/speakup/speakup_dtlk.h
index b3b3
1 - 100 of 183 matches
Mail list logo
