Comment string is unnecessarily verbose. Checkpatch emits WARNING:
line over 80 characters.
Reduce comment string without loss of meaning.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/k
Checkpatch emits various warnings and checks;
WARNING: Avoid multiple line dereference
CHECK: Alignment should match open parenthesis
WARNING: line over 80 characters
CHECK: Blank lines aren't necessary before a close brace '}'
These are all whitespace fixes.
Refactor whitespace inline with kern
'auth_type - 1' is used as an index into a key table. Adding a variable
appropriately named simplifies the code and adds meaning when
reading. Adding a pointer variable of type struct *kpa_key_t adds to
readability by removing the table access each time the key is used.
The key index is used to cr
Checkpatch emits WARNING: quoted string split across lines. Line is
already over 80 characters long, adding 3 more does little to effect
line length while improving readibility.
Concatenate split string into single line.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 3
Checkpatch emits WARNING: Too many leading tabs - consider code
refactoring. Function contains 5 levels of nesting and 14 local
variables. Code can be simplified and nesting reduced by refactoring
into separate functions.
WPA code is contained and may be factored out into a separate
function. This
Checkpatch emits CHECK: Logical continuations should be on the
previous line. Also the same code section causes checkpatch to emit
WARNING: Avoid multiple line dereference.
Move logical line continuations onto the previous line. Move multiple
line dereferences onto single line.
Make these two cha
Checkpatch emits a number of checkpatch warnings, errors and
checks when parsing ks_hostif.c. We can remove a number
of these by refactoring hostif_data_indication(). Function contains a
chunk of code for handling WPA, this is a good target for refactoring.
Patch 01 refactors WPA code into a separ
Code is deeply nested. One level of indentation may be removed by
inverting if statement conditional.
Invert conditional, return if new conditional evaluates to true.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 136 +++--
1 file chang
On Mon, Mar 13, 2017 at 09:28:34AM +0530, SIMRAN SINGHAL wrote:
> On Mon, Mar 13, 2017 at 12:03 AM, Alison Schofield
> wrote:
> > On Sun, Mar 12, 2017 at 07:02:50PM +0530, simran singhal wrote:
> >> The IIO subsystem is redefining iio_dev->mlock to be used by
> >> the IIO core only for protecting
On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 01:05:06PM -0700, Steve Longerbeam wrote:
On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote:
If it's too difficult to get the imx219 csi-2
On Mon, Mar 13, 2017 at 12:03 AM, Alison Schofield wrote:
> On Sun, Mar 12, 2017 at 07:02:50PM +0530, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes between INDIO_DIRECT_MODE, I
From: Philippe Reynes
Date: Wed, 8 Mar 2017 23:41:04 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
Previous work was done auditing return statements and use of goto
statements in drivers/staging/dgnc however some mistakes were
made. Review picked up the mistakes but due to developer omission
patch set was merged.
Make changes do dgnc inline with previous review suggestions.
Patch 01 change ret
Checkpatch emits CHECK: Blank lines aren't necessary before a close
brace '}'. Previous attempts were made to make uniform the error
handling in dgnc but improvements are still possible.
Undo whitespace changes that should not have been made :(. Make return
statement placement uniform throughout
Function return type is 'int'. Returned variable is of type
'uint'. uint can be implicitly converted to int. Most significant bit
is not set so there is no risk in implicit conversion.
Remove unnecessary type cast.
Signed-off-by: Tobin C. Harding
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 fi
In various functions a return code variable is defined at the top of
function, for example;
rc = -ENODEV;
and then the variable is returned. This makes it harder to read since
it separates the error code from the return site.
Return the error code directly instead of using a variable.
Signed-of
This supports spelling unicode characters by just passing them to
the speech synthesis in direct mode.
Signed-off-by: Samuel Thibault
Index: linux-4.10/drivers/staging/speakup/main.c
===
--- linux-4.10.orig/drivers/staging/speakup/m
Hello,
This patch series fixes a couple of issues of the previous "support 16bit
unicode screen reading" series:
- actually get unicode characters when reviewing console text.
- fix unicode character spelling
Samuel
--
Samuel
CN > J'ai enseigné l'algorythmique.
GLG> C'est quoi l'algorythmiq
9831013cbdbd3d06430a1db01d8c32d50c7d1c04 ('speakup: convert screen reading to
16bit characters') paved the way for handling unicode characters in speakup, but
for the review mode, it missed actually getting unicode characters from the VC.
This fixes by just turning the use_unicode parameter to 1.
On Sun, Mar 12, 2017 at 11:02:41PM +0100, Greg KH wrote:
> On Mon, Mar 13, 2017 at 07:50:42AM +1100, Tobin C. Harding wrote:
> > On Sun, Mar 12, 2017 at 05:24:38PM +0100, gre...@linuxfoundation.org wrote:
> > >
> > > This is a note to let you know that I've just added the patch titled
> > >
> > >
Em Sun, 12 Mar 2017 22:29:04 +0100
Pavel Machek escreveu:
> Mid-layer is difficult... there are _hundreds_ of possible
> pipeline setups. If it should live in kernel or in userspace is a
> question... but I don't think having it in kernel helps in any way.
Mid-layer is difficult, because we eith
Hi Radoslaw,
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Radoslaw-Pietrzyk/staging-fb
Em Sun, 12 Mar 2017 21:13:24 +
Russell King - ARM Linux escreveu:
> On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote:
> > Yet, udev/systemd has some rules that provide an unique name for V4L
> > devices at /lib/udev/rules.d/60-persistent-v4l.rules. Basically, it
> > runs
On Mon, Mar 13, 2017 at 07:50:42AM +1100, Tobin C. Harding wrote:
> On Sun, Mar 12, 2017 at 05:24:38PM +0100, gre...@linuxfoundation.org wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > staging: dgnc: remove item from TODO list
> >
> > to my staging
This patch fixes the following sparse warnings:
drivers/staging/rtl8192u/r8192U_dm.c:2307:49: warning: cast from restricted
__le16
drivers/staging/rtl8192u/r8192U_dm.c:2308:44: warning: cast from restricted
__le16
drivers/staging/rtl8192u/r8192U_dm.c:2309:44: warning: cast from restricted
__le16
Em Sun, 12 Mar 2017 10:56:53 -0700
Steve Longerbeam escreveu:
> On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote:
> > On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
> > Given what Mauro has said, I'm convinced that the media controller stuff
> > is a complete failure f
Hi Arushi,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.11-rc1 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-sm750fb-Imp
On Sat 2017-03-11 23:14:56, Russell King - ARM Linux wrote:
> On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote:
> > This situation is there since 2009. If I remember well, you tried to write
> > such generic plugin in the past, but never finished it, apparently because
> > it i
On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote:
> Yet, udev/systemd has some rules that provide an unique name for V4L
> devices at /lib/udev/rules.d/60-persistent-v4l.rules. Basically, it
> runs a small application (v4l_id) with creates a persistent symling
> using rules lik
On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote:
> On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote:
> > But hold on, if my logic is correct, then why did the CSI power-off
> > get reached in your case, multiple times? Yes I think there is a bug,
> > link_no
Em Sun, 12 Mar 2017 19:47:00 +
Russell King - ARM Linux escreveu:
> Another issue.
>
> The "reboot and the /dev/video* devices come up in a completely
> different order" problem seems to exist with this version.
>
> The dot graph I supplied previously had "ipu1_csi0 capture" on
> /dev/video
On Sun, Mar 12, 2017 at 05:24:38PM +0100, gre...@linuxfoundation.org wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> staging: dgnc: remove item from TODO list
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/
On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote:
> But hold on, if my logic is correct, then why did the CSI power-off
> get reached in your case, multiple times? Yes I think there is a bug,
> link_notify() is not checking if the link has already been disabled.
> I will fix this. B
On 03/12/2017 01:36 PM, Steve Longerbeam wrote:
On 03/12/2017 01:16 PM, Steve Longerbeam wrote:
On 03/12/2017 12:44 PM, Steve Longerbeam wrote:
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote:
There's actually no
On 03/12/2017 01:16 PM, Steve Longerbeam wrote:
On 03/12/2017 12:44 PM, Steve Longerbeam wrote:
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote:
There's actually nothing preventing userland from disabling a link
mul
On Sun, Mar 12, 2017 at 01:05:06PM -0700, Steve Longerbeam wrote:
>
>
> On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote:
> >On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote:
> >>If it's too difficult to get the imx219 csi-2 transmitter into the
> >>LP-11 state on power on,
On 03/12/2017 12:44 PM, Steve Longerbeam wrote:
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote:
There's actually nothing preventing userland from disabling a link
multiple times, and imx_media_link_notify() complies,
On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote:
If it's too difficult to get the imx219 csi-2 transmitter into the
LP-11 state on power on, perhaps the csi-2 receiver can be a little
more lenient on the transmitter and m
On 03/12/2017 12:47 PM, Russell King - ARM Linux wrote:
Another issue.
The "reboot and the /dev/video* devices come up in a completely
different order" problem seems to exist with this version.
The dot graph I supplied previously had "ipu1_csi0 capture" on
/dev/video4. I've just rebooted, an
On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote:
> If it's too difficult to get the imx219 csi-2 transmitter into the
> LP-11 state on power on, perhaps the csi-2 receiver can be a little
> more lenient on the transmitter and make the LP-11 timeout a warning
> instead of error-out.
Another issue.
The "reboot and the /dev/video* devices come up in a completely
different order" problem seems to exist with this version.
The dot graph I supplied previously had "ipu1_csi0 capture" on
/dev/video4. I've just rebooted, and now I find it's on
/dev/video2 instead.
Here's the extrac
On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote:
On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote:
There's actually nothing preventing userland from disabling a link
multiple times, and imx_media_link_notify() complies, and so
csi_s_power(OFF) gets called multiple times,
On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote:
> There's actually nothing preventing userland from disabling a link
> multiple times, and imx_media_link_notify() complies, and so
> csi_s_power(OFF) gets called multiple times, and so that WARN_ON()
> in there is silly, I borrowed
On 03/12/2017 10:51 AM, Russell King - ARM Linux wrote:
I've just looked at my test system's dmesg, and spotted this in the log.
It's been a while since these popped out of the kernel, so I don't know
what caused them (other than the obvious, a media-ctl command.)
My script which sets this up
This patch adjusts lines so that they are less than 80 char.
Checkpatch.pl idenitified the issue.
Signed-off-by: Craig Inches
---
drivers/staging/lustre/lustre/include/lu_object.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include
On Sun, Mar 12, 2017 at 2:34 PM, Benjamin Gaignard
wrote:
> 2017-03-09 18:38 GMT+01:00 Laura Abbott :
>> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
>>> 2017-03-06 17:04 GMT+01:00 Daniel Vetter :
On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote:
> On Mon, Mar 06, 2017 at 11
On Sun, Mar 12, 2017 at 07:02:50PM +0530, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used t
On Sun, Mar 12, 2017 at 06:40:52PM +0530, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used t
On Sun 2017-03-12 07:37:45, Russell King - ARM Linux wrote:
> On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
> >
> >
> > On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
> > >On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
> > >>
> > >>
> > >>On 03/11/2
On Sun, Mar 12, 2017 at 07:56:56PM +0200, Andrii wrote:
> Signed-off-by: Andrii Vladyka
{sigh}
Please go read the patch-bot items, you did not fix all of the issues it
raised.
Take some time, fix them up, and wait a day or so before resending.
There is no rush.
greg k-h
___
On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote:
On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote:
On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote:
On 03/11/2017 10:45 AM, Russell King - ARM L
Signed-off-by: Andrii Vladyka diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 255c30e..3fa6af2 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -30,7 +30,6 @@ void init_mlme_ap_info(struct adap
I've just looked at my test system's dmesg, and spotted this in the log.
It's been a while since these popped out of the kernel, so I don't know
what caused them (other than the obvious, a media-ctl command.)
My script which sets this up only enables links, and then configures the
formats etc, and
On Sun, Mar 12, 2017 at 06:52:26PM +0200, Andrii wrote:
> Signed-off-by: Andrii Vladyka
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (h
On Fri, Mar 10, 2017 at 03:20:34PM -0800, Steve Longerbeam wrote:
>
>
> On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote:
> >Version 5 gives me no v4l2 controls exposed through the video device
> >interface.
> >
> >Just like with version 4, version 5 is completely useless with IMX219:
> >
>
The function atomisp_set_stop_timeout on being called, simply returns
back. The function hasn't been mentioned in the TODO and doesn't have
FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
removed.
This was done using Coccinelle.
@@
identifier f;
@@
void f(...) {
-retu
Convert macro GAT_CONFIG to static inline function as static inline
functions are preferred over macros. This change is possible since the
arguments at all call sites have the same type.
The uses were updated with Coccinelle:
@r1@
expression dev,reg,chan,src;
@@
-GAT_CONFIG(chan, src)
+pci224_gat
Signed-off-by: Andrii Vladyka diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 255c30e..b324429 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -30,7 +30,6 @@ void init_mlme_ap_info(struct adap
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-next
head: 38081c71859efee77c7f3fec07bc4748acb248dc
commit: 49637a458b61629672a8ae19fdae2058c64815cf [393/425] staging: media:
atomisp: remove '.' from pci Makefile
config: x86_64-randconfig-x011-03122325 (attach
On Sun, Mar 12, 2017 at 06:40:52PM +0530, simran singhal wrote:
> The IIO subsystem is redefining iio_dev->mlock to be used by
> the IIO core only for protecting device operating mode changes.
> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
>
> In this driver, mlock was being used t
On Sun, Mar 12, 2017 at 05:47:33PM +0200, Andrii wrote:
> On Sun, 12 Mar 2017 16:42:07 +0100
> Greg KH wrote:
>
> > On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote:
> > > Fixed three code style warnings (multiple line dereference) reported
> > > by checkpatch.pl script.
> > >
> > > Signed
On Sun, Mar 12, 2017 at 02:36:47PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 09, 2017 at 03:53:00PM +0100, Marcin Ciupak wrote:
> > Replace simple_strtoul with kstrtoint.
>
> Why?
Because
> > simple_strtoul is marked for obsoletion.
as reported by checkpatch.pl.
> >
> > Signed-off-by: Marc
On Sun, 12 Mar 2017 16:42:07 +0100
Greg KH wrote:
> On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote:
> > Fixed three code style warnings (multiple line dereference) reported
> > by checkpatch.pl script.
> >
> > Signed-off-by: Andrii Vladyka
>
> > diff --git a/drivers/staging/wlan-ng/h
On Sun, 12 Mar 2017, SIMRAN SINGHAL wrote:
> On Sun, Mar 12, 2017 at 7:24 PM, Greg KH wrote:
> > On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> >> The function atomisp_set_stop_timeout on being called, simply returns
> >> back. The function hasn't been mentioned in the TODO a
On Sun, 12 Mar 2017, simran singhal wrote:
> Convert macro GAT_CONFIG to static inline function as static inline
> functions are preferred over macros. This change is possible since the
> arguments at all call sites have the same type.
>
> This was done using Coccinelle:
>
> @r@
> expression e;
On Sun, Mar 12, 2017 at 7:24 PM, Greg KH wrote:
> On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
>> The function atomisp_set_stop_timeout on being called, simply returns
>> back. The function hasn't been mentioned in the TODO and doesn't have
>> FIXME code around. Hence, atomisp_s
On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote:
> Fixed three code style warnings (multiple line dereference) reported
> by checkpatch.pl script.
>
> Signed-off-by: Andrii Vladyka
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134
Convert macro GAT_CONFIG to static inline function as static inline
functions are preferred over macros. This change is possible since the
arguments at all call sites have the same type.
This was done using Coccinelle:
@r@
expression e;
@@
- #define GAT_CONFIG(chan, src) e
+ static inline unsigne
Fixed three code style warnings (multiple line dereference) reported
by checkpatch.pl script.
Signed-off-by: Andrii Vladyka diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6134eba..a050748 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/dri
On Sun, Mar 12, 2017 at 08:25:28PM +0530, SIMRAN SINGHAL wrote:
> On Sun, Mar 12, 2017 at 7:04 PM, Greg KH wrote:
> > On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote:
> >> Replace strcpy with strlcpy as strcpy does not check for buffer
> >> overflow.
> >
> > Can there be a buffer ov
On Sun, 12 Mar 2017, walter harms wrote:
>
>
> Am 11.03.2017 20:32, schrieb Colin King:
> > From: Colin Ian King
> >
> > There is no need to check if ret is non-zero, remove this
> > redundant check and just return the error status from the call
> > to mt9m114_write_reg_array.
> >
> > Detected
Am 11.03.2017 20:32, schrieb Colin King:
> From: Colin Ian King
>
> There is no need to check if ret is non-zero, remove this
> redundant check and just return the error status from the call
> to mt9m114_write_reg_array.
>
> Detected by CoverityScan, CID#1416577 ("Identical code for
> differen
On Sun, Mar 12, 2017 at 7:04 PM, Greg KH wrote:
> On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote:
>> Replace strcpy with strlcpy as strcpy does not check for buffer
>> overflow.
>
> Can there be a buffer overflow here? If not, then strcpy is just fine
> to use. Do you see a poten
The bd variable in dgnc_tty_digiseta() is assigned with
ch->ch_bd but it is not used in this function except checking NULL.
The ch->ch_bd could be replaced with bd variable in dgnc_tty_digiseta()
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(
The dgnc_tty_send_break() has a switch-case condition for msec.
It is no use except case -1.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_t
The bd variable in dgnc_tty_send_break() is assigned with
ch->ch_bd but it is not used in this function except checking NULL.
The ch->ch_bd could be replaced with bd variable in dgnc_tty_send_break()
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insert
On Sun, Mar 12, 2017 at 7:12 PM, Greg KH wrote:
> On Sat, Mar 11, 2017 at 05:10:34PM +0530, SIMRAN SINGHAL wrote:
>> On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter
>> wrote:
>> > On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
>> >> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter
On Sun, Mar 12, 2017 at 7:26 PM, Greg KH wrote:
> On Fri, Mar 10, 2017 at 06:12:31PM +0530, simran singhal wrote:
>> Convert macro GAT_CONFIG to static inline function as static inline
>> functions are preferred over macros. This change is possible since the
>> arguments at all call sites have the
On Sat, Mar 11, 2017 at 12:29:09AM +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons in speakup driver to be more
> consistant with the rest of the kernel coding style.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/speakup/selection.c | 2 +-
> drivers/staging/
On Fri, Mar 10, 2017 at 10:25:27AM +0100, Radoslaw Pietrzyk wrote:
> Allows bpp to be set from dt
>
> Signed-off-by: Radoslaw Pietrzyk
> ---
> drivers/staging/fbtft/fbtft-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c
> b/drivers/staging/fb
On Fri, Mar 10, 2017 at 09:16:32PM +0530, Arushi Singhal wrote:
> Commenting Code Is a Bad Idea.
No, "Commenting code is a good idea". I think you mean "commenting out
code is a bad idea", correct?
And no need for putting the sentance in all caps.
thanks,
greg k-h
_
On Sat, Mar 11, 2017 at 12:12:43AM +0530, Arushi Singhal wrote:
> This patch fixes the warnings reported by checkpatch.pl
> for please use a blank line after function/struct/union/enum
> declarations.
>
> Signed-off-by: Arushi Singhal
You didn't put what subsystem: driver you are modifying in th
On Fri, Mar 10, 2017 at 04:20:23AM +0530, simran singhal wrote:
> This patch removes unnecessary typecast of c90 int constant.
>
> WARNING: Unnecessary typecast of c90 int constant
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++---
> 1 file changed,
On Sat, Mar 11, 2017 at 10:39:56PM +0200, Andrii wrote:
> Fixed code style warnings reported by checkpatch.pl script.
What warning would that be? Please always be very specific.
>
> Signed-off-by: Andrii Vladyka
Trailing whitespace on this line :(
> diff --git a/drivers/staging/wlan-ng/hfa
On Sat, Mar 11, 2017 at 12:50:19AM +0100, Thibaut SAUTEREAU wrote:
> Remove trailing whitespaces as pointed out by checkpatch.pl.
>
> Signed-off-by: Thibaut SAUTEREAU
> ---
> drivers/staging/ks7010/ks_hostif.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
Patch doesn'
On Sun, Mar 12, 2017 at 06:32:27PM +0530, Manoj Sawai wrote:
> Fixes a checkpatch error which occurs on almost every line.
>
> "ERROR: Macros with complex values should be enclosed in parentheses"
>
> Couple of other warnings about using spaces instead of tab are also
> fixed since they are in th
On Sat, Mar 11, 2017 at 01:55:55PM +0100, Thibaut SAUTEREAU wrote:
> Fix checkpatch.pl warning about line over 80 characters by breaking function
> parameters into two lines.
>
> Signed-off-by: Thibaut SAUTEREAU
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 3 ++-
> 1 file changed, 2 insertion
On Sat, Mar 11, 2017 at 08:54:07AM +0530, Arushi Singhal wrote:
> Improve readability by fixing multiple checkpatch.pl
> issues in sm750fb driver.
>
> Arushi Singhal (3):
> staging: sm750fb: function prototype argument should have an
> identifier name
> staging: sm750fb: fixes add blank li
On Fri, Mar 10, 2017 at 06:12:31PM +0530, simran singhal wrote:
> Convert macro GAT_CONFIG to static inline function as static inline
> functions are preferred over macros. This change is possible since the
> arguments at all call sites have the same type.
>
> This was done using Coccinelle:
>
>
On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
>
On Sat, Mar 11, 2017 at 05:10:34PM +0530, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter
> wrote:
> > On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
> >> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter
> >> wrote:
> >> > Don't resend, but next time if you
On Fri, Mar 10, 2017 at 12:20:44AM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Fix coding style issues and comments in rtl_core.c
What issues would that be? Please always be specific and tell us what
you do.
Also always test-build your patches, otherwise you make maintainers
r
On Sat, Mar 11, 2017 at 01:07:40PM +, Craig Inches wrote:
> This patch resolves the "Comparisons should place the constant on
> the right side of the test" found with checkpatch tool.
Both are constants, I think checkpatch is the thing that is wrong here,
don't you agree?
thanks,
greg k-h
__
On Thu, Mar 09, 2017 at 03:53:00PM +0100, Marcin Ciupak wrote:
> Replace simple_strtoul with kstrtoint.
Why?
> simple_strtoul is marked for obsoletion.
>
> Signed-off-by: Marcin Ciupak
> ---
> drivers/staging/lustre/lustre/obdclass/obd_mount.c | 20
> 1 file changed, 16 in
On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote:
> Replace strcpy with strlcpy as strcpy does not check for buffer
> overflow.
Can there be a buffer overflow here? If not, then strcpy is just fine
to use. Do you see a potential code path here that actually is a
problem using this?
2017-03-09 18:38 GMT+01:00 Laura Abbott :
> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote:
>> 2017-03-06 17:04 GMT+01:00 Daniel Vetter :
>>> On Mon, Mar 06, 2017 at 11:58:05AM +0100, Mark Brown wrote:
On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote:
> No one gave a thi
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
On Wed, Mar 08, 2017 at 04:54:43PM -0500, Roy Pledge wrote:
> From: Stuart Yoder
>
> add document describing the dpio driver and it's role, components
> and major interfaces
>
> Signed-off-by: Stuart Yoder
You need to also sign off on patches you send me from others if I am to
be able to accep
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a lock in the devices g
Fixes a checkpatch error which occurs on almost every line.
"ERROR: Macros with complex values should be enclosed in parentheses"
Couple of other warnings about using spaces instead of tab are also
fixed since they are in the same line as the error.
Signed-off-by: Manoj Sawai
---
drivers/stagi
100 matches
Mail list logo
