[GIT PULL] Staging driver warning fixes for 4.11-rc2

The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.11-rc2 for you to fetch changes up to 69eb1596b4d

Re: [Outreachy kernel] [PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name

On Sat, 11 Mar 2017, Arushi Singhal wrote: > function prototype arguments like 'struct vb_device_info *','unsigned > long' etc. should have an identifier name. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/sm750fb/ddk750_display.h | 2 +- > drivers/staging/sm750fb/ddk750_mode.h

Re: [Outreachy kernel] [PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis

On Sat, 11 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". > > Signed-off-by: Arushi Singhal > --- > drivers/staging/sm750fb/ddk750_mode.c | 79 > +-- > 1 file changed, 39 insertions(+), 40 deletions(-)

Re: [Outreachy kernel] [PATCH 00/10] staging: iio: Remove exceptional & on functions name

On Sat, 11 Mar 2017, simran singhal wrote: > This patch-series removes exceptional & on functions name. The semantic patch shown does nothing to check that the use of & is exception in the given file. It just removes all the & on function names. julia > > simran singhal (10): > staging: ii

[PATCH 10/10] staging: iio: gyro: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/gyro/adis16060_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 08/10] staging: iio: adis16203: Remove exceptional & on function name

In this file, function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/accel/adis16203.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH 09/10] staging: iio: resolver: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/resolver/ad2s1200.c | 2 +- drivers/staging/iio/resolver/ad2s90.c | 2

[PATCH 04/10] staging: iio: cdc: ad7152: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/cdc/ad7152.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

[PATCH 05/10] staging: iio: adis16240: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/accel/adis16240.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 06/10] staging: iio: adis16201: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/accel/adis16201.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 00/10] staging: iio: Remove exceptional & on functions name

This patch-series removes exceptional & on functions name. simran singhal (10): staging: iio: ad7192: Remove exceptional & on function name staging: iio: ad7780: Remove exceptional & on function name staging: iio: cdc: ad7746: Remove exceptional & on function name staging: iio: cdc: ad7152

[PATCH 07/10] staging: iio: adis16209: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/accel/adis16209.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH 01/10] staging: iio: ad7192: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/adc/ad7192.c | 12 ++-- 1 file changed, 6 insertions(+), 6 dele

[PATCH 03/10] staging: iio: cdc: ad7746: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/cdc/ad7746.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 02/10] staging: iio: ad7780: Remove exceptional & on function name

In this file,function names are otherwise used as pointers without &. Found using coccinelle. // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f // Signed-off-by: simran singhal --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 0/3] staging: sm750fb: multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in sm750fb driver. Arushi Singhal (3): staging: sm750fb: function prototype argument should have an identifier name staging: sm750fb: fixes add blank line after function/struct/union/enum declarations staging: sm750fb: Align

[PATCH 2/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/sm750_cursor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/sm750fb/sm750_cursor.

[PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_mode.c | 79 +-- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/driv

[PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h| 2 +- drivers/staging/sm750fb/ddk750_power.h | 2 +- dr

[PATCH V2] Staging: bcm2835: Fixed style of block comments

Fixed style of block comments across whole driver Found using checkpatch Signed-off-by: Derek Robson --- Version #1 had ugly long subject name. .../media/platform/bcm2835/bcm2835-camera.c| 24 ++ drivers/staging/media/platform/bcm2835/controls.c | 22 +++

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter wrote: > Don't resend, but next time if you wanted to fold all these patches and > send them as one patch that would be fine. > Hi Dan, Before I sent this patches as single patch only, but then greg asked me to resend them as different patches. Tha

[PATCH] staging: ks7010: remove trailing whitespaces

Remove trailing whitespaces as pointed out by checkpatch.pl. Signed-off-by: Thibaut SAUTEREAU --- drivers/staging/ks7010/ks_hostif.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured a

Re: [PATCH v5 22/39] media: Add userspace header file for i.MX

Hi! > diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild > index aafaa5a..fa78958 100644 > --- a/include/uapi/media/Kbuild > +++ b/include/uapi/media/Kbuild > @@ -1 +1,2 @@ > # UAPI Header export list > +header-y += imx.h > diff --git a/include/uapi/media/imx.h b/include/uapi/medi

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: > >On 10/03/17 05:52, Steve Longerbeam wrote: > >>Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > >>output device has measured an interval between the reception o

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start failed

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

Hi Boris, On 03/10/2017 05:06 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:15:15AM -0500, Brijesh Singh wrote: If kernel_maps_pages_in_pgd is called early in boot process to change the kernel_map_pages_in_pgd() memory attributes then it fails to allocate memory when spliting large

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi Mauro (and others), On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 10 Mar 2017 15:20:48 +0100 > Hans Verkuil escreveu: > > > > > > As I've already mentioned, from talking about this with Mauro, it seems > > > Mauro is in agreement with permitting the control

Re: [PATCH 0/3] multiple checkpatch issues

On Sat, Mar 11, 2017 at 03:26:54AM +0530, Arushi Singhal wrote: > Improve readability by fixing multiple checkpatch.pl > issues in sm750fb driver. Note, _PLEASE_ put the subsystem/driver name in this 0/X email subject line, like your patches have them. It makes it easier when I sort patches by d

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On Fri, Mar 10, 2017 at 6:57 PM, Pavel Machek wrote: > And it should not depend on configuration. Hardware vendor should be > able to ship board with working device tree... We are talking about pin conflict here. Please read the commit log of this patch for details. _

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On Fri 2017-03-10 16:17:28, Fabio Estevam wrote: > On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky > wrote: > > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: > >> There is a pin conflict with GPIO_6. This pin functions as a power > >> input pin to the OV5642 camera sensor, but ENET uses it as the h/w >

[PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h| 2 +- drivers/staging/sm750fb/ddk750_power.h | 2 +- dr

[PATCH 2/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/sm750_cursor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/sm750fb/sm750_cursor.

[PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_mode.c | 79 +-- 1 file changed, 39 insertions(+), 40 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/driv

[PATCH 0/3] multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in sm750fb driver. Arushi Singhal (3): staging: sm750fb: function prototype argument should have an identifier name staging: sm750fb: fixes add blank line after function/struct/union/enum declarations staging: sm750fb: Alig

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > Argh! that is indeed a bug at libv4l (and maybe at gstreamer). > > I guess that the always_needs_conversion logic was meant to be used to > really odd proprietary formats, e. g: > > /* Vendor-specific formats */ > #define V4L2_PIX_FMT_CPIA1v4l2_fourcc('C', 'P', 'I', 'A') /* cp

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

Don't resend, but next time if you wanted to fold all these patches and send them as one patch that would be fine. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverd

[PATCH 2/2] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/staging/speakup/speakup_decpc.c |

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Fri, 10 Mar 2017 15:57:09 + Russell King - ARM Linux escreveu: > On Fri, Mar 10, 2017 at 12:26:34PM -0300, Mauro Carvalho Chehab wrote: > > Hi Russell, > > > > Em Fri, 10 Mar 2017 13:07:33 + > > Russell King - ARM Linux escreveu: > > > > > The idea that the v4l libraries should in

[PATCH 0/2] Improve code readability

Improve readability by fixing multiple checkpatch.pl issues. Arushi Singhal (2): staging: speakup: Avoid multiple assignments on same line staging: speakup: fixes braces {} should be used on all arms of this statement drivers/staging/speakup/main.c | 6 -- drivers/staging/

[PATCH 1/2] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 00335e

Re: [PATCH v5 00/39] i.MX Media Driver

Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start failed with -110 imx6-mipi-csi2: LP-11 timeout, phy_state = 0x

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky wrote: > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: >> There is a pin conflict with GPIO_6. This pin functions as a power >> input pin to the OV5642 camera sensor, but ENET uses it as the h/w >> workaround for erratum ERR006687, to wake-up the ARM core

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On 3/9/2017 8:52 PM, Steve Longerbeam wrote: > There is a pin conflict with GPIO_6. This pin functions as a power > input pin to the OV5642 camera sensor, but ENET uses it as the h/w > workaround for erratum ERR006687, to wake-up the ARM cores on normal > RX and TX packet done events. So we need to

[PATCH] staging: speakup: Comparison to NULL could be written

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/varhandlers.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletion

[PATCH] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++--- drivers/staging/speakup/speakup_decpc.c |

[PATCH] Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

[PATCH] staging: speakup: Blank lines removed after an open brace '{'

Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index edde9e68779e..

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is o

Re: [Outreachy kernel] [PATCH] staging: speakup: Avoid multiple assignments on same line

On Fri, 10 Mar 2017, Arushi Singhal wrote: > Should I resend the patch Maybe let it go. If Greg asked for a resend, he's probably fine with it as is. It's more me who would rather know whether it is something I have seen before :) julia > > On Friday, March 10, 2017 at 10:50:28 PM UTC+5:30,

Re: [Outreachy kernel] [PATCH] staging: speakup: Avoid multiple assignments on same line

On Fri, 10 Mar 2017, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." Is this something that you have sent before that Greg asked you to resend? It could be good to put RESEND in [PATCH] in that case. julia > > Signed-off-by: Arush

[PATCH] staging: speakup: Avoid multiple assignments on same line

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, Mar 10, 2017 at 03:57:09PM +, Russell King - ARM Linux wrote: > Enabling debug output in gstreamer's v4l2src plugin confirms that > the kernel's bayer format are totally hidden from gstreamer when > linked with libv4l2, but are present when it isn't linked with > libv4l2. Here's the in

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On 03/10/2017 06:27 AM, Brian Starkey wrote: > On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: >> On 10/03/17 10:31, Brian Starkey wrote: >>> Hi, >>> >>> On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >>> >>> [snip]

Re: [RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

Hi Boris and Paolo, On 03/09/2017 10:29 AM, Borislav Petkov wrote: On Thu, Mar 09, 2017 at 05:13:33PM +0100, Paolo Bonzini wrote: This is not how you check if running under a hypervisor; you should check the HYPERVISOR bit, i.e. bit 31 of cpuid(1).ecx. This in turn tells you if leaf 0x4000

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, Mar 10, 2017 at 12:26:34PM -0300, Mauro Carvalho Chehab wrote: > Hi Russell, > > Em Fri, 10 Mar 2017 13:07:33 + > Russell King - ARM Linux escreveu: > > > The idea that the v4l libraries should intercept the format negotiation > > between the application and kernel is a particularly

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Fri, 10 Mar 2017 15:20:48 +0100 Hans Verkuil escreveu: > > > As I've already mentioned, from talking about this with Mauro, it seems > > Mauro is in agreement with permitting the control inheritence... I wish > > Mauro would comment for himself, as I can't quote our private discussion > > on

[PATCH 2/2] staging: dvb-frontends: removed code in comments.

Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal -

[PATCH 1/2] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index b3b3

[PATCH 0/2] checkpatch cleanups

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: identation should use tabs staging: dvb-frontends: removed code in comments. drivers/media/dvb-frontends/drxk_hard.c | 1 - drivers/staging/speakup/speakup_dtlk.h | 10 +

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi Russell, Em Fri, 10 Mar 2017 13:07:33 + Russell King - ARM Linux escreveu: > The idea that the v4l libraries should intercept the format negotiation > between the application and kernel is a particularly painful one - the > default gstreamer build detects the v4l libraries, and links agai

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Em Fri, 10 Mar 2017 13:54:28 +0100 Hans Verkuil escreveu: > > Devices that have complex pipeline that do essentially require using the > > Media controller interface to configure them are out of that scope. > > > > Way too much of how the MC devices should be used is in the minds of > develo

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: On 10/03/17 10:31, Brian Starkey wrote: Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still h

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 15:01, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 02:22:29PM +0100, Hans Verkuil wrote: >> And nobody of the media core developers has the time to work on the docs, >> utilities and libraries you need to make this all work cleanly and reliably. > > Well, talking about do

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, Mar 10, 2017 at 02:22:29PM +0100, Hans Verkuil wrote: > And nobody of the media core developers has the time to work on the docs, > utilities and libraries you need to make this all work cleanly and reliably. Well, talking about docs, and in connection to control inheritence, this is alrea

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On Fri, Mar 10, 2017 at 7:40 AM, Daniel Vetter wrote: > On Fri, Mar 10, 2017 at 10:31:13AM +, Brian Starkey wrote: >> Hi, >> >> On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: >> > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >> >> [snip] >> >> > > >> > > For me those patches

[PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

The function atomisp_set_stop_timeout on being called, simply returns back. The function hasn't been mentioned in the TODO and doesn't have FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been removed. This was done using Coccinelle. @@ identifier f; @@ void f(...) { -retu

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 14:07, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 01:54:28PM +0100, Hans Verkuil wrote: >> But there was always meant to be a layer (libv4l plugin) that could be >> used to setup a 'default scenario' that existing applications could use, >> but that was never enforced, sa

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On Fri, Mar 10, 2017 at 01:54:28PM +0100, Hans Verkuil wrote: > But there was always meant to be a layer (libv4l plugin) that could be > used to setup a 'default scenario' that existing applications could use, > but that was never enforced, sadly. However, there's other painful issues lurking in u

[PATCH 1/2] staging: css2400/sh_css: Remove parentheses from return arguments

The sematic patch used for this is: @@ identifier i; constant c; @@ return - ( \(i\|-i\|i(...)\|c\) - ) ; Signed-off-by: simran singhal Acked-by: Julia Lawall --- .../media/atomisp/pci/atomisp2/css2400/sh_css.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions

[PATCH 0/2] staging: media: Remove parentheses from return arguments

This patch-series removes unnecessary parantheses from return arguments. simran singhal (2): staging: css2400/sh_css: Remove parentheses from return arguments staging: sh_css_firmware: Remove parentheses from return arguments .../media/atomisp/pci/atomisp2/css2400/sh_css.c | 20

[PATCH 2/2] staging: sh_css_firmware: Remove parentheses from return arguments

The sematic patch used for this is: @@ identifier i; constant c; @@ return - ( \(i\|-i\|i(...)\|c\) - ) ; Signed-off-by: simran singhal Acked-by: Julia Lawall --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 04/03/17 14:13, Sakari Ailus wrote: > Hi Russell, > > On Fri, Mar 03, 2017 at 11:06:45PM +, Russell King - ARM Linux wrote: >> On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote: >>> Hi Steve, >>> >>> On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipe

[PATCH] staging: comedi: amplc_pci224: Convert macro GAT_CONFIG to static inline function

Convert macro GAT_CONFIG to static inline function as static inline functions are preferred over macros. This change is possible since the arguments at all call sites have the same type. This was done using Coccinelle: @r@ expression e; @@ - #define GAT_CONFIG(chan, src) e + static inline unsigne

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On Fri, Mar 10, 2017 at 10:31:13AM +, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: > > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > > > > > > > For me those patches are going in the right direction. > > > > > > I still have f

Re: [PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

On 10/03/17 05:52, Steve Longerbeam wrote: > Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or > output device has signaled a new frame is ready before a previous > frame has completed reception or transmission. This usually indicates > a DMA read/write channel is having trouble ga

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 10/03/17 05:52, Steve Longerbeam wrote: > Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > output device has measured an interval between the reception or transmit > completion of two consecutive frames of video that is outside the nominal > frame interval by some toleran

Re: [PATCH v5 22/39] media: Add userspace header file for i.MX

On 10/03/17 05:53, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls for the > i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam I would not export this while the imx driver is

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

On 10/03/17 10:31, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: >> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > >>> >>> For me those patches are going in the right direction. >>> >>> I still have few questions: >>> - since alignmen

Re: [PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 10/03/17 05:52, Steve Longerbeam wrote: > v4l2_pipeline_inherit_controls() will add the v4l2 controls from > all subdev entities in a pipeline to a given video device. > > Signed-off-by: Steve Longerbeam > --- > drivers/media/v4l2-core/v4l2-mc.c | 48 > +++

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

On 10 March 2017 at 11:16, Michael Zoran wrote: > On Fri, 2017-03-10 at 11:11 +, Dave Stevenson wrote: >> On 10 March 2017 at 05:08, Michael Zoran wrote: >> > The code that queries properties on the camera has a check >> > for buffer overruns if the firmware sends too much data. This >> > ch

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

On Fri, 2017-03-10 at 11:11 +, Dave Stevenson wrote: > On 10 March 2017 at 05:08, Michael Zoran wrote: > > The code that queries properties on the camera has a check > > for buffer overruns if the firmware sends too much data.  This > > check is incorrect, and during testing I was seeing stack

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

On 10 March 2017 at 05:08, Michael Zoran wrote: > The code that queries properties on the camera has a check > for buffer overruns if the firmware sends too much data. This > check is incorrect, and during testing I was seeing stack corruption. > > I believe this error can actually happen in norm

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

On Thu, Mar 02, 2017 at 10:15:15AM -0500, Brijesh Singh wrote: > If kernel_maps_pages_in_pgd is called early in boot process to change the kernel_map_pages_in_pgd() > memory attributes then it fails to allocate memory when spliting large > pages. The patch extends the cpa_data to provide the supp

[PATCH v2 2/2] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- changes in v2 - add

[PATCH v2 0/2] staging: speakup: checkpatch guided cleanups

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator drivers/staging/speakup/main.c | 8 drivers/staging/speakup/seriali

[PATCH v2 1/2] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 6d9c9

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also removed

[PATCH 2/2] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- drivers/staging/spea

[PATCH 1/2] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 6d9c9

[PATCH 0/2] staging: speakup: checkpatch guided cleanups

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator drivers/staging/speakup/main.c | 8 drivers/staging/speakup/seriali

[PATCH 4.10 135/167] VME: restore bus_remove function causing incomplete module unload

4.10-stable review patch. If anyone has any objections, please let me know. -- From: Stefano Babic commit 9797484ba83d68f18fe1cbd964b7cd830f78f0f7 upstream. Commit 050c3d52cc7810d9d17b8cd231708609af6876ae ("vme: make core vme support explicitly non-modular") dropped the remove

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On Thu, Mar 09, 2017 at 06:38:18PM -0800, Steve Longerbeam wrote: > On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: > >I'm not sure that statement is entirely accurate. With the IMX219 > >camera, I _could_ (with previous iterations of the iMX capture code) > >stop it streaming, wait a whil

[PATCH] Allows setting bpp from dt

Allows setting bpp from dt Radoslaw Pietrzyk (1): staging: fbtft: Allows bpp to be set from dt drivers/staging/fbtft/fbtft-core.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev

[PATCH] staging: fbtft: Allows bpp to be set from dt

Allows bpp to be set from dt Signed-off-by: Radoslaw Pietrzyk --- drivers/staging/fbtft/fbtft-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 7c8af29..b25288b 100644 --- a/drivers/staging/fbtft/fbtft-core

[PATCH 4.9 122/153] VME: restore bus_remove function causing incomplete module unload

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Stefano Babic commit 9797484ba83d68f18fe1cbd964b7cd830f78f0f7 upstream. Commit 050c3d52cc7810d9d17b8cd231708609af6876ae ("vme: make core vme support explicitly non-modular") dropped the remove

Re: [RFC PATCH 08/12] cma: Store a name in the cma structure

Hi Laura, Thanks for the patch. On 3 March 2017 at 03:14, Laura Abbott wrote: > > Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it > useful to have an explicit name attached to each region. Store the name > in each CMA structure. > > Signed-off-by: Laura Abbott > --- > d