Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-02 Thread Steve Longerbeam
On 03/02/2017 03:48 PM, Steve Longerbeam wrote: On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-02 Thread Steve Longerbeam
On 03/02/2017 03:48 PM, Steve Longerbeam wrote: On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-02 Thread Steve Longerbeam
On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/me

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-02 Thread Steve Longerbeam
On 03/02/2017 07:53 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:15PM -0800, Steve Longerbeam wrote: Add a new FRAME_TIMEOUT event to signal that a video capture or output device has timed out waiting for reception or transmit completion of a video frame. Signed-off-by: St

Re: [PATCH] netvsc: fix use-after-free in netvsc_change_mtu()

2017-03-02 Thread David Miller
From: Dexuan Cui Date: Thu, 2 Mar 2017 13:00:53 + > 'nvdev' is freed in rndis_filter_device_remove -> netvsc_device_remove -> > free_netvsc_device, so we mustn't access it, before it's re-created in > rndis_filter_device_add -> netvsc_device_add. > > Signed-off-by: Dexuan Cui Applied.

[PATCH] staging: rtl8192u: fix spacing around if statements

2017-03-02 Thread Robin Krahl
Corrects the spacing around two if statements to fix these checkpatch.pl errors: ERROR: space required before the open brace '{' ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Robin Krahl --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread Joe Perches
On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: > > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > > > The following Coccinelle script was used to detect this: > > > @r@ > > > expression x; > > > void* e; > > > type T; > > >

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread Joe Perches
On Fri, 2017-03-03 at 03:35 +0530, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 3:29 AM, Joe Perches wrote: > > On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote: > > > On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: > > > > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > >

Re: [Outreachy kernel] Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread Julia Lawall
On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 3:29 AM, Joe Perches wrote: > > On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote: > >> On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: > >> > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > >> > > The follo

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:29 AM, Joe Perches wrote: > On Fri, 2017-03-03 at 03:25 +0530, SIMRAN SINGHAL wrote: >> On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: >> > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: >> > > The following Coccinelle script was used to detect this: >> > >

[PATCH] staging: speakup: Fixed coding style errors and aligned indents

2017-03-02 Thread Tuomo Rinne
Fixed indentation to use tabs and aligned all the fields to same level. Signed-off-by: Tuomo Rinne --- drivers/staging/speakup/speakup_decpc.c | 90 - 1 file changed, 44 insertions(+), 46 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/driver

Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> diff --git a/drivers/staging/rts5208/rtsx_transport.c >> b/drivers/staging/rts5208/rtsx_transport.c >> index 2379901..d745b93 100644 >> --- a/drivers/staging/rts5208/rtsx_transport.c >> +++ b/drivers/staging/rts5208/rtsx_transport.c >> @@ -76

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void >> *pcontext) >> { >> unsigned long irql; >> struct recv_reorder_ctrl *preorder_ctrl = >> - (struct recv_reorder_ctrl *)pcontext; >>

Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer

2017-03-02 Thread Julia Lawall
> diff --git a/drivers/staging/rts5208/rtsx_transport.c > b/drivers/staging/rts5208/rtsx_transport.c > index 2379901..d745b93 100644 > --- a/drivers/staging/rts5208/rtsx_transport.c > +++ b/drivers/staging/rts5208/rtsx_transport.c > @@ -767,7 +767,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip

Re: [Outreachy kernel] [PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread Julia Lawall
> @@ -635,7 +635,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext) > { > unsigned long irql; > struct recv_reorder_ctrl *preorder_ctrl = > - (struct recv_reorder_ctrl *)pcontext; > + pcontext; Coccinelle doesn't a

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches wrote: > On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: >> The following Coccinelle script was used to detect this: >> @r@ >> expression x; >> void* e; >> type T; >> identifier f; >> @@ >> ( >> *((T *)e) >> > >> >> ((T *)x)[...] >> > >> >>

[RFC PATCH 12/12] staging; android: ion: Enumerate all available heaps

2017-03-02 Thread Laura Abbott
Practiaclly speaking, most Ion heaps are either going to be available all the time (system heaps) or found based off of the reserved-memory node. Parse the CMA and reserved-memory nodes to assign the heaps. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Makefile| 2 +- dri

[RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable

2017-03-02 Thread Laura Abbott
Currently, all heaps are compiled in all the time. In switching to a better platform model, let's allow these to be compiled out for good measure. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Kconfig| 32 drivers/staging/android/ion/Makefile | 8 +++--

[RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-02 Thread Laura Abbott
When CMA was first introduced, its primary use was for DMA allocation and the only way to get CMA memory was to call dma_alloc_coherent. This put Ion in an awkward position since there was no device structure readily available and setting one up messed up the coherency model. These days, CMA can b

[RFC PATCH 09/12] cma: Introduce cma_for_each_area

2017-03-02 Thread Laura Abbott
Frameworks (e.g. Ion) may want to iterate over each possible CMA area to allow for enumeration. Introduce a function to allow a callback. Signed-off-by: Laura Abbott --- include/linux/cma.h | 2 ++ mm/cma.c| 14 ++ 2 files changed, 16 insertions(+) diff --git a/include

[RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-02 Thread Laura Abbott
Now that we call dma_map in the dma_buf API callbacks there is no need to use the existing cache APIs. Remove the sync ioctl and the existing bad dma_sync calls. Explicit caching can be handled with the dma_buf sync API. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion-ioctl.c

[RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-03-02 Thread Laura Abbott
Technically, calling dma_buf_map_attachment should return a buffer properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to ensure this happens. As a side effect, this lets Ion buffers take advantage of the dma_buf sync ioctls. Signed-off-by: Laura Abbott --- drivers/staging/android/

[RFC PATCH 08/12] cma: Store a name in the cma structure

2017-03-02 Thread Laura Abbott
Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it useful to have an explicit name attached to each region. Store the name in each CMA structure. Signed-off-by: Laura Abbott --- drivers/base/dma-contiguous.c | 5 +++-- include/linux/cma.h | 4 +++- mm/cma.c

[RFC PATCH 07/12] staging: android: ion: Remove old platform support

2017-03-02 Thread Laura Abbott
Device specific platform support has been haphazard for Ion. There have been several independent attempts and there are still objections to what bindings exist right now. Just remove everything for a fresh start. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Kconfig

[RFC PATCH 05/12] staging: android: ion: Remove page faulting support

2017-03-02 Thread Laura Abbott
The new method of syncing with dma_map means that the page faulting sync implementation is no longer applicable. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 117 -- 1 file changed, 117 deletions(-) diff --git a/drivers/stag

[RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

2017-03-02 Thread Laura Abbott
Ion currently returns a single sg_table on each dma_map call. This is incorrect for later usage. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c

[RFC PATCH 02/12] staging: android: ion: Remove alignment from allocation field

2017-03-02 Thread Laura Abbott
The align field was supposed to be used to specify the alignment of the allocation. Nobody actually does anything with it except to check if the alignment specified is out of bounds. Since this has no effect on the actual allocation, just remove it. Signed-off-by: Laura Abbott --- drivers/stagi

[RFC PATCH 01/12] staging: android: ion: Remove dmap_cnt

2017-03-02 Thread Laura Abbott
The reference counting of dma_map calls was removed. Remove the associated counter field as well. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion_priv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/io

[RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-02 Thread Laura Abbott
Hi, There's been some recent discussions[1] about Ion-like frameworks. There's apparently interest in just keeping Ion since it works reasonablly well. This series does what should be the final clean ups for it to possibly be moved out of staging. This includes the following: - Some general clean

Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread Joe Perches
On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > > > > ((T *)x)[...] > > > > ((T*)x)->f > > > > - (T*) > e > ) NAK. Nice, but you stil

[PATCH 3/3] staging: fbtft: fb_sh1106: use new helper helper fbtft_write_buf_dc

2017-03-02 Thread Heiner Kallweit
Make use of new helper fbtft_write_buf_dc. Signed-off-by: Heiner Kallweit --- drivers/staging/fbtft/fb_sh1106.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/staging/fbtft/fb_sh1106.c b/drivers/staging/fbtft/fb_sh1106.c index d6f79bbd..45999c3c 1

[PATCH 2/3] staging: fbtft: use helper fbtft_write_buf_dc in fbtft-bus.c

2017-03-02 Thread Heiner Kallweit
Make use of new helper fbtft_write_buf_dc. Signed-off-by: Heiner Kallweit --- drivers/staging/fbtft/fbtft-bus.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index ec4504

[PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 2/5] staging: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- drivers/staging/lustre/lustre/mgc/

[PATCH 1/5] staging: nvec: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 1/3] staging: fbtft: add helper fbtft_write_buf_dc

2017-03-02 Thread Heiner Kallweit
Factor out setting DC GPIO and writing buffer content to helper fbtft_write_buf_dc. Signed-off-by: Heiner Kallweit --- drivers/staging/fbtft/fbtft-core.c | 15 +++ drivers/staging/fbtft/fbtft.h | 1 + 2 files changed, 16 insertions(+) diff --git a/drivers/staging/fbtft/fbtft-c

[PATCH 2/2] Fix endiannes error

2017-03-02 Thread Adrien Descamps
sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected restricte

[PATCH 1/2] Fix sparse warnings by using appropriate endian types

2017-03-02 Thread Adrien Descamps
Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Compile tested only. Signed-off-by: Adrien Descamps --- drivers/staging/wlan-ng/hfa384x.h | 58 +-- drivers/s

[PATCH] staging: nvec: Remove unnecessary cast on void pointer

2017-03-02 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/nvec/nvec_kbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Michael Zoran
On Thu, 2017-03-02 at 21:07 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 2. März 2017 um 04:41 > > geschrieben: > > > +static long > > +vchiq_compat_ioctl_dump_phys_mem(struct file *file, > > +  unsigned int cmd, > > +  unsigned long arg

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Stefan Wahren
> Michael Zoran hat am 2. März 2017 um 04:41 geschrieben: > > > This patch adds compatibility wrappers for the ioctls > exposed by vchiq/vc04_services. The compat ioctls are > completely implemented on top of the native ioctls. No > existing lines are modified. > > While the ideal approach w

[PATCH] staging: fbtft: fb_sh1106: use own implementation of write_register

2017-03-02 Thread Heiner Kallweit
The default implementation of write_register keeps DC low for the first byte only. SH1106 requires DC to be low for all bytes of a multi-byte command. To deal with this limitation we currently use a separate call to write_reg for each single command byte what is not really efficient. Therefore ove

[PATCH 7/7] staging: media: Do not use multiple blank lines

2017-03-02 Thread simran singhal
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/

[PATCH 5/7] staging: media: Remove multiple assignments

2017-03-02 Thread simran singhal
Remove multiple assignments by factorizing them. Problem found using checkpatch.pl CHECK: multiple assignments should be avoided Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/med

[PATCH 2/7] staging: media: Add blank line after a declaration

2017-03-02 Thread simran singhal
Add blank line after a declaration. Problem found using checkpatch. This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 7 +++ 1 file changed, 7 inse

[PATCH 6/7] staging: media: Use x instead of x != NULL

2017-03-02 Thread simran singhal
Use x instead of x != NULL . This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/

[PATCH 4/7] staging: media: Remove blank line before '}' and after '{' braces

2017-03-02 Thread simran singhal
Remove unneeded blank lines preceding/following '}' and '{' braces, as pointed out by checkpatch. This patch addresses the following checkpatch checks: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: simran s

[PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-02 Thread simran singhal
This patch removes unnecessary typecast of c90 int constant. WARNING: Unnecessary typecast of c90 int constant Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c

[PATCH 3/7] staging: media: Replace NULL with "!"

2017-03-02 Thread simran singhal
Use ! in comparison tests using "==NULL" rather than moving the "==NULL" to the right side of the test. Addesses multiple instances of the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: simran singhal --- drivers/staging/media/

[PATCH] staging: fbtft: improve a syslog message in fbtft_register_framebuffer

2017-03-02 Thread Heiner Kallweit
There are drivers like fb_sh1106 which allocate a txbuf less than 1 KiB. In this case the message would include "0 KiB buffer memory" what doesn't make sense and in general I doubt that there is any benefit in informing the user about allocation of a very small buffer. Therefore omit this message

Re: [PATCH v3] staging: iio: adis16201: Move header file content to source file

2017-03-02 Thread Jonathan Cameron
On 28/02/17 19:49, simran singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: simran singhal Hi Simran, Good follow up but as I'd already applied it I made the mods directly to the original patch. Ple

Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

2017-03-02 Thread Brijesh Singh
Hi Mark, On 03/02/2017 11:39 AM, Mark Rutland wrote: On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: The CCP device is part of the AMD Secure Processor. In order to expand the usage of the AMD Secure Processor, create a framework that allows functional components of the AMD Secur

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Michael Zoran
On Thu, 2017-03-02 at 10:45 -0800, Eric Anholt wrote: > Michael Zoran writes: > > >   > > +#if defined(CONFIG_COMPAT) > > +static long > > +vchiq_compat_ioctl_queue_message(struct file *file, > > +  unsigned int cmd, > > +  unsigned long arg) >

Re: [PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-02 Thread Jonathan Cameron
On 01/03/17 18:37, Arushi Singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: Arushi Singhal Just noticed that I have another series doing this change waiting for review so probably going to have alrea

Re: [PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-02 Thread Jonathan Cameron
On 01/03/17 18:37, Arushi Singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/iio/frequency/ad9832.c | 100 +- > drivers/staging/iio/freq

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

2017-03-02 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/s

[PATCH 3/4] staging: speakup: identation should use tabs

2017-03-02 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index b3b3

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

2017-03-02 Thread Arushi Singhal
Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index a12ec

[PATCH 0/4] Fix multiple checkpatch issues

2017-03-02 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator staging: speakup: identation should use tabs staging: speakup: Alignment should match

[PATCH 2/4] staging: speakup: spaces preferred around operator

2017-03-02 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- drivers/staging/spea

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Eric Anholt
Michael Zoran writes: > This patch adds compatibility wrappers for the ioctls > exposed by vchiq/vc04_services. The compat ioctls are > completely implemented on top of the native ioctls. No > existing lines are modified. > > While the ideal approach would be to cleanup the existing > code, thi

Re: [Outreachy kernel] [PATCH v2] staging: speakup: Comparison to NULL could be written

2017-03-02 Thread Alison Schofield
On Thu, Mar 02, 2017 at 08:37:21AM -0800, Alison Schofield wrote: > On Thu, Mar 02, 2017 at 02:13:02PM +0530, Arushi Singhal wrote: > > Fixed coding style for null comparisons in speakup driver to be more > > consistant with the rest of the kernel coding style. > > > > Signed-off-by: Arushi Singha

Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

2017-03-02 Thread Mark Rutland
On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: > The CCP device is part of the AMD Secure Processor. In order to expand the > usage of the AMD Secure Processor, create a framework that allows functional > components of the AMD Secure Processor to be initialized and handled > appropr

Re: [Outreachy kernel] [PATCH 1/6] staging: wlan-ng: Fix sparse warning of restricted __le16

2017-03-02 Thread Alison Schofield
On Thu, Mar 02, 2017 at 12:14:40PM +0100, Julia Lawall wrote: > > > On Thu, 2 Mar 2017, SIMRAN SINGHAL wrote: > > > On Thu, Mar 2, 2017 at 3:20 PM, Julia Lawall wrote: > > > > > > > > > On Thu, 2 Mar 2017, Julia Lawall wrote: > > > > > >> > > >> > > >> On Thu, 2 Mar 2017, simran singhal wrote:

Re: [PATCH] netvsc: fix use-after-free in netvsc_change_mtu()

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 13:00:53 + Dexuan Cui wrote: > 'nvdev' is freed in rndis_filter_device_remove -> netvsc_device_remove -> > free_netvsc_device, so we mustn't access it, before it's re-created in > rndis_filter_device_add -> netvsc_device_add. > > Signed-off-by: Dexuan Cui > Cc: "K. Y. Sri

[PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style

2017-03-02 Thread Georgios Emmanouil
Added blank line after function and modified comment style. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/wilc_spi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index 4f3892

[PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error

2017-03-02 Thread Georgios Emmanouil
Fixed spelling error. 'unkmown' to 'unknown'. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/wilc_spi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index b48cb1c8..4f38922 1

[PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis

2017-03-02 Thread Georgios Emmanouil
Fixed alignment to match parenthesis. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/wilc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index 6bd4047..b48cb1c8 100644 --- a/driv

[PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style

2017-03-02 Thread Georgios Emmanouil
Fixed comment style to the preferred kernel comment style. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/wilc_spi.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c index

Re: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 10:47:49 +0100 Vitaly Kuznetsov wrote: > Waiting for release_event in all three drivers introduced issues on release > as on_reset() hook is not always called. E.g. if the device was never > opened we will never get the completion. > > Move the waiting code to hvutil_transpor

Re: [Outreachy kernel] [PATCH 1/4] staging: speakup: Placed Logical on the previous line

2017-03-02 Thread Alison Schofield
On Thu, Mar 02, 2017 at 09:05:57PM +0530, Arushi Singhal wrote: > Placed Logical continuations on the previous line as reported by > checkpatch.pl. > > Signed-off-by: Arushi Singhal Hi Arushi, I'm not seeing the patch cover letter for this one. That would be your [PATCH 0/4] and would come firs

[PATCH] Staging:wilc1000:wilc_sdio: Modified comment style to preferred kernel comment style

2017-03-02 Thread Georgios Emmanouil
Modified comment style to preferred kernel comment style. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/wilc_sdio.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wilc1000/wilc_sdio.c inde

Re: [Outreachy kernel] [PATCH v2] staging: speakup: Comparison to NULL could be written

2017-03-02 Thread Alison Schofield
On Thu, Mar 02, 2017 at 02:13:02PM +0530, Arushi Singhal wrote: > Fixed coding style for null comparisons in speakup driver to be more > consistant with the rest of the kernel coding style. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > - fixed coding style error and upto the coding

[PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-02 Thread Georgios Emmanouil
Modified the 'if-else' statement to make it more readable. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/linux_wlan.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c in

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-02 Thread Sakari Ailus
Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: > v4l2_pipeline_inherit_controls() will add the v4l2 controls from > all subdev entities in a pipeline to a given video device. > > Signed-off-by: Steve Longerbeam > --- > drivers/media/v4l2-core/v4l2-mc.c | 48 > +

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-02 Thread Sakari Ailus
Hi Steve, On Wed, Feb 15, 2017 at 06:19:15PM -0800, Steve Longerbeam wrote: > Add a new FRAME_TIMEOUT event to signal that a video capture or > output device has timed out waiting for reception or transmit > completion of a video frame. > > Signed-off-by: Steve Longerbeam > --- > Documentation/

[RFC PATCH v2 15/32] x86: Add support for changing memory encryption attribute in early boot

2017-03-02 Thread Brijesh Singh
Some KVM-specific custom MSRs shares the guest physical address with hypervisor. When SEV is active, the shared physical address must be mapped with encryption attribute cleared so that both hypervsior and guest can access the data. Add APIs to change memory encryption attribute in early boot code

[RFC PATCH v2 23/32] kvm: introduce KVM_MEMORY_ENCRYPT_OP ioctl

2017-03-02 Thread Brijesh Singh
If hardware supports encrypting then KVM_MEMORY_ENCRYPT_OP ioctl can be used by qemu to issue platform specific memory encryption commands. Signed-off-by: Brijesh Singh --- arch/x86/include/asm/kvm_host.h |2 ++ arch/x86/kvm/x86.c | 12 include/uapi/linux/kvm.h

[RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

2017-03-02 Thread Brijesh Singh
The CCP device is part of the AMD Secure Processor. In order to expand the usage of the AMD Secure Processor, create a framework that allows functional components of the AMD Secure Processor to be initialized and handled appropriately. Signed-off-by: Brijesh Singh Signed-off-by: Tom Lendacky ---

[PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement

2017-03-02 Thread Georgios Emmanouil
Removed unnecessary 'if' statement and integrated the condition to the previous 'if' statement. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/host_interface.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface

[PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis

2017-03-02 Thread Georgios Emmanouil
Fixed alignment to match open parenthesis. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 090fd43..bbe

[RFC PATCH v2 16/32] x86: kvm: Provide support to create Guest and HV shared per-CPU variables

2017-03-02 Thread Brijesh Singh
Some KVM specific MSR's (steal-time, asyncpf, avic_eio) allocates per-CPU variable at compile time and share its physical address with hypervisor. It presents a challege when SEV is active in guest OS. When SEV is active, guest memory is encrypted with guest key and hypervisor will no longer able t

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

2017-03-02 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/s

[PATCH 3/4] staging: speakup: identation should use tabs

2017-03-02 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/staging/speakup/speakup_dtlk.h index b3b3

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

2017-03-02 Thread Arushi Singhal
Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index a12ec

[PATCH 2/4] staging: speakup: spaces preferred around operator

2017-03-02 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- drivers/staging/spea

[PATCH 1/3] Staging:wilc1000:host_interface: Removed unnecessary blank line

2017-03-02 Thread Georgios Emmanouil
Removed unnecessary blank line. Signed-off-by: Georgios Emmanouil --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index c307cce..090fd43 100644 --- a/drivers/st

[RFC PATCH v2 03/32] KVM: SVM: prepare for new bit definition in nested_ctl

2017-03-02 Thread Brijesh Singh
From: Tom Lendacky Currently the nested_ctl variable in the vmcb_control_area structure is used to indicate nested paging support. The nested paging support field is actually defined as bit 0 of the field. In order to support a new feature flag the usage of the nested_ctl and nested paging suppor

[RFC PATCH v2 21/32] crypto: ccp: Add Secure Encrypted Virtualization (SEV) interface support

2017-03-02 Thread Brijesh Singh
The Secure Encrypted Virtualization (SEV) interface allows the memory contents of a virtual machine (VM) to be transparently encrypted with a key unique to the guest. The interface provides: - /dev/sev device and ioctl (SEV_ISSUE_CMD) to execute the platform provisioning commands from the us

[RFC PATCH v2 22/32] kvm: svm: prepare to reserve asid for SEV guest

2017-03-02 Thread Brijesh Singh
In current implementation, asid allocation starts from 1, this patch adds a min_asid variable in svm_vcpu structure to allow starting asid from something other than 1. Signed-off-by: Brijesh Singh Reviewed-by: Paolo Bonzini --- arch/x86/kvm/svm.c |4 +++- 1 file changed, 3 insertions(+), 1

[RFC PATCH v2 28/32] kvm: svm: Add support for SEV GUEST_STATUS command

2017-03-02 Thread Brijesh Singh
The command is used for querying the SEV guest status. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 37 + 1 file changed, 37 insertions(+) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index c108064..977aa22 100644 --- a/arch/x86/kvm/svm.c +

[RFC PATCH v2 24/32] kvm: x86: prepare for SEV guest management API support

2017-03-02 Thread Brijesh Singh
The patch adds initial support required to integrate Secure Encrypted Virtualization (SEV) feature. ASID management: - Reserve asid range for SEV guest, SEV asid range is obtained through CPUID Fn8000_001f[ECX]. A non-SEV guest can use any asid outside the SEV asid range. - SEV guest must

[RFC PATCH v2 20/32] crypto: ccp: Add Platform Security Processor (PSP) interface support

2017-03-02 Thread Brijesh Singh
AMD Platform Security Processor (PSP) is a dedicated processor that provides the support for encrypting the guest memory in a Secure Encrypted Virtualiztion (SEV) mode, along with software-based Tursted Executation Environment (TEE) to enable the third-party tursted applications. Signed-off-by: Br

[RFC PATCH v2 26/32] kvm: svm: Add support for SEV LAUNCH_UPDATE_DATA command

2017-03-02 Thread Brijesh Singh
The command is used for encrypting the guest memory region using the VM encryption key (VEK) created from LAUNCH_START. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 150 1 file changed, 150 insertions(+) diff --git a/arch/x86/kvm/sv

[RFC PATCH v2 18/32] kvm: svm: Use the hardware provided GPA instead of page walk

2017-03-02 Thread Brijesh Singh
From: Tom Lendacky When a guest causes a NPF which requires emulation, KVM sometimes walks the guest page tables to translate the GVA to a GPA. This is unnecessary most of the time on AMD hardware since the hardware provides the GPA in EXITINFO2. The only exception cases involve string operation

[RFC PATCH v2 17/32] x86: kvmclock: Clear encryption attribute when SEV is active

2017-03-02 Thread Brijesh Singh
The guest physical memory area holding the struct pvclock_wall_clock and struct pvclock_vcpu_time_info are shared with the hypervisor. Hypervisor periodically updates the contents of the memory. When SEV is active we must clear the encryption attributes of the shared memory pages so that both hyper

[RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-02 Thread Brijesh Singh
If kernel_maps_pages_in_pgd is called early in boot process to change the memory attributes then it fails to allocate memory when spliting large pages. The patch extends the cpa_data to provide the support to use memblock_alloc when slab allocator is not available. The feature will be used in Secu

[RFC PATCH v2 12/32] x86: Add early boot support when running with SEV active

2017-03-02 Thread Brijesh Singh
From: Tom Lendacky Early in the boot process, add checks to determine if the kernel is running with Secure Encrypted Virtualization (SEV) active by issuing a CPUID instruction. During early compressed kernel booting, if SEV is active the pagetables are updated so that data is accessed and decomp

  1   2   >