Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
Version #1 Introduced lines longer then 80
Version #2 Lacked spaces at either end of comment line
drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 191 -
1 file changed, 107 insertions
This patch adds compatibility wrappers for the ioctls
exposed by vchiq/vc04_services. The compat ioctls are
completely implemented on top of the native ioctls. No
existing lines are modified.
While the ideal approach would be to cleanup the existing
code, this path is simplier and easier to revi
Change the audio's dependency on BCM2835_VCHIQ to a select
since audio support is typically more important to people
then base VCHIQ(which they may not even know what it's for).
Also, with a dependency the audio support would not be
visiable until VCHIQ is selected first, and that may
not be what
Create a new memuconfig for Broadcom VideoCore services
since VideoCore is a general term used by Broadcom for a
large family of products that includes more then the BCM2835.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/Kconfig | 15 +++
1 file changed, 11 insertion
Change the camera's dependency on BCM2835_VCHIQ to a select
since camera support is typically more important to people
then base VCHIQ(which they may not even know what it's for).
Also, with a dependency the camera support would not be
visiable until VCHIQ is selected first, and that may
not be wh
The current toplevel menu item for vc04-services has this description:
Kernel to VideoCore communication interface for the
BCM2835 family of products.
Defaults to Y when the Broadcom Videocore services
are included in the build, N otherwise.
1. This isn't quite how things work today. Videocore is
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/i18n.c | 2 +-
drivers/staging/speakup/kobjects.c | 38 +++---
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/d
Hi Arnd,
I submitted a change which is in Linux-next now that makes the whole
CACHE_LINE_SIZE macro meaningless. It now always reads the size from
the DT and errors out with -ENODEV if the property is missing.
I was going to submit a change to delete the macro completely, just
never got to it.
This adds /dev/softsynthu, along /dev/softsynth, which emits output in
UTF-8 encoding, thus allowing to support 16bit characters. Most of the
code is shared, only the read function has to behave differently in
latin1 and in unicode mode. Since Linux only supports 16bit characters,
we can just har
Hello,
This patch series adds 16bit unicode support to speakup, through three
patches:
- extend synth buffer to 16bit unicode characters
- convert screen reading to 16bit characters
- add unicode variant of /dev/softsynth
Samuel
--
Samuel
hm. I've lost a machine.. literally _lost_. it respond
This adds 16bit character support to most of the screen reading by
extending characters to u16 throughout the code.
Non-latin1 characters are assumed to be alphabetic type for now.
non-latin1 vt_notifier_call-provided characters are not ignored any
more, and the 16bit character returned by get_ch
This extends the synth buffer slots to 16bit, so as to hold 16bit
unicode characters.
synth_buffer_getc and synth_buffer_peek now return 16bit characters.
Speech synthesizers which do not support characters beyond latin1 can
use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1
chara
fixed the following sparse warning by adding proper cast:
drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning:
incorrect type in argument 2 (different address spaces)
drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74:expected char
const [noderef] *
drivers/staging
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.
Signed-off-by: Dmitr
After several hours of debugging this obviously bogus but elaborate
gcc-7.0.1 warning,
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c: In function
'vchiq_complete_bulk':
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:603:4:
error: argument 2 null where non
While debugging another problem I noticed that g_cache_line_size gets set
to sizeof(CACHE_LINE_SIZE), which is sizeof(int) or 4, while presumably
CACHE_LINE_SIZE (e.g. 32) was meant.
This initializes it the way it was meant.
Signed-off-by: Arnd Bergmann
---
drivers/staging/vc04_services/interfa
On Wed, Mar 01, 2017 at 10:58:59PM +0100, Daniel Glöckner wrote:
On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automat
On Wed, Mar 01, 2017 at 06:30:17PM +0800, kbuild test robot wrote:
> drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner
> here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no
Fix coding style issue.
Signed-off-by: Maciej Billewicz
---
drivers/staging/bcm2835-audio/bcm2835-pcm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 16127e0..18e2f40 100644
-
On Wed, 2017-03-01 at 20:58 +0100, Julia Lawall wrote:
>
> On Thu, 2 Mar 2017, Arushi Singhal wrote:
>
> > Fixed coding style for null comparisons in speakup driver to be more
> > consistant with the rest of the kernel coding style.
And Arushi, please use checkpatch on your proposed
patches befo
On Thu, 2 Mar 2017, Arushi Singhal wrote:
> Fixed coding style for null comparisons in speakup driver to be more
> consistant with the rest of the kernel coding style.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> drivers/staging/speakup/kobjects.c |
On 03/01/2017 11:21 AM, Arushi Singhal wrote:
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/kobjects.c | 2 +-
driv
Indentation should always use tabs and never spaces.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index 1a3e34880ac1..11f1418b4006 100644
--- a/
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c | 2 +-
drivers/staging/speakup/kobjects.c | 2 +-
drivers/staging/speakup/main.c | 38
> Michael Zoran hat am 1. März 2017 um 17:39 geschrieben:
>
>
> On Wed, 2017-03-01 at 16:51 +0300, Dan Carpenter wrote:
> > On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote:
> > >
> > > > Michael Zoran hat am 28. Februar 2017 um
> > > > 19:49 geschrieben:
> > > >
> > > >
> > >
The contents of the header file are used only by this single
source file. Move content into .c and remove .h.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/frequency/ad9832.c | 100 +-
drivers/staging/iio/frequency/ad9832.h | 128 -
New variable is added to make the code more readable.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/XGI_main_26.c | 29 ++---
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.
On Wed, 2017-03-01 at 16:51 +0300, Dan Carpenter wrote:
> On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote:
> >
> > > Michael Zoran hat am 28. Februar 2017 um
> > > 19:49 geschrieben:
> > >
> > >
> > > Change the audio's dependency on BCM2835_VCHIQ to a select.
> > >
> > > Signed-
> From: k...@exchange.microsoft.com [mailto:k...@exchange.microsoft.com]
> Sent: Tuesday, February 28, 2017 07:18
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> ...
> From: Dexuan Cui
>
> If the daemon is NOT running at all, when we disable the util device from
> Hyper-V Manage
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
(c)
> >>> > > int (*on_msg)(void *, int); /* callback on new user
> >>> > > message */
> >>> >
> >>> > I think we can get away without introducing this new flag, e.g. if we
> >>> > replace release_event with an atomic which will hol
On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote:
>
> > Michael Zoran hat am 28. Februar 2017 um 19:49
> > geschrieben:
> >
> >
> > Change the audio's dependency on BCM2835_VCHIQ to a select.
> >
> > Signed-off-by: Michael Zoran
> > ---
> > drivers/staging/vc04_services/bcm2835
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 628b2b91d50c74e2475a11a0db5978d9a36d2026
commit: ab3287407598cb395309b6ec82333037d761130c [203/209] staging:
vc04_services: bcm2835-camera: Simplify NULL comparisons
config: arm-allmodconfig (attach
Remove unnecessary whiteshpaces in rtl_wc.
Problems found by checkpatch.pl.
Signed-off-by: Sumantro Mukherjee
---
Changes since v1:
-Add reason of change
-Add version number to patch
Changes since v2:
-update from name and signed off name
Chnages since v3:
-modifi
On 01-03-17, 02:46, Jonathan Bowie wrote:
> Fixed incosistent spacing around arithmetic operator.
>
> Signed-off-by: Jonathan Bowie
> ---
> v2
> -fixed subject added changelog
> v3
> -CC:ed linux-next incorrectly, added proper summary
> v4
> -CC:ed correct mailing list, moved changelog t
Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved as it's often nicer to read if
&(foo[0]) is converted to foo like:
memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bs
On Wed, Mar 01, 2017 at 02:46:30AM -0800, Jonathan Bowie wrote:
> Fixed incosistent spacing around arithmetic operator.
>
> Signed-off-by: Jonathan Bowie
> ---
> v2
> -fixed subject added changelog
> v3
> -CC:ed linux-next incorrectly, added proper summary
> v4
> -CC:ed correct mailing l
Fixed incosistent spacing around arithmetic operator.
Signed-off-by: Jonathan Bowie
---
v2
-fixed subject added changelog
v3
-CC:ed linux-next incorrectly, added proper summary
v4
-CC:ed correct mailing list, moved changelog to summary body
v5
-correctly placed changelog
drivers/s
On Wed, Mar 01, 2017 at 02:30:02AM -0800, Jonathan Bowie wrote:
> Fixed incosistent spacing around arithmetic operator.
>
> v2
> -fixed subject, added changelog
> v3
> -CC:ed linux-next incorrectly, added proper summary
> v4
> -CC:ed staging mailing list, moved changelog to summary body
As I ment
On Wednesday 01 March 2017 03:23 PM, Sumantro wrote:
Remove unnecessary whitespaces in rtl_wc.
Problem found by checkpatch.pl.
Signed-off-by: Sumantro
You went back to the same state again. :(
Your from and signed-off-by should have this format:
'firstname lastname '
---
Changes since v
drivers/staging/media/atomisp/i2c/gc0310.c:1470:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
gc0310.c |
drivers/staging/media/atomisp/i2c/ov2680.c:1535:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
ov2680.c |
drivers/staging/media/atomisp/i2c/ap1302.c:1250:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
ap1302.c |
drivers/staging/media/atomisp/i2c/imx/imx.c:2486:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
imx.c |1
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c:465:2-3: Unneeded
semicolon
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_v4l2.c:511:2-3: Unneeded
semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Alan Cox
Signed-off-by: Fenggu
drivers/staging/media/atomisp/i2c/ov2722.c:1352:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
ov2722.c |
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_ioctl.c:560:5-8: Unneeded
variable: "ret". Return "0" on line 577
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
Please take the pat
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 628b2b91d50c74e2475a11a0db5978d9a36d2026
commit: 628b2b91d50c74e2475a11a0db5978d9a36d2026 [209/209] staging/atomisp: Add
support for the Intel IPU v2
config: i386-allmodconfig (attached as .config)
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_subdev.c:161:5-8: Unneeded
variable: "ret". Return "0" on line 163
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
Please take the pa
drivers/staging/media/atomisp/i2c/mt9m114.c:1946:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
mt9m114.c |
drivers/staging/media/atomisp/pci/atomisp2/./atomisp_compat_css20.c:551:3-4:
Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
atomisp_compat_css20.c |2 +-
1 file changed, 1 insertion(+), 1
drivers/staging/media/atomisp/i2c/imx/../ov8858.c:2199:3-8: No need to set
.owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
ov8858
drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c:248:3-8: No need
to set .owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
drivers/staging/media/atomisp/i2c/gc2235.c:1208:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
gc2235.c |
drivers/staging/media/atomisp/i2c/lm3554.c:986:3-8: No need to set .owner here.
The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
lm3554.c |
drivers/staging/media/atomisp/i2c/ov5693/ov5693.c:2066:3-8: No need to set
.owner here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
ov5693
Fixed incosistent spacing around arithmetic operator.
v2
-fixed subject, added changelog
v3
-CC:ed linux-next incorrectly, added proper summary
v4
-CC:ed staging mailing list, moved changelog to summary body
Signed-off-by: Jonathan Bowie
---
drivers/staging/greybus/tools/loopback_test.c | 2 +-
In both of the cited files (only one is shown), buffer is allocated using
devm_kzalloc, so the kfree is not appropriate.
julia
-- Forwarded message --
Date: Wed, 1 Mar 2017 18:12:08 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [staging:staging-testin
Remove unnecessary whitespaces in rtl_wc.
Problem found by checkpatch.pl.
Signed-off-by: Sumantro
---
Changes since v1:
-Add reason of change
` -Add version number to patch
-Add full legal name
Changes since v2:
-update from name and signed off name
---
drivers/st
* Arnd Bergmann wrote:
> This new 32-bit warning just showed up:
>
> arch/x86/hyperv/hv_init.c: In function 'hyperv_init':
> arch/x86/hyperv/hv_init.c:167:1: error: label 'register_msr_cs' defined but
> not used [-Werror=unused-label]
>
> The easiest solution is to move the label up into the
On Wed, Mar 01, 2017 at 02:16:38AM +0530, Sumantro wrote:
> Remove unncessary whitespaces in rtl_wc.c.
>
> Problem found by checkpatch.pl.
>
> Signed-off-by: Sumantro Mukherjee
Your "From:" name doesn't match your "Signed-off-by:" name :(
___
devel ma
60 matches
Mail list logo
