Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-24 Thread Greg KH
On Fri, Feb 24, 2017 at 12:10:21PM -0800, SIMRAN SINGHAL wrote: > > > On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote: > > On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote: > > Replaces left shift operation (1 << d) by BIT(x) macro. > > > > Fix th

Re: [PATCH] staging: fsl-mc: fix coding style warning

2017-02-24 Thread Greg KH
On Fri, Feb 24, 2017 at 08:24:42PM +0200, Lucian Zala wrote: > Hi Greg, > > I am a little bit confused regarding your reply, it seems > that the patch applied afterall, or? > > http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/fsl-mc?h=staging-testing&id=3bee20

Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-24 Thread Greg KH
On Sat, Feb 25, 2017 at 04:18:27AM +0530, SIMRAN SINGHAL wrote: > On Fri, Feb 24, 2017 at 10:47 PM, Greg KH wrote: > > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote: > >> Extra parentheses were causing checkpatch issues > >> and were removed. > >> > >> Signed-off-by: simran singha

Re: [Outreachy kernel] [PATCH v4 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Rename struct tstrRSSI to rssi_history_buffer for clarity > and to remove camel casing. > > Signed-off-by: Tahia Khan Acked-by: Julia Lawall > --- > drivers/staging/wilc1000/coreconfigurator.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

2017-02-24 Thread Julia Lawall
On Sat, 25 Feb 2017, Arushi Singhal wrote: > > > On Fri, Feb 24, 2017 at 10:18 PM, Julia Lawall wrote: > > > On Fri, 24 Feb 2017, Arushi Singhal wrote: > > > > > > > On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman > > wrote: > >       On Wed, Feb 22, 20

Re: [Outreachy kernel] [PATCH] staging: ks7010: codes in the comments are removed

2017-02-24 Thread Julia Lawall
Remember to use the imperative and to make your subject lines as short as possible. Here the subject line could be "remove code in comments". julia On Sat, 25 Feb 2017, Arushi Singhal wrote: > Commenting Code Is a Bad Idea. > Comments are their to explain the code and how the code achieves its

Re: [Outreachy kernel] [PATCH v2] staging: xgifb: correct the multiple line dereference

2017-02-24 Thread Julia Lawall
On Sat, 25 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > And If there is boolean operator then it is fixed by Splitting line at > boolean operator.This is a coding style error. There is strange spacing and capitalization

Re: [PATCH v2] staging: xgifb: correct the multiple line dereference

2017-02-24 Thread Joe Perches
On Sat, 2017-02-25 at 05:11 +0530, Arushi Singhal wrote: > Error was reported by checkpatch.pl as > WARNING: Avoid multiple line dereference... > And If there is boolean operator then it is fixed by Splitting line at > boolean operator.This is a coding style error. > The changes are made such that

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Dan Carpenter
On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote: > > > Dan Carpenter hat am 24. Februar 2017 um 20:57 > > geschrieben: > > > > > > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > > > Hi Christophe, > > > > > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: >

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-24 Thread Oleg Drokin
On Feb 24, 2017, at 11:59 AM, Greg Kroah-Hartman wrote: > On Sat, Feb 18, 2017 at 04:47:14PM -0500, James Simmons wrote: >> From: Alex Zhuravlev >> >> on small filesystems plain log can grow dramatically. especially >> given large record sizes produced by DNE and extended chunksize. >> I saw >5

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-24 Thread Oleg Drokin
On Feb 24, 2017, at 11:59 AM, Greg Kroah-Hartman wrote: > On Sat, Feb 18, 2017 at 04:47:14PM -0500, James Simmons wrote: >> From: Alex Zhuravlev >> >> on small filesystems plain log can grow dramatically. especially >> given large record sizes produced by DNE and extended chunksize. >> I saw >5

Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-24 Thread Joe Perches
On Sat, 2017-02-25 at 04:18 +0530, SIMRAN SINGHAL wrote: > On Fri, Feb 24, 2017 at 10:47 PM, Greg KH wrote: > > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > > > > > > Signed-off-by: simran singhal

[PATCH v2] staging: xgifb: correct the multiple line dereference

2017-02-24 Thread Arushi Singhal
Error was reported by checkpatch.pl as WARNING: Avoid multiple line dereference... And If there is boolean operator then it is fixed by Splitting line at boolean operator.This is a coding style error. The changes are made such that the other errors does not generate beacause of this change like lin

[PATCH] staging: ks7010: codes in the comments are removed

2017-02-24 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in thos patch codes in the comments are removed. Signed-off-by: Arushi Singhal -

Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-24 Thread SIMRAN SINGHAL
On Fri, Feb 24, 2017 at 10:47 PM, Greg KH wrote: > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote: >> Extra parentheses were causing checkpatch issues >> and were removed. >> >> Signed-off-by: simran singhal >> --- >> >> v2: >>-Removed parentheses around argument of cast >>

[PATCH v4 3/3] staging: wilc1000: Rename network_info member str_rssi to rssi_history

2017-02-24 Thread Tahia Khan
Change name of str_rssi to rssi_history within the network_info struct for clarity. Signed-off-by: Tahia Khan Acked-by: Julia Lawall --- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--- 2 files changed, 8 insertio

[PATCH v4 2/3] staging: wilc1000: Rename tstrRSSI members and change type of u8Full to bool

2017-02-24 Thread Tahia Khan
Remove Hungarian notation and camel casing from all tstrRSSI members' names. Additionally, change type of u8Full to bool since it only takes values 1 or 0. Signed-off-by: Tahia Khan Acked-by: Julia Lawall --- drivers/staging/wilc1000/coreconfigurator.h | 6 +++--- drivers/staging/wilc1

[PATCH v4 0/3] staging: wilc1000: multiple coding style changes to struct tstrRSSI

2017-02-24 Thread Tahia Khan
Multiple coding style changes to struct tstrRSSI. Initially reported by checkpath.pl: Avoid CamelCase: Avoid CamelCase: Avoid CamelCase: Changes since v3: Reformatting commit messages, as requested by Julia Lawall Tahia Khan (3): staging: wilc1000: Rename struct tstrRSSI to rssi_h

[PATCH v4 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-24 Thread Tahia Khan
Rename struct tstrRSSI to rssi_history_buffer for clarity and to remove camel casing. Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/

[Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject

2017-02-24 Thread Long Li
A PCI_EJECT message can arrive at the same time we are calling pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message or in create_root_hv_pci_bus(), in this case we could potentailly modify the bus from multiple places. Properly lock the bus access. Thanks Dexuan Cui f

[Resend PATCH 1/2 v3] pci-hyperv: properly handle pci bus remove

2017-02-24 Thread Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is already removed before the call, so we don't need to rescan the bus in the workqueue scheduled from hv_pci_devices_present. By introducing s

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
> Dan Carpenter hat am 24. Februar 2017 um 20:57 > geschrieben: > > > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > > Hi Christophe, > > > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > > >If 'kzalloc()' fails, we should release resources allocated so far, just as >

Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, SIMRAN SINGHAL wrote: > > > On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote: > On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote: > > Replaces left shift operation (1 << d) by BIT(x) macro. > > > > Fix the checkpatch.pl

Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

2017-02-24 Thread Pavel Machek
Hi! > > Plus you might want to describe which port correspond to which gpio > > state/bitfield values... > > > > > +struct vidsw { > > > > I knew it: it is secretely a switch! :-). > > This driver started as a two-input gpio controlled bus switch. > I changed the name when adding support for bi

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Dan Carpenter
On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > Hi Christophe, > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > >If 'kzalloc()' fails, we should release resources allocated so far, just as > >done in all other cases in this function. > > > >Signed-off-by: Christophe JAILLE

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-24 Thread Jeff King
On Fri, Feb 24, 2017 at 12:03:45PM +0100, Geert Uytterhoeven wrote: > > The problem isn't on the applying end, but rather on the generating end. > > The From header in the attached mbox is: > > > > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= > > > > Slightly related,

Re: [PATCH] staging: fsl-mc: fix coding style warning

2017-02-24 Thread Lucian Zala
Hi Greg, I am a little bit confused regarding your reply, it seems that the patch applied afterall, or? http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/fsl-mc?h=staging-testing&id=3bee20f39e4df8d65e8d34ab9b3ab92e5acc Have I messed something in it? BR, L

[PATCH v2] staging: bcm2835-camera: Fix a memory leak in error handling path in 'bm2835_mmal_init()'

2017-02-24 Thread Christophe JAILLET
If 'kzalloc()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- Not sure that the error handling path is correct. Is 'gdev[0]' freed? Should it be? v2: Rename patch to include '-camera' in the subject --

Re: [PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning

2017-02-24 Thread Greg KH
On Fri, Feb 24, 2017 at 08:55:14PM +0530, Manoj Sawai wrote: > Fixed a checkpatch.pl about coding style in comments. > '*' missing on subsequent lines. > > Signed-off-by: Manoj Sawai > --- > drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This

Re: [PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk

2017-02-24 Thread Greg KH
On Fri, Feb 17, 2017 at 06:48:46PM +0900, Chetan Sethi wrote: > This is 04th patch to ks_wlan.h fixing coding style issue of using > pr_notice instead of printk, warning as issued by checkpatch.pl > > Signed-off-by: Chetan Sethi > --- > v2: > - split multiple changes across different patches > v

Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.

2017-02-24 Thread Greg KH
On Thu, Feb 23, 2017 at 10:15:55AM -0800, Joe Perches wrote: > On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote: > > Fixed checkpath.pl erros "space prohibited after that open/close > > parenthesis" in vchiq_version.c file. > > > > Signed-off-by: Yamanappagouda Patil > > --- > > ..

Re: [PATCH] remove unnecessary initial allocation of vc

2017-02-24 Thread Greg KH
On Tue, Feb 21, 2017 at 07:33:32PM +0530, Pranay Kr. Srivastava wrote: > This patch removes the unnecessary allocation of > current foreground vc during initialization. > > Also change the prototype of speakup_allocate to take > extra argument of gfp_* flags. Thus not requiring > GFP_ATOMIC during

Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 12:50:26PM +0530, Pranay Kr. Srivastava wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > > Signed-off-by:

Re: [PATCH 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk

2017-02-24 Thread Greg KH
On Fri, Feb 17, 2017 at 12:09:04PM +0900, Chetan Sethi wrote: > This is 04th patch to ks_wlan.h fixing coding style issue of using > pr_notice instead of printk, warning as issued by checkpatch.pl > > Signed-off-by: Chetan Sethi > --- > drivers/staging/ks7010/ks_wlan.h | 2 +- > 1 file changed,

Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-24 Thread Greg KH
On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote: > Extra parentheses were causing checkpatch issues > and were removed. > > Signed-off-by: simran singhal > --- > > v2: >-Removed parentheses around argument of cast >-Removed cast I can't keep track of random patches in t

Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-24 Thread Greg KH
On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote: > Replaces left shift operation (1 << d) by BIT(x) macro. > > Fix the checkpatch.pl issue: > CHECK: Prefer using the BIT macro replacing > > Signed-off-by: simran singhal > --- > > V2: >-modified patch message. > > drivers/

Re: [PATCHv2] Checkpatch fixes for staging/drivers/ks7010.

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 01:52:58PM -0800, Matthew Giassa wrote: > Wrapping complex macros with parentheses. > Adding extra spaces between macros and integer literals. > Indentation changes to remove checkpatch warnings. > Swapping out C++-style comments with C-style comments. > > Signed-off-by: Ma

Re: [PATCH v3 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 06:31:12PM +0530, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [PATCH 5/8] staging: ks7010: Remove level of indentation

2017-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 20, 2017 at 07:46:40PM +1100, Tobin C. Harding wrote: > 'if' statement conditional guards large block of code. Conditional can > be inverted and function made to return. This allows following code to > have one level of indentation removed. > > Invert conditional and return directly if

Re: staging: ks7010: Checkpatch fixes

2017-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 20, 2017 at 04:45:05PM +1100, Tobin C. Harding wrote: > Checkpatch emits various messages. Struct ks_stdio_card contains a > spinlock. It is never used. The data structure contains two fields, > both of which are accessed in ways that don't seem to allow use of a > spinlock. I am not fu

Re: [PATCH 6/9] staging: ks7010: Refactor code

2017-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 20, 2017 at 03:23:31PM +1100, Tobin C. Harding wrote: > Code may be refactored to take advantage of previous commit. > > Refactor code. Introduce four new line over 80 warnings. Make code > more legible. > > Signed-off-by: Tobin C. Harding > --- > drivers/staging/ks7010/ks7010_sdio.

Re: [PATCH] staging: ks7010: Block comments use * on subsequent lines

2017-02-24 Thread Greg KH
On Sat, Feb 18, 2017 at 09:02:33PM +0530, Arushi Singhal wrote: > Some of the block comments styles are not encouraged: > for example: > /* > block comment without introductory * > */ > and > /* > * block comment with line terminating */ > > Signed-off-by: Arushi Singhal > --- > drivers/staging/

Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

2017-02-24 Thread Greg KH
On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote: > This is 02nd patch to file ks_wlan.h file fixing error of enclosing > complex macro value in parentheses No need to have the "This is the XXX patch..." in the changelog text, you don't see that in any other commit logs, right? > > S

Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name

2017-02-24 Thread Greg Kroah-Hartman
On Wed, Feb 22, 2017 at 11:46:39PM +0530, Arushi Singhal wrote: > function prototype argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. > > Signed-off-by: Arushi Singhal > --- > changes in v3 > -make the subject title more relevant. > -change the ident

Re: [PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-24 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 04:47:14PM -0500, James Simmons wrote: > From: Alex Zhuravlev > > on small filesystems plain log can grow dramatically. especially > given large record sizes produced by DNE and extended chunksize. > I saw >50% of space consumed by a single llog file which was still > in u

Re: [PATCH 12/14] staging: lustre: llog: change lgh_hdr_lock to mutex

2017-02-24 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 04:47:13PM -0500, James Simmons wrote: > From: wang di > > Change lgh_hdr_lock from spinlock to mutex because if > the llog object is a remote object it can be stalled > while being fetched. but this lock is never even used! Why have it at all? > > Signed-off-by: wang

Re: [PATCH v2] Staging: wlan-ng: fixed block comments should align the * on each line

2017-02-24 Thread Kroah-Hartman
On Fri, Feb 17, 2017 at 06:25:16AM -0500, Bo YU wrote: > Right-shift a space key to align the * on each line. > > Signed-off-by: Bo YU > --- > drivers/staging/wlan-ng/p80211metastruct.h | 88 > ++-- > 1 file changed, 44 insertions(+), 44 deletions(-) Does not apply to

Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

2017-02-24 Thread Julia Lawall
On Fri, 24 Feb 2017, Arushi Singhal wrote: > > > On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman > wrote: > On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote: > > function prototype arguments like 'struct vb_device_info > *','unsigned > > long' etc. sho

Re: [PATCH 1/1] Staging: FBTFT: Fix wrong type casting warnings generated by sparse

2017-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 20, 2017 at 10:26:00PM +0900, Mandel Benjamin wrote: > > Fixed the following warnings reported by sparse: > > drivers/staging/fbtft/fb_watterott.c:83:16: warning: incorrect type in > assignment (different base types) > drivers/staging/fbtft/fb_watterott.c:83:16:expected unsigned

Re: [PATCH] staging: fsl-mc: fix coding style warning

2017-02-24 Thread Greg KH
On Thu, Feb 16, 2017 at 08:42:47PM +0200, Lucian Zala wrote: > Fix for "WARNING: Avoid multiple line dereference - prefer > 'mc_msi_domain->host_data'" found by checkpatch.pl in > bus/irq-gic-v3-its-fsl-mc-msi.c. > > Signed-off-by: Lucian Zala > --- > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fs

Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line

2017-02-24 Thread Greg Kroah-Hartman
On Fri, Feb 17, 2017 at 09:33:01AM -0500, Maksymilian Piechota wrote: > On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote: > > On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote: > > > move else if statement to a single line > > > > > > Signed-off-by: Maksymilian

Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 08:26:01PM +0200, Georgios Emmanouil wrote: > Coding style issue. Added brances to the conditional statement. > > Signed-off-by: Georgios Emmanouil > --- > drivers/staging/xgifb/XGI_main_26.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Same here,

Re: [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement

2017-02-24 Thread Greg KH
On Wed, Feb 22, 2017 at 08:23:17PM +0200, Georgios Emmanouil wrote: > Coding style issue. Added brances to the 'if' statement. > > Signed-off-by: Georgios Emmanouil > --- > drivers/staging/xgifb/XGI_main_26.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Someone sent this same cha

Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

2017-02-24 Thread Greg Kroah-Hartman
On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote: > function prototype arguments like 'struct vb_device_info *','unsigned > long' etc. should have an identifier name. > > Signed-off-by: Arushi Singhal > --- > Changes in v3: > - By mistake one irrelevant line was added which is rem

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Fri 24-02-17 16:40:13, peter enderborg wrote: > On 02/24/2017 04:03 PM, Michal Hocko wrote: > > On Fri 24-02-17 15:42:49, peter enderborg wrote: > >> On 02/24/2017 03:11 PM, Michal Hocko wrote: > >>> On Fri 24-02-17 14:16:34, peter enderborg wrote: > On 02/24/2017 01:28 PM, Michal Hocko wro

[PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue

2017-02-24 Thread Manoj Sawai
fixed the following checkpatch.pl warning: "drivers/staging/bcm2835-audio/bcm2835-pcm.c:320: WARNING: braces {} are not necessary for single statement blocks" Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH 4/4] Staging: bcm2835-audio: bcm2835-vchiq.c: lines over 80 character limit

2017-02-24 Thread Manoj Sawai
Trimmed lines that were unnecessarily over 80 characters long. Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/bcm2835-audi

[PATCH 2/4] Staging: bcm2835-audio: bcm835-ctl.c: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed the following warning : "drivers/staging/bcm2835-audio/bcm2835-ctl.c:251: WARNING: Block comments use a trailing */ on a separate line" Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/s

[PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning

2017-02-24 Thread Manoj Sawai
Fixed a checkpatch.pl about coding style in comments. '*' missing on subsequent lines. Signed-off-by: Manoj Sawai --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread peter enderborg
On 02/24/2017 04:03 PM, Michal Hocko wrote: > On Fri 24-02-17 15:42:49, peter enderborg wrote: >> On 02/24/2017 03:11 PM, Michal Hocko wrote: >>> On Fri 24-02-17 14:16:34, peter enderborg wrote: On 02/24/2017 01:28 PM, Michal Hocko wrote: >>> [...] > Yeah, I strongly believe that the chose

Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

2017-02-24 Thread kbuild test robot
Hi Pranay, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.10] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pranay-Kr-Srivastava/return-same-error-value-fro

RE: [PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-24 Thread Dexuan Cui
> From: Bjorn Helgaas > ... > My question wasn't so much whether pci-hyperv.c *needs* to set MPS; I > don't expect a guest to need to or even be able to configure things > like that. I agree. > My question is whether it would do any harm if we did eventually do > MPS configuration in the generic

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Fri 24-02-17 15:42:49, peter enderborg wrote: > On 02/24/2017 03:11 PM, Michal Hocko wrote: > > On Fri 24-02-17 14:16:34, peter enderborg wrote: > >> On 02/24/2017 01:28 PM, Michal Hocko wrote: > > [...] > >>> Yeah, I strongly believe that the chosen approach is completely wrong. > >>> Both in a

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread peter enderborg
On 02/24/2017 03:11 PM, Michal Hocko wrote: > On Fri 24-02-17 14:16:34, peter enderborg wrote: >> On 02/24/2017 01:28 PM, Michal Hocko wrote: > [...] >>> Yeah, I strongly believe that the chosen approach is completely wrong. >>> Both in abusing the shrinker interface and abusing oom_score_adj as th

Re: [PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-24 Thread Bjorn Helgaas
On Fri, Feb 24, 2017 at 11:16:03AM +, Dexuan Cui wrote: > > From: devel [mailto:driverdev-devel..@...] On Behalf Of Bjorn Helgaas > > Sent: Saturday, February 11, 2017 06:00 > > ... > > On Wed, Feb 08, 2017 at 04:49:22PM -0600, Bjorn Helgaas wrote: > > > The PCI core doesn't configure the PCIe

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Fri 24-02-17 14:16:34, peter enderborg wrote: > On 02/24/2017 01:28 PM, Michal Hocko wrote: [...] > > Yeah, I strongly believe that the chosen approach is completely wrong. > > Both in abusing the shrinker interface and abusing oom_score_adj as the > > only criterion for the oom victim selection

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread peter enderborg
On 02/24/2017 01:28 PM, Michal Hocko wrote: > On Fri 24-02-17 13:19:46, peter enderborg wrote: >> On 02/23/2017 09:36 PM, Martijn Coenen wrote: >>> On Thu, Feb 23, 2017 at 9:24 PM, John Stultz wrote: So, just for context, Android does have a userland LMK daemon (using the mempressure not

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
Hi Christophe, Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: If 'kzalloc()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- Not sure that the error handling path is correct. Is 'gdev[0]' freed? Sh

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Fri 24-02-17 13:19:46, peter enderborg wrote: > On 02/23/2017 09:36 PM, Martijn Coenen wrote: > > On Thu, Feb 23, 2017 at 9:24 PM, John Stultz wrote: > >> So, just for context, Android does have a userland LMK daemon (using > >> the mempressure notifiers) as you mentioned, but unfortunately I'm

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread peter enderborg
On 02/23/2017 09:36 PM, Martijn Coenen wrote: > On Thu, Feb 23, 2017 at 9:24 PM, John Stultz wrote: >> So, just for context, Android does have a userland LMK daemon (using >> the mempressure notifiers) as you mentioned, but unfortunately I'm >> unaware of any devices that ship with that implementa

RE: [PATCH v1 0/3] PCI: Configure PCIe MPS settings

2017-02-24 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel..@...] On Behalf Of Bjorn Helgaas > Sent: Saturday, February 11, 2017 06:00 > ... > On Wed, Feb 08, 2017 at 04:49:22PM -0600, Bjorn Helgaas wrote: > > The PCI core doesn't configure the PCIe MPS settings by itself. Each > > host bridge driver has to call pcie_

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-24 Thread Geert Uytterhoeven
On Thu, Feb 23, 2017 at 7:17 AM, Jeff King wrote: > On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: >> > Poor Simon Sandström. >> > >> > Funnily enough, this only exists for one commit. You've got several >> > other commits from Simon that get his name right. >> > >> > What happened? >> >

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Thu 23-02-17 12:24:57, John Stultz wrote: > On Wed, Feb 22, 2017 at 4:01 AM, Michal Hocko wrote: > > From: Michal Hocko > > > > Lowmemory killer is sitting in the staging tree since 2008 without any > > serious interest for fixing issues brought up by the MM folks. The main > > objection is th

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-24 Thread Michal Hocko
On Thu 23-02-17 21:36:00, Martijn Coenen wrote: > On Thu, Feb 23, 2017 at 9:24 PM, John Stultz wrote: [...] > > This is reportedly because while the mempressure notifiers provide a > > the signal to userspace, the work the deamon then has to do to look up > > per process memory usage, in order to