Re: [Outreachy kernel] [PATCH v3 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Rename struct tstrRSSI to rssi_history_buffer for clarity and to remove camel > casing. Here the commit log messge line is definitely too long. julia > > Signed-off-by: Tahia Khan > --- > drivers/staging/wilc1000/coreconfigurator.h | 4 ++-- > 1 fil

Re: [Outreachy kernel] [PATCH v3 2/3] staging: wilc1000: Rename tstrRSSI members and change type of u8Full to bool

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Remove Hungarian notation and camel casing from all tstrRSSI members' names. > Additionally, change type of u8Full to bool since it only takes values 1 or 0. Acked-by: Julia Lawall Maybe the second line of the commit message is a little too long. It i

Re: [Outreachy kernel] [PATCH v3 3/3] staging: wilc1000: Rename network_info member str_rssi to rssi_history

2017-02-23 Thread Julia Lawall
On Fri, 24 Feb 2017, Tahia Khan wrote: > Change name of str_rssi to rssi_history within the network_info struct for > clarity. > > Signed-off-by: Tahia Khan Acked-by: Julia Lawall Good job at cutting up the patch in a meaningful way. julia > --- > drivers/staging/wilc1000/coreconfigurato

[PATCH v3 3/3] staging: wilc1000: Rename network_info member str_rssi to rssi_history

2017-02-23 Thread Tahia Khan
Change name of str_rssi to rssi_history within the network_info struct for clarity. Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) d

[PATCH v3 2/3] staging: wilc1000: Rename tstrRSSI members and change type of u8Full to bool

2017-02-23 Thread Tahia Khan
Remove Hungarian notation and camel casing from all tstrRSSI members' names. Additionally, change type of u8Full to bool since it only takes values 1 or 0. Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 6 +++--- drivers/staging/wilc1000/wilc_wfi_cfgoperation

[PATCH v3 1/3] staging: wilc1000: Rename struct tstrRSSI to rssi_history_buffer

2017-02-23 Thread Tahia Khan
Rename struct tstrRSSI to rssi_history_buffer for clarity and to remove camel casing. Signed-off-by: Tahia Khan --- drivers/staging/wilc1000/coreconfigurator.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h b/drivers/staging/

[PATCH v3 0/3] staging: wilc1000: multiple coding style changes to struct tstrRSSI

2017-02-23 Thread Tahia Khan
Multiple coding style changes to struct tstrRSSI. Initially reported by checkpath.pl: Avoid CamelCase: Avoid CamelCase: Avoid CamelCase: Changes since v2: Renaming tstrRSSI and members with more descriptive names, as suggested by Arend Van Spriel Tahia Khan (3): staging: wilc1000: Re

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-23 Thread Steve Longerbeam
On 02/23/2017 01:10 AM, Philipp Zabel wrote: Hi Steve, On Wed, 2017-02-22 at 15:52 -0800, Steve Longerbeam wrote: Hi Philipp, On 02/16/2017 03:32 AM, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: The previous API and negotiation of mbus codes and pixel fo

[media] s5p-cec: strange clk enabling pattern

2017-02-23 Thread Alexey Khoroshilov
The s5p-cec driver has a few places that touch hdmicec clk: static int s5p_cec_probe(struct platform_device *pdev) { ... cec->clk = devm_clk_get(dev, "hdmicec"); if (IS_ERR(cec->clk)) return PTR_ERR(cec->clk); ... } static int __maybe_unused s5p_cec

Re: [PATCH] staging, android: remove lowmemory killer from the tree

2017-02-23 Thread John Stultz
On Wed, Feb 22, 2017 at 4:01 AM, Michal Hocko wrote: > From: Michal Hocko > > Lowmemory killer is sitting in the staging tree since 2008 without any > serious interest for fixing issues brought up by the MM folks. The main > objection is that the implementation is basically broken by design: >

Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote: > Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" > in vchiq_version.c file. > > Signed-off-by: Yamanappagouda Patil > --- > .../vc04_services/interface/vchiq_arm/vchiq_version.c| 16 >

Re: [Linaro-mm-sig] [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

2017-02-23 Thread Laura Abbott
On 02/22/2017 05:01 PM, Chen Feng wrote: > > > On 2017/2/22 3:29, Laura Abbott wrote: >> On 02/20/2017 10:05 PM, Chen Feng wrote: >>> Hi Laura, >>> >>> When we enable kernel v4.4 or newer version on our platform, we meet the >>> issue >>> of flushing cache without reference device. It seems that

[PATCH] Staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Fix following warning: WARNING: line over 80 characters +&synth->attributes) < 0) Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/

Re: [PATCH v2] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Greg KH
On Thu, Feb 23, 2017 at 10:23:04PM +0800, Man Choy wrote: > Signed-off-by: Man Choy > --- > drivers/staging/speakup/synth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I can not take patches without any changelog text :( ___ devel maili

[PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.

2017-02-23 Thread Yamanappagouda Patil
Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file. Signed-off-by: Yamanappagouda Patil --- .../vc04_services/interface/vchiq_arm/vchiq_version.c| 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/st

Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
On Thu, Feb 23, 2017 at 9:34 PM, Joe Perches wrote: > On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote: > [] >> diff --git a/drivers/staging/speakup/synth.c >> b/drivers/staging/speakup/synth.c > [] >> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth) >> if (!spk_qui

[PATCH v2] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 1cd38e7..968d8b6 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/s

Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote: [] > diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c [] > @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth) > if (!spk_quiet_boot) > synth_printf("%s found\n", synth->long_na

[PATCH] staging: speakup: synth: Fix checkpatch warning

2017-02-23 Thread Man Choy
Signed-off-by: Man Choy --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index a61c02b..1cd38e7 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-23 Thread Philipp Zabel
Hi Steve, On Wed, 2017-02-22 at 15:52 -0800, Steve Longerbeam wrote: > Hi Philipp, > > > On 02/16/2017 03:32 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > >> The previous API and negotiation of mbus codes and pixel formats > >> was broken, and has been