Hi Laura,
When we enable kernel v4.4 or newer version on our platform, we meet the issue
of flushing cache without reference device. It seems that this patch set is
a solution. I'm curious the progress of the discussion. Do you have any plan
to fix it in v4.4 and newer kernel verison?
On 2016/9/1
Please pardon the earlier e-mail which was missing the changelog text.
Wrapping complex macros with parentheses to remove checkpatch errors.
Some additional style changes to appease checkpatch.
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +-
1 file changed, 41
On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote:
On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote:
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
From: Russell King
Setting and getting frame rates is part of the negotiation mechanism
between subdevs. T
On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote:
> On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> > From: Russell King
> >
> > Setting and getting frame rates is part of the negotiation mechanism
> > between subdevs. The lack of support means that a frame rate a
On 02/20/2017 02:56 PM, Steve Longerbeam wrote:
On 02/20/2017 02:04 PM, Sakari Ailus wrote:
Hi Steve,
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
From: Russell King
Setting and getting frame rates is part of the negotiation mechanism
between subdevs. The lack of su
Fixes the endianness warning "restricted __le16 degrades to integer" by
converting __le16 to short before using it in bitmasks or in the
macro WLAN_FC_GET_STYPE.
Signed-off-by: Sebastian Haas
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 52 +++
1 file changed, 26 i
On 02/20/2017 02:04 PM, Sakari Ailus wrote:
Hi Steve,
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
From: Russell King
Setting and getting frame rates is part of the negotiation mechanism
between subdevs. The lack of support means that a frame rate at the
sensor can't b
Hi Steve,
On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote:
> From: Russell King
>
> Setting and getting frame rates is part of the negotiation mechanism
> between subdevs. The lack of support means that a frame rate at the
> sensor can't be negotiated through the subdev path.
On Mon, Feb 20, 2017 at 05:44:50PM +, Valentin Huebner wrote:
> Fixes a 'macro with flow control statement' checkpatch code style
> error by removing the board_staging() macro and replacing its two
> calls
checkpatch is wrong here, you are now adding more lines than you remove:
> Signed-off-b
On Mon, Feb 20, 2017 at 09:20:52AM -0800, Matthew Giassa wrote:
> Signed-off-by: Matthew Giassa
> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 80
> +-
> 1 file changed, 41 insertions(+), 39 deletions(-)
I can't take patches without any changelog text :(
__
Fixes a 'macro with flow control statement' checkpatch code style
error by removing the board_staging() macro and replacing its two
calls
Signed-off-by: Valentin Hübner
---
drivers/staging/board/armadillo800eva.c | 10 +-
drivers/staging/board/board.h | 11 ---
drivers/
On 20/02/17 16:02, Cheah Kok Cheong wrote:
On Mon, Feb 20, 2017 at 10:03:39AM +, Ian Abbott wrote:
On 20/02/17 08:28, Cheah Kok Cheong wrote:
Fix checkpatch warning "Avoid multiple line dereference"
using a local variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
drivers/sta
Signed-off-by: Matthew Giassa
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +-
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 84554b6..00eec18 100644
--- a/dr
On Mon, Feb 20, 2017 at 10:40:28PM +0530, sayli karnik wrote:
> Change array index from the loop bound variable to loop index.
> If a poll file fails to open for any intermediate device, all poll files with
> fds of devices from 0 upto that device must be closed in the open_poll_files()
> function.
Change array index from the loop bound variable to loop index.
If a poll file fails to open for any intermediate device, all poll files with
fds of devices from 0 upto that device must be closed in the open_poll_files()
function. The current code only closes the poll file with the most recent fd
al
Extra parentheses were causing checkpatch issues
and were removed.
Signed-off-by: simran singhal
---
v2:
-Removed parentheses around argument of cast
-Removed cast
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
On Mon, 20 Feb 2017, Katie Dunne wrote:
> On Mon, Feb 20, 2017 at 07:37:33AM +0100, Julia Lawall wrote:
> > On Sun, 19 Feb 2017, Katie Dunne wrote:
> >
> > > Remove spaces after casts found by checkpatch.pl. In some cases,
> > > remove returns after casts and place them on a single line.
> >
> >
On Mon, Feb 20, 2017 at 07:37:33AM +0100, Julia Lawall wrote:
> On Sun, 19 Feb 2017, Katie Dunne wrote:
>
> > Remove spaces after casts found by checkpatch.pl. In some cases,
> > remove returns after casts and place them on a single line.
>
> What do you mean by "returns after casts"? I didn't s
On Mon, Feb 20, 2017 at 5:30 PM, Johan Hovold wrote:
> [+CC: greybus and staging lists]
>
> On Sat, Feb 18, 2017 at 01:47:38PM +0530, sayli karnik wrote:
>> Change array index from the loop bound variable to loop index.
>> The open_poll_files() functions attempts to open poll files of devices
>> n
On Mon, Feb 20, 2017 at 10:03:39AM +, Ian Abbott wrote:
> On 20/02/17 08:28, Cheah Kok Cheong wrote:
> >Fix checkpatch warning "Avoid multiple line dereference"
> >using a local variable to avoid line wrap.
> >
> >Signed-off-by: Cheah Kok Cheong
> >---
> > drivers/staging/comedi/drivers/comedi
On 20/02/17 08:28, Cheah Kok Cheong wrote:
Fix checkpatch warning "Avoid multiple line dereference"
using a local variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/drivers/comedi_test.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --gi
Fixed the following warnings reported by sparse:
drivers/staging/fbtft/fb_watterott.c:83:16: warning: incorrect type in
assignment (different base types)
drivers/staging/fbtft/fb_watterott.c:83:16:expected unsigned short
[unsigned] [short] [usertype]
drivers/staging/fbtft/fb_watterott.c:83
On Mon, Feb 20, 2017 at 10:10 AM, =?UTF-8?q?Valentin=20H=C3=BCbner?=
wrote:
> Fixes a 'macro with flow control statement' checkpatch code style
> error by removing the board_staging() macro and replacing its one
> and only call
It's not the only user, as 0day has already told you.
> Signed-off-b
Hi
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.10 next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/UTF-8-q-Valentin-20H-C3-BCbner/Staging-board
[+CC: greybus and staging lists]
On Sat, Feb 18, 2017 at 01:47:38PM +0530, sayli karnik wrote:
> Change array index from the loop bound variable to loop index.
> The open_poll_files() functions attempts to open poll files of devices
> numbered from 0 to device_count. If the open() function inside
On Sat, Feb 4, 2017 at 2:08 AM, Florian Fainelli wrote:
> On 02/03/2017 12:36 PM, Greg KH wrote:
>> On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote:
>>> On Fri, 2017-02-03 at 10:50 -0800, Florian Fainelli wrote:
(with JC's other email)
>>>
>>> And now with Greg's proper email too
On Mon 13-02-17 16:42:42, peter enderborg wrote:
> On 02/10/2017 11:27 AM, Michal Hocko wrote:
> > [I have only now see this cover - it answers some of the questions I've
> > had to specific patches. It would be really great if you could use git
> > send-email to post patch series - it just does
Fixes a 'macro with flow control statement' checkpatch code style
error by removing the board_staging() macro and replacing its one
and only call
Signed-off-by: Valentin Hübner
---
drivers/staging/board/armadillo800eva.c | 10 +-
drivers/staging/board/board.h | 11 ---
On Sun, 19 Feb 2017, Arushi Singhal wrote:
>
>
> On Monday, February 20, 2017 at 12:32:22 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Mon, 20 Feb 2017, Arushi Singhal wrote:
>
> > Unnecessary parentheses should be avoided as reported by
> checkpatch.pl.
> > Remove unnecessa
hostif_data_indication is able to be refactored after previous
commit.
Refactor function in two separate patches to ease review.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git
Function was not named during initial refactoring.
Give function new meaningful name.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_ho
'if' statement conditional guards large block of code. Conditional can
be inverted and function return. This allows following code to have
one level of indentation removed. However the conditional is complicated,
it can be moved into a separate variable to ease reading.
Move complicated conditiona
Code is able to be refactored after previous removal of levels of
indentation.
Refactor code to bring it more inline with kernel standards.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 53 ++
1 file changed, 20 insertions(+), 33 de
Checkpatch emits various whitespace errors and warnings.
Add whitespace around binary operators and logical operators. Remove
whitespace where checkpatch complains.
Signed-off-by: Tobin C. Harding
---
Perhaps I do not know how to parse a diff visually but these changes
do not look like an impro
Function hostif_data_indication has 14 local variables an is over 200
lines long. Contains code nested deeply. Function could be refactored.
Start to refactor function. Split out three separate functions. Don't
modify code except to make it compile, add/remove correct local
variables and add code
'if' statement conditional guards large block of code. Conditional can
be inverted and function made to return. This allows following code to
have one level of indentation removed.
Invert conditional and return directly if new conditioal is true.
Remove one level of indentation.
Signed-off-by: To
Checkpatch emits WARNING: Comparisons should place the constant on
the right side of the test.
Move constant to the rights side of the test.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/st
This is the second patch series to staging ks7010. The two series
are on different files.
Checkpatch emits various warnings. Warnings are an indication that the
code needs refactoring.
Clear trivial checkpatch warnings and errors first. Split large
function into smaller functions. Refactor new fu
Fix checkpatch warning "Avoid multiple line dereference"
using a local variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
drivers/staging/comedi/drivers/comedi_test.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_tes
39 matches
Mail list logo
