[PATCH 08/14] staging: lustre: llite: remove extraneous export parameter

2017-02-18 Thread James Simmons
From: Andreas Dilger The ll_close_inode_openhandle() and ll_md_close() functions passed an extra "obd_export *md_exp" parameter, but it turns out that all of the callers already pass inode->i_sb->s_fs_info->lsi_llsbi->ll_md_exp in one form or another, so it can just be extracted from "inode" dire

[PATCH 14/14] staging: lustre: lprocfs: move lprocfs_stats_[un]lock to a source file

2017-02-18 Thread James Simmons
When compiling the kernel without optimization, when using GCOV, the lprocfs_stats_alloc_one() symbol is not properly exported to other modules and causes the ptlrpc module to fail loading with an unknown symbol. There is no reason to export the function lprocfs_stats_alloc_one. The reason is due t

[PATCH 10/14] staging: lustre: ldlm: disconnect speedup

2017-02-18 Thread James Simmons
From: Vitaly Fertman disconnect takes too long time if there are many locks to cancel. besides the amount of time spent on each lock cancel, there is a resched() in cfs_hash_for_each_relax(), i.e. disconnect or eviction may take unexpectedly long time. While this patch only contains the client si

[PATCH 06/14] staging: lustre: osc: further LRU OSC cleanup after eviction

2017-02-18 Thread James Simmons
From: Jinshan Xiong Define osc_lru_reserve() and osc_lru_unreserve() to reserve LRU slots in osc_io_write_iter_init() and unreserve them in fini(); Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6271 Reviewed-on: http://review.whamcloud.com/16456 Reviewed-by: B

[PATCH 11/14] staging: lustre: ldlm: fix race of starting bl threads

2017-02-18 Thread James Simmons
From: Niu Yawei There is race in the code of starting bl threads which leads to thread number exceeds the maximum number when race happened, it can also lead to duplicated thread name. This patch fixes the race and cleanup the code a bit. Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd

[PATCH 13/14] staging: lustre: llog: limit file size of plain logs

2017-02-18 Thread James Simmons
From: Alex Zhuravlev on small filesystems plain log can grow dramatically. especially given large record sizes produced by DNE and extended chunksize. I saw >50% of space consumed by a single llog file which was still in use. this leads to test failures (sanityn, etc). the patch introduces additi

[PATCH 12/14] staging: lustre: llog: change lgh_hdr_lock to mutex

2017-02-18 Thread James Simmons
From: wang di Change lgh_hdr_lock from spinlock to mutex because if the llog object is a remote object it can be stalled while being fetched. Signed-off-by: wang di Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6602 Reviewed-on: http://review.whamcloud.com/15274 Reviewed-by: James Simmons

[PATCH 07/14] staging: lustre: lov: trying smaller memory allocations

2017-02-18 Thread James Simmons
From: Yang Sheng Reduce struct lov_io_sub to smaller memory usage on wide-stripe file systems. Signed-off-by: Yang Sheng Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7085 Reviewed-on: http://review.whamcloud.com/17476 Reviewed-by: Bob Glossman Reviewed-by: Jian Yu Reviewed-by: Andreas

[PATCH 09/14] staging: lustre: ldlm: reduce ldlm pool recalc window

2017-02-18 Thread James Simmons
From: Vitaly Fertman Reduce the sleep period from 50 seconds down to LDLM_POOL_CLI_DEF_RECALC_PERIOD which is 10 seconds. Signed-off-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3031 Xyratex-bug-id: MRP-395 MRP-1366 MRP-1366 Reviewed-by: Andriy Skulysh Reviewed-by: Al

[PATCH 01/14] staging: lustre: llite: lower message level for ll_setattr_raw()

2017-02-18 Thread James Simmons
From: Bobi Jam Truncate and write can happen at the same time, so that a file can be set modified even though the file is not restored from released state, and ll_hsm_state_set() is not applicable for the file, and it will return error in this case, we'd lower the error message level in this case

[PATCH 03/14] staging: lustre: osc: remove obsolete asserts

2017-02-18 Thread James Simmons
From: Jinshan Xiong Remove the no longer needed assert in the function osc_cache_truncate_start(). The assertion in osc_object_prune() will become faulty with upcoming changes. The reason this will become a problem is that there may exist freeing pages in object's radix tree at the time of osc_ob

[PATCH 05/14] staging: lustre: ldlm: handle ldlm lock cancel race when evicting client.

2017-02-18 Thread James Simmons
From: Jinshan Xiong A ldlm lock could be canceled simutaneously by ldlm bl thread and cleanup_resource(). In this case, only one side will win the race and the other side should wait for the work to complete. Eviction on group lock is now well supported. Signed-off-by: Jinshan Xiong Intel-bug-i

[PATCH 02/14] staging: lustre: llite: omit to update wire data

2017-02-18 Thread James Simmons
From: Bobi Jam In ll_setattr_raw(), after op_data->op_attr has been copied, the attr is updated and op_data->op_attr does not get updated afterward. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6813 Reviewed-on: http://review.whamcloud.com/16462 Reviewed-by: Jinsh

[PATCH 04/14] staging: lustre: lov: cleanup when cl_io_iter_init() fails

2017-02-18 Thread James Simmons
From: Jinshan Xiong In lov_io_iter_init(), if cl_io_iter_init() against sub io fails, it should call cl_io_iter_fini() to cleanup leftover information; Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6271 Reviewed-on: http://review.whamcloud.com/16456 Reviewed-b

[PATCH 00/14] staging: lustre: missing fixes from lustre 2.8

2017-02-18 Thread James Simmons
This patch series is a batch of fixes from the lustre 2.8 release that is missing from the upstream client. These patches are dependent on the order applied. Alex Zhuravlev (1): staging: lustre: llog: limit file size of plain logs Andreas Dilger (1): staging: lustre: llite: remove extraneous

[PATCH v3 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- v2: -Removed assignment v3: -Removed declaration of qwTSFOffset

Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org,outreachy-ker...@googlegroups.com > Bcc: > Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic > Reply-To: This didn't come out well. > > Simplify function

[PATCH v2 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread simran singhal
gre...@linuxfoundation.org,de...@driverdev.osuosl.org,linux-ker...@vger.kernel.org,outreachy-ker...@googlegroups.com Bcc: Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic Reply-To: Simplify function returns by merging assignment and return into one command line. Found with Coccinel

Re: [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Joe Perches
On Sun, 2017-02-19 at 01:50 +0530, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; [] > diff --git a/drivers/staging

Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: simran singhal > --- > d

[PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > >

Re: [PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote: > Unnecessary parentheses as reported by checkpatch.pl [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct > link_ap_

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > On Sun, 19 Feb 2017, simran singhal wrote: > > Extra parentheses were causing checkpatch issues > > and were removed. [] > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > b/drivers/staging/rtl8192e/rtl819x_HTProc.c [] > > @@ -66

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Extra parentheses were causing checkpatch issues > and were removed. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/st

[PATCH v2 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread simran singhal
Align * on last line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/

[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread simran singhal
Extra parentheses were causing checkpatch issues and were removed. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rt

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Russell King - ARM Linux
On Sat, Feb 18, 2017 at 09:29:17AM -0800, Steve Longerbeam wrote: > On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: > >On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: > >>Hi Russell, > >> > >>I signed-off on this but after more review I'm not sure this is right. > >> > >>T

[PATCH] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
In Linux kernel 4.9-rc1, the function ib_get_dma_mr() was removed and a second parameter was added to ib_alloc_pd(). As this broke the building of the ko2iblnd module in staging, the Kconfig for LNet has marked ko2iblnd as broken and stopped building it. This patch fixes this breakage by: - Remov

[PATCH v2] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
I tried to send this patch yesterday and it appeared to work. However, I did not see an email from the list. Assuming it failed and trying again. I apologize if this is a repeat. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.lin

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Steve Longerbeam
On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: Hi Russell, I signed-off on this but after more review I'm not sure this is right. The CSI-2 receiver really has no control over frame rate. It's output frame rate is the

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Steve Longerbeam
On 02/16/2017 02:57 PM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: In version 4: With this version, I get: [28

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > > > > > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia > Lawall wrote: >

Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insert

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --

Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Greg KH
On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 fil

[PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Arushi Singhal
The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, simran singhal wrote: > > > Align * on a line, to conform to the kernal coding > > style for block comments. > > It is no

Re: [Outreachy kernel] [PATCH 4/6] staging: rtl8192e: Remove blank line after '{'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > Remove blank line after opening brace to fix the > checkpatch issue blank lines aren't necessary after > a open brace '{'. > > Signed-off-by: simran singhal Acked-by: Julia Lawall > --- > drivers/staging/rtl8192e/rtl819x_HT.h | 2 -- > 1 file cha

[PATCH 5/6] staging: rtl8192e: Fixes multiple blank lines issue

2017-02-18 Thread simran singhal
This patch fixes the checkpatch.pl issue: Please don't use multiple blank lines Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index f53

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 1fbd

[PATCH 4/6] staging: rtl8192e: Remove blank line after '{'

2017-02-18 Thread simran singhal
Remove blank line after opening brace to fix the checkpatch issue blank lines aren't necessary after a open brace '{'. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/sta

[PATCH] staging: ks7010: Block comments use * on subsequent lines

2017-02-18 Thread Arushi Singhal
Some of the block comments styles are not encouraged: for example: /* block comment without introductory * */ and /* * block comment with line terminating */ Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks7010_sdio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > Align * on a line, to conform to the kernal coding > style for block comments. It is not clear what is means to align * on a line. What line? What has been done is to add a space at the beginning of the line. But then the line goes over 80 charact

[PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread simran singhal
Align * on a line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. > > Signed-off-by: Arushi Singhal Acked-by: Julia Lawall > --- > drivers/staging/xgifb/vb_init.h | 3 +-- > 1 file changed, 1 insert

[PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/stagin

Re: [Outreachy kernel] [PATCH v2 1/6] staging: rtl8192e: Replaced comparison to NULL statements

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch removes the explicit NULL comparison. This issue was found by > checkpatch. > > Signed-off-by: simran singhal Acked-by: Julia Lawall > --- > > v2: >-Modified commit message > > drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---

[PATCH v2 1/6] staging: rtl8192e: Replaced comparison to NULL statements

2017-02-18 Thread simran singhal
This patch removes the explicit NULL comparison. This issue was found by checkpatch. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/r

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/stagin

Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. This could be a bit more clear as "Add variable names to function prototype parameter list." > > Signed-off-by: Arushi Singhal > --- >

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/

Re: [Outreachy kernel] [PATCH 1/6] staging: rtl8192e: Replaced comparison to NULL statements

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch corrects check generated by checkpatch.pl by There is not much information in the first line. Use the imperative: Replace comparisons to NULL by ... > replacing comparison to null statements with equivalent > statements in the form of "

Re: [Outreachy kernel] [PATCH 2/6] staging: rtl8192e: Remove CamelCase

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, simran singhal wrote: > This patch renames pBA to pba to avoid camelcase. I think that this was tried in the last round and was rejected, because BA is meaningful. You also see BA in the name of a header file. The kind of camel case that one should remove is whenTextIsWritt

[PATCH 2/6] staging: rtl8192e: Remove CamelCase

2017-02-18 Thread simran singhal
This patch renames pBA to pba to avoid camelcase. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 100 +++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-18 Thread Michael Zoran
On Sat, 2017-02-18 at 03:22 -0800, Michael Zoran wrote: > The original github source allowed for the cache-line-size property > to be missing.  Since recent firmwares also require this property, > it makes sense to always require it in the driver as well. > > If the cache-line-size property is mis

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Sakari Ailus
Hi Philipp and Russell, On Fri, Feb 17, 2017 at 04:04:30PM +0100, Philipp Zabel wrote: > On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > > Hi Philipp, Steve and Russell, > > > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > > On Thu, 2017-02-16 at 14:27 -0800, Steve

Re: [patch v2] staging: bcm2835-camera: fix error handling in init

2017-02-18 Thread walter harms
looks more readable now :) Acked-by: wha...@bfs.de Am 18.02.2017 00:20, schrieb Dan Carpenter: > The unwinding here isn't right. We don't free gdev[0] and instead > free 1 step past what was allocated. Also we can't allocate "dev" then > we should unwind instead of returning directly. > > Fixe

[PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-18 Thread Michael Zoran
The original github source allowed for the cache-line-size property to be missing. Since recent firmwares also require this property, it makes sense to always require it in the driver as well. If the cache-line-size property is missing, then the driver probe should fail as no dev since the kernel

Re: [PATCH] staging: vc04_services: fix missing check of return value for query of dt_node property

2017-02-18 Thread Michael Zoran
On Sat, 2017-02-18 at 10:42 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 18. Februar 2017 um > > 01:03 geschrieben: > > > > > > This appears to be an ancient issue with the old github.com > > sources. > > no, in the old sources DT binding was optional [1]. But now it sh

Re: [PATCH] staging: vc04_services: fix missing check of return value for query of dt_node property

2017-02-18 Thread Stefan Wahren
Hi Michael, > Michael Zoran hat am 18. Februar 2017 um 01:03 > geschrieben: > > > This appears to be an ancient issue with the old github.com sources. no, in the old sources DT binding was optional [1]. But now it should be mandatory and i think cache-line-size should be a required property,

[PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues

2017-02-18 Thread Georgios Emmanouil
Fixed coding style issues. Patch applies to linux-next-20170217 tree. Signed-off-by: Georgios Emmanouil --- drivers/staging/xgifb/XGI_main_26.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_mai

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Russell King - ARM Linux
On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: > Hi Russell, > > I signed-off on this but after more review I'm not sure this is right. > > The CSI-2 receiver really has no control over frame rate. It's output > frame rate is the same as the rate that is delivered to it. > > S