[PATCH 1/6] staging: rtl8192e: Replaced comparison to NULL statements

This patch corrects check generated by checkpatch.pl by replacing comparison to null statements with equivalent statements in the form of "!x". Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

Re: [PATCH] staging: rtl8192u: Fix warnings about endianness

On February 16, 2017 4:31:16 AM GMT+08:00, Dan Carpenter wrote: >On Wed, Feb 15, 2017 at 09:33:15AM +0100, Arnd Bergmann wrote: >> I see the same warning was addressed very differently in 99277c1f9962 >> ("Staging: rtl8192e: Fix Sparse warning of cast to restricted __le16 >in >> rtllib_crypt_tki

[PATCH] bcm2048: Fix checkpatch checks

Fix following checks: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); CHECK: spaces preferred around that '+' (ctx:VxV) + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); ^ CHE

Re: [PATCH] Staging: ks7010: ks_*: Braces should be used on all arms of these statements

On Fri, 2017-02-17 at 22:41 +0100, Shiva Kerdel wrote: > Braces should be used on all arms of these statements (CHECK).. [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -2148,8 +2148,9 @@ void hostif_sme_mode_setup(struct ks_wlan_private *priv) >

Re: [PATCH] Staging: ks7010: ks_*: Braces should be used on all arms of these statements

On Fri, 2017-02-17 at 14:50 -0800, Joe Perches wrote: > On Fri, 2017-02-17 at 22:41 +0100, Shiva Kerdel wrote: > > Braces should be used on all arms of these statements (CHECK).. > > [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c > > b/drivers/staging/ks7010/ks_hostif.c > > [] > > @@ -21

[PATCH] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

In Linux kernel 4.9-rc1, the function ib_get_dma_mr() was removed and a second parameter was added to ib_alloc_pd(). As this broke the building of the ko2iblnd module in staging, the Kconfig for LNet has marked ko2iblnd as broken and stopped building it. This patch fixes this breakage by: - Remov

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

Ok, I personally like that better anyhow. Also, there was mention of the line limit even exceeding 100 characters (130ish?) and that was being tossed around at one point (if I remember correctly). On Fri, Feb 17, 2017 at 8:38 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 20:32 -0500, Adan Hawth

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

On Fri, 2017-02-17 at 20:32 -0500, Adan Hawthorn wrote: > Thanks, Joe. > > Is this to say that scripts/checkpatch.pl should be updated to some > higher column limit? I have made these cleanup changes before in a > like manner. Hard to say. There could be some sensitivity to long identifier name

Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: > Fix checkpatch.pl warning of the form "WARNING: Use of volatile is > usually wrong: see Documentation/process/volatile-considered-harmful.rst." Why are you sure the volatile use is not necessary? > Signed-off-by: Nathan Howard > --- > dr

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

Thanks, Joe. Is this to say that scripts/checkpatch.pl should be updated to some higher column limit? I have made these cleanup changes before in a like manner. On Fri, Feb 17, 2017 at 8:17 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl war

Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: > Fix checkpatch.pl warning of the form "WARNING: line over 80 characters." [] > diff --git a/drivers/staging/bcm2835-audio/bcm2835.h > b/drivers/staging/bcm2835-audio/bcm2835.h [] > @@ -163,8 +163,10 @@ int bcm2835_audio_write(struct bcm2835

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 02/15/2017 06:19 PM, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 level for

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 02/15/2017 06:19 PM, Steve Longerbeam wrote: From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 level for

Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

Thank you, Joe. Please remove this patch at this time; it was sent in error. On Fri, Feb 17, 2017 at 6:04 PM, Joe Perches wrote: > On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote: >> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is >> usually wrong: see Documentation/pro

[PATCH] staging: vc04_services: fix missing check of return value for query of dt_node property

This appears to be an ancient issue with the old github.com sources. If the cache-line-size property is missing, then the driver probe should fail as no dev since the kernel and dt may be out of sync. The fix is to add a check for the return value of of_property_read_u32. Signed-off-by: Micha

[patch] staging: bcm2835/mmal-vchiq: unlock on error in buffer_from_host()

We should unlock before returning on this error path. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c index f06

[patch v2] staging: bcm2835-camera: fix error handling in init

The unwinding here isn't right. We don't free gdev[0] and instead free 1 step past what was allocated. Also we can't allocate "dev" then we should unwind instead of returning directly. Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.") Signed-off-by: Dan Carpente

Re: [PATCH] [media] Staging: media/lirc: don't call put_ir_rx on rx twice

This one is a false positive. The original code is correct. I was looking through my mail boxes to see the history of this and why it hadn't been fixed earlier. Someone tried to fix it in 2011: https://www.spinics.net/lists/linux-driver-devel/msg17403.html Then I complained about it again in 201

[PATCH] Staging: ks7010: ks_*: Braces should be used on all arms of these statements

Braces should be used on all arms of these statements (CHECK).. Signed-off-by: Shiva Kerdel --- drivers/staging/ks7010/ks_hostif.c | 6 -- drivers/staging/ks7010/ks_wlan_net.c | 42 +++- 2 files changed, 31 insertions(+), 17 deletions(-) diff --git a/drive

Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues

On Fri, 2017-02-17 at 13:39 -0500, Nathan Howard wrote: > The following coding style issues (as per checkpatch.pl) were resolved. What Greg said is true, and the volatile conversion especially needs to be verified. > diff --git a/drivers/staging/bcm2835-audio/bcm2835.h > b/drivers/staging/bcm283

[PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue

Fix checkpatch.pl warning of the form "WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst." Signed-off-by: Nathan Howard --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue

Fix checkpatch.pl warning of the form "WARNING: line over 80 characters." Signed-off-by: Nathan Howard --- drivers/staging/bcm2835-audio/bcm2835.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bc

[PATCH 3/5] staging: bcm2835-audio: bcm2835.h: fix macro coding style issue

Fix checkpatch.pl warning of the form "CHECK: Macro argument 'vol' may be better as '(vol)' to avoid precedence issues." Signed-off-by: Nathan Howard --- drivers/staging/bcm2835-audio/bcm2835.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-aud

[PATCH 2/5] staging: bcm2835-audio: bcm2835.h: fix printk coding style issue

Fix checkpatch.pl warning of the form "WARNING: Prefer subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ..." Signed-off-by: Nathan Howard --- drivers/staging/bcm2835-audio/bcm2835.h | 10 +- 1 file changed, 5 insertions(+), 5 del

[PATCH 1/5] staging: bcm2835-audio: bcm2835.h: fix block comment warning

Fix checkpatch.pl warning: "Block comments use * on subsequent lines." Signed-off-by: Nathan Howard --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835

Re: [PATCH] pci-hyperv: Use device serial number as PCI domain

On Mon, Feb 13, 2017 at 06:10:11PM +, Haiyang Zhang wrote: > > This allows PCI domain numbers starts with 1, and also unique > on the same VM. So names, such as VF NIC names, that include > domain number as part of the name, can be shorter than that > based on part of bus UUID previously. The

Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues

On Fri, Feb 17, 2017 at 01:39:07PM -0500, Nathan Howard wrote: > The following coding style issues (as per checkpatch.pl) were resolved. > > WARNING: Block comments use * on subsequent lines > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... > WARNING: Missing a blank line after dec

[PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues

The following coding style issues (as per checkpatch.pl) were resolved. WARNING: Block comments use * on subsequent lines WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... WARNING: Missing a blank line after declarations WARNING: Use of volatile is usually wrong:... WARNING: line ove

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 02/17/2017 06:16 AM, Philipp Zabel wrote: On Fri, 2017-02-17 at 11:47 +0100, Philipp Zabel wrote: On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: +static void csi2_dphy_init(struct csi2_dev *csi2) +{ + /* +* FIXME: 0x14 is derived from a fixed D-PHY reference +

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

On Fri, 17 Feb 2017, Andy Lutomirski wrote: > On Fri, Feb 17, 2017 at 2:14 AM, Vitaly Kuznetsov wrote: > > Not only. As far as I understand (and I *think* K. Y. pointed this out) > > when VM is migrating to another host TSC page clocksource is disabled for > > extended period of time so we're bett

[PATCH 06/10] vmbus: fix spelling errors

Several spelling errors in comments Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 10 +- drivers/hv/hv_kvp.c | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 81a80c82f1bd..deb852238b2d 10064

[PATCH 10/10] vmbus: expose debug info for drivers

Allow driver to get debug information about state of the ring. Signed-off-by: Stephen Hemminger --- drivers/hv/hyperv_vmbus.h | 11 --- drivers/hv/ring_buffer.c | 1 + include/linux/hyperv.h| 17 + 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/dri

[PATCH 05/10] vmbus: remove unnecessary initialization

Don't initialize variables that are then set a few lines later. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index d0ff5b41161a..52d0556a5a25 100

[PATCH 09/10] vmbus: cleanup header file style

Minor changes to align hyper-v vmbus include files with current linux kernel style. Signed-off-by: Stephen Hemminger --- drivers/hv/hyperv_vmbus.h | 16 include/linux/hyperv.h| 12 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/hv/hyper

[PATCH 08/10] vmbus: make channel_message table constant

This table is immutable and should be const. Cleanup indentation and whitespace for this as well. Signed-off-by: Stephen Hemminger --- drivers/hv/channel_mgmt.c | 48 +++ drivers/hv/hyperv_vmbus.h | 2 +- drivers/hv/vmbus_drv.c| 2 +- 3 files cha

[PATCH 02/10] vmbus: use rcu for per-cpu channel list

The per-cpu channel list is now referred to in the interrupt routine. This is mostly safe since the host will not normally generate an interrupt when channel is being deleted but if it did then there would be a use after free problem. To solve, this use RCU protection on ther per-cpu list. Signed

[PATCH v3 00/10] vmbus: related patches

This is mostly the same set of vmbus cleanups and bug fixes as v2. In addition: * Addresses rcu sparse annotation issue caught by kbuild * Exposes ring debug info -- intended for later debugfs hook in networking Stephen Hemminger (10): vmbus: only reschedule tasklet if time limit exceeded

[PATCH 07/10] hyperv: remove unnecessary return variable

hv_ringbuffer_read cleanup. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index 52d0556a5a25..8a249740b4b4 100644 --- a/drivers/hv/ring_buffer.c +++ b/dri

[PATCH 03/10] hyperv: fix warning about missing prototype

Compiling with warnings enabled finds missing prototype for hv_do_hypercall. Signed-off-by: Stephen Hemminger --- arch/x86/hyperv/hv_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index db64baf0e500..d4a5f820af5d 1

[PATCH 04/10] vmbus: remove useless return's

No need for empty return at end of void function Signed-off-by: Stephen Hemminger --- drivers/hv/hv_balloon.c | 2 -- drivers/hv/hv_fcopy.c| 2 -- drivers/hv/hv_kvp.c | 2 -- drivers/hv/hv_snapshot.c | 2 -- drivers/hv/ring_buffer.c | 2 -- drivers/hv/vmbus_drv.c | 2 -- include/linu

[PATCH 01/10] vmbus: only reschedule tasklet if time limit exceeded

The change to reschedule tasklet if more data arrives in ring buffer can cause performance regression if host timing is such that the next response happens in small window. Go back to a modified version of the original looping behavior. If the race occurs in a small time, then loop. But if the tas

[PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro

Replaces left shift operation (1 << d) by BIT(x) macro. Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing Signed-off-by: simran singhal --- V2: -modified patch message. drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 - 1 file changed,

Re: [PATCH] pci-hyperv: Use device serial number as PCI domain

On Mon, 13 Feb 2017 18:10:11 + Haiyang Zhang wrote: > This allows PCI domain numbers starts with 1, and also unique > on the same VM. So names, such as VF NIC names, that include > domain number as part of the name, can be shorter than that > based on part of bus UUID previously. The new name

Re: [PATCH] hv: hide unused label

On Tue, 14 Feb 2017 22:17:17 +0100 Arnd Bergmann wrote: > This new 32-bit warning just showed up: > > arch/x86/hyperv/hv_init.c: In function 'hyperv_init': > arch/x86/hyperv/hv_init.c:167:1: error: label 'register_msr_cs' defined but > not used [-Werror=unused-label] > > The easiest solution i

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

On Fri, Feb 17, 2017 at 2:14 AM, Vitaly Kuznetsov wrote: > Thomas Gleixner writes: > >> On Wed, 15 Feb 2017, Vitaly Kuznetsov wrote: >>> Actually, we already have an implementation of TSC page update in KVM >>> (see arch/x86/kvm/hyperv.c, kvm_hv_setup_tsc_page()) and the update does >>> the follo

[PATCH] [media] Staging: media/lirc: don't call put_ir_rx on rx twice

From: Colin Ian King There is an exit path where rx is kfree'd on put_ir_rx and then a jump to label out_put_xx will again kfree it with another call to put_ir_rx. Fix this by adding a new label that avoids this 2nd call to put_ir_rx for this specific case. Detected with CoverityScan, CID#14511

Re: [PATCH v4 00/36] i.MX Media Driver

On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > Hi Philipp, Steve and Russell, > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > > > On

[PATCH] staging: octeon: remove unused variable

A cleanup patch left one local variable without a reference: drivers/staging/octeon/ethernet-rx.c:339:28: warning: unused variable 'priv' [-Wunused-variable] This removes the declaration too. Fixes: 66812da3a689 ("staging: octeon: Use net_device_stats from struct net_device") Signed-off-by: Ar

Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line

On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote: > On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote: > > move else if statement to a single line > > > > Signed-off-by: Maksymilian Piechota > > --- > > drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- > > 1 file

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, 2017-02-17 at 11:47 +0100, Philipp Zabel wrote: > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > > for sensors with a MIPI CSI2 interface. > > > > Signed-off-by: Steve Longerbeam > > --- > > drivers/staging

Re: [PATCH v4 00/36] i.MX Media Driver

On Fri, Feb 17, 2017 at 02:22:14PM +0200, Sakari Ailus wrote: > Hi Philipp, Steve and Russell, > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > I think with Russell's explanation of how the imx219 sensor operates, > > we'll have to do something before calling the sensor s_str

Re: [PATCH v4 00/36] i.MX Media Driver

Hi Philipp, Steve and Russell, On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > > On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > > >>

[PATCH v2] staging: rtl8192u: Fix warnings about endianness

drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:expected unsigned short [unsigned] [usertype] len drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:got re

Re: [PATCH v4 00/36] i.MX Media Driver

On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > >> In version 4: > > > > With this version, I get: > > > > [28762.892053] imx6-mipi-csi2: LP-11 timeout, ph

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, 2017-02-17 at 11:06 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > > +static void csi2_dphy_init(struct csi2_dev *csi2) > > > +{ > > > + /* > > > + * FIXME: 0x14 is d

[PATCH v2] Staging: wlan-ng: fixed block comments should align the * on each line

Right-shift a space key to align the * on each line. Signed-off-by: Bo YU --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng/p80

Re: [PATCH v4 00/36] i.MX Media Driver

On Fri, 2017-02-17 at 10:56 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:39:11AM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > > > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: > > > > > > > > > > >

[PATCH 03/11] staging: comedi: jr3_pci: Reset all DSPs

The various JR3 PCI models have from 1 to 4 DSPs, one per subdevice. Prior to loading the firmware to all the DSPs, the initialization code in `jr3_pci_auto_attach()` resets the first DSP. As far as I can tell, it should reset all of them. Change it to do so. Signed-off-by: Ian Abbott --- driv

[PATCH 08/11] staging: comedi: jr3_pci: separate out poll state enum

The type of the `state` member of `struct jr3_pci_subdev_private` is defined in-situ as an enumerated type without a tag. For aesthetic reasons, define the type as `enum jr3_pci_poll_state` outside the containing `struct`. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/jr3_pci.c |

[PATCH 02/11] staging: comedi: jr3_pci: cope with jiffies wraparound

The timer expiry routine `jr3_pci_poll_dev()` checks for expiry by checking whether the absolute value of `jiffies` (stored in local variable `now`) is greater than the expected expiry time in jiffy units. This will fail when `jiffies` wraps around. Also, it seems to make sense to handle the expir

[PATCH 07/11] staging: comedi: jr3_pci: remove next_time_max member

The `next_time_max` member of `struct jr3_pci_subdev_private` is assigned to, but never read. Remove it. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/jr3_pci.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/come

[PATCH 09/11] staging: comedi: jr3_pci: re-work struct jr3_pci_subdev_private range

The `range` member of `struct jr3_pci_subdev_private` is an array of a tag-less `struct` type whose layout is similar to `struct comedi_lrange`. Both `struct` types end with a member also called `range`. In the case of tag-less `struct` type, it is a single `struct comedi_krange`. In the case of

[PATCH 05/11] staging: comedi: jr3_pci: re-work firmware copyright display

If debug messages are enabled, the card initialization done in `jr3_pci_auto_attach()` spits out 24 (0x18) debug messages to show the null-terminated copyright string embedded in the firmware, one character at a time, including the ASCII NUL characters at the end. Factor out the copyright display

[PATCH 01/11] staging: comedi: jr3_pci: fix possible null pointer dereference

For some reason, the driver does not consider allocation of the subdevice private data to be a fatal error when attaching the COMEDI device. It tests the subdevice private data pointer for validity at certain points, but omits some crucial tests. In particular, `jr3_pci_auto_attach()` calls `jr3_

[PATCH 10/11] staging: comedi: jr3_pci: pass transform by reference

Local function `set_transforms` has a parameter of type `struct jr3_pci_transform`. This has a size 32 bytes, which is quite large for passing around in a function call. Change it to use type `const struct jr3_pci_transform *`. (In practice, it is probably inlined by the compiler anyway, but doi

[PATCH 11/11] staging: comedi: jr3_pci: replace devpriv->iobase with dev->mmio

The "jr3_pci" driver currently uses the `iobase` member of its private device data `struct jr3_pci_dev_private` to store a pointer to its ioremapped register region. Use the `mmio` member of the `struct comedi_device` to store this instead, and remove the `iobase` member. The `iobase` member was o

[PATCH 04/11] staging: comedi: jr3_pci: struct comedi_lrange should normally be const

Fix three checkpatch warnings of the form: WARNING: struct comedi_lrange should normally be const Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/jr3_pci.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/driver

[PATCH 06/11] staging: comedi: jr3_pci: remove unneeded 'spriv' checks

If `jr3_pci_auto_attach()` returns with no error, we can now be sure that the COMEDI subdevice private data structures have been allocated. Remove the tests for a valid pointer to the private data structure in `jr3_pci_ai_insn_read()`, `jr3_pci_open()`, and `jr3_pci_poll_subdevice()`, since they wi

[PATCH 00/11] staging: comedi: jr3_pci: some bug fixes and cleanups

Some bug-fixes and clean-ups for the jr3_pci driver. I have more clean-up patches for this driver waiting in the wings, but the series was getting a bit long. Patches 01 to 03 fix various bugs. Patches 04 and 05 fix some checkpatch warnings. Patch 08 actually introduces a couple more checkpatch

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > +static void csi2_dphy_init(struct csi2_dev *csi2) > > +{ > > + /* > > +* FIXME: 0x14 is derived from a fixed D-PHY reference > > +* clock from the HSI_TX PLL, a

Re: [PATCH v4 00/36] i.MX Media Driver

On Fri, Feb 17, 2017 at 11:39:11AM +0100, Philipp Zabel wrote: > On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: > > > > > > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > > >On Wed, Feb 15

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile | 1 + > drivers/staging/media/imx/imx6-

Re: [PATCH v4 00/36] i.MX Media Driver

On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > >On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > > >>In version 4: > >

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

On Fri, 17 Feb 2017, Vitaly Kuznetsov wrote: > Thomas Gleixner writes: > > On Wed, 15 Feb 2017, Vitaly Kuznetsov wrote: > >> Actually, we already have an implementation of TSC page update in KVM > >> (see arch/x86/kvm/hyperv.c, kvm_hv_setup_tsc_page()) and the update does > >> the following: > >>

Re: [PATCH v2 0/3] x86/vdso: Add Hyper-V TSC page clocksource support

Thomas Gleixner writes: > On Wed, 15 Feb 2017, Vitaly Kuznetsov wrote: >> Actually, we already have an implementation of TSC page update in KVM >> (see arch/x86/kvm/hyperv.c, kvm_hv_setup_tsc_page()) and the update does >> the following: >> >> 0) stash seq into seq_prev >> 1) seq = 0 making all

[PATCH v3 6/6] drivers: staging: fix coding style issue of aligning comments properly

This is 06th patch to file ks_wlan.h in order to fix coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch.pl Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in sub

[PATCH v3 5/6] drivers: staging: fix coding style issue of using __func__ instead of __FUNCTION__

This is 05th patch to file ks_wlan.h which fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch.pl Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject driver

[PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk

This is 04th patch to ks_wlan.h fixing coding style issue of using pr_notice instead of printk, warning as issued by checkpatch.pl Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject drivers/staging/ks7010/ks_wlan.h |

[PATCH v3 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces

This is 03rd patch to file ks_wlan.h fixing coding style issue of using tabs instead of spaces at start of line, error as issued by checkpatch.pl Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject drivers/staging/ks7

[PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

This is 02nd patch to file ks_wlan.h file fixing error of enclosing complex macro value in parentheses Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject - incorporated review comment of correct indentation for do sta

[PATCH v3 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters

This is patch 01 to ks_wlan.h file in order to fix warning of line over 80 characters, as issued by checkpatch.pl Signed-off-by: Chetan Sethi --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject drivers/staging/ks7010/ks_wlan.h | 11 ++-

[PATCH] Staging: BCM2835-Audio: bcm2835-pcm: single line block statement braces fix

A single line statement under an if clause doesn't require braces {} Signed-off-by: Daniel Perez de Andres --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm283

Re: [PATCH v4 18/36] media: Add i.MX media core driver

On Thu, 2017-02-16 at 17:33 -0800, Steve Longerbeam wrote: > > On 02/16/2017 05:02 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > >> + > >> +- Clean up and move the ov5642 subdev driver to drivers/media/i2c, and > >> + create the binding docs for it.