Hi, Chetan,
On Fri, Feb 17, 2017 at 02:51:11PM +0900, chetan wrote:
Is this fix really necessary?
This way of fixing is seen across multiple places in the kernel, so it
seems standard way of handling these kind of errors from checkpatch.
That's fair. I suppose the correct way to go about it w
Hi Matthew,
> Is this fix really necessary?
This way of fixing is seen across multiple places in the kernel, so it
seems standard way of handling these kind of errors from checkpatch.
> On that note though, if it is going to be added I think it would make
> sense to get the indentation correct wi
Fix checkpatch check notices by simplifying comparisons to NULL.
Signed-off-by: Olav Haugan
---
drivers/staging/speakup/synth.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02ba06d
Fix checkpatch warning about line being over 80 characters.
Signed-off-by: Olav Haugan
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index b57315110e67..8340748ae9cb 10
v2:
-Split fixes into separate patches
Olav Haugan (2):
staging: speakup: (coding style) Simplify comparisons to NULL
staging: speakup: (coding style) Limit line to 80 chars
drivers/staging/speakup/synth.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
--
Qual
Hi Chetan,
On Fri, Feb 17, 2017 at 12:08:02PM +0900, Chetan Sethi wrote:
+do {if (KS_WLAN_DEBUG > (n)) \
+ printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ } while (0)
Is this fix really necessary? I know checkpatch is complaining, b
This is 06th patch to file ks_wlan.h in order to fix coding style issue
of having block comments using a trailing */ on a separate line, warning
as issued by checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
This is 05th patch to file ks_wlan.h which fixes coding style issue of
using __func__ instead of gcc specific __FUNCTION__, warning as issued by
checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
This is 04th patch to ks_wlan.h fixing coding style issue of using
pr_notice instead of printk, warning as issued by checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h
This is 03rd patch to file ks_wlan.h fixing coding style issue of using
tabs instead of spaces at start of line, error as issued by checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/k
This is 02nd patch to file ks_wlan.h file fixing error of enclosing
complex macro value in parentheses and do-while statement has been used
to prevent further warnings from checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 5 +++--
1 file changed, 3 insertions(+),
This is patch 01 to ks_wlan.h file in order to fix warning of line over
80 characters, as issued by checkpatch.pl
Signed-off-by: Chetan Sethi
---
drivers/staging/ks7010/ks_wlan.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/dr
On 02/16/2017 05:02 AM, Philipp Zabel wrote:
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
+
+- Clean up and move the ov5642 subdev driver to drivers/media/i2c, and
+ create the binding docs for it.
This is done already, right?
I cleaned up ov5640 and moved it to drivers/m
Hi Stephen,
[auto build test WARNING on next-20170216]
[cannot apply to linus/master linux/master tip/x86/core v4.9-rc8 v4.9-rc7
v4.9-rc6 v4.10-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Thu, Feb 16, 2017 at 06:12:58PM -0500, Nathan Howard wrote:
> Fix various coding style issues as per checkpatch.pl.
You need to be very specific as to exactly what you are fixing here.
And please only do one type of thing per patch.
Please fix up and resend.
thanks,
greg k-h
On 02/16/2017 04:51 PM, Fabio Estevam wrote:
Hi Steve,
On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam
wrote:
Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor.
The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux.
The OV5640 connects to the inp
Hi Steve,
On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam
wrote:
> Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor.
>
> The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux.
>
> The OV5640 connects to the input port on the MIPI CSI-2 receiver on
> mi
Changed bit swifting operators to BIT macros (preferred),
This change will also solve the preferred space surrounding
the operator checks.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.h | 20 ++--
drivers/staging/ks7010/ks_wlan.h | 30 +++
Fix various coding style issues as per checkpatch.pl.
Signed-off-by: Nathan Howard
---
drivers/staging/bcm2835-audio/bcm2835.h | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.h
b/drivers/staging/bcm2835-
On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote:
>
>
> On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote:
> >On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote:
> >>In version 4:
> >
> >With this version, I get:
> >
> >[28762.892053] imx6-mipi-csi2: LP-11 timeo
Several spelling errors in comments
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel.c | 10 +-
drivers/hv/hv_kvp.c | 10 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 81a80c82f1bd..deb852238b2d 10064
Minor changes to align hyper-v vmbus include files with current
linux kernel style.
Signed-off-by: Stephen Hemminger
---
drivers/hv/hyperv_vmbus.h | 16
include/linux/hyperv.h| 12 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/hv/hyper
This table is immutable and should be const.
Cleanup indentation and whitespace for this as well.
Signed-off-by: Stephen Hemminger
---
drivers/hv/channel_mgmt.c | 48 +++
drivers/hv/hyperv_vmbus.h | 2 +-
drivers/hv/vmbus_drv.c| 2 +-
3 files cha
Don't initialize variables that are then set a few lines later.
Signed-off-by: Stephen Hemminger
---
drivers/hv/ring_buffer.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index d0ff5b41161a..52d0556a5a25 100
Compiling with warnings enabled finds missing prototype for
hv_do_hypercall.
Signed-off-by: Stephen Hemminger
---
arch/x86/hyperv/hv_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
index db64baf0e500..d4a5f820af5d 1
hv_ringbuffer_read cleanup.
Signed-off-by: Stephen Hemminger
---
drivers/hv/ring_buffer.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 52d0556a5a25..8a249740b4b4 100644
--- a/drivers/hv/ring_buffer.c
+++ b/dri
The per-cpu channel list is now referred to in the interrupt
routine, but this is racy since list might be modified at same time.
This is mostly safe since the host will not normally generate
an interrupt when channel is being deleted but if it did then there
would be a use after free problem.
To
No need for empty return at end of void function
Signed-off-by: Stephen Hemminger
---
drivers/hv/hv_balloon.c | 2 --
drivers/hv/hv_fcopy.c| 2 --
drivers/hv/hv_kvp.c | 2 --
drivers/hv/hv_snapshot.c | 2 --
drivers/hv/ring_buffer.c | 2 --
drivers/hv/vmbus_drv.c | 2 --
include/linu
This is update to earlier set of patches. Added the time limit
patch and dropped the low_latency removal patch.
Stephen Hemminger (9):
vmbus: use rcu for per-cpu channel list
vmbus: only reschedule tasklet if time limit exceeded
hyperv: fix warning about missing prototype
vmbus: remove us
The change to reschedule tasklet if more data arrives in ring buffer
can cause performance regression if host timing is such that the
next response happens in small window.
Go back to a modified version of the original looping behavior.
If the race occurs in a small time, then loop. But if the tas
On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote:
On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote:
In version 4:
With this version, I get:
[28762.892053] imx6-mipi-csi2: LP-11 timeout, phy_state = 0x
[28762.899409] ipu1_csi0: pipeline_set_stream failed with -1
On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote:
> In version 4:
With this version, I get:
[28762.892053] imx6-mipi-csi2: LP-11 timeout, phy_state = 0x
[28762.899409] ipu1_csi0: pipeline_set_stream failed with -110
--
RMK's Patch system: http://www.armlinux.org.uk/devel
On Fri, 17 Feb 2017, simran singhal wrote:
> Replace a mix of tabs and spaces indentation by tabs only.
>
> Fixed checkpatch warning "Statements should start on a tabstop" in
> rtl8192u module.
>
> Signed-off-by: simran singhal
Acked-by: Julia Lawall
> ---
>
> v2:
>-Modified "warnings"
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8192u module.
Signed-off-by: simran singhal
---
v2:
-Modified "warnings" to "warning" in the patch Subject.
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |
On Fri, 17 Feb 2017, simran singhal wrote:
> This is a nonfunctional change, declare register bit values with BIT()
> helper macro.
>
> Fix the checkpatch.pl issue:
> CHECK: Prefer using the BIT macro replacing
> bit shifting on 1 with the BIT(x) macro.
>
> The BIT() macro will make all the cons
This is a nonfunctional change, declare register bit values with BIT()
helper macro.
Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro replacing
bit shifting on 1 with the BIT(x) macro.
The BIT() macro will make all the constants explicitly 'unsigned', which
helps to avoid the warnin
The subject line says "warnings", but there seems to be only one.
julia
On Fri, 17 Feb 2017, simran singhal wrote:
> Replace a mix of tabs and spaces indentation by tabs only.
>
> Fixed checkpatch warning "Statements should start on a tabstop" in
> rtl8192u module.
>
> Signed-off-by: simran sing
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8192u module.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Sorry for replying properly.
On Fri, Feb 17, 2017 at 1:16 AM, Greg KH wrote:
> On Fri, Feb 17, 2017 at 12:49:54AM +0530, SIMRAN SINGHAL wrote:
>> I am attaching the screenshot of what I am getting from the
>> script get_maintainer.pl.
>
> I can't read images from a text email client.
ok, will ke
Octal permissions should be used instead of symbolic ones for easier
reading.
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
Signed-off-by: simran singhal
---
v2:
-Added more informatio
Removed an empty line.
Signed-off-by: Georgios Emmanouil
---
drivers/staging/wlan-ng/prism2mgmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index 0e671c3..e23a0d0 100644
--- a/drivers/staging/wlan-ng/prism2mgmt
On Fri, 17 Feb 2017, simran singhal wrote:
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> This warning is detected by checkpatch.pl
This one has all the pieces in the right place, but please redo with the
suggestions on the pr
On Thu, Feb 16, 2017 at 08:02:58PM +0100, Daniel Perez wrote:
> Hi Greg,
> I agree with you, that patch looks ugly. I came about this (non) coding style
> mistake by running scripts/checkpatch --file --terse on speakup_decp.c . I
> re-ran it just now on the unpatched version to check, and I get the
On Fri, Feb 17, 2017 at 12:49:54AM +0530, SIMRAN SINGHAL wrote:
> I am attaching the screenshot of what I am getting from the
> script get_maintainer.pl.
I can't read images from a text email client.
I totally don't understand this conversation at all, what is the
question? What is this concerni
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
On Fri, 17 Feb 2017, simran singhal wrote:
> linux-ker...@vger.kernel.org
> Bcc:
> Subject: [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with
> octal permissions
> Reply-To:
Your email did not come out well. This part should not be in the message.
Try sending the message to you
linux-ker...@vger.kernel.org
Bcc:
Subject: [PATCH 1/3] staging: rtl8192u: Replace symbolic permissions with
octal permissions
Reply-To:
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
Signed
On 02/16/2017 03:54 AM, Philipp Zabel wrote:
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
Add bindings documentation for the i.MX media driver.
Signed-off-by: Steve Longerbeam
---
Documentation/devicetree/bindings/media/imx.txt | 66 +
1 file changed, 6
I am attaching the screenshot of what I am getting from the
script get_maintainer.pl.
Thanks,
Simran
On Fri, Feb 17, 2017 at 12:23 AM, Greg KH wrote:
> On Fri, Feb 17, 2017 at 12:20:22AM +0530, SIMRAN SINGHAL wrote:
>> Then which tree it applies to.
>
> I have no idea, you wrote it, not me :)
>
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/
On Thu, Feb 16, 2017 at 10:44:16AM -0800, Steve Longerbeam wrote:
> On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote:
> >[8.012191] imx_media_common: module is from the staging directory, the
> >quality is unknown, you have been warned.
> >[8.018175] imx_media: module is from the sta
I didn't mean what you get. I just want to say I am a beginner and like to
contribute to Linux kernel. But at present, I am in learning mode.
I never mean that I am doing this for learning C or C++ but yes for
contributing to
Linux kernel in every possible way.
And, would be very happy if you gui
On 02/16/2017 06:20 AM, Russell King - ARM Linux wrote:
On Thu, Feb 16, 2017 at 01:09:35PM +, Russell King - ARM Linux wrote:
More crap.
If the "complete" method fails (or, in fact, anything in
v4l2_async_test_notify() fails) then all hell breaks loose, because
of the total lack of clea
Hi Greg,
I agree with you, that patch looks ugly. I came about this (non) coding style
mistake by running scripts/checkpatch --file --terse on speakup_decp.c . I
re-ran it just now on the unpatched version to check, and I get the following:
drivers/staging/speakup/speakup_decpc.c:88: WARNING: Bloc
On Fri, Feb 17, 2017 at 12:20:22AM +0530, SIMRAN SINGHAL wrote:
> Then which tree it applies to.
I have no idea, you wrote it, not me :)
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinf
Then which tree it applies to.
Thanks,
Simran
On Fri, Feb 17, 2017 at 12:05 AM, Greg KH wrote:
> On Wed, Feb 15, 2017 at 01:46:27AM +0530, simran singhal wrote:
>> Fixed checkpatch.pl warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: simran singhal
>> ---
>> d
On 02/16/2017 04:40 AM, Russell King - ARM Linux wrote:
On Thu, Feb 16, 2017 at 11:52:06AM +, Russell King - ARM Linux wrote:
On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote:
+static const struct platform_device_id imx_csi_ids[] = {
+ { .name = "imx-ipuv3-csi" },
+
On Wed, Feb 15, 2017 at 05:06:27PM +0800, maomao xu wrote:
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37: warning: incorrect
> type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:564:37:expected
> unsigned short [unsigned] [usertype] len
Fix for "WARNING: Avoid multiple line dereference - prefer
'mc_msi_domain->host_data'" found by checkpatch.pl in
bus/irq-gic-v3-its-fsl-mc-msi.c.
Signed-off-by: Lucian Zala
---
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Thu, Feb 16, 2017 at 06:33:38PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/dr
On Thu, Feb 16, 2017 at 06:33:25PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69
> +
> 1 file changed, 35 insertions(+), 34 deletions(-)
>
On Thu, Feb 16, 2017 at 06:30:51PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87
> ---
> 1 file changed, 47 insertions(+), 40 deletions(-)
>
On Wed, Feb 15, 2017 at 01:46:27AM +0530, simran singhal wrote:
> Fixed checkpatch.pl warning:
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/r8190_rtl8256.h | 19 +--
> 1 file changed, 9 insertions(+), 10 de
On Wed, Feb 15, 2017 at 01:45:49AM +0530, simran singhal wrote:
> Fixing the following checkpatch.pl errors and warning:
> WARNING: Block comments use * on subsequent lines
>
> CHECK: Please don't use multiple blank lines
Don't do different things in the same patch :(
___
On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote:
> Fix the following checkpatch.pl error and warnings:
> WARNING: please, no space before tabs
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
On Wed, Feb 15, 2017 at 01:45:18AM +0530, simran singhal wrote:
> Fixing the following checkpatch.pl errors and warning:
> WARNING: Block comments use * on subsequent lines
>
> CHECK: Please don't use multiple blank lines
>
> CHECK: Alignment should match open parenthesis
>
> CHECK: spaces prefe
On Wed, Feb 15, 2017 at 01:48:13PM +0530, SIMRAN SINGHAL wrote:
> On Wed, Feb 15, 2017 at 9:01 AM, Joe Perches wrote:
> > On Wed, 2017-02-15 at 08:52 +0530, SIMRAN SINGHAL wrote:
> >> Yes, I totally agree with joe.
> >>
> >> But as there is no coding style issue in this patch.
> >
> > Style is mor
On 02/16/2017 03:37 AM, Russell King - ARM Linux wrote:
Two problems.
On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote:
media: imx: propagate sink pad formats to source pads
1) It looks like all cases aren't being caught:
- entity 74: ipu1_csi0 (3 pads, 4 links)
On Wed, Feb 15, 2017 at 02:01:47PM +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
>
> Signed-off-by: Arushi Singhal
> ---
> drivers/staging/xgifb/vb_init.h | 2 +-
> 1 file changed, 1 insertion(+),
On Wed, Feb 15, 2017 at 10:24:26PM +0900, Chetan Sethi wrote:
> This is patch to ks_wlan.h which fixes various coding style errors and
> warnings issued by checkpatch.pl
What do you mean by "various"? Always be very specific as to what you
are doing, and why you are doing it.
And only do one typ
On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote:
> move else if statement to a single line
>
> Signed-off-by: Maksymilian Piechota
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng
On Tue, Feb 14, 2017 at 11:16:41PM -0500, Bo YU wrote:
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Bo YU
> ---
> drivers/staging/wlan-ng/p80211metastruct.h | 88
> ++--
> 1 file changed, 44 insertions(+), 44 deletions(-)
Your patch is
On 02/16/2017 03:29 AM, Philipp Zabel wrote:
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
[...]
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c
b/drivers/staging/media/imx/imx-ic-prpencvf.c
index dd9d499..c43f85f 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
On Wed, Feb 15, 2017 at 08:39:35PM -0800, Olav Haugan wrote:
> Fix checkpatch warnings.
Which warning is that? Please be very specific and do not mix different
types of fixes into one patch.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverpro
On Wed, Feb 15, 2017 at 12:02:43PM +0100, Daniel Perez wrote:
> Fixed a coding style issue (block comments misasligned and code indents
> not done with tabs)
>
> Signed-off-by: Daniel Perez
> ---
> drivers/staging/speakup/speakup_decpc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-
On 02/16/2017 03:05 AM, Russell King - ARM Linux wrote:
On Wed, Feb 15, 2017 at 06:19:30PM -0800, Steve Longerbeam wrote:
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/drivers/staging/media/imx/imx-media-csi.c
index ae24b42..3cb97e2 100644
--- a/drivers/staging/media/imx/imx-media-
On 02/16/2017 02:28 AM, Russell King - ARM Linux wrote:
On Wed, Feb 15, 2017 at 06:19:25PM -0800, Steve Longerbeam wrote:
Adds MIPI CSI-2 Receiver subdev driver. This subdev is required
for sensors with a MIPI CSI2 interface.
Signed-off-by: Steve Longerbeam
Just like I reported on the 30th
On 02/16/2017 02:27 AM, Russell King - ARM Linux wrote:
On Wed, Feb 15, 2017 at 06:19:20PM -0800, Steve Longerbeam wrote:
Add the core media driver for i.MX SOC.
Signed-off-by: Steve Longerbeam
Just as I reported on the 30th January:
Applying: media: Add i.MX media core driver
.git/rebase-
On Wed, 15 Feb 2017, Vitaly Kuznetsov wrote:
> Actually, we already have an implementation of TSC page update in KVM
> (see arch/x86/kvm/hyperv.c, kvm_hv_setup_tsc_page()) and the update does
> the following:
>
> 0) stash seq into seq_prev
> 1) seq = 0 making all reads from the page invalid
> 2) s
On 16/02/17 14:05, Cheah Kok Cheong wrote:
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achiev
On Thu, Feb 16, 2017 at 04:33:37PM +0100, Anthony Brandon wrote:
> Fix some warnings reported when running make C=1 M=drivers/staging/fbtft.
That doesn't say what you are fixing. Please be a lot more descriptive
about why you are making the change...
thanks,
greg k-h
___
Spaces should be added around operators to improve readability
and are required in some cases.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/ks7010/ks_hostif.h | 64 +-
drivers/staging/ks7010/ks_wlan.h |
> From: Maxime Rossi Bellom
>
> sparse warn about _u32 used for two arguments in function
> osc_match_base instead of enum ldlm_type and enum ldlm_mode as
> used in the prototype.
>
> Signed-off-by: Maxime Rossi Bellom
One of the pieces of a earlier patch I broke up that got lost :-(
Thanks f
Fix some warnings reported when running make C=1 M=drivers/staging/fbtft.
Signed-off-by: Anthony Brandon
---
drivers/staging/fbtft/fb_ra8875.c| 2 +-
drivers/staging/fbtft/fb_watterott.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra887
Multiple blank lines shouldn't be used.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks7010_sdio.c | 1 -
drivers/staging/ks7010/ks_wlan_net.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010/ks7010_sdio.c
index a604c8
A blank line should be added after function/struct/union/enum
declarations.
Signed-off-by: Shiva Kerdel
---
drivers/staging/ks7010/ks7010_sdio.h | 1 +
drivers/staging/ks7010/ks_wlan.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging/ks7010/ks7010_sdio.h
b/drivers/stagi
Missing a blank line after declarations
Signed-off-by: Bo YU
---
drivers/staging/bcm2835-audio/bcm2835-pcm.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 014bf7ab69f4..16127e062661 100644
On Thu, 16 Feb 2017, Bjorn Helgaas wrote:
> On Wed, Feb 15, 2017 at 10:16:32PM +0100, Thomas Gleixner wrote:
>
> > I think I suggested to Jiang to do that 'update with default functions' to
> >
> > - avoid exporting the world and some more
> >
> > - have the flexibility to add new functions to t
On Wed, Feb 15, 2017 at 10:16:32PM +0100, Thomas Gleixner wrote:
> I think I suggested to Jiang to do that 'update with default functions' to
>
> - avoid exporting the world and some more
>
> - have the flexibility to add new functions to the ops w/o updating a
> gazillion of existing usage si
On Thu, Feb 16, 2017 at 01:09:35PM +, Russell King - ARM Linux wrote:
> On Thu, Feb 16, 2017 at 12:40:27PM +, Russell King - ARM Linux wrote:
> > However, the following is primerily directed at Laurent as the one who
> > introduced the BUG_ON() in question...
> >
> > NEVER EVER USE BUG_ON(
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achieved by creating a device during init
to stand
On Thu, Feb 16, 2017 at 10:10:34AM +, Ian Abbott wrote:
> On 15/02/17 06:05, Cheah Kok Cheong wrote:
> >On Mon, Feb 13, 2017 at 11:14:14AM +, Ian Abbott wrote:
> >>On 11/02/17 10:37, Cheah Kok Cheong wrote:
> [snip]
> >>>+static void __exit comedi_test_exit(void)
> >>>+{
> >>>+ comedi_auto
On Thu, Feb 16, 2017 at 02:02:03PM +0100, Philipp Zabel wrote:
> On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
> > +- imx-csi subdev is not being autoloaded as a kernel module, probably
> > + because ipu_add_client_devices() does not register the IPU client
> > + platform devices, bu
On Thu, Feb 16, 2017 at 12:40:27PM +, Russell King - ARM Linux wrote:
> However, the following is primerily directed at Laurent as the one who
> introduced the BUG_ON() in question...
>
> NEVER EVER USE BUG_ON() IN A PATH THAT CAN RETURN AN ERROR.
>
> It's possible to find Linus rants about t
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
> Add the core media driver for i.MX SOC.
>
> Signed-off-by: Steve Longerbeam
> ---
> Documentation/media/v4l-drivers/imx.rst | 542 +
> drivers/staging/media/Kconfig | 2 +
> drivers/stagi
On Thu, Feb 16, 2017 at 11:52:06AM +, Russell King - ARM Linux wrote:
> On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote:
> > +static const struct platform_device_id imx_csi_ids[] = {
> > + { .name = "imx-ipuv3-csi" },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(platform, im
On Wed, Feb 15, 2017 at 01:47:55PM +0100, walter harms wrote:
>
>
> Am 15.02.2017 13:25, schrieb Dan Carpenter:
> > We should free gdev[0] so the > should be >=.
> >
> > Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera
> > driver.")
> > Signed-off-by: Dan Carpenter
> >
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote:
> Add bindings documentation for the i.MX media driver.
>
> Signed-off-by: Steve Longerbeam
> ---
> Documentation/devicetree/bindings/media/imx.txt | 66
> +
> 1 file changed, 66 insertions(+)
> create mode 1006
On Wed, Feb 15, 2017 at 06:19:22PM -0800, Steve Longerbeam wrote:
> +static const struct platform_device_id imx_csi_ids[] = {
> + { .name = "imx-ipuv3-csi" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(platform, imx_csi_ids);
> +
> +static struct platform_driver imx_csi_driver = {
> + .probe
Two problems.
On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote:
> media: imx: propagate sink pad formats to source pads
1) It looks like all cases aren't being caught:
- entity 74: ipu1_csi0 (3 pads, 4 links)
type V4L2 subdev subtype Unknown flags 0
de
1 - 100 of 109 matches
Mail list logo
