> From: Thomas Gleixner [mailto:t...@linutronix.de]
> Sent: Saturday, February 11, 2017 02:02
> ...
> That's important if the stuff happens cross CPU. If the update happens on
> the same CPU then this is a different story and as there are VMexits
> involved they might provide the required ordering
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 61 +++---
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/staging/r
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
b/drivers/staging/rtl8192u/ieee802
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
b/drivers/staging/rtl81
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87 ---
1 file changed, 47 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
b/drivers/stagin
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 91 +++
1 file changed, 58 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
b/drivers/stagin
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 290 +++---
1 file changed, 150 insertions(+), 140 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 28 +++---
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
b/drivers/staging/
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 164 ++---
1 file changed, 82 insertions(+), 82 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
b/drivers/staging/rtl8192u/ieee80
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 71 +++---
1 file changed, 36 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/s
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/ieee80211_module.c | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/st
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
b/drivers/staging/rtl8192u
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8180_93cx6.c | 36 +-
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c
b/drivers/staging/rtl8192u/
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
b/drivers/staging/rtl8192u/ieee802
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8190_rtl8256.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h
b/drivers/staging/rtl8192u/r8190_rtl8
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U.h | 39 ++-
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U.h
b/drivers/staging/rtl8192u/r8192
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_core.c | 70 +-
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_dm.c | 175 +++
1 file changed, 97 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
Version #1 had a problem where I commented out valid code.
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 82
1 file changed, 52 insertions(+), 30 deletions(-)
diff --git a
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_hw.h | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_hw.h
b/drivers/staging/rtl8192u/r8192U_hw.
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_phy.c | 41 +++
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_phy.c
b/drivers/staging/rtl8192u/r
Fixed style of block comments.
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
index f
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_firmware.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index
Fixed style of block comments across all of the rtl8192u driver
This driver has a lot of code commented out that could be deleted, I have not
changed that.
Version #1 had a bug in 04/25 where I commented out valid code.
Derek Robson (25):
Staging: rtl8192u: r819xU_phy.c - style fix
Staging
On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman
wrote:
> On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
>> Fix following errors:
>>
>> ERROR: do not initialise statics to NULL
>> +static struct snd_card *g_card = NULL;
>>
>> ERROR: do not initialise statics to NULL
>> +static struct
(resending text only)
On 02/02/2017 02:36 AM, Laurent Pinchart wrote:
Hi Steve,
Thank you for the patch. Many of the comments below apply to the ov5642 driver
too, please take them into account when reworking patch 23/24.
On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote:
This driver is
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/rxtx.c | 54 +--
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/stagin
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/firmware.c | 34 +-
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656/rf.c | 12 ++--
drivers/staging/vt6
On Mon, Feb 13, 2017 at 03:26:37AM +0530, simran singhal wrote:
> Fix the checkpatch.pl issue:
> CHECK: Prefer using the BIT macro replacing
> bit shifting on 1 with the BIT(x) macro.
>
> Signed-off-by: simran singhal
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140
> --
Fix the checkpatch.pl issue:
CHECK: Prefer using the BIT macro replacing
bit shifting on 1 with the BIT(x) macro.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 -
1 file changed, 70 insertions(+), 70 deletions(-)
diff --git a/driv
Fixed a coding style issue, where an octal value was needed insted of decimal.
Signed-off-by: Ran Algawi
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/media/bc
Fix multiple checkpatch.pl warnings
WARNING: function definition argument '..' should also have an identifier name
Signed-off-by: Jacob Zachariah
---
drivers/staging/xgifb/vb_setmode.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/vb
On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote:
> Hello Greg,
> First, I appreciate you taking the time to educate me. I used the checkpatch
> script on the file I fixed and he reported the line as an error. Do you
> consider all checkpatch warnings/error/checks as coding style fixes?
Hello Greg,
I apperaciate you taking the time to educate me.
Do you consider all checkpatch errors/warnnings/checks as code style
fixes?
With regards,
Ran A.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mail
Hi,
Static analysis via CoverityScan picked up an issue in
cmpk_handle_query_config_rx where the following operation on an u8 is
clearly not correct:
rx_query_cfg.cfg_action = (pmsg[4] & 0x8000) >> 31;
The result of this operation is always zero. I suspect this should be:
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8192u module.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
b/drivers
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
This warning is detected by checkpatch.pl
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channe
This patch fixes the following code style errors:
ERROR: code indent should use tabs where possible
Signed-off-by: Mandel Benjamin
---
drivers/staging/vc04_services/interface/vchi/vchi_common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_service
On Sun, Feb 12, 2017 at 11:17:58AM +0530, simran singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro as it's
> extensively used by other function in this driver.
>
> This was done with coccinelle:
> @@ int g; @@
>
> -(1 << g)
> +BIT(g)
>
> Signed-off-by: simran singhal
On Sat, Feb 11, 2017 at 10:53:33PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8192u/r819xU_cmdpkt.c | 99
> +++-
> 1 file changed, 60 insertions(+), 39 deletions(-)
>
On Sat, Feb 11, 2017 at 10:57:28PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69
> +
> 1 file changed, 35 insertions(+), 34 deletions(-)
>
On Sat, Feb 11, 2017 at 12:41:29AM +0200, Ran Algawi wrote:
> Fixed an error where the system was given a code in the form of decimal
> instead of octal.
It's not really an "error", right? Please be more descriptive of
exactly what is going on here (hint, it's a coding style warning...)
thanks,
On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
> Fix following errors:
>
> ERROR: do not initialise statics to NULL
> +static struct snd_card *g_card = NULL;
>
> ERROR: do not initialise statics to NULL
> +static struct bcm2835_chip *g_chip = NULL;
>
> Signed-off-by: Man Choy
> ---
>
On Sat, Feb 11, 2017 at 07:11:31PM +0900, beny wrote:
> This patch fixes the following code style errors:
>
> ERROR: code indent should use tabs where possible
> ERROR: space prohibited after that open parenthesis '('
>
> Signed-off-by: Mandel Benjamin
This name doesn't match up with your name
On Sat, Feb 11, 2017 at 12:12:38PM -0500, James Simmons wrote:
> From: wang di
>
> Do not migrate root inode.
That says _what_ happens here, but you aren't giving any hint as to
_why_ this is needed.
I'll take this, but be more careful about your changelog comments in the
future...
thanks,
gr
On Sun, Feb 12, 2017 at 05:55:34AM -0500, Brian Masney wrote:
> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
>
> Signed-off-by: Brian Masney
Sorry, Jonathan, I forgot to run git format-patch with --no-renames and
didn't realize until the emails went out. I attached the
The sysfs attribute in_proximity_sampling_frequency_available currently
shows the values 1 3 5 10 13 20 83 100. These values are supposed to
correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms).
When passing in a sampling frequency of 3, it actually uses a sleep
time of 200ms inste
Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
Signed-off-by: Brian Masney
---
drivers/iio/light/Kconfig | 10 ++
drivers/iio/light/Makefile | 1 +
drivers/{staging => }/iio/light/isl29028.c | 0
drivers/staging/iio/light/Kconfig
This is hopefully the last of the changes that are needed to move
this driver out of staging.
Datasheet:
http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29028.pdf
Changes since v1:
- in_proximity_sampling_frequency_available sysfs attribute now shows
decimals.
Brian Masney (2):
This patch fixes the issue by aligning the * on each line in block
comments.
Signed-off-by: Arushi Singhal
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/main.c | 2 +-
drivers/staging
This patch fixes the issue by aligning the * on each line in block
comments.
Signed-off-by: Arushi Singhal
---
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/main.c | 2 +-
drivers/sta
The local socket address is defined as a __be32 value. However, if the
local ip address is not given, then the constant INADDR_ANY is used.
This patch converts INADDR_ANY to __be32 for type consistency.
Fixes the following sparse warnings:
drivers/staging/lustre/lnet/lnet/lib-socket.c:396:41: w
Removing unnecessary parentheses from an expression of the form &(x).
Issue found by checkpatch.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee
Fix following errors:
ERROR: do not initialise statics to NULL
+static struct snd_card *g_card = NULL;
ERROR: do not initialise statics to NULL
+static struct bcm2835_chip *g_chip = NULL;
Signed-off-by: Man Choy
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions
58 matches
Mail list logo
