This patch fixes following checkpatch.pl
warnings: WARNING:do not add new typedefs.
All the related files have been modified.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++--
.../staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 4 ++--
.../
Change permissions to octal style.
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c
b/drivers/staging/iio/im
Change permissions to octal style.
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index ee741c012b92..e49f8845f923 100644
In Linux kernel 4.9-rc1, the function ib_get_dma_mr()
was removed and a second parameter was added to ib_alloc_pd().
As this broke the building of the ko2iblnd module in
staging, the Kconfig for LNet has marked ko2iblnd as broken
and stopped building it.
This patch fixes this breakage by:
- Remov
> -Original Message-
> From: Stephen Hemminger
> Sent: Friday, February 10, 2017 8:39 AM
> To: Greg KH ; KY Srinivasan
>
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; leann.ogasaw...@can
This patch replaces bit shifting on 1 with the BIT(x) macro as it's
extensively used by other function in this driver.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 188 -
> -Original Message-
> From: k...@exchange.microsoft.com [mailto:k...@exchange.microsoft.com]
> Sent: Saturday, February 11, 2017 7:43 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.c
> -Original Message-
> From: Jess Frazelle [mailto:m...@jessfraz.com]
> Sent: Friday, February 10, 2017 5:38 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; Bjorn Helgaas ; Keith
> Busch ; open list:Hyper-V CORE AND DRIVERS
> ; open list:PCI SUBSYSTEM p...@vger.kernel.or
Fix a checkpatch.pl WARNING: line over 80 characters
Signed-off-by: Jacob Zachariah
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_
This fixes the following checkpatch.pl warnings:
WARNING: printk() should include KERN_ facility level
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/
Fix 'void function return statements are not generally useful'
checkpatch.pl warnings.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/stagin
Fix brace placement errors caught by checkpatch.pl ERROR: that open
brace { should be on the previous line
Signed-off-by: simran singhal
---
.../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 90 --
1 file changed, 30 insertions(+), 60 deletions(-)
diff --git a/drivers/sta
Remove comparison to true and false in if statement.
Problem found usingcheckpatch.pl.
CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++--
1 file changed, 2
This patch fixes the checkpatch issue:
CHECK: No space is necessary after a cast
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
This patch replace explicit NULL comparison with ! or unmark operator to
simplify code.
Reported by checkpatch.pl for comparison to NULL could be
written "!XXX" or "XXX".
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++--
1 file changed, 6 i
This patch remove useless function ieee80211_ccmp_null.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 1 -
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 6 --
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
3 file
This fixes all checkpatch form of this from the Lustre tree: CHECK:
braces {} should be used on all arms of this statement
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/
Checkpatch recommended changes.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
b/drivers/staging/rtl8192u/ieee80211/ieee8021
This patch modifies the assignments into single assignments.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
b/drivers/stag
This patch fixes the checkpatch warning by removing unnecessary space
after a cast.
CHECK: No space is necessary after a cast
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
This patch fixes the checkpatch warning by removing multiple blank
lines.
CHECK: Please don't use multiple blank lines
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8
Thank you all for taking the time to look at this. I'm sorry for
filling your inboxes with my mistakes - as you probably guessed, I'm
new to kernel development, so I really appreciate the feedback.
Perry
On Fri, Feb 10, 2017 at 1:55 PM, Larry Finger wrote:
> On 02/10/2017 12:23 PM, Perry Hooker
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achieved by creating a device during init
to stand
On Fri, Feb 10, 2017 at 7:18 PM, Long Li wrote:
> Hi Bjorn,
>
> This patch and the other one in the series ([Resend PATCH 2/2 v3] pci-hyperv:
> lock pci bus on device eject) have been Acked.
>
> Is there anything else should be done before it can be merged? Please let me
> know.
Sorry, I don't
> Align else if statement to normal kernel style
>
> Maksymilian Piechota (2):
> staging: lustre: move logical continuations at the end of line
> staging: lustre: move else if statement to a single line
Its not lustre :-)
> drivers/staging/wlan-ng/prism2mgmt.c | 6 ++
> 1 file changed
From: wang di
Do not migrate root inode.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7577
Reviewed-on: http://review.whamcloud.com/17669
Reviewed-by: Lai Siyao
Reviewed-by: John L. Hammond
Reviewed-by: Oleg Drokin
Signed-off-by: James Simmons
---
drivers/stag
From: Niu Yawei
ll_migrate() should check reply status before trying to read
reply buffer, checking if request is NULL doesn't make sense.
Signed-off-by: Niu Yawei
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8807
Reviewed-on: https://review.whamcloud.com/23666
Reviewed-by: Andreas Dilge
> On Sat, Jan 28, 2017 at 07:04:33PM -0500, James Simmons wrote:
> > From: wang di
> >
> > Check if the request is NULL, before retrieve reply body
> > from the request.
> >
> > Signed-off-by: wang di
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7396
> > Reviewed-on: http://review.w
This patch series covers all the current fixes for the function
ll_migrate(). Originally only the first patch was submitted but
it was pointed out other flaws existed in the code. Two more
patches that cover those flaws are included in this patch set.
These patches are order dependent.
Niu Yawei (
From: wang di
Check if the request is NULL, before retrieve reply body
from the request.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7396
Reviewed-on: http://review.whamcloud.com/17079
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Signed-off-by: James
On 10/02/17 07:00, Derek Robson wrote:
> Changed file permissions to octal.
> Found with checkpatch.
>
> Signed-off-by: Derek Robson
Applied - thanks,
> ---
> drivers/staging/iio/meter/meter.h | 60
> +++
> 1 file changed, 30 insertions(+), 30 deletions(-)
>
On 06/02/17 04:01, Derek Robson wrote:
> Changed file permissions to octal.
> Found with checkpatch.
>
> Signed-off-by: Derek Robson
Hi Derek,
Someone else got there first I'm afraid. Already changed in the testing branch
of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316
Fixes the following sparse output:
drivers/staging/wlan-ng/p80211conv.c:132:25: warning: cast to restricted __be16
drivers/staging/wlan-ng/p80211conv.c:132:25: warning: cast to restricted __be16
drivers/staging/wlan-ng/p80211conv.c:132:25: warning: cast to restricted __be16
drivers/staging/wlan-ng
This patch fixes the following code style errors:
ERROR: code indent should use tabs where possible
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Mandel Benjamin
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_common.h
b/drivers/staging/vc04_services/int
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 61 +++---
1 file changed, 36 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/staging/r
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
b/drivers/staging/rtl81
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
b/drivers/staging/rtl8192u/ieee802
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 290 +++---
1 file changed, 150 insertions(+), 140 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
b/drivers/staging/rtl8192u/ieee80
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 91 +++
1 file changed, 58 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
b/drivers/stagin
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 28 +++---
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 69 +
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
b/drivers/staging/
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87 ---
1 file changed, 47 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
b/drivers/stagin
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 164 ++---
1 file changed, 82 insertions(+), 82 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/stag
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/ieee80211_module.c | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
b/drivers/st
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
b/drivers/staging/rtl8192u
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 71 +++---
1 file changed, 36 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/s
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
b/drivers/staging/rtl8192u/ieee802
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8180_93cx6.c | 36 +-
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c
b/drivers/staging/rtl8192u/
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U.h | 39 ++-
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U.h
b/drivers/staging/rtl8192u/r8192
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8190_rtl8256.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h
b/drivers/staging/rtl8192u/r8190_rtl8
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_core.c | 70 +-
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/
On 09/02/17 01:54, Brian Masney wrote:
> Move ISL29028 ALS / Proximity Sensor out of staging and into mainline.
>
> Signed-off-by: Brian Masney
I've taken another quick look at the driver and think this will be fine once
we have cleaned up that small question on the sampling frequencies.
Jonatha
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_dm.c | 175 +++
1 file changed, 97 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_dm.c
b/drivers/staging/rtl8192u/r8
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r8192U_hw.h | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_hw.h
b/drivers/staging/rtl8192u/r8192U_hw.
Fixed style of block comments.
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
index f
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_cmdpkt.c | 99 +++-
1 file changed, 60 insertions(+), 39 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
b/drivers/staging/rtl8192
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_firmware.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index
Fixed style of block comments
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/rtl8192u/r819xU_phy.c | 41 +++
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_phy.c
b/drivers/staging/rtl8192u/r
Fixed style of block comments across all of the rtl8192u driver
Derek Robson (25):
Staging: rtl8192u: r819xU_phy.c - style fix
Staging: rtl8192u: r819xU_firmware.c - style fix
Staging: rtl8192u: r819xU_cmdpkt.h - style fix
Staging: rtl8192u: r819xU_cmdpkt.c - style fix
Staging: rtl8192u
On 09/02/17 01:54, Brian Masney wrote:
> Add entry for the in_proximity_sampling_frequency_available sysfs
> entry to the existing sampling_frequency_available ABI documentation.
>
> Signed-off-by: Brian Masney
Applied.
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 1 +
> 1 file changed, 1 i
On 09/02/17 01:54, Brian Masney wrote:
> Add Brian Masney's copyright to the header for the several rounds of
> staging cleanups that has been done to this driver.
>
> Signed-off-by: Brian Masney
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders
to play with
On 09/02/17 01:54, Brian Masney wrote:
> With the introduction of runtime power management in commit 2db5054ac28d
> ("staging: iio: isl29028: add runtime power management support"), the
> system could go to sleep and turn off the device without notifying the
> runtime power management code. This pa
On 09/02/17 01:54, Brian Masney wrote:
> The sysfs attribute in_proximity_sampling_frequency_available currently
> shows the values 1 3 5 10 13 20 83 100. These values are supposed to
> correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms).
> When passing in a sampling frequency of
On 09/02/17 01:54, Brian Masney wrote:
> This driver in some cases can busy wait for upwards of 100 ms. Since the
> kernel at this point is not running in atomic context, and is running in
> process context, we can safely use msleep() instead. This patch changes
> the two occurrences of mdelay() to
On 09/02/17 01:54, Brian Masney wrote:
> When proximity is enabled in isl29028_enable_proximity(), the function
> msleep() is called with the sampling frequency, which is not correct.
> This patch changes the code to sleep the specified amount of time listed
> in the datasheet instead.
>
> Signed-
On 10/02/17 07:00, Derek Robson wrote:
> Changed file permissions to octal.
> Found with checkpatch.
>
> Signed-off-by: Derek Robson
Applied to the togreg branch of iio.git - pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/meter/meter.h
On Thu, Feb 09, 2017 at 12:28:42PM +, Ian Abbott wrote:
> On 27/01/17 15:55, Cheah Kok Cheong wrote:
> >Currently user can input any value for amplitude and period.
> >This patch set a sane max value for auto-configuration mode.
> >
> >For manual configuration mode, it is assumed this is taken
Dear Ian,
Thank you for taking the trouble to review this.
On Thu, Feb 09, 2017 at 12:25:15PM +, Ian Abbott wrote:
>
> I think the "manual" parameter is misnamed, since this parameter controls
> whether a dummy hardware device is created by the driver or not. Reserved
> COMEDI devices can
70 matches
Mail list logo