On Fri 10-02-17 08:39:11, peter enderborg wrote:
> On 02/09/2017 09:05 PM, Michal Hocko wrote:
> > On Thu 09-02-17 14:21:52, peter enderborg wrote:
> >> Fundamental changes:
> >> 1 Does NOT take any RCU lock in shrinker functions.
> >> 2 It returns same result for scan and counts, so we dont need
On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
> Im not speaking for google, but I think there is a work ongoing to
> replace this with user-space code.
Really? I have not heard this at all, any pointers to whom in Google is
doing it?
> Until then we have to polish this version
Hi Avraham,
Thank you for the patches.
On Thursday 09 Feb 2017 18:57:55 Avraham Shukron wrote:
> Fixed multi-line comments to their preferred style (First line empty)
>
> Signed-off-by: Avraham Shukron
For both of them,
Acked-by: Laurent Pinchart
I've applied the patches to my tree and will
On 02/09/2017 09:05 PM, Michal Hocko wrote:
> On Thu 09-02-17 14:21:52, peter enderborg wrote:
>> Fundamental changes:
>> 1 Does NOT take any RCU lock in shrinker functions.
>> 2 It returns same result for scan and counts, so we dont need to do
>> shinker will know when it is pointless to call s
Im not speaking for google, but I think there is a work ongoing to
replace this with user-space code. Until then we have to polish
this version as good as we can. It is essential for android as it is now.
On 02/09/2017 09:54 PM, Michal Hocko wrote:
> On Thu 09-02-17 21:07:37, Greg KH wrote:
>> On
On 02/09/2017 09:13 PM, Greg Kroah-Hartman wrote:
> On Thu, Feb 09, 2017 at 04:42:35PM +0100, peter enderborg wrote:
>> This collects stats for shrinker calls and how much
>> waste work we do within the lowmemorykiller.
>>
>> Signed-off-by: Peter Enderborg
>> ---
>> drivers/staging/android/Kconfi
Changed file permissions to octal.
Found with checkpatch.
Signed-off-by: Derek Robson
---
drivers/staging/iio/meter/meter.h | 60 +++
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/iio/meter/meter.h
b/drivers/staging/iio/meter
This patch fixes the following sparse warning:
drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted
__le32
Signed-off-by: Perry Hooker
---
drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/u
On Wed, 8 Feb 2017 18:30:56 -0700
k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> The hypercall page only needs to be executable but currently it is setup to
> be writable as well. Fix the issue.
>
> Signed-off-by: K. Y. Srinivasan
> Cc:
> ---
> arch/x86/hyperv/hv_init.c |
On 02/09/2017 03:49 PM, Steve Longerbeam wrote:
On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote:
On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote:
Actually, this exact function already exists as
dw_mipi_dsi_phy_write in
drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it
On 02/08/2017 03:42 PM, Russell King - ARM Linux wrote:
On Wed, Feb 08, 2017 at 03:23:53PM -0800, Steve Longerbeam wrote:
Actually, this exact function already exists as dw_mipi_dsi_phy_write in
drivers/gpu/drm/rockchip/dw-mipi-dsi.c, and it looks like the D-PHY
register 0x44 might contain a f
On Thu, 9 Feb 2017 21:14:25 +0100 (CET)
Thomas Gleixner wrote:
> On Thu, 9 Feb 2017, Stephen Hemminger wrote:
>
> > The actual code looks fine, but the style police will not like you.
> > { should be at start of line on functions.
> > And #else should be at start of line,
> >
> > But maybe this
On Thu, 9 Feb 2017 14:55:50 -0800
Andy Lutomirski wrote:
> On Thu, Feb 9, 2017 at 12:45 PM, KY Srinivasan wrote:
> >
> >
> >> -Original Message-
> >> From: Thomas Gleixner [mailto:t...@linutronix.de]
> >> Sent: Thursday, February 9, 2017 9:08 AM
> >> To: Vitaly Kuznetsov
> >> Cc: x...
On Thu, Feb 9, 2017 at 12:45 PM, KY Srinivasan wrote:
>
>
>> -Original Message-
>> From: Thomas Gleixner [mailto:t...@linutronix.de]
>> Sent: Thursday, February 9, 2017 9:08 AM
>> To: Vitaly Kuznetsov
>> Cc: x...@kernel.org; Andy Lutomirski ; Ingo Molnar
>> ; H. Peter Anvin ; KY Srinivasa
This patch fixes a checkpatch.pl error in bcm2835.c
ERROR: do not initialise statics to NULL
Signed-off-by: William Stevenson
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/st
It appears that our coding style prefers that logical continuations
have the operator at the end of the line. Fix that.
While at it, stick the 'if' after 'else' where it belongs.
Signed-off-by: Frans Klaver
---
drivers/staging/wlan-ng/prism2mgmt.c | 11 +--
1 file changed, 5 insertions(
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
inde
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c
b/drivers/staging/comedi/drive
On Thu 09-02-17 21:07:37, Greg KH wrote:
> On Thu, Feb 09, 2017 at 08:26:41PM +0100, Michal Hocko wrote:
> > On Thu 09-02-17 14:21:45, peter enderborg wrote:
> > > This collects stats for shrinker calls and how much
> > > waste work we do within the lowmemorykiller.
> >
> > This doesn't explain wh
> -Original Message-
> From: Thomas Gleixner [mailto:t...@linutronix.de]
> Sent: Thursday, February 9, 2017 9:08 AM
> To: Vitaly Kuznetsov
> Cc: x...@kernel.org; Andy Lutomirski ; Ingo Molnar
> ; H. Peter Anvin ; KY Srinivasan
> ; Haiyang Zhang ; Stephen
> Hemminger ; Dexuan Cui
> ; linu
On Thu, Feb 09, 2017 at 04:42:35PM +0100, peter enderborg wrote:
> This collects stats for shrinker calls and how much
> waste work we do within the lowmemorykiller.
>
> Signed-off-by: Peter Enderborg
> ---
> drivers/staging/android/Kconfig | 11
> drivers/staging/android/Ma
On Thu, Feb 09, 2017 at 08:26:41PM +0100, Michal Hocko wrote:
> On Thu 09-02-17 14:21:45, peter enderborg wrote:
> > This collects stats for shrinker calls and how much
> > waste work we do within the lowmemorykiller.
>
> This doesn't explain why do we need this information and who is going to
> u
On Thu, 9 Feb 2017, Stephen Hemminger wrote:
> The actual code looks fine, but the style police will not like you.
> { should be at start of line on functions.
> And #else should be at start of line,
>
> But maybe this was just more of exchange mangling the mail.
Looks like.
> +struct ms_hyperv
On Thu 09-02-17 14:21:52, peter enderborg wrote:
> Fundamental changes:
> 1 Does NOT take any RCU lock in shrinker functions.
> 2 It returns same result for scan and counts, so we dont need to do
> shinker will know when it is pointless to call scan.
> 3 It does not lock any other process than t
On Thu 09-02-17 14:21:45, peter enderborg wrote:
> This collects stats for shrinker calls and how much
> waste work we do within the lowmemorykiller.
This doesn't explain why do we need this information and who is going to
use it. Not to mention it exports it in /proc which is considered a
stable
On Thu 09-02-17 14:21:49, peter enderborg wrote:
> This adds subscribtion for changes in oom_score_adj, this
> value is important to android systems.
Why? Who is user of this API?
--
Michal Hocko
SUSE Labs
___
devel mailing list
de...@linuxdriverproject
This patch fixes the checkpatch issue:
CHECK: No space is necessary after a cast
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
This patch replace explicit NULL comparison with ! or unmark operator to
simplify code.
Reported by checkpatch.pl for comparison to NULL could be
written "!XXX" or "XXX".
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++--
1 file changed, 6 i
Why not use existing seqlock's?
-Original Message-
From: Thomas Gleixner [mailto:t...@linutronix.de]
Sent: Thursday, February 9, 2017 9:08 AM
To: Vitaly Kuznetsov
Cc: x...@kernel.org; Andy Lutomirski ; Ingo Molnar
; H. Peter Anvin ; KY Srinivasan
; Haiyang Zhang ; Stephen Hemminger
;
The actual code looks fine, but the style police will not like you.
{ should be at start of line on functions.
And #else should be at start of line,
But maybe this was just more of exchange mangling the mail.
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Th
This patch remove useless function ieee80211_ccmp_null.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 1 -
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 6 --
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 -
3 file
On Thu, 9 Feb 2017, Vitaly Kuznetsov wrote:
> +#ifdef CONFIG_HYPERV_TSCPAGE
> +static notrace u64 vread_hvclock(int *mode)
> +{
> + const struct ms_hyperv_tsc_page *tsc_pg =
> + (const struct ms_hyperv_tsc_page *)&hvclock_page;
> + u64 sequence, scale, offset, current_tick, cur_
Broke argument list so that it won't exceed 80 characters
Signed-off-by: Avraham Shukron
---
drivers/staging/media/omap4iss/iss_video.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/drivers/staging/media/omap4iss/iss_video.c
i
Fixed multi-line comments to their preferred style (First line empty)
Signed-off-by: Avraham Shukron
---
drivers/staging/media/omap4iss/iss_video.c | 38 --
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/d
On Thu, Feb 09, 2017 at 01:01:18PM +, Colin King wrote:
> From: Colin Ian King
>
> Currently newline.flow_control is uninitialized, so it can contain
> any garbage from the stack. I believe it should be initialized with
> GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS
> e
This patch fixes only obvious lines.
There are still more issues.
Signed-off-by: Gioh Kim
---
drivers/staging/greybus/arche-apb-ctrl.c | 5 +++-
drivers/staging/greybus/arche-platform.c | 43 +---
drivers/staging/greybus/audio_codec.c| 5 +++-
drivers/staging/gr
Fix "Octal permissions are preffered than symbolic ones" issues.
Signed-off-by: Gioh Kim
---
drivers/staging/greybus/es2.c | 4 ++--
drivers/staging/greybus/loopback.c | 2 +-
drivers/staging/greybus/svc.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
This fixes all checkpatch form of this from the Lustre tree: CHECK:
braces {} should be used on all arms of this statement
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Wednesday, February 8, 2017 10:55 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; le
This collects stats for shrinker calls and how much
waste work we do within the lowmemorykiller.
Signed-off-by: Peter Enderborg
---
drivers/staging/android/Kconfig | 11
drivers/staging/android/Makefile| 1 +
drivers/staging/android/lowmemorykiller.c |
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/staging/co
Removed unnecessary white spaces found via checkpatch.pl:
WARNING: Statements should start on a tabstop
Signed-off-by: Youngdo, Lee
---
drivers/staging/nvec/nvec_power.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec_power.c
b/drivers/staging/n
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2815.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dt2815.c
b/drivers/staging/comedi/drivers/dt2815.
Checkpatch recommended changes.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
b/drivers/staging/rtl8192u/ieee80211/ieee8021
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6656/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/channel.h b/drivers/staging/vt6656/channe
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2814.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dt2814.c
b/drivers/staging/comedi/drivers/dt2814.
Add Laurentiu Tudor as a second maintainer and update Stuart Yoder's
email address.
Signed-off-by: Stuart Yoder
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index c2395ea..6050912 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dt2801.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2801.c
b/drivers/staging/comedi/drivers/dt2
Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol
defined by the hypervisor is different from VCLOCK_PVCLOCK. Implement the
required support by adding hvclock_page VVAR.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/entry/vdso/vclock_gettime.c | 36
To use Hyper-V TSC page clocksource from vDSO we need to make tsc_pg
available. Implement hv_get_tsc_page() and add CONFIG_HYPERV_TSCPAGE to
make #ifdef-s simple.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/hyperv/hv_init.c | 9 +++--
arch/x86/include/asm/mshyperv.h | 8
driv
Hi,
Hyper-V TSC page clocksource is suitable for vDSO, however, the protocol
defined by the hypervisor is different from VCLOCK_PVCLOCK. Implemented the
required support. Simple sysbench test shows the following results:
Before:
# time sysbench --test=memory --max-requests=50 run
...
real
On Thu, Feb 09, 2017 at 02:21:45PM +0100, peter enderborg wrote:
> This collects stats for shrinker calls and how much
> waste work we do within the lowmemorykiller.
>
> Signed-off-by: Peter Enderborg
> ---
> drivers/staging/android/Kconfig | 11
> drivers/staging/android/Ma
It fixes the following warning reported by sparse:
drivers/staging/wilc1000/linux_wlan.c:67:33: warning: too long
initializer-string for array of char(no space for nul char)
Signed-off-by: Franck Demathieu
---
drivers/staging/wilc1000/linux_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 d
This patch modifies the assignments into single assignments.
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
b/drivers/stag
Fundamental changes:
1 Does NOT take any RCU lock in shrinker functions.
2 It returns same result for scan and counts, so we dont need to do
shinker will know when it is pointless to call scan.
3 It does not lock any other process than the one that is
going to be killed.
Background.
The low
Lowmemorykiller efficiency problem and a solution.
Lowmemorykiller in android has a severe efficiency problem. The basic
problem is that the registered shrinker gets called very often without
anything actually happening. This is in some cases not a problem as
it is a simple calculation that retu
This adds subscribtion for changes in oom_score_adj, this
value is important to android systems. For task that uses
oom_score_adj they read the task list. This can be long
and need rcu locks and has a impact on the system. Let
the user track the changes based on oom_score_adj changes
and keep them
This collects stats for shrinker calls and how much
waste work we do within the lowmemorykiller.
Signed-off-by: Peter Enderborg
---
drivers/staging/android/Kconfig | 11
drivers/staging/android/Makefile| 1 +
drivers/staging/android/lowmemorykiller.c
On 09/02/17 12:59, Saber Rezvani wrote:
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dmm32at.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dmm
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6655/baseband.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.h
b/drivers/s
This patch fixes the checkpatch warning by removing unnecessary space
after a cast.
CHECK: No space is necessary after a cast
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
From: Colin Ian King
Currently newline.flow_control is uninitialized, so it can contain
any garbage from the stack. I believe it should be initialized with
GB_SERIAL_AUTO_RTSCTS_EN enabled if the termios c_cflag is CRTSCTS
enabled.
Signed-off-by: Colin Ian King
---
drivers/staging/greybus/uar
On Thu, Feb 09, 2017 at 06:25:20PM +0530, Arushi wrote:
> Function definitions arguments should also have an identifier name as
> reported by checkpatch.pl.
>
> Signed-off-by: Arushi Singhal
This name does not match up with your From: line :(
Also, please wrap your changelog text at the correc
Fix the checkpatch.pl issue:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Saber Rezvani
---
drivers/staging/comedi/drivers/dmm32at.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dmm32at.c
b/drivers/staging/comedi/drivers/d
Function definitions arguments should also have an identifier name as reported
by checkpatch.pl.
Signed-off-by: Arushi Singhal
---
drivers/staging/vt6655/baseband.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.h
b/drivers/
On 27/01/17 15:55, Cheah Kok Cheong wrote:
Currently user can input any value for amplitude and period.
This patch set a sane max value for auto-configuration mode.
For manual configuration mode, it is assumed this is taken care of
by the COMEDI userspace tool since there's no limit set here fro
This patch fixes the checkpatch warning by removing multiple blank
lines.
CHECK: Please don't use multiple blank lines
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8
On 25/01/17 17:31, Cheah Kok Cheong wrote:
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achiev
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi Singhal
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block
On Wed, Feb 08, 2017 at 12:45:47AM +0100, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The ยง6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
> __ if it has pointer type, it
This patch fixes the checkpatch warning by adding a blank line after
declarations.
WARNING: Missing a blank line after declarations
Signed-off-by: simran singhal
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging
On Mon, Feb 06, 2017 at 01:26:50PM +0530, Abhijit Naik wrote:
> bcm2835-vchiq.c and vc_vchi_audioserv_defs.h:
> fixing ERROR: space prohibited before that close parenthesis
>
> Signed-off-by: Abhijit Naik
> ---
> drivers/staging/bcm2835-audio/bcm2835-vchiq.c | 16
> dri
On Tue, Feb 07, 2017 at 07:06:12AM -0500, Maksymilian Piechota wrote:
> Patch version 5:
> - break up particular changes to separate commits
> - change prefix to proper driver (wlan-ng)
What changed in the previous 4 versions?
___
devel mailing list
de..
On Tue, Feb 07, 2017 at 07:07:59AM -0500, Maksymilian Piechota wrote:
> Signed-off-by: Maksymilian Piechota
> ---
> drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
I can not take patches without any changelog text, sorry. Please fix up
and resen
The struct 'ni_private' holds the variable 'serial_number' which post
assignment is never used. Remove the variable and code pertaining to
obtaining its value.
As a side note, this also fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type i
On Thu, Feb 09, 2017 at 05:13:34PM +0530, Arushi wrote:
> This patch fixes the issue by aligning the * on each line in block comments.
>
> Signed-off-by: Arushi
Do you really sign documents with just this single word for a name?
> ---
> [Patch v1] is rejected as the changes done is not correct
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block was not
This patch fixes the issue by aligning the * on each line in block comments.
Signed-off-by: Arushi
---
[Patch v1] is rejected as the changes done is not correct and is not following
the linux kernel coding style in file drivers/staging/speakup/speakup_decpc.c
as * on each line in block was not
From: Colin Ian King
u.crypt.alg is an array of u8 integers and hence the null check on
this array is redundant and can be removed.
Detected with CoverityScan, CID#146583 ("Array compared against 0")
Signed-off-by: Colin Ian King
---
drivers/staging/rtl8192e/rtllib_softmac.c | 32
Hello,
On Thu, Feb 9, 2017 at 4:34 PM, Greg KH wrote:
> On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type
>> in assignment (different base types)
>> driver
On 09/02/2017 11:04, Greg KH wrote:
On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in
assignment (different base types)
drivers/staging/comedi/drivers//ni_pc
On Thu, Feb 09, 2017 at 12:04:01PM +0100, Gioh Kim wrote:
> There are many coding style issues.
> I fixed only obvious issues.
> Fixied issues:
> - Use 4 digit octal (0777) not decimal permissions
> - line over 80 characters
> - Avoid unnecessary line continuations
Again, only do one thing per pat
On Thu, Feb 09, 2017 at 12:04:59PM +0100, Gioh Kim wrote:
> Fix two coding style issues:
> 1. line over 80 characters
> 2. Octal permissions are preffered than symbolic ones
I just said not to do this, why resend it?
Also, you forgot to include the correct people and mailing list on the
patch, pl
Fix two coding style issues:
1. line over 80 characters
2. Octal permissions are preffered than symbolic ones
Signed-off-by: Gioh Kim
---
drivers/staging/greybus/es2.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greyb
There are many coding style issues.
I fixed only obvious issues.
Fixied issues:
- Use 4 digit octal (0777) not decimal permissions
- line over 80 characters
- Avoid unnecessary line continuations
I checked all files were built without error.
Signed-off-by: Gioh Kim
---
drivers/staging/fbtft/fb_
From: Colin Ian King
u.crypt.alg is an array of u8 integers and hence the null check on
this array is redundant and can be removed.
Detected with CoverityScan, CID#143214 ("Array compared against 0")
Signed-off-by: Colin Ian King
---
.../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 32 +++
On Tue, Feb 07, 2017 at 05:40:57PM +0200, Avraham Shukron wrote:
> Signed-off-by: Avraham Shukron
> ---
> drivers/staging/media/omap4iss/iss_video.c | 38
> --
> 1 file changed, 25 insertions(+), 13 deletions(-)
Again, I don't take patches with no changelog text :(
_
On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
> This patch fixes the following sparse error:
> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type
> in assignment (different base types)
> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected res
On Thu, Feb 09, 2017 at 06:30:02PM +0800, Ganesh Mahendran wrote:
> Hi, Greg:
>
> 2017-02-09 18:17 GMT+08:00 Greg KH :
> > On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
> >> A gentle ping.
> >
> > I don't see a patch here that can be accepted, what are you asking for
> > a resp
Hi, Greg:
2017-02-09 18:17 GMT+08:00 Greg KH :
> On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
>> A gentle ping.
>
> I don't see a patch here that can be accepted, what are you asking for
> a response from?
I sent a patch before:
https://patchwork.kernel.org/patch/9429257/
Pl
Fixed missing conversion to le32, detected by sparse
(invalid assignment from int to __le32)
Signed-off-by: Carlos Palminha
---
v1->v2:
missed sob line (too late in the night...)
drivers/staging/rtl8712/rtl8712_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
On Thu, Feb 09, 2017 at 05:54:03PM +0800, Ganesh Mahendran wrote:
> A gentle ping.
I don't see a patch here that can be accepted, what are you asking for
a response from?
confused,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://dri
A gentle ping.
Thanks.
2016-11-15 21:18 GMT+08:00 Ganesh Mahendran :
> Hi, Greg
>
> 2016-11-15 18:18 GMT+08:00 Greg KH :
>> On Tue, Nov 15, 2016 at 05:55:39PM +0800, Ganesh Mahendran wrote:
>>> VM_IOREMAP is used to access hardware through a mechanism called
>>> I/O mapped memory. Android binder
On Wed, 2017-02-08 at 15:23 -0800, Steve Longerbeam wrote:
[...]
> >> +
> >> +static int imxcsi2_get_fmt(struct v4l2_subdev *sd,
> >> + struct v4l2_subdev_pad_config *cfg,
> >> + struct v4l2_subdev_format *sdformat)
> >> +{
> >> + struct imxcsi2_dev *csi2 =
94 matches
Mail list logo
