The find_dev_index() function is frustrating. If you give it an invalid
index then it returns 0. That was the intent except there is an
off-by-one so it can return MAX_NIC_TYPE which is one higher than we
want.
There is one caller which had a sanity check to catch invalid returns,
but the other
POKE32 and PEEK32 have been replaced by inlined functions poke32 and
peek32.
Having inline functions instead of macros help to get the correct
type-checking and avoid the possible precedence issues reported by
checkpatch.
Signed-off-by: Matthieu Simon
---
drivers/staging/sm750fb/ddk750_chip.c
On Wed, Feb 08, 2017 at 01:04:52AM +, Dilger, Andreas wrote:
>
> > On Feb 3, 2017, at 03:33, Greg Kroah-Hartman
> > wrote:
> >
> > On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote:
> >> From: Andreas Dilger
> >>
> >> Update the sysfs "version" file to print "lustre: " with
>
On Wed, Feb 08, 2017 at 01:23:15AM +, Carlos Palminha wrote:
> Fixed sparse warnings
> * No need to convert from le32, pointers for structure with same endianness
> (cast from restricted __le32)
> * Need to convert bitwise operation for le32 structure (invalid assignment
> from int to __le32)
On Wed, Feb 08, 2017 at 01:19:39AM +, Carlos Palminha wrote:
>
>
> On 08-02-2017 00:58, Dan Carpenter wrote:
> >On Wed, Feb 08, 2017 at 12:47:22AM +, Carlos Palminha wrote:
> >>Fixed the following sparse warnings:
> >>* cast from restricted __le32
> >>* invalid assignment from int to __le
On Wed, 2017-02-08 at 01:19 +0300, Dan Carpenter wrote:
> On Tue, Feb 07, 2017 at 01:13:34PM -0800, Eric Anholt wrote:
> > Dan Carpenter writes:
> >
> > > There is a bunch of vc04_services that we're still looking to
> > > merge in
> > > the near future. Please hold off deleting these until we a
Fixed sparse warnings
* No need to convert from le32, pointers for structure with same endianness
(cast from restricted __le32)
* Need to convert bitwise operation for le32 structure (invalid assignment from
int to __le32)
Signed-off-by: Carlos Palminha
---
Changes v1->v2:
* Clarify patch descr
On 08-02-2017 00:58, Dan Carpenter wrote:
On Wed, Feb 08, 2017 at 12:47:22AM +, Carlos Palminha wrote:
Fixed the following sparse warnings:
* cast from restricted __le32
* invalid assignment from int to __le32
The changelog doesn't give me any confidence that you understand the
implicat
> On Feb 3, 2017, at 03:33, Greg Kroah-Hartman
> wrote:
>
> On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote:
>> From: Andreas Dilger
>>
>> Update the sysfs "version" file to print "lustre: " with
>> the version number.
>>
>> Signed-off-by: Andreas Dilger
>> Intel-bug-id: https
On Wed, Feb 08, 2017 at 12:47:22AM +, Carlos Palminha wrote:
> Fixed the following sparse warnings:
> * cast from restricted __le32
> * invalid assignment from int to __le32
>
The changelog doesn't give me any confidence that you understand the
implications of this patch. You silenced the wa
Fixed the following sparse warnings:
* cast from restricted __le32
* invalid assignment from int to __le32
Signed-off-by: Carlos Palminha
---
drivers/staging/rtl8712/rtl8712_xmit.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c
In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
__ if it has pointer type, it is initialized to a null pointer.
Signed-off-by: AbdAllah-MEZITI
v2: -f
On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote:
> In C a static pointer will be initialized to NULL.
> The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
> If an object that has static storage duration is not initialized
> explicitly, then:
> __ if it has pointer type, it is initialized to
Hi Benoit,
On Tuesday 07 Feb 2017 07:36:48 Benoit Parrot wrote:
> Laurent Pinchart wrote on Tue [2017-Feb-07 12:26:32 +0200]:
> > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> >> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> >>> On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> >
On Tue, Feb 07, 2017 at 01:13:34PM -0800, Eric Anholt wrote:
> Dan Carpenter writes:
>
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future. Please hold off deleting these until we are further
> > along on that.
>
> Checking the downstream tree, these a
In C a static pointer will be initialized to NULL.
The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that:
If an object that has static storage duration is not initialized
explicitly, then:
__ if it has pointer type, it is initialized to a null pointer.
Signed-off-by: AbdAllah-MEZITI
v2: -f
Dan Carpenter writes:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future. Please hold off deleting these until we are further
> along on that.
Checking the downstream tree, these are actually dead.
signature.asc
Description: PGP signature
__
On Tue, Feb 07, 2017 at 04:11:33PM +, Jake Oshins wrote:
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, February 6, 2017 11:12 PM
> > To: Jake Oshins
> > Cc: de...@linuxdriverproject.org; linux-...@vger.kernel.org
> > Subject: [bug re
Hi Benoit,
On Tue, Feb 07, 2017 at 07:36:48AM -0600, Benoit Parrot wrote:
> Laurent Pinchart wrote on Tue
> [2017-Feb-07 12:26:32 +0200]:
> > Hi Steve,
> >
> > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> > > On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > > > On Monday 06 Feb 2
Hi Steve,
On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote:
> From: Philipp Zabel
>
> This driver can handle SoC internal and external video bus multiplexers,
> controlled either by register bit fields or by a GPIO. The subdevice
> passes through frame interval and mbus configura
On Tue, Feb 07, 2017 at 11:11:22AM -0800, Matthieu Simon wrote:
> checkpatch noticed possible precedence issues resulting in the definition
> of PEEK32 and POKE32. So, these arguments should be enclosed in
> parentheses.
>
> Signed-off-by: Matthieu Simon
> ---
> drivers/staging/sm750fb/ddk750_ch
checkpatch noticed possible precedence issues resulting in the definition
of PEEK32 and POKE32. So, these arguments should be enclosed in
parentheses.
Signed-off-by: Matthieu Simon
---
drivers/staging/sm750fb/ddk750_chip.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
On Tue, Feb 07, 2017 at 03:09:44PM +0300, Dan Carpenter wrote:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future. Please hold off deleting these until we are further
> along on that.
>
OK.
Thanks.
--
Mit freundlichen Grüßen
Alexander Alemayhu
__
This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in
assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted
__be32 [usertype] serial_number
drivers/staging/comedi/drivers
Help Desk
Scheduled Maintenance & Upgrade
Your account is in the process of being upgraded to the newest
Windows-based servers and an enhanced online email interface inline with
internet infrastructure Maintenance. The new servers will provide better
anti-spam and anti-virus functions, along
> -Original Message-
> From: Dexuan Cui
> Sent: Tuesday, February 7, 2017 4:00 AM
> To: Bjorn Helgaas ; linux-...@vger.kernel.org;
> de...@linuxdriverproject.org; Jake Oshins
> Cc: KY Srinivasan ; Stephen Hemminger
> ; Haiyang Zhang ;
> o...@aepfle.de; gre...@linuxfoundation.org; linux-k
The csi_try_crop call in set_fmt should compare the cropping rectangle
to the currently set input format, not to the previous input format.
Signed-off-by: Philipp Zabel
---
This is a patch against the current imx-media-staging-md-wip branch.
S_FMT wouldn't update the cropping rectangle during the
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, February 6, 2017 11:12 PM
> To: Jake Oshins
> Cc: de...@linuxdriverproject.org; linux-...@vger.kernel.org
> Subject: [bug report] PCI: hv: Add paravirtual PCI front-end for Microsoft
> Hyper-V VMs
From: Laurentiu Tudor
Leave only APIs that area actually used in the bus driver.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed
From: Laurentiu Tudor
The implementation was removed in commit:
decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x)
but the prototype was left behind.
Also fix a message that was wrongly mentioning it.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/f
From: Laurentiu Tudor
When hot unplugging a mc-bus device the kernel displays
this pertinent message, followed by a stack dump:
"Device 'foo.N' does not have a release() function,
it is broken and must be fixed."
Add the required callback to fix and drop the now
uneeded explicit freeing.
From: Laurentiu Tudor
It was used just to sanity check some obscure
cases that are unlikely to ever happen.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git
From: Laurentiu Tudor
Mixing two memory management systems, in this case
managed device resource api and refcounted objects
is a bad idea. Lifetime of an object is controlled
by its refcount so allocating it with other apis
that have their own lifetime control is not ok.
Drop devm_*() apis in fav
From: Laurentiu Tudor
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +
drivers/staging/fsl-mc/bus/fsl-
From: Laurentiu Tudor
Leave only APIs that will be used in upcomming drivers.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed ba
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/dpbp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c
b/drivers/staging/fsl-mc/bus/dpbp.c
index 1fa7257..d9e450a 100644
--- a/drivers/staging/fsl-mc/
From: Laurentiu Tudor
These APIs are not used yet, so drop the dead code.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
Also in this patch, add missing prototype for
From: Laurentiu Tudor
Let's drop the slab cache for objects
until we actually have proof that it improves
performance. This makes the code cleaner.
Signed-off-by: Laurentiu Tudor
---
v3:
- made distinct patch with slab cache removal
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 17 +++---
From: Laurentiu Tudor
First 4 patches fix several driver model related
issues and drop an useless atomic global.
The rest of the patches are cleanups mostly
consisting in removing dead code.
Only patch 3, 4, 5 and 10 changed. See individual patch notes for
details.
Laurentiu Tudor (10):
stagi
Signed-off-by: Avraham Shukron
---
drivers/staging/media/omap4iss/iss_video.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/drivers/staging/media/omap4iss/iss_video.c
index e21811a..0bac582 100644
--- a/drivers/staging/media/om
Signed-off-by: Avraham Shukron
---
drivers/staging/media/omap4iss/iss_video.c | 38 --
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/drivers/staging/media/omap4iss/iss_video.c
index bb0e3b4..e21811a 100644
Laurent Pinchart wrote on Tue [2017-Feb-07
12:26:32 +0200]:
> Hi Steve,
>
> On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> > On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> > >> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
>
> -Original Message-
> From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com]
> Sent: Tuesday, February 07, 2017 8:15 AM
> To: gre...@linuxfoundation.org
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; ag...@suse.de;
> a...@arndb.de; Ioana
> Ciornei ; Ruxandra Ioa
When the balloon is inflated we see it as kernel allocated memory and this
is confusing especially when it is used as a replacement for memory hot
unplug. Hide the balloon with adjust_managed_page_count(). Virtio
ballooning driver does this already.
compute_balloon_floor() is adjusted to keep the
From: Laurentiu Tudor
Mixing two memory management systems, in this case
managed device resource api and refcounted objects
is a bad idea. Lifetime of an object is controlled
by its refcount so allocating it with other apis
that have their own lifetime control is not ok.
Drop devm_*() apis in fav
On 07/02/17 14:19, Johan Hovold wrote:
> On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote:
>> Add a struct timer_list to struct gb_operation and use that to implement
>> generic operation timeouts.
>>
>> This simplifies the synchronous operation handling somewhat while also
>> providing
From: Laurentiu Tudor
When hot unplugging a mc-bus device the kernel displays
this pertinent message, followed by a stack dump:
"Device 'foo.N' does not have a release() function,
it is broken and must be fixed."
Add the required callback to fix and drop the now
uneeded explicit freeing.
On Mon, Jan 23, 2017 at 01:04:14PM +0100, Johan Hovold wrote:
> Add a struct timer_list to struct gb_operation and use that to implement
> generic operation timeouts.
>
> This simplifies the synchronous operation handling somewhat while also
> providing a generic timeout mechanism that drivers can
On Tue, Feb 07, 2017 at 03:01:23PM +0100, Arnd Bergmann wrote:
> On Tue, Feb 7, 2017 at 2:17 PM, Dan Carpenter
> wrote:
> > "ret" isn't necessarily initialized on the success path.
> >
> > Signed-off-by: Dan Carpenter
> >
>
> The patch seems correct, but do you have any idea why gcc-7 didn't
>
From: Laurentiu Tudor
Leave only APIs that area actually used in the bus driver.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed
From: Laurentiu Tudor
These APIs are not used yet, so drop the dead code.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
Also in this patch, add missing prototype for
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c
b/drivers/staging/fsl-mc/bus/dpbp.c
index 1fa7257..d9e450a 100644
--- a/drivers/staging/fsl-mc/bus/dpbp.c
+++ b/dr
From: Laurentiu Tudor
Leave only APIs that will be used in upcomming drivers.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed ba
From: Laurentiu Tudor
Let's drop the slab cache for objects
until we actually have proof that it improves
performance. This makes the code cleaner.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-
From: Laurentiu Tudor
It was used just to sanity check some obscure
cases that are unlikely to ever happen.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/staging/
From: Laurentiu Tudor
First 4 patches fix several driver model related
issues and drop an useless atomic global.
The rest of the patches are cleanups mostly
consisting in removing dead code.
v2:
- split slab cache removal in distinct patch
- redundant deallocation dropped in patch that adds re
From: Laurentiu Tudor
The implementation was removed in commit:
decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x)
but the prototype was left behind.
Also fix a message that was wrongly mentioning it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bu
From: Laurentiu Tudor
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 -
2
Hi Philipp,
On Tuesday 07 Feb 2017 11:41:30 Philipp Zabel wrote:
> On Tue, 2017-02-07 at 12:26 +0200, Laurent Pinchart wrote:
> > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> >> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> >>> On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> >
On Tue, Feb 7, 2017 at 2:17 PM, Dan Carpenter wrote:
> "ret" isn't necessarily initialized on the success path.
>
> Signed-off-by: Dan Carpenter
>
The patch seems correct, but do you have any idea why gcc-7 didn't
warn about this?
I assume that you found it with smatch, and nobody else did.
"ret" isn't necessarily initialized on the success path.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index 9ac1f72a178e..b7922be4909c 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
+++ b/driv
We just dereferenced "instance" on the line before so checking it here
is pointless. Anyway, it can't be NULL here so let's remove the check.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/bcm2835-audio/bcm2835-vchiq.c
index b7922be490
The > should be >= otherwise we write beyond the end of the array when
we do:
chip->alsa_stream[idx] = alsa_stream;
Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
b/drivers
Hello Ulka Vaze,
You didn't introduce this warning but you were fixing nearby code so you
might know the answer.
drivers/staging/lustre/lustre/lmv/lmv_obd.c:1069 lmv_iocontrol()
warn: check 'reqlen' for integer overflows 'obd_iocontrol()'
drivers/staging/lustre/lustre/lmv/lmv_obd
There is a bunch of vc04_services that we're still looking to merge in
the near future. Please hold off deleting these until we are further
along on that.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
Signed-off-by: Maksymilian Piechota
---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index af83f2a..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
++
Signed-off-by: Maksymilian Piechota
---
drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index 64a9ebc..af83f2a 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
Signed-off-by: Maksymilian Piechota
---
drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index 16fb2d3..64a9ebc 100644
--- a/drivers/staging/wlan-ng/prism2mgmt
Patch version 5:
- break up particular changes to separate commits
- change prefix to proper driver (wlan-ng)
Maksymilian Piechota (3):
staging: wlan-ng: move logical continuations at the end of line
staging: wlan-ng: move else if statement to a single line
staging: wlan-ng: realign else if
Looking at the history these calls were introduced in 71bad7f08641
(staging: add bcm2708 vchiq driver, 2013-07-02) and they were not
being used at all.
Discovered using sparse and fixes the following output:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:816:1: warning:
symbol 'v
Fixes checkpatch check "No space is necessary after a cast".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bcm2835.c
index 5bd
Fixes checkpatch check "Comparison to NULL could be written '!chip'".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bcm2835.c
Fixes checkpatch CHECK: "Alignment should match open parenthesis".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bc
Fixes checkpatch error "open brace { should be on the previous line".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bcm2835.
Fixes checkpatch warning "Missing a blank line after declarations".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audi
Fixes checkpatch warning "unnecessary whitespace before a quoted
newline".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bcm28
According to the coding style, "bcm2835_ship ** rchip" should be
"bcm2835 **rchip".
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-au
Fixes multiple checkpatch errors and warnings in bcm2835.c.
Changes in v2:
* Separated v1 patch into multiple smaller patches.
Simon Sandström (8):
staging: bcm2835-audio: Remove static initialisation
staging: bcm2835-audio: Remove incorrect whitespace
staging: bcm2835-audio: Remove white
Static pointers are explicility initialised to NULL.
Signed-off-by: Simon Sandström
---
drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c
b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d
On Tue, 2017-02-07 at 12:26 +0200, Laurent Pinchart wrote:
> Hi Steve,
>
> On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> > On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> > >> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
> >
Hi Steve,
On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> >> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
> >>> On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote:
> On 01/
The devfn of 00:02.0 is 0x10.
devfn_to_wslot(0x10) == 0x2, and wslot_to_devfn(0x2) should be 0x10,
while it's 0x2 in the current code.
Due to this, hv_eject_device_work() -> pci_get_domain_bus_and_slot()
returns NULL and pci_stop_and_remove_bus_device() is not called.
Later when the real device d
On 07-02-17, 09:02, Greg Kroah-Hartman wrote:
> On Tue, Feb 07, 2017 at 11:15:29AM +0530, Viresh Kumar wrote:
> > Move all greybus documentation to the top level Documentation/
> > directory, as that's the obvious place where everyone will look for it.
>
> No, not until we have the core greybus co
On Mon, Feb 06, 2017 at 07:58:35PM +0200, Avraham Shukron wrote:
> Fixes line-over-80-characters issues as well as multiline comments style.
When you say things like "as well as", that's a hint that this needs to
be broken up into different patches. Please do so here.
thanks,
greg k-h
_
On Mon, Feb 06, 2017 at 08:21:51PM +0100, Simon Sandström wrote:
> Fix following warnings in bcm2835.c:
> * Do not initialise statics to NULL.
> * Unnecessary whitespace before a quoted newline.
> * Open brace { on wrong line.
>
> Fix 'Missing blank line after declarations' by simplifying
> bcm283
On Tue, Feb 07, 2017 at 11:15:29AM +0530, Viresh Kumar wrote:
> Move all greybus documentation to the top level Documentation/
> directory, as that's the obvious place where everyone will look for it.
No, not until we have the core greybus code out of staging. While code
is in staging, it is self
86 matches
Mail list logo
