Re: [PATCH] somedriver: remove the initialization of static pointers.

2017-02-04 Thread AbdAllah MEZITI
On Sun, 5 Feb 2017 01:29:43 +0100 Greg Kroah-Hartman wrote: > On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote: > > In C a static pointer will be initialized to NULL (e.g: draft C99 > > standard $6.7.8): "If an object that has static storage duration is > > not initialized explicit

[PATCH 2/2] staging: vchip_shim: Remove unneeded stddef.h include

2017-02-04 Thread Stafford Horne
Building on openrisc musl toolchain this causes the allyesconfig build to fail. drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c:42:20: fatal error: stddef.h: No such file or directory Removing this causes no issues with the build. Signed-off-by: Stafford Horne --- drivers/st

Re: [PATCH] somedriver: remove the initialization of static pointers.

2017-02-04 Thread Greg Kroah-Hartman
On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote: > In C a static pointer will be initialized to NULL (e.g: draft C99 standard > $6.7.8): > "If an object that has static storage duration is not initialized > explicitly, then: > __ if it has pointer type, it is initialized to a null

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Joe Perches
On Sat, 2017-02-04 at 20:24 +0100, Julia Lawall wrote: > > On Sat, 4 Feb 2017, Joe Perches wrote: > > > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > > > > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > > > > > (adding Julia Lawall) > > > > > > > > On Fri, 2017-02-03 at 20:44 -080

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-04 Thread Stephen Hemminger
On Sat, 4 Feb 2017 11:00:49 -0600 Parav Pandit wrote: > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens > --- > drivers/infiniband/core/cma.c

[PATCH] somedriver: remove the initialization of static pointers.

2017-02-04 Thread AbdAllah-MEZITI
In C a static pointer will be initialized to NULL (e.g: draft C99 standard $6.7.8): "If an object that has static storage duration is not initialized explicitly, then: __ if it has pointer type, it is initialized to a null pointer;" Signed-off-by: AbdAllah-MEZITI --- drivers/staging/bcm2835-au

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > > > (adding Julia Lawall) > > > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Der

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Joe Perches
On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > (adding Julia Lawall) > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > > A style fix across whole drive

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Fri, 3 Feb 2017, Joe Perches wrote: > (adding Julia Lawall) > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > A style fix across whole driver. > > > changed permissions to octal style, found using checkpatch > >

[PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-04 Thread Parav Pandit
This patch makes use of is_vlan_dev() function instead of flag comparison which is exactly done by is_vlan_dev() helper function. Signed-off-by: Parav Pandit Reviewed-by: Daniel Jurgens --- drivers/infiniband/core/cma.c| 6 ++ drivers/infiniband/sw/rxe/rxe_net.c

RE: [PATCH] net-next: treewide use is_vlan_dev() helper function.

2017-02-04 Thread Parav Pandit
Hi Joe, > -Original Message- > From: Joe Perches [mailto:j...@perches.com] > On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote: > > This patch makes use of is_vlan_dev() function instead of flag > > comparison which is exactly done by is_vlan_dev() helper function. > > Thanks. > > bt

RE: [PATCH 1/1] Drivers: hv: Fix the bug in generating the guest ID

2017-02-04 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, February 4, 2017 7:58 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

Re: [PATCH 1/1] Drivers: hv: Fix the bug in generating the guest ID

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 08:46:23AM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > Fix the bug in the generation of the guest ID. Without this fix > the host side telemetry code is broken. > > Signed-off-by: K. Y. Srinivasan If it's broken, does that mean this should go

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/04/2017 06:29 AM, Julia Lawall wrote: > > > > > > On Sat, 4 Feb 2017, Guenter Roeck wrote: > > > > > On 02/03/2017 11:27 PM, Joe Perches wrote: > > > > (adding Julia Lawall) > > > > > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: >

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/04/2017 06:29 AM, Julia Lawall wrote: On Sat, 4 Feb 2017, Guenter Roeck wrote: On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across wh

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/03/2017 11:27 PM, Joe Perches wrote: > > (adding Julia Lawall) > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > > A style fix across whole driver. > > > > cha

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Der

Re: [PATCH] Staging: iio: resolver: ad2s1210.c - style fix

2017-02-04 Thread Jonathan Cameron
On 04/02/17 01:45, Derek Robson wrote: > Changed symbolic permissions to octal permissions. > Found using checkpatch > > Signed-off-by: Derek Robson Applied. Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 24 > 1 file changed, 12 insertions(+), 12 d

[GIT PULL] Staging/IIO driver fixes for 4.10-rc7

2017-02-04 Thread Greg KH
The following changes since commit a121103c922847ba5010819a3f250f1f7fc84ab8: Linux 4.10-rc3 (2017-01-08 14:18:17 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.10-rc7 for you to fetch changes up to b17c1bba9ce

Re: Is it time to move drivers/staging/netlogic/ out of staging?

2017-02-04 Thread Greg KH
On Fri, Feb 03, 2017 at 06:37:02PM -0800, Florian Fainelli wrote: > > > On 02/03/2017 12:44 PM, Greg KH wrote: > > On Fri, Feb 03, 2017 at 12:38:45PM -0800, Florian Fainelli wrote: > >> On 02/03/2017 12:36 PM, Greg KH wrote: > >>> On Fri, Feb 03, 2017 at 10:57:16AM -0800, Joe Perches wrote: > >>>