Fix regression after 7ad82572 where conversion macros le16_to_cpu was removed
sparse output:
drivers/staging/wlan-ng/p80211netdev.c:241:44: warning: incorrect type in
argument 2 (different base types)
drivers/staging/wlan-ng/p80211netdev.c:241:44:expected unsigned short
[unsigned] [usertype]
This driver makes no sense outside of ARM or ARM64.
Add an explicit build dependency on:
(ARM || ARM64 || COMPILE_TEST)
Also set the default build to n
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/bc
The bcm2835-audio driver has a legacy code path for initializing
devices without a device tree. Delete this code path and remove
the non device tree devices.
Signed-off-by: Michael Zoran
---
drivers/staging/bcm2835-audio/bcm2835.c | 271 +---
1 file changed, 2 insert
The device sends data to the audio devices by sending a message with
the data through VC04_SERVICES/VCHIQ. This message contains a
callback pointer that is always filled in with the same function.
This is prone to corruption issues.
Instead fill the callback fields with a fixed cookie value to pe
The check for the smallest ioctl data in libcfs_ioctl_getdata()
is incorrect. Instead of checking against struct libcfs_ioctl_data
compare the size to struct libcfs_ioctl_hdr.
Reported-by: Doug Oucharek
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/libcfs/linux/linux-module.c | 2
The reason for __REQ_LAYOUT_USER__ was to expose a
section of code in layout.c to userland for a utility
similar to wireshark. This was done before wireshark
existed but now that it does we no longer need to do
this type of hack. This also reduces lustre_acl.h to
strictly a kernel header now.
Sign
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Thursday, January 26, 2017 6:52 AM
> To: Cathy Avery
> Cc: KY Srinivasan ; h...@infradead.org; Haiyang Zhang
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; dan.carpen...@oracle.com;
> de...@lin
From: Steve Guminski
This patch makes no functional changes. Struct initializers in the
fid directory that use C89 or GCC-only syntax are updated to C99
syntax.
The C99 syntax prevents incorrect initialization if values are
accidently placed in the wrong position, allows changes in the struct
d
Building the lustre client with W=1 reports the following
error:
obdclass/obd_mount.c: In function lmd_parse:
obdclass/obd_mount.c:880: warning: variable set but not used
The solution is to move s3 to the inner loop
where it is only used.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.
From: Dmitry Eremin
Update max_ptlrpcds module parameter descriptions to let
users know its obsolete. Change cpt to CPT for the module
parameter description ptlrpcd_per_cpt_max so it matches
documentation.
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8890
Rev
From: Fan Yong
Under DNE mode, if we do not restrict the linkEA size, and if there
are too many cross-MDTs hard links to the same object, then it will
casue the llog overflow. On the other hand, too many linkEA entries
in the linkEA will serious affect the linkEA performance because we
only suppo
From: Dmitry Eremin
Environment for request interpreters is not used any more.
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8887
Reviewed-on: https://review.whamcloud.com/24061
Reviewed-by: John L. Hammond
Reviewed-by: Bob Glossman
Reviewed-by: Oleg Drokin
From: Niu Yawei
The replay cursor should be updated properly when close happened
during replay, otherwise, ptlrpc_replay_next() could run into a
dead loop due to an invalid replay cursor:
- replay cursor is moved to an open request during replay;
- application close that open file, so the rq_rep
From: Patrick Farrell
An earlier commit accidentally changed handling of IT_OPEN,
making it take the MDS_INODELOCK_UPDATE bits lock instead of
MDS_INODELOCK_LOOKUP. This does not cause any known bugs.
Signed-off-by: Patrick Farrell
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8842
Review
From: wang di
If an application attempts to remove millions of files in a
single directory it will fail. This failure was tracked down to
the nlink < 2 check in lmv_revalidate_slaves, because after
nlink reaches to maximum value of LDISKFS_LINK_MAX (65000),
the nlink broadcast back from the serve
The use of 64 bit time introduces an expensive 64 bit
division operation. Since the time lapse being calculated
in osc_cache_too_much will never be more than seventy years
we can cast the time lapse to an long and perform a normal
32 bit divison operation instead.
Signed-off-by: James Simmons
Int
Remove the inline function socklnd_init_msg.
Its only used by the kernel code so no point
keeping it in an UAPI header.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142
Reviewed-on: https://review.whamcloud.com/18506
Reviewed-by: Dmitry Eremin
Reviewed-by: Do
From: Steve Guminski
This patch makes no functional changes. Struct initializers in the
libcfs directory that use C89 or GCC-only syntax are updated to C99
syntax.
The C99 syntax prevents incorrect initialization if values are
accidently placed in the wrong position, allows changes in the struct
From: Yang Sheng
The function generic_file_read_iter() does not check EOF
before invoke direct_IO callback. So we have to check it
ourselves.
Signed-off-by: Yang Sheng
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8969
Reviewed-on: https://review.whamcloud.com/24552
Reviewed-by: Bob Gloss
From: Rahul Deshmukh
There exists timing race between umount and other
thread which will increment the reference count on
mnt e.g. getattr. If umount thread lose the race
then umount fails with EBUSY error. To avoid this
timed wait is added so that umount thread will wait
for user to decrement th
In the case of interval_tree.h only interval_set()
uses LASSERT which is removed in this patch and
interval_set() instead reports a real error. The
header libcfs.h for interval_tree.h is not needed
anymore so we can just use the standard linux
kernel headers instead.h
Signed-off-by: James Simmons
From: Niu Yawei
Sync write should update m/ctime promptly, otherwise, stale m/ctime
could be updated on the OST object by the sync write RPC.
Signed-off-by: Niu Yawei
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7310
Reviewed-on: http://review.whamcloud.com/21063
Reviewed-by: John L. Ham
From: "John L. Hammond"
None of the obd_notify() handlers listen for the OBD_NOTIFY_CREATE
event, so remove it and its sole use in lov_add_target().
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8403
Reviewed-on: https://review.whamcloud.com/21420
Reviewed-b
From: "John L. Hammond"
In mdc_close() if ptlrpc_request_pack() fails then set req to NULL so
that an already freed request is not returned in *request.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8811
Reviewed-on: https://review.whamcloud.com/23843
Review
From: Steve Guminski
The patch updates the prototype in osc_internal.h to match the
enums used in the declaration.
The osc_match_base declaration in lustre/osc/osc_request.c uses
enums for stricter checking on the type and mode parameters:
int osc_match_base(struct obd_export *exp,
From: Liang Zhen
ksocklnd reaper thread always tries to close the connection for the
first timedout zero-copy TX. This is wrong if this connection is
already being closed, because the reaper will see the same TX again
and again and cannot find out other timedout zero-copy TXs and close
connection
From: Dmitry Eremin
Don't treat unability to set CPU partition affinity as error.
Improve those warning messages.
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703
Reviewed-on: https://review.whamcloud.com/23307
Reviewed-by: Patrick Farrell
Reviewed-by: Doug
From: Bobi Jam
So that debug log only contains relevant messages for debugging
purpose.
Signed-off-by: Bobi Jam
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8413
Reviewed-on: http://review.whamcloud.com/22753
Reviewed-by: Andreas Dilger
Reviewed-by: Fan Yong
Reviewed-by: Oleg Drokin
S
From: "John L. Hammond"
Remove the unused lmv.*.placement parameter along with supporting
functions and struct members.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7674
Reviewed-on: http://review.whamcloud.com/18019
Reviewed-by: Ben Evans
Reviewed-by: Fra
From: Jinshan Xiong
OSC has to make sure that it won't issue write RPCs with too many
chunks otherwise it will casue ZFS to create transactions much
bigger than DMU_MAX_ACCESS in size, which will end up with write
failure.
Signed-off-by: Jinshan Xiong
Signed-off-by: Dmitry Eremin
Intel-bug-id:
Replace the ulong_ptr_t and long_ptr_t with standard
kernel types.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245
Reviewed-on: http://review.whamcloud.com/20204
Reviewed-by: Frank Zago
Reviewed-by: Dmitry Eremin
Reviewed-by: Oleg Drokin
Signed-off-by: Jam
From: Lai Siyao
Current client doesn't check permission before updating filesystem
default stripe on MGS, which isn't secure and obvious.
Since we setattr on MDS first, and then set default stripe on MGS,
we can just return error upon setattr failure.
Now filesystem default stripe is stored in
From: Bobi Jam
lov_device::ld_target[ost_idx] could be NULL if the OST target is
not filled in lov_device::ld_lov::lov_tgt_desc[ost_idx] yet.
Signed-off-by: Bobi Jam
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8018
Reviewed-on: http://review.whamcloud.com/21411
Reviewed-by: Jinshan Xion
From: Dmitry Eremin
The function cfs_cpt_table_create_pattern() alters the string
passed to it. Currently we are passing in the module parameter
string cpu_pattern which is incorrect. Instead lets duplicate
the module parameter string and pass that to the function
cfs_cpt_table_create_pattern().
From: Fan Yong
The 'fld_read_server' uses 'RMF_GENERIC_DATA' to hold the 'FLD_QUERY'
RPC reply that is composed of 'struct lu_seq_range_array'. But there
is not registered swabber function for 'RMF_GENERIC_DATA'. So the RPC
peers need to handle the RPC reply with fixed little-endian format.
In t
From: Andriy Skulysh
Whole policy structure was zeroed twice. Once during enqueue
and second time during resend or replay. Policy structure
should be initialized with default values only in ldlm_lock_new().
Signed-off-by: Andriy Skulysh
Signed-off-by: Ben Evans
Intel-bug-id: https://jira.hpdd.
From: Vladimir Saveliev
ptlrpc_import_delay_req() refuses to delay blocking asts when import
is not in LUSTRE_IMP_FULL yet. That leads to client eviction assuming
that it failed to respond.
Allow delays for blocking asts being resent.
Signed-off-by: Vladimir Saveliev
Intel-bug-id: https://jira
From: Alexander Boyko
This patch resolves IO vs eviction race.
After eviction failed export stayed at stale list,
a client had IO processing and reconnected during it.
A client sent brw rpc with last lock cookie and new connection.
The lock with failed export was found and assert was happened.
(
From: Dmitry Eremin
Change default value of CPT pattern and make it match NUMA topology
Signed-off-by: Liang Zhen
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5050
Reviewed-on: http://review.whamcloud.com/22377
Reviewed-by: James Simmons
Reviewed-by: Olaf W
From: Niu Yawei
reply_out_callback() should call ptlrpc_schedule_difficult_reply()
to finalize the rs if it's already not on uncommitted list, otherwise,
the rs and the export held by rs could be leaked:
- target_send_reply() sends a difficult reply before the transaction
committed, the reply
From: Fan Yong
Originally, the logic of handling config_llog_data::cld_refcount
is some confusing, it may cause the cld_refcount to be leaked or
trigger "LASSERT(atomic_read(&cld->cld_refcount) > 0);" when put
the reference. This patch clean related logic as following:
1) When the 'cld' is creat
From: Fan Yong
There is race condition when allocating fid/seq in parallel
as following:
The thread1 will release the lcs_mutex via seq_fid_alloc_prep(),
then another fid allocation thread2 can obtain the lcs_mutex and
allocate FID in the new sequence that has just been allocated by
the thread1
From: Dmitry Eremin
Setting extended attributes permissions are properly checked with and
without ACLs. In user.* namespace, only regular files and directories
can have extended attributes. For sticky directories, only the owner
and privileged user can write attributes.
Signed-off-by: Dmitry Ere
From: Oleg Drokin
By forcing creates to always go via lookup we lose some
important caching benefits too.
Instead let's trust creates with positive cached entries.
Then we have 3 possible outcomes:
1. Negative dentry - we go via atomic_open and do the create
by name there.
2. Positive dentry,
From: Andreas Dilger
Change the order of checks for inactive OSCs in lov_prep_statfs_set()
so that administratively disabled OSTs do not generate any output in
"lfs df" at all, to avoid needlessly cluttering the output.
Enable the lazystatfs mount option by default, so that "df" does not
hang wh
From: Ben Evans
These #if 0 blocks have been in place for years. Assume
they are not used and remove them
Signed-off-by: Ben Evans
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8058
Reviewed-on: http://review.whamcloud.com/20416
Reviewed-by: John L. Hammond
Reviewed-by: Frank Zago
Revie
From: "John L. Hammond"
Remove obsolete comments about the behavior of ll_unlink()
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8003
Reviewed-on: http://review.whamcloud.com/19881
Reviewed-by: Andrew Perepechko
Reviewed-by: James Simmons
Reviewed-by: Oleg
From: Alex Zhuravlev
First of all, this is expensive procedure including a global
mutex and per-bucket spinlocks. also, all the threads observed
exceed will be calling lu_site_purge() and essentially serialized
on that. instead we can let other threads to skip the whole
procedure.
Signed-off-by:
From: "John L. Hammond"
In sptlrpc_gc_add_sec() swap the arguments to list_add_tail() so that
it does what we meant it to do.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8270
Reviewed-on: http://review.whamcloud.com/20784
Reviewed-by: Andreas Dilger
Revie
From: Nathaniel Clark
If a backing filesystem (ZFS) returns that it supports very large
(LLONG_MAX) object sizes, that should be correctly supported. This
fixes the check for unitialized stripe_maxbytes in
lsm_unpackmd_common(), so that ZFS can return LLONG_MAX and it will be
okay. This issue is
From: Jinshan Xiong
ignore_layout can be set for operations that layout won't be changed,
typically page operations. Ignoring layout change in group lock
request will confuse layout change code at LOV layer and hit
assertion.
Signed-off-by: Henri Doreau
Signed-off-by: Jinshan Xiong
Signed-off-
From: Giuseppe Di Natale
The target_obd debugfs file was not being generated correctly
in cases where nonconsecutive MDT indices were used when
generating a filesystem.
Signed-off-by: Giuseppe Di Natale
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8100
Reviewed-on: http://review.whamclou
From: Bobi Jam
Register cache shrinker to reclaim memory from cl_page LRU list.
Signed-off-by: Bobi Jam
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6842
Reviewed-on: http://review.whamcloud.com/15630
Reviewed-by: Andreas Dilger
Reviewed-by: Jinshan Xiong
Reviewed-by: Oleg Drokin
Sign
From: frank zago
The function hai_dump_data_field will do a stack buffer
overrun when cat'ing /sys/fs/lustre/.../hsm/actions if an action has
some data in it.
hai_dump_data_field uses snprintf. But there is no check for
truncation, and the value returned by snprintf is used as-is. The
coordinat
From: Ulka Vaze
This issue is found by smatch; has been reported as-
Unchecked usage of potential ERR_PTR result in lmv_hsm_req_count
and lmv_hsm_req_build. Added ERR_PTR in both functions and also
return value check added.
Signed-off-by: Ulka Vaze
Signed-off-by: Aditya Pandit
Intel-bug-id: ht
From: Ann Koehler
The algorithm for counting freeable objects in the lu_cache shrinker
does not scale with the number of cpus. The LU_SS_LRU_LEN counter
for each cpu is read and summed at shrink time while holding the
lu_sites_guard mutex. With a large number of cpus and low memory
conditions, pr
Batch of missing fixes for lustre for the upstream client.
Alex Zhuravlev (1):
staging: lustre: obdclass: do not call lu_site_purge() for single object
exceed
Alexander Boyko (1):
staging: lustre: ptlrpc: skip lock if export failed
Andreas Dilger (3):
staging: lustre: mdc: quiet console m
From: Andreas Dilger
Update the sysfs "version" file to print "lustre: " with
the version number.
Signed-off-by: Andreas Dilger
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5969
Reviewed-on: http://review.whamcloud.com/16721
Reviewed-by: James Simmons
Reviewed-by: Dmitry Eremin
Reviewe
From: Bruno Faccini
When a LBUG has occurred, without panic_on_lbug being set,
health_check sysfs file must return an unhealthy state.
Signed-off-by: Bruno Faccini
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7486
Reviewed-on: http://review.whamcloud.com/17981
Reviewed-by: Bobi Jam
Revi
From: wang di
Check if the request is NULL, before retrieve reply body
from the request.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7396
Reviewed-on: http://review.whamcloud.com/17079
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Signed-off-by: James
From: Jinshan Xiong
Read ahead currently doesn't handle 16MB RPC packets correctly
by assuming the packets are a default size instead of querying
the size. This work adjust the read ahead policy to issue
read ahead RPC by the underlying RPC size.
Signed-off-by: Jinshan Xiong
Signed-off-by: Gu Z
From: Jeremy Filizetti
Restore connect flags on failure of ptlrpc_connect_import()
to prevent an LBUG due to flags mismatch.
Signed-off-by: Jeremy Filizetti
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7185
Reviewed-on: http://review.whamcloud.com/16950
Reviewed-by: Andreas Dilger
Revie
From: Lai Siyao
This patch dropped support for remote entry statahead, because it
needs 2 async RPCs to fetch both LOOKUP lock from parent MDT and
UPDATE lock from client MDT, which is complicated. Plus not
supporting remote entry statahead won't cause any issue.
* pack child fid in statahead re
From: Niu Yawei
Set mbits for EINPROGRESS resend in ptl_send_rpc().
Signed-off-by: Niu Yawei
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8193
Reviewed-on: http://review.whamcloud.com/20377
Reviewed-by: Liang Zhen
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
Signed-off-by: Jam
From: Andreas Dilger
If a user process is waiting for MDS recovery during close, but the
process is interrupted, the file is still closed but it prints a
message on the console. Quiet the console message for -EINTR, since
this is expected behaviour.
Signed-off-by: Andreas Dilger
Intel-bug-id: h
From: Jinshan Xiong
In ll_setattr_raw(), it needs to know if a file is released
when the file is being truncated. It used to get this information
by accessing lov_stripe_md. This turns out not necessary. This
patch removes the access of lov_stripe_md and solves the problem
in lov_io_init_released
On 01/24/2017 03:27 AM, Philipp Zabel wrote:
Hi Steve, Hans,
[added Laurent to Cc: who I believe might have an opinion on the media
bus formats, too. Sorry for the wall of text, I have put a marker where
the MEDIA_BUS argument starts]
The central issue seems to be that I think media pad links
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, January 19, 2017 6:17 AM
> To: de...@linuxdriverproject.org
> Cc: Thomas Gleixner ; linux-ker...@vger.kernel.org;
> Haiyang Zhang ; KY Srinivasan
> ; John Stultz ; Alex Ng (LIS)
> ; Stephen Hemmin
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, January 23, 2017 5:40 PM
> To: KY Srinivasan ; Haiyang Zhang
>
> Cc: de...@linuxdriverproject.org; Stephen Hemminger
>
> Subject: [PATCH 00/14] hv: vmbus cleanup patches
>
> No new functi
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, January 27, 2017 10:36 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang ;
> de...@linuxdriverproject.org; Stephen Hemminger
>
> Subject: Re: [PATCH 07/14] vmbus: remove conditional locking of
>
Fixed comment formatting issue.
Signed-off-by: Vitali Liaukovich
---
drivers/staging/speakup/speakup_bns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/speakup_bns.c
b/drivers/staging/speakup/speakup_bns.c
index 570f0c2..e49889f 100644
--- a/driver
On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote:
> A style fix across whole driver.
> changed permissions to octal style, found using checkpatch
[]
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
> @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL");
> MODULE_VERSION(SP
On Sat, Jan 28, 2017 at 10:49:10AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov
> ---
> checkpatch fixes: remove not necessary braces
{sigh}
Please take some time, and go read Documentation/SubmittingPatches.
Then wait a day, review the patches that other people send out, and
Signed-off-by: Martin Karamihov
---
checkpatch fixes: remove not necessary braces
drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0
On Sat, Jan 28, 2017 at 10:34:35AM +0200, Martin Karamihov wrote:
> checkpatch fixes: removes not necessary braces
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I do
On Sat, Jan 28, 2017 at 10:34:36AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov
> ---
> drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I can't take a patch with no changelog text :(
Signed-off-by: Martin Karamihov
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c
b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 134fa6c595a8..26e0ef224299 100644
--- a/drivers/staging/rtl8188eu
checkpatch fixes: removes not necessary braces
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
78 matches
Mail list logo
