On 01/20/2017 06:29 AM, Hans Verkuil wrote:
On 01/07/2017 03:11 AM, Steve Longerbeam wrote:
+
+static const struct v4l2_ctrl_config prpenc_std_ctrl[] = {
+ {
+ .id = V4L2_CID_HFLIP,
+ .name = "Horizontal Flip",
+ .type = V4L2_CTRL_TYPE_BOOLEAN,
+
On Tue, 2017-01-24 at 22:22 +, Dilger, Andreas wrote:
> On Jan 24, 2017, at 09:40, Ernestas Kulik wrote:
> >
> > Using octal permissions instead of symbolic ones is preferred.
>
> Typically the reverse is true - using symbolic constants is preferred over
> numeric ones.
> Where does this re
On 01/24/2017 04:02 AM, Philipp Zabel wrote:
Hi Hans,
On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote:
+
+int vidsw_g_mbus_config(struct v4l2_subdev *sd, struct v4l2_mbus_config *cfg)
+{
+ struct vidsw *vidsw = v4l2_subdev_to_vidsw(sd);
+ struct media_pad *pad;
+ int
On Jan 24, 2017, at 09:40, Ernestas Kulik wrote:
>
> Using octal permissions instead of symbolic ones is preferred.
Typically the reverse is true - using symbolic constants is preferred over
numeric ones.
Where does this recommendation come from?
Cheers, Andreas
> Signed-off-by: Ernestas Kuli
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Make the function static and remove it from the exported
symbols.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 8
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Add a new function which is a wrapper on top of vchi_msg_queue
that is specifically for queuing a message located in user
address space.
int
vchi_queue_user_message(VCHI_SE
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Add a new function which is a wrapper on top of vchi_msg_queue
that is specifically for queuing a message located in kernel
address space.
int
vchi_queue_kernel_message(VCH
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic. Remove it and replace it with two more specific functions.
int
vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle,
void *data,
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic. Remove it and replace it with two more specific functions.
int
vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle,
void *data,
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Make the function static and remove it from the exported
symbols.
Signed-off-by: Michael Zoran
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 8
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Add a new function which is a wrapper on top of vchi_msg_queue
that is specifically for queuing a message located in user
address space.
int
vchi_queue_user_message(VCHI_SE
The vchi_msg_queue function which is used by other drivers
to queue a message is difficult to understand and overly
generic.
Add a new function which is a wrapper on top of vchi_msg_queue
that is specifically for queuing a message located in kernel
address space.
int
vchi_queue_kernel_message(VCH
Using octal permissions instead of symbolic ones is preferred.
Signed-off-by: Ernestas Kulik
---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c | 2 +-
drivers/staging/lustre/lustre/llite/llite_lib.c | 4 ++--
drivers/staging/lustre/lustre
Using octal permissions instead of symbolic ones is preferred.
Signed-off-by: Ernestas Kulik
---
drivers/staging/lustre/lnet/libcfs/module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet/libcfs/module.c
b/drivers/staging/lustre/lnet/libcfs/m
On 24/01/17 15:09, Johan Hovold wrote:
> Bryan, if you could consider my review feedback and respin your last
> three patches on top of my timeout patch, I think we should be good.
Sure thing
___
devel mailing list
de...@linuxdriverproject.org
http://d
On Tue, 24 Jan 2017 06:54:46 +
Dexuan Cui wrote:
> +static inline void
> +init_cached_read_index(struct vmbus_channel *channel)
> +{
> + struct hv_ring_buffer_info *rbi = &channel->inbound;
> +
> + rbi->cached_read_index = rbi->ring_buffer->read_index;
> +}
Looks good thanks. This sh
On Mon, Jan 23, 2017 at 05:50:23PM +0100, Johan Hovold wrote:
> On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote:
> > Have you run this through loopback without any # of in-flight operations
> > constrained ?
>
> No, not yet as that would require also your changes to the loopback
On Mon, Jan 23, 2017 at 07:43:09AM -0800, Michael Zoran wrote:
> On Mon, 2017-01-23 at 14:38 +0300, Dan Carpenter wrote:
> > I'm attaching how I would basically like to see patch 1/7 done. It's
> > not perfect, I did it as quickly as possible and haven't tested
> > anything. I would normally be m
Hello Steve,
On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote:
> From: Philipp Zabel
[snip]
>
> +config VIDEO_MULTIPLEXER
> + tristate "Video Multiplexer"
> + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
The driver can be build as a module...
> +
> +static const st
Hi Hans,
On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote:
> On 01/07/2017 03:11 AM, Steve Longerbeam wrote:
> > From: Philipp Zabel
> >
> > This driver can handle SoC internal and external video bus multiplexers,
> > controlled either by register bit fields or by a GPIO. The subdevice
> >
On Wed, 2017-01-18 at 17:44 -0800, Steve Longerbeam wrote:
>
> On 01/14/2017 02:42 PM, Steve Longerbeam wrote:
> >
> >>> +/* parse inputs property from a sensor node */
> >>> +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd,
> >>> +struct imx_media_subdev
Hi Steve,
On Mon, 2017-01-23 at 17:45 -0800, Steve Longerbeam wrote:
>
> On 01/23/2017 05:38 PM, Steve Longerbeam wrote:
> >
> >>
> >>> Second, ignoring the above locking issue for a moment,
> >>> v4l2_pipeline_pm_use()
> >>> will call s_power on the sensor _first_, then the mipi csi-2 s_power,
>
On Mon, 2017-01-23 at 12:08 +0100, Hans Verkuil wrote:
> On 01/23/2017 12:00 PM, Philipp Zabel wrote:
> > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote:
[...]
> As long as it is mentioned in the TODO, and ideally in the Kconfig as well,
> then I'm fine with it.
>
> The big advantage of bein
Hi Steve, Hans,
[added Laurent to Cc: who I believe might have an opinion on the media
bus formats, too. Sorry for the wall of text, I have put a marker where
the MEDIA_BUS argument starts]
The central issue seems to be that I think media pad links / media bus
formats should describe physical lin
On Tue, Jan 24, 2017 at 09:41:09AM +0100, Artur Lorincz wrote:
>
> The get_maintainer.pl script returns
> "The current directory does not appear to be a linux kernel source tree"
> error message, hence sending the patch to you.
That's a horrid changelog message, why would you put that here?
And
Found by checkpatch:
- s/cacluated/calculated/
- s/convertor/converter/
- s/psudo/pseudo/
- s/halfs/halves/
Signed-off-by: Joseph Wright
---
drivers/staging/rtl8712/rtl8712_recv.c| 4 ++--
drivers/staging/rtl8712/rtl8712_xmit.c| 2 +-
drivers/staging/rtl8712/rtl871x_ioctl_linux
26 matches
Mail list logo
