Using iio_trigger_put() to free a trigger leads to release of
a resource we never held. Replace with iio_trigger_free().
Signed-off-by: Alison Schofield
---
Patches to use devm_* funcs are ready to follow this for
the interrupt & bfin-timer triggers.
drivers/iio/trigger/iio-trig-interrupt.c
Macros with complex values enclosed in parentheses
Signed-off-by: Kartikey Singh
---
drivers/staging/rtl8188eu/include/wifi.h | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/i
On Wed, Jan 18, 2017 at 1:38 AM, Stefano Manni wrote:
> Following error detected by checkpatch.pl:
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
>
> Signed-off-by: Stefano Manni
> ---
> drivers/staging/fbtft/flexfb.c | 18 +-
> 1 file changed, 9 insertions(+), 9 del
Following error detected by checkpatch.pl:
ERROR: Use 4 digit octal (0777) not decimal permissions
Signed-off-by: Stefano Manni
---
drivers/staging/fbtft/flexfb.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/stag
From: Phil Elwell
This reduces the memory dump size to a sufficient value of 16 bytes.
Signed-off-by: Phil Elwell
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
From: Phil Elwell
An issue was observed when flushing openmax components
which generate a large number of messages returning
buffers to host.
We occasionally found a duplicate message from 16
messages prior, resulting in a buffer returned twice.
So fix the issue by adding more memory barriers.
From: Phil Elwell
Service callbacks are not allowed to return an error. The internal
callback that delivers events and messages to user tasks does not
enqueue them if the service is closing, but this is not an error
and should not be reported as such.
Signed-off-by: Phil Elwell
Signed-off-by: S
This patch series contain several fixes from the Foundation kernel
and based on this pull request [1] from Phil Elwell. Since the
original commits wasn't ready for mainline submission i reworked them.
[1] - https://github.com/anholt/linux/pull/63
Phil Elwell (5):
staging: vchiq_core: Reduce the
From: Phil Elwell
The constants MAX_COMPLETIONS and MSG_QUEUE_SIZE control
the number of messages that can be outstanding to each client
before the system as a whole stalls. If the numbers are too
small then unnecessary thread switching will occur while
waiting for a (potentially low priority) cl
From: Phil Elwell
The dequeue_pending flag wasn't protected by a spinlock in the
service_callback. So fix this to make it safe.
Signed-off-by: Phil Elwell
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 13 -
1 file changed, 8 insertions(+),
This patch fixes 2 issues detected with sparse (-Wtypesign)
Pierre-Yves Kerbrat (2):
staging: rtl8188eu: fix type of wpa_ielen in rtw_get_cipher_info
staging: rtl8188eu: fix type sign of len in rtw_get_bcn_info
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++--
1 file changed, 2 insert
wpa_ielen was declared u32 when we actually use an int
Fix sparse (-Wtypesign) issues:
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1008:60: warning:
incorrect type in argument 2 (different signedness)
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1008:60:expected int
*wpa_ie_len
drivers/st
len was declared unsigned int where we use an int
Fix sparse (-Wtypesign) issues:
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1081:88: warning:
incorrect type in argument 3 (different signedness)
drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1081:88:expected int
*len
drivers/staging/rtl818
On Tue, 17 Jan 2017, Vitaly Kuznetsov wrote:
> Stephen Hemminger writes:
> >> static int hv_timesync_init(struct hv_util_service *srv)
> >> {
> >>INIT_WORK(&wrk.work, hv_set_host_time);
> >> +
> >> + hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL);
> >> + if (IS_ERR_OR_NULL(hv_pt
Open braces for enum, union and struct go on the same line.
Signed-off-by: Adrien Descamps
Reviewed-by: Eric Anholt
---
.../interface/vchi/connections/connection.h| 3 +--
.../interface/vchi/message_drivers/message.h | 9 +++--
drivers/staging/vc04_services/interface
On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal
>
> Proper byte order was completely disregarded for multi byte data shared
> between AP and module (and APB1). Fix this.
>
> Signed-off-by: Vaibhav Agarwal
> ---
Hi Vaibhav.
I think you got them all exce
On Tue, 17 Jan 2017, Vitaly Kuznetsov wrote:
> do_settimeofday() is deprecated, use do_settimeofday64() instead.
>
> Signed-off-by: Vitaly Kuznetsov
> Acked-by: John Stultz
Acked-by: Thomas Gleixner
___
devel mailing list
de...@linuxdriverproject.or
Hi Vaibhav.
On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote:
> mixer control->info call back function checks for -ve values to rebase
> min and max values. However, le32 variable is used to fetch values from
> GB module FW. Thus -ve value checking is not required. Fix this!!
nit:
On Tue, Jan 17, 2017 at 08:19:28PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal
>
> Uninitialized variable sig_bits was used while configuring stream params
> for codec module. These params are used to configure PCM settings for
> APBridgeA.
>
> Usually, this is dependent on codec capab
On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote:
> From: Vaibhav Agarwal
>
> Dummy codec register were initially added while populating dummy codec
> mixer controls until module topology parser was available. Now, these
> dummy registers are nowhere used and thus can be safely rem
Fix checkpatch.pl "space required after that ','" errors
Signed-off-by: simran singhal
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d7d85b3..6380b41 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_so
Stephen Hemminger writes:
> On Tue, 17 Jan 2017 16:27:17 +0100
> Vitaly Kuznetsov wrote:
>
>> With TimeSync version 4 protocol support we started updating system time
>> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
>> there is a time sample from the host which trigg
Stephen Hemminger writes:
> On Tue, 17 Jan 2017 16:27:19 +0100
> Vitaly Kuznetsov wrote:
>
>> With TimeSync version 4 protocol support we started updating system time
>> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
>> there is a time sample from the host which trigg
On Tue, 17 Jan 2017 16:27:19 +0100
Vitaly Kuznetsov wrote:
> With TimeSync version 4 protocol support we started updating system time
> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
> there is a time sample from the host which triggers do_settimeofday[64]().
> While t
On Tue, 17 Jan 2017 16:27:17 +0100
Vitaly Kuznetsov wrote:
> With TimeSync version 4 protocol support we started updating system time
> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
> there is a time sample from the host which triggers do_settimeofday[64]().
> While t
With TimeSync version 4 protocol support we started updating system time
continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
there is a time sample from the host which triggers do_settimeofday[64]().
While the time from the host is very accurate such adjustments may cause
iss
do_settimeofday() is deprecated, use do_settimeofday64() instead.
Signed-off-by: Vitaly Kuznetsov
Acked-by: John Stultz
---
drivers/hv/hv_util.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index e770774..94719eb 100644
--
With TimeSync version 4 protocol support we started updating system time
continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
there is a time sample from the host which triggers do_settimeofday[64]().
While the time from the host is very accurate such adjustments may cause
iss
From: Vaibhav Agarwal
Proper byte order was completely disregarded for multi byte data shared
between AP and module (and APB1). Fix this.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_module.c | 2 +-
drivers/staging/greybus/audio_topology.c | 88 +
From: Vaibhav Agarwal
Uninitialized variable sig_bits was used while configuring stream params
for codec module. These params are used to configure PCM settings for
APBridgeA.
Usually, this is dependent on codec capability and thus populated via
codec dai_driver definition. In our case, it is fi
From: Vaibhav Agarwal
Dummy codec register were initially added while populating dummy codec
mixer controls until module topology parser was available. Now, these
dummy registers are nowhere used and thus can be safely removed.
Since ASoC framework requires a valid callback for both read & write
This patch series include following cleanup changes in GB Audio driver.
- Avoid unnecessary checks for le32 variables
- Initialize sig_bits before configuring hw_params
- Remove junk codec register mapping
- Ensure proper byte ordering
Next task is to enable build for GB codec driver. However this
mixer control->info call back function checks for -ve values to rebase
min and max values. However, le32 variable is used to fetch values from
GB module FW. Thus -ve value checking is not required. Fix this!!
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 12 --
On Tue, Jan 17, 2017 at 12:47:30AM -0800, Joe Perches wrote:
> On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> > On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > > Split line at boolean operator.
> > >
> > > Error was reported by checkpatch.pl as
> > > WARNING: Avoid
Thomas Gleixner writes:
> On Fri, 13 Jan 2017, Vitaly Kuznetsov wrote:
>> With TimeSync version 4 protocol support we started updating system time
>> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds
>> there is a time sample from the host which triggers do_settimeofday[6
If the call to devm_iio_device_alloc() fails, then isl29028_probe()
logs a message saying that memory cannot be allocated. The user's system
most likely has larger issues at this point. This patch removes that
error message since the error code is passed on and the message is not
necessary.
Signed
isl29028_chip_init_and_power_on() calls isl29028_set_als_scale() and
this is not needed until the user actually needs to take a reading from
the ALS/IR sensor. This patch moves the isl29028_set_als_scale() call
from isl29028_chip_init_and_power_on() to isl29028_set_als_ir_mode().
This sets the stag
This patch adds runtime power management support to the isl29028 driver.
It defaults to powering off the device after two seconds of inactivity.
isl29028_chip_init_and_power_on() currently only zeros the CONFIGURE
register on the chip, which will cause the chip to turn off. This patch
also renames
On Tue, 2017-01-17 at 11:27 +0300, Dan Carpenter wrote:
> On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> > Split line at boolean operator.
> >
> > Error was reported by checkpatch.pl as
> > WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
[]
> > diff
The #define ISL29028_DEV_ATTR was not used so this patch removes the
unnecessary code.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/iio/light/isl29028.c
b/drivers/staging/iio/light/isl29028.c
index d05d76
isl29028_enable_proximity() has a boolean argument named enable. This
function is only called once and the enable flag is set to true in that
call. This patch removes the enable parameter from that function.
Signed-off-by: Brian Masney
---
The device gets runtime power management support in the n
The wording and style of the different error messages was not
consistent. This patch makes the wording and style consistent
throughout the driver.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 56
1 file changed, 32 insertions(+), 24
The alignment of the variables in the struct isl29028_chip is not
consistent. This changes all of the variables to use consistent
alignment to improve the code readability.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 10 +-
1 file changed, 5 insertions(+), 5 de
isl29028_write_raw() contains unnecessary parenthesis when checking to
see if the passed in lux scale is valid. This patch removes the
unnecessary parenthesis.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
isl29028_chip_init_and_power_on() calls isl29028_set_proxim_sampling()
and this is not needed until the user actually needs to take a proximity
reading. This patch moves the isl29028_set_proxim_sampling() call from
isl29028_chip_init_and_power_on() to isl29028_enable_proximity().
This sets the stag
Add and remove newlines to improve code readability in preparation for
moving the driver out of staging.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 33 -
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/iio
Two separate calls to regmap_update_bits() in isl29028_set_als_scale()
and isl29028_set_als_ir_mode() did not have their function arguments
on the next line aligned correctly to the open parenthesis. This patch
corrects the alignment.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl
If the call to isl29028_chip_init_and_power_on() in isl29028_probe()
fails, then isl29028_probe() will log an error message. All of the
error paths in that call path already have error logging in place. This
patch removes the unnecessary logging.
Signed-off-by: Brian Masney
---
drivers/staging/i
When isl29028_set_proxim_sampling() fails, it was up to both callers to
log the failure message. This patch moves the logging into
isl29028_set_proxim_sampling() to reduce the overall amount of code in
the driver.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 31
When isl29028_set_als_scale() fails, it was up to both callers to log
the failure message. This patch moves the logging into
isl29028_set_als_scale() to reduce the overall amount of code in the
driver.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/isl29028.c | 27 ++--
isl29028_proxim_get() checks to see if the promixity needs to be
enabled on the chip and then calls isl29028_read_proxim(). There
are no other callers of isl29028_read_proxim(). The naming between
these two functions can be confusing so this patch combines the
two to avoid the confusion.
Signed-of
This patch set contains more of my cleanups to the isl29028 light driver
in preparation for moving the driver out of staging. The main feature
introduced by this patch set is support for runtime power management
and autosuspend after two seconds. The rest of the patches are minor
code improvements,
On Tue, Jan 17, 2017 at 09:11:28AM +0100, Dhananjay Balan wrote:
> Split line at boolean operator.
>
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
>
> Signed-off-by: Dhananjay Balan
> ---
> drivers/staging/fsl-mc/bus/irq-
Split line at boolean operator.
Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference - prefer 'mc_msi_domain->host_data'
Signed-off-by: Dhananjay Balan
---
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
54 matches
Mail list logo
