Re: [PATCH] staging: rtl8192u: Correct coding style issues.

2017-01-10 Thread Greg KH
On Tue, Jan 10, 2017 at 11:23:20PM +0100, Javier Rodriguez wrote: > Add character '*' in all lines of the block comments. > Also remove one unnecessary line. When you have to say "also", that's a huge hint that you need to break the patch up into different patches. Please do so here and resend.

[PATCH] staging: wlan-ng: Fix sparse warnings about endianness

2017-01-10 Thread Eric Salem
Fixed sparse warnings about endianness. E.g.: warning: cast to restricted __le16 Signed-off-by: Eric Salem --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 6

[PATCH] staging:vt6656:mac.c Aligned to match open parenthesis

2017-01-10 Thread Scott Matheina
Fixes checkpatch warning: Alignment should match open parenthesis Signed-off-by: Scott Matheina --- drivers/staging/vt6656/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c index 86d98bc..417fdad 100644 --- a

Re: [PATCH] staging: greybus: loopback_test: fix checkpatch bad function definition error

2017-01-10 Thread Viresh Kumar
On Wed, Jan 11, 2017 at 6:59 AM, Abdul Rauf wrote: > Fix the following Errors: > Bad function definition - void abort() should probably be void abort(void) > > Signed-off-by: Abdul Rauf > --- > drivers/staging/greybus/tools/loopback_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] staging: greybus: fix checkpatch braces not necessary warning

2017-01-10 Thread Viresh Kumar
On Wed, Jan 11, 2017 at 6:25 AM, Abdul Rauf wrote: > Fix the following warnings: > braces {} are not necessary for any arm of this statement > > Signed-off-by: Abdul Rauf > --- > drivers/staging/greybus/loopback.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Acked-by: Viresh K

[PATCH 9/9] treewide: Inline ib_dma_map_*() functions

2017-01-10 Thread Bart Van Assche
Almost all changes in this patch except the removal of local variables that became superfluous and the actual removal of the ib_dma_map_*() functions have been generated as follows: git grep -lE 'ib_(sg_|)dma_' | xargs -d\\n \ sed -i -e 's/\([^[:alnum:]_]\)ib_dma_\([^(]*\)(\&\([^,]\+\),/\1d

[PATCH v2] staging: most: hdm-usb: Fix mismatch between types used in sizeof operator

2017-01-10 Thread Eric Salem
Fixed mismatch between types used in sizeof operator. Signed-off-by: Eric Salem --- drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 8a6da16..01e3a

[PATCH] staging: rtl8192u: Correct coding style issues.

2017-01-10 Thread Javier Rodriguez
Add character '*' in all lines of the block comments. Also remove one unnecessary line. Signed-off-by: Javier Rodriguez --- drivers/staging/rtl8192u/r8180_93cx6.h | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Joe Perches
On Tue, 2017-01-10 at 23:40 +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names Please read Documentation/SubmittingPatches (umm, m

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Greg KH
On Tue, Jan 10, 2017 at 11:40:30PM +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names > > Sent against staging-next. > > Signed-o

[PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Bogdan Purcareata
Fix following checkpatch warnings: - Lines over 80 characters - void function with return statement - Unaligned comment mark - Header function prototypes missing variable names Sent against staging-next. Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion-ioctl.c | 3 ++- dri

[PATCH] staging: greybus: loopback_test: fix checkpatch bad function definition error

2017-01-10 Thread Abdul Rauf
Fix the following Errors: Bad function definition - void abort() should probably be void abort(void) Signed-off-by: Abdul Rauf --- drivers/staging/greybus/tools/loopback_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/dr

[PATCH] staging: greybus: fix checkpatch braces not necessary warning

2017-01-10 Thread Abdul Rauf
Fix the following warnings: braces {} are not necessary for any arm of this statement Signed-off-by: Abdul Rauf --- drivers/staging/greybus/loopback.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback

RE: [PATCH] staging: unisys: fix checkpatch block comments warning

2017-01-10 Thread Kershner, David A
> -Original Message- > From: Abdul Rauf Mujahid [mailto:abdulraufmuja...@gmail.com] > Sent: Tuesday, January 10, 2017 6:51 PM > To: Kershner, David A ; > gre...@linuxfoundation.org; j...@redhat.com; *S-Par-Maintainer > > Cc: de...@driverdev.osuosl.org > Subject: Re: [PATCH] staging: unisys

Re: [PATCH] staging: unisys: fix checkpatch block comments warning

2017-01-10 Thread Abdul Rauf Mujahid
On 01/10/2017 06:36 PM, Kershner, David A wrote: >> -Original Message- >> From: Abdul Rauf [mailto:abdulraufmuja...@gmail.com] >> Sent: Tuesday, January 10, 2017 6:24 PM >> To: gre...@linuxfoundation.org; j...@redhat.com; *S-Par-Maintainer >> >> Cc: de...@driverdev.osuosl.org >> Subject:

RE: [PATCH] staging: unisys: fix checkpatch block comments warning

2017-01-10 Thread Kershner, David A
> -Original Message- > From: Abdul Rauf [mailto:abdulraufmuja...@gmail.com] > Sent: Tuesday, January 10, 2017 6:24 PM > To: gre...@linuxfoundation.org; j...@redhat.com; *S-Par-Maintainer > > Cc: de...@driverdev.osuosl.org > Subject: [PATCH] staging: unisys: fix checkpatch block comments wa

[PATCH] staging: unisys: fix checkpatch block comments warning

2017-01-10 Thread Abdul Rauf
Fix the following warnings: Block comments should align the * on each line Signed-off-by: Abdul Rauf --- drivers/staging/unisys/visorbus/visorchipset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/vis

Re: [PATCH 01/18] Drivers: hv: vmbus: Move the definition of hv_x64_msr_hypercall_contents

2017-01-10 Thread Greg KH
On Fri, Dec 30, 2016 at 01:35:55PM -0800, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > As part of the effort to separate out architecture specific code, move the > definition of hv_x64_msr_hypercall_contents to x86 specific header file. > > Signed-off-by: K. Y. Srinivasan > -

Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-10 Thread roman . sommer
> Fair enough, but you are fixing all of these new "unsigned int" > warnings in that driver, right? > > How about fixing the sole remaining instance in the loopback driver so > that this is done for the whole subsystem once and for all? Thanks for the hint, I will do that. ___

Re: [PATCH 0/9] staging: vc04_services: Clean up vchiq driver

2017-01-10 Thread Greg Kroah-Hartman
On Sun, Jan 08, 2017 at 06:15:09PM +, Stefan Wahren wrote: > This is a loose bunch of clean up patches for the bcm2835 vchiq driver. All now applied, thanks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverpr

Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-10 Thread Johan Hovold
On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote: > From: Christian Bewermeyer > > Note that this patch does not fix all checkpatch warnings for > gpio.c Fair enough, but you are fixing all of these new "unsigned int" warnings in that driver, right? How about fixing the sole remaini

Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16

2017-01-10 Thread Greg KH
On Mon, Jan 09, 2017 at 09:25:56PM -0600, Eric Salem wrote: > Fixed the following sparse warning: > > drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning: > cast to restricted __le16 > > by correcting the variable's type (also updated sizeof). > > Signed-off-by: Eric Salem > Acked-by: Christ

[PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int

2017-01-10 Thread Roman Sommer
From: Christian Bewermeyer Note that this patch does not fix all checkpatch warnings for gpio.c Signed-off-by: Christian Bewermeyer Signed-off-by: Roman Sommer --- drivers/staging/greybus/gpio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dri

Re: [PATCH v2] Staging: greybus: style fix, permissions as octal

2017-01-10 Thread Greg KH
On Mon, Jan 09, 2017 at 02:24:29PM +0100, Johan Hovold wrote: > On Fri, Jan 06, 2017 at 08:43:57PM +1300, Derek Robson wrote: > > Changed permissions to be in octal style. > > Found by checkpatch. > > > > Signed-off-by: Derek Robson > > --- > > > > This version of patch also make the file type p

Re: [PATCH v2 0/4] hv_util: adjust system time smoothly

2017-01-10 Thread Thomas Gleixner
Vitaly, On Tue, 10 Jan 2017, Vitaly Kuznetsov wrote: > Thomas Gleixner writes: > > 1) do_adjtimex() is assuming that there is a single client connected which > >is responsible for the updates. So I seriously doubt that a NTP client > >running in the guest will cooperate nicely with that t

Re: [PATCH v2 0/4] hv_util: adjust system time smoothly

2017-01-10 Thread Vitaly Kuznetsov
Thomas Gleixner writes: > On Wed, 4 Jan 2017, Vitaly Kuznetsov wrote: > >> Changes since v1: >> - do do_settimeofday64() when ICTIMESYNCFLAG_SYNC flag is present in the >> request (Alex Ng) >> - add pr_debug() for the case when do_adjtimex() fails (Alex Ng) >> >> Original description: >> >> W

[PATCH] vme: Fix wrong pointer utilization in ca91cx42_slave_get

2017-01-10 Thread Augusto Mecking Caringi
In ca91cx42_slave_get function, the value pointed by vme_base pointer is set through: *vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]); So it must be dereferenced to be used in calculation of pci_base: *pci_base = (dma_addr_t)*vme_base + pci_offset; This bug was caught thanks to the foll

[PATCH next] rtlwifi: rtl8192de: fix missing curly braces

2017-01-10 Thread Vincent Stehlé
Cc: Larry Finger Cc: Kalle Valo Cc: Joe Perches Cc: Ping-Ke Shih --- Hi, I saw that in Linux next-20170110. Best regards, Vincent. drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwi

Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16

2017-01-10 Thread Christian Gromm
On Mon, 9 Jan 2017 21:25:56 -0600 Eric Salem wrote: > Fixed the following sparse warning: > > drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning: > cast to restricted __le16 > > by correcting the variable's type (also updated sizeof). > > Signed-off-by: Eric Salem Acked-by: Christian Gro