[PATCH] Staging: comedi: comedi_compat32: fixed a syntax error

2016-12-25 Thread Jonathan Villatoro
Fixed a syntax error in the function definition's parameter. Signed-off-by: Jonathan Horacio Villatoro Córdoba --- drivers/staging/comedi/comedi_compat32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_compat32.h b/drivers/staging/comedi/comed

Re: [PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread Al Viro
On Sun, Dec 25, 2016 at 10:34:54PM +, Jonathan Cameron wrote: > > > On 25 December 2016 20:14:09 GMT+00:00, Al Viro > wrote: > >On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: > >> Across the file, variables were sometimes upper case, some times > >> lower case, this fix add

Re: [PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread Jonathan Cameron
On 25 December 2016 20:14:09 GMT+00:00, Al Viro wrote: >On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: >> Across the file, variables were sometimes upper case, some times >> lower case, this fix addresses a few of the instances with this >> inconsistency. > >NAK. Go learn C and

Re: [PATCHv4 8/8] Fixes style issues due to mis-aligned carry over lines

2016-12-25 Thread kbuild test robot
Hi Scott, [auto build test ERROR on iio/togreg] [also build test ERROR on v4.9 next-20161224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio

Re: [PATCHv4 3/8] Fix camel case issues

2016-12-25 Thread kbuild test robot
Hi Scott, [auto build test ERROR on iio/togreg] [also build test ERROR on v4.9 next-20161224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio

Re: [PATCHv4 7/8] Changed code to align with coding style of using octat

2016-12-25 Thread kbuild test robot
Hi Scott, [auto build test ERROR on iio/togreg] [also build test ERROR on v4.9 next-20161224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio

Re: [PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread kbuild test robot
Hi Scott, [auto build test ERROR on iio/togreg] [also build test ERROR on v4.9 next-20161224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio

Re: [PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread Al Viro
On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote: > Across the file, variables were sometimes upper case, some times > lower case, this fix addresses a few of the instances with this > inconsistency. NAK. Go learn C and don't come back until you've done that. If somebody has told y

[PATCHv4 7/8] Changed code to align with coding style of using octat

2016-12-25 Thread Scott Matheina
The permmission code was changed to reflect octat (0644/0444) for required permissions. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 264 ++-- 1 file changed, 101 insertions(+), 163 deletions(-) diff --git a/drivers/staging/iio/addac/a

[PATCHv4 8/8] Fixes style issues due to mis-aligned carry over lines

2016-12-25 Thread Scott Matheina
Lines were not aligned with (, this patch simply changes the indention, no substantive changes function of driver. Signed-Off-By: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 415 ++-- 1 file changed, 210 insertions(+), 205 deletions(-) diff --git a/

[PATCHv4 6/8] Fixed code wrap alignment with preceding (.

2016-12-25 Thread Scott Matheina
The code wasn't aligned with preceding ( on following lines, fixes this coding style issue. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/iio/addac/adt

[PATCHv4 5/8] Remove line after closing braces

2016-12-25 Thread Scott Matheina
There was an additional line which was un-needed, removed that line. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index e78d302..4678a64 100644 -

[PATCHv4 4/8] Fix braces not present on all arms of if else statement

2016-12-25 Thread Scott Matheina
Adds braces to second arm of if else statement. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 2b584a0..e78d302 100644 ---

[PATCHv4 3/8] Fix camel case issues

2016-12-25 Thread Scott Matheina
Cases of camel case were fixed by making variables lower case throughout the file. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c

[PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread Scott Matheina
Across the file, variables were sometimes upper case, some times lower case, this fix addresses a few of the instances with this inconsistency. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 48 ++--- 1 file changed, 24 insertions(+), 24 d

[PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac

2016-12-25 Thread Scott Matheina
*** BLURB HERE *** Scott Matheina (8): fixed long description text exceeding 80 characters Fixed variables not being consistently lower case Fix camel case issues Fix braces not present on all arms of if else statement Remove line after closing braces Fixed code wrap alignment with pre

[PATCHv4 1/8] fixed long description text exceeding 80 characters

2016-12-25 Thread Scott Matheina
The description was split into 2 lines due to the line greatly exceeding the 80 character soft limit. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging

[PATCHv4 7/8] Changed code to align with coding style of using octat

2016-12-25 Thread Scott Matheina
The permmission code was changed to reflect octat (0644/0444) for required permissions. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 264 ++-- 1 file changed, 101 insertions(+), 163 deletions(-) diff --git a/drivers/staging/iio/addac/a

[PATCHv4 2/8] Fixed variables not being consistently lower case

2016-12-25 Thread Scott Matheina
Across the file, variables were sometimes upper case, some times lower case, this fix addresses a few of the instances with this inconsistency. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 48 ++--- 1 file changed, 24 insertions(+), 24 d

[PATCHv4 3/8] Fix camel case issues

2016-12-25 Thread Scott Matheina
Cases of camel case were fixed by making variables lower case throughout the file. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c

[PATCHv4 5/8] Remove line after closing braces

2016-12-25 Thread Scott Matheina
There was an additional line which was un-needed, removed that line. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index e78d302..4678a64 100644 -

[PATCHv4 4/8] Fix braces not present on all arms of if else statement

2016-12-25 Thread Scott Matheina
Adds braces to second arm of if else statement. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 2b584a0..e78d302 100644 ---

[PATCHv4 1/8] fixed long description text exceeding 80 characters

2016-12-25 Thread Scott Matheina
The description was split into 2 lines due to the line greatly exceeding the 80 character soft limit. Signed-off-by: Scott Matheina --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging

[PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac

2016-12-25 Thread Scott Matheina
*** BLURB HERE *** Scott Matheina (8): fixed long description text exceeding 80 characters Fixed variables not being consistently lower case Fix camel case issues Fix braces not present on all arms of if else statement Remove line after closing braces Fixed code wrap alignment with pre