Hello,
My name is Alimat Abdul and I am an American soldier serving in the Military
of the 1st Armored Division in Iraq. As you know, we are being attacked by
insurgents everyday and car bombings. We stumbled into Saddam Hussein's storage
vault and discovered funds belonging to his family. The
On 11/21/2016 09:56 PM, andrea wrote:
> This patch fix code style warnings for octeon-usb driver
>
> Signed-off-by: Andrea Ghittino
Hello Andrea,
please fix up these things and resend your patch as v2:
- The From header field of your mail should match the name in the
Signed-off-by line of yo
This patch fix code style warnings for octeon-usb driver
Signed-off-by: Andrea Ghittino
---
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..92f3a7e 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/
Add proper error handling to bus_configure and have it propagate errors
back up the stack. This helped to streamline the function as well.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 45 +-
1 file cha
From: Erik Arfvidson
The purpose of this patch is to add style consistency and beautify the
entire file.
Grammar:
Uppercased beginning of new sentences/paragraphs
Missing ' and .
Fixed several comments using prefix phrase "as is in" to "as in"
Standard Grammar
Comments:
Fixed comments to follow
It really isn't an error when you call visorchannel_signalremove and
there isn't anything in the queue. Just means that the IOSP didn't
process anything since the last time you checked. Just inform the
caller that it is empty by returning -EAGAIN.
Signed-off-by: David Kershner
---
drivers/stagin
Now that visorchannel_signalinsert returns a Linux error code, we need
to convert controlvm_respond_chipset_init to return an error instead of
a void.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 +++-
1 file changed, 3
From: Erik Arfvidson
This patch renames poorly named 'local' variable to 'dest'.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys
McCOY: You've got him, Jim! You've got him where you want him.
This patchset adds async operations to greybus-core. Rather than have
different drivers do variations on the same theme of launching and timing
out asynchronous operations, it makes sense instead to provide this
functionality via greyb
This patch adds asynchronous Greybus operation support to operation.c.
After doing a gb_operation_request_send() it schedules a delayed worker.
When the delayed worker's timer expires the worker runs and does a
gb_operation_cancel(). A gb_operation_cancel() operation will result in the
operation co
This patch adds a delayed workqueue which will be used in later patches to
provide a timeout mechanism for asynchronous operations.
Signed-off-by: Bryan O'Donoghue
---
drivers/staging/greybus/operation.c | 15 +++
drivers/staging/greybus/operation.h | 1 +
2 files changed, 16 insert
Pass the error returned from visorchannel_signalinsert up the stack
instead of just ignoring it.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drive
From: Erik Arfvidson
The purpose of this patch is to add style consistency and
beautify the entire file. This patch removes unused pound defines
and cleans up spacing and tabbing of pound defines.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/i
The function visorchanel_signalinsert now returns an error, propagate
the error up the stack to be handled.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --g
Propagate the error up the stack instead of ignoring it.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
The function controlvm_respond returns proper error handling, so now we
can propagate the error up and handle it appropriately.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 delet
Add proper error handling to the function save_crash_message.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 50 ++
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/unisys/
Controlvm_respond now returns an error. Add error handling to the
bus_responder function.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
Controlvm_respond_chipset_init now errors out correctly. Pass the errors
back up to the stack to be processed.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --g
The following series addresses the following issues:
- Cleanup of the iochannel.h file comments
- Additional error handling added to the controlvm path
- Change name of variables for better clarity
Changes since v1:
- regenerated via git format-patch to pick up lead
From: Erik Arfvidson
This patch renames the poorly named 'local' var to 'dest' in
the visorbus_private.h file
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_private.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
Earlier versions of the loopback code released the per-device mutex
in-order to allow for more parallel asynchronous send/receive paths to
execute. In the interim though new variables have been added to the
struct gb_loopback{}; structure and as a result gb->send_count is now racy
w/r to the contro
The API presented by operation.h expects milliseconds to be passed in.
This patch drops the conversion from user-input microseconds-to-jiffies and
from jiffies-to-milliseconds and instead converts directly from
microseconds-to-milliseconds. The new minimum timeout will be one
millisecond as opposed
Loopback has its own internal method for tracking and timing out
asynchronous operations however previous patches make it possible to use
functionality provided by operation.c to do this instead. Using the code in
operation.c means we can completely subtract the timer, the work-queue, the
kref and
Asynchronous operation completion handler's lives are made easier if there
is a generic pointer that can store private data associated with the
operation. This patch adds a pointer field to operation.h and get/set
methods to access that pointer.
Signed-off-by: Bryan O'Donoghue
---
drivers/stagin
This patch changes macros into inline functions to avoid this checkpatch
check:
Macro argument 'x' may be better as '(x)' to avoid precedence issues
It also removes two macros because they aren't being used.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/slicoss/slic.h| 20 ++
On Mon, Nov 21, 2016 at 10:58:29AM -0500, David Kershner wrote:
> From: Erik Arfvidson
>
> The purpose of this patch is to add style consistency and beautify the
> entire file.
>
> Grammar:
> Uppercased beginning of new sentences/paragraphs
> Missing ' and .
> Fixed several comments using prefix
The function controlvm_respond returns proper error handling, so now we
can propagate the error up and handle it appropriately.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 delet
From: Erik Arfvidson
The purpose of this patch is to add style consistency and
beautify the entire file. This patch removes unused pound defines
and cleans up spacing and tabbing of pound defines.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/i
The following series addresses the following issues:
- Cleanup of the iochannel.h file comments
- Additional error handling added to the controlvm path
- Change name of variables for better clarity
David Kershner (10):
staging: unisys: visorbus: controlvm_respond_chipset_
Controlvm_respond_chipset_init now errors out correctly. Pass the errors
back up to the stack to be processed.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --g
Add proper error handling to the function save_crash_message.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 50 ++-
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/unisys/visorbu
It really isn't an error when you call visorchannel_signalremove and
there isn't anything in the queue. Just means that the IOSP didn't
process anything since the last time you checked. Just inform the
caller that it is empty by returning -EAGAIN.
Signed-off-by: David Kershner
---
drivers/stagin
Pass the error returned from visorchannel_signalinsert up the stack
instead of just ignoring it.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drive
Add proper error handling to bus_configure and have it propagate errors
back up the stack. This helped to streamline the function as well.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 45 ---
1 file changed, 2
Controlvm_respond now returns an error. Add error handling to the
bus_responder function.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
The function visorchanel_signalinsert now returns an error, propagate
the error up the stack to be handled.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --g
Propagate the error up the stack instead of ignoring it.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b
From: Erik Arfvidson
The purpose of this patch is to add style consistency and beautify the
entire file.
Grammar:
Uppercased beginning of new sentences/paragraphs
Missing ' and .
Fixed several comments using prefix phrase "as is in" to "as in"
Standard Grammar
Comments:
Fixed comments to follow
Now that visorchannel_signalinsert returns a Linux error code, we need
to convert controlvm_respond_chipset_init to return an error instead of
a void.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/visorchipset.c | 8 +++-
1 file changed, 3
From: Erik Arfvidson
This patch renames poorly named 'local' variable to 'dest'.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorchannel.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys
From: Erik Arfvidson
This patch renames the poorly named 'local' var to 'dest' in
the visorbus_private.h file
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_private.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --gi
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dri
Make modifications to comment style
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/speakup/speakup_soft.c
b/drivers/
Make suggested checkpatch modification for
CHECK: Please don't use multiple blank lines
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/speakup/
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary after an
open brace '{'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
Make Linux kernel style modifications for speak_soft.c to include:
Space around operator
Logical continuation
Multiple blank lines
Blank line after {
comment modifications
Align parenthesis
Walt Feasel (6):
staging: speakup: speakup_soft.c Space around operator
staging: speakup: speakup_soft.
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_soft.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletion
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_spkout.c | 24
1 file changed, 12 insertions(+), 12 deletions(
Make modifications to comments
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_spkout.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/speakup_spkout.c
b/drivers/sta
Make Linux kernel style modifications for speakup_spkout.c to include:
comment modifications
Space around operator
Walt Feasel (2):
staging: speakup: speakup_spkout.c comment modifications
staging: speakup: speakup_spkout.c Space around operator
drivers/staging/speakup/speakup_spkout.c | 31
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_txprt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Make Linux kernel style modifications to speakup-txprt.c to include:
Comment modifications
Spaces preferred around operator
Walt Feasel (2):
staging: speakup: speakup_txprt.c Comment modifications
staging: speakup: speakup_txprt.c Spaces preferred around operator
drivers/staging/speakup/sp
Make modifications to comments
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/speakup_txprt.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/speakup_txprt.c
b/drivers/stagi
Make Linux kernel style modifications to spk_priv_keyinfo.h to include:
align columns
Space around operator
Walt Feasel (2):
staging: speakup: spk_priv_keyinfo.h align columns
staging: speakup: spk_priv_keyinfo.h Space around operator
drivers/staging/speakup/spk_priv_keyinfo.h | 148 +++
Make suggested checkpatch modification for
CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_priv_keyinfo.h | 44 +++---
1 file changed, 22 insertions(+), 22 de
Make modifications to align columns
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_priv_keyinfo.h | 104 ++---
1 file changed, 51 insertions(+), 53 deletions(-)
diff --git a/drivers/staging/speaku
Make Linux kernel style modifications to spk_types.h to include:
Comment modifications
Align parenthesis
Walt Feasel (2):
staging: speakup: spk_types.h Comment modifications
staging: speakup: spk_types.h Align parenthesis
drivers/staging/speakup/spk_types.h | 16 +++-
1 file cha
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
Make modifications to comment style
Signed-off-by: Walt Feasel
---
v2 makes changes to correct for email format patch submission
drivers/staging/speakup/spk_types.h | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/speakup/spk_types.h
b/drivers/
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
ind
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel
---
drivers/staging/emxx_udc/emxx_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emx
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line
Signed-off-by: Walt Feasel
---
drivers/staging/emxx_udc/emxx_udc.c | 37 +++--
1 file changed, 15 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/em
Make suggested checkpatch modification for
WARNING: braces {} are not necessary for single
statement blocks
Signed-off-by: Walt Feasel
---
drivers/staging/emxx_udc/emxx_udc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/stag
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary after an
open brace '{'
Signed-off-by: Walt Feasel
---
drivers/staging/emxx_udc/emxx_udc.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_
Make Linux kernel style modifications for emxx_udc.c to include:
Blank lines after {
Logical continuation
Single statement blocks
Spaces preferred around operators
Align parenthesis
Walt Feasel (5):
staging: emxx_udc: emxx_udc.c Blank lines after {
staging: emxx_udc: emxx_udc.c Logical contin
On Mon, Nov 21, 2016 at 11:09 AM, Greg KH wrote:
> Ok, I'm lost too, sorry. I looked at the driver and shmem_data is
> created by calling pci_zalloc_consistent, and that's not __iomem space,
> but a real pointer.
>
> So your patch is correct here, sorry for the noise, I'll go apply it.
>
> thank
> On 21 Nov 2016, at 10:05, Greg KH wrote:
>
>> On Sat, Nov 19, 2016 at 11:03:28PM +0100, Samuel Thibault wrote:
>> Hello,
>>
>> Just looking over the patch, it looks good. I don't think it needs to be
>> split in 4 pieces though, I'd say merge patches 1, 3, and 4 together,
>> where patch 3 wo
On Sun, Nov 20, 2016 at 05:20:08PM -0800, Vijai Kumar K wrote:
> Fix checkpatch warning:
> WARNING: Statements should start on a tabstop
>
> Signed-off-by: Vijai Kumar K
> ---
> drivers/staging/rtl8712/rtl8712_led.c | 24
> drivers/staging/rtl8712/rtl871x_recv.c | 2 +-
On Mon, Nov 21, 2016 at 12:46:48AM -0500, Oleg Drokin wrote:
> From: Jian Yu
>
> This patch removes the usage of MAX_STRING_SIZE from
> copy_from_user() and just copies enough bytes to cover
> count passed in.
>
> Signed-off-by: Jian Yu
> Reviewed-on: http://review.whamcloud.com/23462
> Intel-b
On Sun, Nov 20, 2016 at 09:21:51AM +0100, Sergio Paracuellos wrote:
> On Sat, Nov 19, 2016 at 2:20 PM, Greg KH wrote:
> > On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
> >> Remove incorrect __iomem annotation.
> >>
> >> This patch fix the following sparse warnings in slicoss
On Sat, Nov 19, 2016 at 11:03:28PM +0100, Samuel Thibault wrote:
> Hello,
>
> Just looking over the patch, it looks good. I don't think it needs to be
> split in 4 pieces though, I'd say merge patches 1, 3, and 4 together,
> where patch 3 would be modified to make dummy use spk_serial_out too, to
The indent code blocks of the else statements were unnecessary
and are better written without them.
Signed-off-by: Shiva Kerdel
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++--
drivers/staging/rtl8712/rtl871x_mlme.c| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
di
74 matches
Mail list logo
