Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

Hi Lino, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20

[net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit) coppe

[net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git://linuxtv.

Gigabit ethernet driver for Alacritechs SLIC devices

Hi, this is a rework of the slicoss gigabit ethernet driver from Alacritech that is currently part of the staging area. The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepted the staging version can be removed (as Greg told me by

[PATCH] [STYLE]staging:dgcn:digi.h Spelling correction

Make spelling correction for "regular" Signed-off-by: Walt Feasel --- drivers/staging/dgnc/digi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h index 4e36573..bfd80ca 100644 --- a/drivers/staging/dgnc/digi.h +++ b/dr

[PATCH] [STYLE 4/4]staging:dgnc:dgnc_tty.c waitqueue_active comment

Made suggested modifications from checkpatch in reference to WARNING: waitqueue_active without comment Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_tty.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 72f47

[PATCH] [STYLE 3/4]staging:dgnc:dgnc_tty.c Modify block comments

Make block comment format changes to comply with style guides Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_tty.c | 166 1 file changed, 66 insertions(+), 100 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgn

[PATCH v2] [STYLE 2/4]staging:dgnc:dgnc_tty.c Spelling corrections

Make spelling corrections for satisfy and transitions Signed-off-by: Walt Feasel --- v2 resubmitted without behaviour drivers/staging/dgnc/dgnc_tty.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c i

Re: [PATCH] [STYLE 2/4]staging:dgnc:dgnc_tty.c Spelling corrections

On 11/12/16 15:53, Walt Feasel wrote: > Made various spelling corrections in the comments Make > > Signed-off-by: Walt Feasel > --- > drivers/staging/dgnc/dgnc_tty.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drive

[PATCH] [STYLE 2/4]staging:dgnc:dgnc_tty.c Spelling corrections

Made various spelling corrections in the comments Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_tty.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 52be33f..4240609 100644 --- a/

[PATCH] [STYLE 1/4]staging:dgnc:dgnc_tty.c Space preferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

Hi Walt, Thanks for the patch, unfortunately, it's a NAK. If you search the ml archives, you'll see this has been addressed before. On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to CHECK: Please don't use multiple blank

[PATCH] [STYLE 2/2]staging:dgnc:dgnc_sysfs.c Delete blank line

Removed unnecessary blankline at end of file Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_sysfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index 6e8c53b..d41517c 100644 --- a/drivers/staging/dgnc/dgnc_sy

[PATCH] [STYLE 1/2]staging:dgnc:dgnc_sysfs.c Modify block text

Modified multiline comment for style consistency Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index 290bf6e..6e8c53b 100644 --- a/drive

[PATCH] [STYLE 1/2]staging:dgnc:dgnc_neo.c block comment modifications

Modified block comments for style consistency Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 5becb37..03fc58e 1006

[PATCH] [STYLE 2/2]staging:dgnc:dgnc_neo.c block comment modifications

Modified block comments for style consistency Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 03f

[PATCH] [STYLE 2/2]staging:dgnc:dgnc_driver.h block comment modifications

Modified block comments for style consistency Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 03f

[PATCH] [STYLE 1/2]staging:dgnc:dgnc_driver.h block comment modifications

Modified block comments for style consistency Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_neo.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 5becb37..03fc58e 1006

[PATCH] [STYLE]staging:dgnc:dgnc_driver.h Spelling correction

Corrected spelling mistake for statements Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h index 8792026..5770a85 100644 --- a/drivers/sta

[PATCH] [STYLE]staging:dgnc:dgnc_driver.c Blankline before }

Made suggested modifications from checkpatch in reference to CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgn

[PATCH] [STYLE]staging:dgnc:dgnc_cls.h Spelling correction

Corrected a spelling mistake for control Signed-off-by: Walt Feasel --- drivers/staging/dgnc/dgnc_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h index 2597e36..463ad30 100644 --- a/drivers/staging/dgnc/d

[PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

Made suggested modifications from checkpatch in reference to CHECK: Please don't use multiple blank lines Signed-off-by: Walt Feasel --- drivers/staging/skein/threefish_block.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/skein/threefish_block.c b/drivers

[PATCH] Revert "[STYLE]staging:MAINTAINERS email revision speakup"

This reverts commit 0970517be9d3d3e3a2fd5aa5a9938318b375f2d0. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 40d272c..ec1ee3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11540,7 +11540,7 @@ F: drivers/staging/slicoss/ ST

[PATCH] [STYLE]staging:speakup:TODO Modify current email

Modified email address to reflect current address Signed-off-by: Walt Feasel --- drivers/staging/speakup/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO index 3094799..993410c 100644 --- a/drivers/staging/speaku

Re: [PATCH] [STYLE]staging:MAINTAINERS email revision speakup

Walt Feasel writes: > Modified email address per the TODO file in > speakup's email listing, also verified email > address from speakup's website NAK. The website needs updating, because it has Kirk's old addresses. k...@reisers.ca is correct. ___ dev

[PATCH] [STYLE]staging:MAINTAINERS email revision speakup

Modified email address per the TODO file in speakup's email listing, also verified email address from speakup's website Signed-off-by: Walt Feasel --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ec1ee3e..40d272c 100644 --- a/MAI

[PATCH] [STYLE 2/2]staging:speakup:varhandlers.c Align match parenthesis

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/varhandlers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/varhandlers.c b/driver

[PATCH v4 26/26] staging: iio: tsl2583: move out of staging

Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline. Signed-off-by: Brian Masney --- .../ABI/testing/sysfs-bus-iio-light-tsl2583| 20 + drivers/iio/light/Kconfig | 7 + drivers/iio/light/Makefile | 1 + drivers/iio/ligh

[PATCH v4 25/26] staging: iio: tsl2583: add copyright and MODULE_AUTHOR

Add Brian Masney's copyright to the header and to the MODULE_AUTHOR for all of the staging cleanups that has been done to this driver. The original MODULE_AUTHOR() did not have a space between his name and email address. This patch also adds the missing space. Signed-off-by: Brian Masney --- dr

[PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset call

The entries in the lux table (als_device_lux) can be updated via sysfs through the function in_illuminance_lux_table_store(). The last row in the table must be terminated with values that are zero. The sysfs code already ensures that the last row is all zeros. The call to memset to clear out the ta

[PATCH v4 22/26] staging: iio: tsl2583: remove comment for tsl2583_probe()

The comment for tsl2583_probe() does not provide any useful value. This patch removes the comment. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c

[PATCH v4 24/26] staging: iio: tsl2583: remove unnecessary variable initialization

The ret variable in tsl2583_suspend() and tsl2583_resume() was initialized to 0. This is not necessary so this patch removes the initialization. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH v4 19/26] staging: iio: tsl2583: move from a global to a per device lux table

The driver contains a global lux table that can be updated via sysfs. Change this to a per device lux table so that multiple devices can be hooked up to the same system with different lux tables. There are 10 entries, plus 1 for the termination segment, set aside for the entries in the lux table.

[PATCH v4 21/26] staging: iio: tsl2583: clarified comment about clearing interrupts

The comment that describes the code that clears the interrupt bit was vague and didn't provide much value. This patch adds more detail about why that bit needs to be cleared. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletio

[PATCH v4 20/26] staging: iio: tsl2583: add tsl2583 to list of supported devices in the header

The header only listed the tsl2580 and tsl2581 devices as supported by this driver. This patch adds the tsl2583 since it is also supported by this driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v4 14/26] staging: iio: tsl2583: updated code comment to match what the code does

If channel 0 does not have any data, then the code sets the lux to zero. The corresponding comment says that the last value is returned. This updates the comment to correctly reflect what the code does. It also clarifies the comment about why 0 is returned. Signed-off-by: Brian Masney --- driver

[PATCH v4 17/26] staging: iio: tsl2583: remove unnecessary parentheses

in_illuminance_lux_table_store() contains some unnecessary parentheses. This patch removes them since they provide no value. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/tsl25

[PATCH v4 09/26] staging: iio: tsl2583: fix alignment of #define values

Most of the values in the #defines have their values aligned on a single column, but some do not. This changes the remaining defines to use consistent alignment with the majority to improve code readability. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 10 +- 1 f

[PATCH v4 07/26] staging: iio: tsl2583: cleaned up logging

There are several places in the code where the function name is hardcoded in the log message. Use the __func__ constant string to build the log message. This also clarifies some of the error messages to match the code and ensures that the correct priority is used since the message is already being

[PATCH v4 18/26] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. Replace this with sizeof(value[1]). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/stagi

[PATCH v4 10/26] staging: iio: tsl2583: fix comparison between signed and unsigned integers

Fixed warning found by make W=2: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.

[PATCH v4 15/26] staging: iio: tsl2583: moved code block inside else statement

The check for ch1lux > ch0lux inside tsl2583_get_lux is only valid if the ratio is not equal to zero. Move the code block inside the else statement. This does away with the need to initialize the variables to zero. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 23

[PATCH v4 04/26] staging: iio: tsl2583: change current chip state from a tristate to a bool

The current chip state is represented as a tristate (working, suspended, and unknown). The unknown state was not used. This patch changes the chip state so that it is now represented as a single boolean value (suspended). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 20 +

[PATCH v4 06/26] staging: iio: tsl2583: remove the FSF's mailing address

Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian Masney -

[PATCH v4 16/26] staging: iio: tsl2583: change tsl2583_als_calibrate() to return 0 on success

tsl2583_als_calibrate() returns the newly computed gain_trim if the calibration was successful. This function is only called by in_illuminance_calibrate_store() and the return value inside that sysfs attribute is only checked to see if an error was returned. This patch changes tsl2583_als_calibrate

[PATCH v4 12/26] staging: iio: tsl2583: combine sysfs documentation

There are two separate files describing the tsl2583 sysfs attributes. Combine the two files into one. Updated the name of the sysfs attributes to match the current ABI. Signed-off-by: Brian Masney Suggested-by: Peter Meerwald-Stadler --- .../Documentation/light/sysfs-bus-iio-light-tsl2583 | 16

[PATCH v4 05/26] staging: iio: tsl2583: remove redundant write to the control register in taos_probe()

taos_probe() calls i2c_smbus_write_byte() to select the control register, however there are no subsequent calls to i2c_smbus_read_byte(). The write call is unnecessary and is removed by this patch. Verified that the driver still functions correctly using a TSL2581 hooked up to a Raspberry Pi 2. S

[PATCH v4 08/26] staging: iio: tsl2583: unify function and variable prefix to tsl2583_

Some functions and variables were prefixed with either taos, tsl258x, taos2583, or tsl2583. Change everything to use the tsl2583 prefix since that is the name of the .c file. The taos_settings member inside the taos_settings struct was renamed to als_settings. Signed-off-by: Brian Masney --- dri

[PATCH v4 13/26] staging: iio: tsl2583: fix multiline comment syntax

The definition of the tsl2583_device_lux struct has a series of single line comments. There are two other cases where the multiline comments did not have an initial blank line. Change these comments to use the proper multiline syntax. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl

[PATCH v4 11/26] staging: iio: tsl2583: change newlines to improve readability

Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/light/tsl2583.c b/

[PATCH] [STYLE 1/2]staging:speakup:varhandlers.c Moddified block comment

Modified block comment to multiline style Signed-off-by: Walt Feasel --- drivers/staging/speakup/varhandlers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c index 21186e3..5ab7245 100644 --- a/

[PATCH v4 02/26] staging: iio: tsl2583: remove unnecessary chip status check in taos_get_lux

taos_get_lux checks to see if the chip is in a working state. This check is not necessary since it is only called from tsl2583_read_raw and in_illuminance_calibrate_store (via taos_als_calibrate). The chip state is already checked by these functions. Signed-off-by: Brian Masney --- drivers/stagi

[PATCH v4 03/26] staging: iio: tsl2583: remove unnecessary chip status checks in suspend/resume

The device probing and the suspend/resume code checks a flag internal to the driver that determines whether or not the chip is in a working state. These checks are not needed. This patch removes the unnecessary checks. It will do no harm to the hardware if the chip is reinitialized if it is already

[PATCH v4 01/26] staging: iio: tsl2583: check if chip is in a working state in in_illuminance_calibrate_store

in_illuminance_calibrate_store() did not check to see if the chip is in a working state. This patch adds the proper check. The return value from taos_als_calibrate() was also not checked in this function, so the proper check was also added while changes are being made here. Signed-off-by: Brian Ma

[PATCH v4 00/26] staging: iio: tsl2583: move out of staging

This patch set continues my work to clean up the tsl2583 driver to move it out of staging. Some highlights include: - Eliminated some unnecessary i2c calls to the sensor. - Fixed issue with changes to calibscale and int_time not being set on the chip. - Moved from a global lux table to a per dev

[PATCH] [STYLE 2/2]staging:speakup:thread.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/thread.c b/drivers/staging/spea

[PATCH] [STYLE 1/2]staging:speakup:thread.c Modified block comment

Modified block comment to multiline style Signed-off-by: Walt Feasel --- drivers/staging/speakup/thread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/thread.c b/drivers/staging/speakup/thread.c index 90c383e..e4de7dc 100644 --- a/drivers/staging/

[PATCH] [STYLE 5/5]staging:speakup:synth.c Blankline before close }

Made suggested modifications from checkpatch in reference to CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/sy

[PATCH] [STYLE 4/5]staging:speakup:synth.c Align match parenthesis

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/spe

[PATCH] [STYLE 3/5]staging:speakup:synth.c Space preferred around

Made suggested modifications from checkpatch in reference to CHECK: spaces preferred around that '/,+,-' Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging

[PATCH] [STYLE 2/5]staging:speakup:synth.c Logical continuation previous

Made suggested modifications from checkpatch in reference to CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/driver

[PATCH v2] [STYLE 1/5]staging:speakup:synth.c Modified block text

Modified block comment for alignment consistency Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 54b2f39..800fbbf 100644 --- a/drivers/stagin

[PATCH] [STYLE 1/5]staging:speakup:synth.c Modified block text

Modified block comment for alignment consistency Signed-off-by: Walt Feasel --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 54b2f39..29efdb1 100644 --- a/drivers/stagin

Re: [PATCH v2] staging: vc04_services: rework ioctl code path

Hi Michael, > Michael Zoran hat am 11. November 2016 um 07:15 > geschrieben: > > > VCHIQ/vc04_services has a userland device interface > that includes ioctls. The current ioctl implementation > is a single monolithic function over 1,000+ lines > that handles 17 different ioctls through a comple

[PATCH] [STYLE]staging:speakup:spk_types.h Align match parenthesis

Made suggested modifications from checkpatch in reference to CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/spk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/stagin

[PATCH] [STYLE]staging:speakup:spk_priv_keyinfo.h Spaces preferred around

Made suggested modifications from checkpatch in reference to CHECK: spaces preferred around that '+' Signed-off-by: Walt Feasel --- drivers/staging/speakup/spk_priv_keyinfo.h | 44 +++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/spea

[PATCH] [STYLE 2/2]staging:speakup:speakup_txprt.c Spaces preferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_txprt.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/speakup/speaku

[PATCH] [STYLE 1/2]staging:speakup:speakup_txprt.c Block comment align

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified multiline comment to single Removed blank line at end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_txprt.c | 8 +++- 1 file changed, 3 inse

[PATCH] [STYLE 2/2]staging:speakup:speakup_spkout.c Spaces preferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_spkout.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/speakup/spe

[PATCH] [STYLE 1/2]staging:speakup:speakup_spkout.c Block comment align

Made suggested modifications from checkpatch in reference to: WARNING: Block comments should align the * on each line Modified multiline text to single Removed blankline at end Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_spkout.c | 8 +++- 1 file changed, 3 inserti

Re: [PATCH v3 16/28] staging: iio: tsl2583: updated code comment to match what the code does

On 12/11/16 16:59, Brian Masney wrote: > On Sat, Nov 12, 2016 at 04:36:37PM +, Jonathan Cameron wrote: >> On 10/11/16 09:25, Brian Masney wrote: >>> If channel 0 does not have any data, then the code sets the lux to zero. >>> The corresponding comment says that the last value is returned. This

[PATCH] [STYLE 5/5]staging:speakup:speakup_soft.c Blank lines

Made suggested modifications from checkpatch in reference to: CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_soft.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dr

[PATCH] [STYLE 4/5]staging:speakup:speakup_soft.c Logical continuations

Made suggested modifications from checkpatch in reference to: CHECK: Logical continuations should be on the previous line Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_soft.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_

Re: [PATCH v3 16/28] staging: iio: tsl2583: updated code comment to match what the code does

On Sat, Nov 12, 2016 at 04:36:37PM +, Jonathan Cameron wrote: > On 10/11/16 09:25, Brian Masney wrote: > > If channel 0 does not have any data, then the code sets the lux to zero. > > The corresponding comment says that the last value is returned. This > > updates the comment to correctly refle

[PATCH] [STYLE 3/5]staging:speakup:speakup_soft.c Align match parenthesis

Made suggested modifications from checkpatch in reference to: CHECK: Alignment should match open parenthesis Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_soft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers

[PATCH] [STYLE 2/5]staging:speakup:speakup_soft.c Space preferred around

Made suggested modifications from checkpatch in reference to: CHECK: spaces preferred around that '|' Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_soft.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/speakup/s

[PATCH] [STYLE 1/5]staging:speakup:speakup_soft.c Modify block text

Modified multiline comment to single Signed-off-by: Walt Feasel --- drivers/staging/speakup/speakup_soft.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers/staging/speakup/speakup_soft.c index 6b1d0f5..c14a136 100644 --- a

Re: [PATCH v3 28/28] staging: iio: tsl2583: move out of staging

On 10/11/16 09:26, Brian Masney wrote: > Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline. > > Signed-off-by: Brian Masney The rest of the series (that I haven't commented on) looks good to me. I'll pick them up once those few minor changes are sorted. Thanks, Jonathan > ---

Re: [PATCH v3 21/28] staging: iio: tsl2583: move from a global to a per device lux table

On 10/11/16 09:25, Brian Masney wrote: > The driver contains a global lux table that can be updated via sysfs. > Change this to a per device lux table so that multiple devices can be > hooked up to the same system with different lux tables. > > There are 10 entries, plus 1 for the termination segm

Re: [PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

On 10/11/16 09:25, Brian Masney wrote: > in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. > Replace this with sizeof(unsigned int). > > Signed-off-by: Brian Masney Preferred to use sizeof(value[0]) in case it changes type sometime in the future? > --- > drivers/staging/ii

Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

On Sat, Nov 12, 2016 at 04:27:32PM +, Jonathan Cameron wrote: > On 12/11/16 16:24, Jonathan Cameron wrote: > > On 10/11/16 09:25, Brian Masney wrote: > >> in_illuminance_calibrate_store() did not check to see if the chip is > >> suspended. This patch adds the proper check. The return value from

Re: [PATCH v3 16/28] staging: iio: tsl2583: updated code comment to match what the code does

On 10/11/16 09:25, Brian Masney wrote: > If channel 0 does not have any data, then the code sets the lux to zero. > The corresponding comment says that the last value is returned. This > updates the comment to correctly reflect what the code does. > > Signed-off-by: Brian Masney Better perhaps to

Re: [PATCH v3 05/28] staging: iio: tsl2583: remove unnecessary chip status checks in suspend/resume

On 10/11/16 09:25, Brian Masney wrote: > The device probing and the suspend/resume code checks a flag internal to > the driver that determines whether or not the chip is in a working > state. These checks are not needed. This patch removes the unnecessary > checks. It will do no harm to the hardwar

Re: [PATCH v3 04/28] staging: iio: tsl2583: remove unnecessary chip status check in taos_get_lux

On 10/11/16 09:25, Brian Masney wrote: > taos_get_lux checks to see if the chip is in a working state. This > check is not necessary since it is only called from tsl2583_read_raw > and in_illuminance_calibrate_store (via taos_als_calibrate). The chip > state is already checked by these functions. >

Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

On 12/11/16 16:24, Jonathan Cameron wrote: > On 10/11/16 09:25, Brian Masney wrote: >> in_illuminance_calibrate_store() did not check to see if the chip is >> suspended. This patch adds the proper check. The return value from >> taos_als_calibrate() was also not checked in this function, so the >>

Re: [PATCH v3 03/28] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

On 10/11/16 09:25, Brian Masney wrote: > in_illuminance_calibrate_store() did not check to see if the chip is > suspended. This patch adds the proper check. The return value from > taos_als_calibrate() was also not checked in this function, so the > proper check was also added while changes are bei

Re: [PATCH v3 02/28] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

On 10/11/16 09:25, Brian Masney wrote: > When updating the in_illuminance_calibscale and > in_illuminance_integration_time sysfs attributes, these values were not > actually written to the chip. The chip would continue to use the old > parameters. Extracted out tsl2583_set_als_gain() and > tsl2583_

Re: [PATCH v3 01/28] staging: iio: tsl2583: split out functionality of taos_chip_on()

On 10/11/16 09:25, Brian Masney wrote: > taos_chip_on() reads an eight member array called taos_config > that contains the desired state of the chip's registers. Only four > of the registers actually need to be written to. The four that do > not need to be written to are for the {low,high} byte of

Our last deal

Greetings, I have interest of investing in your country. I am a Fund Management Executive with Prudential Plc Asset Management in the UK. I am in search of a partner to assist me in the transfer of 36,000,000GBP and subsequent investment in properties and other lucrative businesses in your cou

Our last deal

Greetings, I have interest of investing in your country. I am a Fund Management Executive with Prudential Plc Asset Management in the UK. I am in search of a partner to assist me in the transfer of 36,000,000GBP and subsequent investment in properties and other lucrative businesses in your cou