On Nov 3, 2016, at 16:49, Andrew Kanner wrote:
>
> Removed redundant declaration of variable 'tx' in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here
>
> Signed-off-by: Andrew Kanner
Review
Removed redundant declaration of variable 'tx' in local scope
Fixed: sparse warning:
socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
socklnd_cb.c:2435:25: originally declared here
Signed-off-by: Andrew Kanner
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++--
2016-11-04 1:12 GMT+03:00 Dilger, Andreas :
> On Nov 3, 2016, at 15:54, Andrew Kanner wrote:
>>
>> Changed variable 'tx' name in local scope
>> Fixed: sparse warning:
>> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
>> socklnd_cb.c:2435:25: originally declared here
>
> Looking
On Nov 3, 2016, at 15:54, Andrew Kanner wrote:
>
> Changed variable 'tx' name in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here
Looking at this more closely (or from a greater distance, har
Changed variable 'tx' name in local scope
Fixed: sparse warning:
socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
socklnd_cb.c:2435:25: originally declared here
Signed-off-by: Andrew Kanner
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++--
1 file changed, 2 in
On Wed, Nov 02, 2016 at 11:27:54AM -0600, Karim Yaghmour wrote:
>
> On 11/02/2016 11:24 AM, Alex Elder wrote:
> > Yes. I just created a test repository there. If you find
> > you have trouble let me know and I'll create one for you.
>
> Do we actually want do that though? I mean, who owns that?
From: Tim Sell
Previously, the sysfs entry (assuming traditional sysfs mountpoint):
/sys/bus/visorbus/devices/visorbus/client_bus_info
violated kernel conventions by printing more than one item. This along
with the fact that the data emitted was diagnostic data (intended to
shadow the clie
The function my_device_changestate was not sending a response if there
was an error with the CONTROLVM message.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 17 -
1 file changed, 12 inse
From: David Binder
Adjusts the formatting of a variable assignment to use fewer line breaks,
making it follow the convention used elsewhere in the s-Par driver set.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorbus/v
Have bus_destroy call chipset_bus_destroy directly instead of going
through bus_epilog.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 37 +++---
1 file changed, 33 insertions(+), 4 deletions(-)
diff --git a/drivers/
Have bus_create call chipset_bus_create directly instead of going
through the function bus_epilog.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 33 ++
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git
The function my_device_destroy should call chipset_device_destroy
directly instead of calling device_epilog. Since this was the last
function to use device_epilog that function was removed as well.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchip
This patch addresses the problem that we were sending double responses
back to the s-Par Firmware when processing CONTROLVM Messages. Every
message responds individually and the epilog functions would send a
response as well.
Since a message could delay the response, it was decided to remove the
e
Do proper error handling and return error codes instead of just ignoring
them.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 33 +++---
1 file changed, 14 insertions(+), 19 deletions(
From: David Binder
This commit adds a default condition to those case statements that do not
already have one. This is done to provide both a logical covering of all
conditions, as well as to maintain uniformity with the rest of the Unisys
driver set.
Signed-off-by: David Binder
Signed-off-by:
Function my_device_changestate should call chipset_device_changestate
directly instead of calling device_epilog.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 36 +++---
1 file changed, 32 insertions(+), 4 deletions(
Add error handling to bus_create function.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 60 +-
1 file changed, 31 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/uni
Remove the function bus_epilog since no one is calling it.
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartman
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 54 +-
1 file changed, 2 insertions(+), 52 deletions(-)
diff --git a/driv
Don't have my_device_create call device_epilog, have it call
chipset_device_create directly instead.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 28 --
1 file changed, 22 insertions(+), 6 deletions(-)
diff --g
The series addresses several different issues:
1. Fixes several issues discovered by Greg KH's code review:
* Converts client_bus_info into a debugfs structure instead of using
sysfs.
* Refactors the code in the functions processing controlvm messages to
avoid calling bus_epilog and device_epilog,
From: Sameer Wadgaonkar
Removed intializations from visorchipset_open(), visorchipset_init()
and moved the memset in initialize_controlvm_payload_info() down in
case of early returns from the function.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reported-by: Greg Kroah-Hartm
From: Tim Sell
The kernel convention is for DEVICE_ATTR_RO() definitions to occur
immediately after the functions that implement the attribute behaviors.
DEVICE_ATTR_RO definitions in visorbus_main.c have been moved to comply
with this convention.
Signed-off-by: Tim Sell
Signed-off-by: David Ke
taos_probe() calls i2c_smbus_write_byte() to select the control
register, however there is no subsequent calls to i2c_smbus_read_byte().
The write call is unnecessary and is removed by this patch.
Verified that the driver still functions correctly using a TSL2581
hooked up to a Raspberry Pi 2.
Si
When updating the in_illuminance_calibscale and
in_illuminance_integration_time sysfs attributes, these values were not
actually written to the chip. The chip would continue to use the old
parameters. Extracted out tsl2583_set_als_gain() and
tsl2583_set_als_time() functions that are now called when
This is my next round of staging cleanups to the tsl2581 light driver
in IIO staging. It mostly contains cleanups to the i2c code. I verified
that the driver still functions correctly using a TSL2581 hooked up to
a Raspberry Pi 2.
This patch set lays the foundation for moving to the regmap API.
B
in_illuminance_lux_table_store() shuts down the chip, updates the
contents of the lux table, and then turns the chip back on. The values
in lux table are not used by the chip and are only used internally by
the driver. It is not necessary to change the power state on the chip.
This patch removes th
taos_probe() queries the all of the sensor's registers and loads all of
the values into a buffer stored on the stack. Only the chip ID register
was actually used. Change the probe function to just query the chip ID
register on the device.
Verified that the driver still functions correctly using a
taos_als_calibrate() queries the control register to determine if the
unit is powered on and has the ADC enabled. It then queries the same
register a second time to determine if the ADC reading is valid. This
patch removes the redundant i2c_smbus_read_byte_data() call.
Verified that the driver sti
There were several places where the driver would first call
i2c_smbus_write_byte() to select the register on the device, and then
call i2c_smbus_read_byte() to get the contents of that register. The
code would look roughly like:
/* Select register */
i2c_smbus_write_byte(client, REGISTER);
/* Rea
in taos_defaults()
The comments in taos_defaults() appear after the line of code
that they apply to. This patch moves the comments so that they appear
before the code. Some of the comments were updated to be more
informative.
Signed-off-by: Brian Masney
---
drivers/staging/iio/light/tsl2583.c |
taos_chip_on() explicitly turns the sensor power on and then writes the
8 registers that are stored in taos_config. The first register in
taos_config is the CONTROL register and the configuration is set to
turn the power off. The existing state sequence in taos_chip_on() is:
- Turn device power on
in_illuminance_calibrate_store() did not check to see if the chip is
suspended. This patch adds the proper check. The return value from
taos_als_calibrate() was also not checked in this function, so the
proper check was also added while changes are being made here.
Signed-off-by: Brian Masney
---
Patch to the rtw_recv. file to fix up 2 brace warnings
(unnecessary braces) found by the checkpath.pl tool
Signed-off-by: Florian Winter
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_r
\
On Tue, Nov 1, 2016 at 4:25 PM, Johan Hovold wrote:
>
> Make sure to drop the device reference taken by of_find_device_by_node()
> before returning from arche_platform_change_state().
>
> Note that this code is expected to be removed, but let's fix up the leak
> nonetheless.
>
> Fixes: 886aba55
34 matches
Mail list logo
