On Tue, Oct 25, 2016 at 11:41 PM, Greg KH wrote:
> On Tue, Oct 25, 2016 at 10:06:48PM +0530, Souptick Joarder wrote:
>> Hi Greg,
>>
>>
>> On Tue, Oct 25, 2016 at 2:33 PM, Greg KH wrote:
>> > On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote:
>> >> This patch is added to free memory
On Tue, Oct 25, 2016 at 07:23:27PM -0700, Michael Zoran wrote:
> The original arm implementation uses dmac_map_area which is not
> portable. Replace it with an architecture neutral version
> which uses dma_map_sg.
>
> As you can see that for larger page sizes, the dma_map_sg
> implementation is f
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Monday, October 24, 2016 9:34 AM
> To: Stuart Yoder ; gre...@linuxfoundation.org
> Cc: German Rivera ; de...@driverdev.osuosl.org;
> linux-ker...@vger.kernel.org;
> a...@arndb.de; Leo Li
> Subject: Re: [PATCH 0/9
The original arm implementation uses dmac_map_area which is not
portable. Replace it with an architecture neutral version
which uses dma_map_sg.
As you can see that for larger page sizes, the dma_map_sg
implementation is faster then the original unportable dma_map_area
implementation.
Test
Every call to the function waitNextVerticalSync() used the macro
primaryWaitVerticalSync(), so the macro was removed and the function
waitNextVerticalSync() renamed to primary_wait_vertical_sync().
With this change, an unnecessary 'if' statement was removed together
with the lines within the 'else
After a recent bugfix, we get a warning about the use of an uninitialized
variable:
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function
'cfs_cpt_table_create_pattern':
drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be
used uninitialized in this functio
A recent rework removed the initialization of the successful return
code from lov_getstripe:
drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe':
drivers/staging/lustre/lustre/lov/lov_pack.c:426:9: error: 'rc' may be used
uninitialized in this function [-Werror=maybe-uniniti
On 10/25/2016 08:44 PM, Colin King wrote:
> From: Colin Ian King
>
> For a IIO_VOLTAGE case, ret is not being set causing an
> uninitialized value being returned by ad7746_read_raw. Fix
> this by setting ret to IIO_VAL_INT for this specific case.
>
> Signed-off-by: Colin Ian King
Arnd did beat
From: Colin Ian King
For a IIO_VOLTAGE case, ret is not being set causing an
uninitialized value being returned by ad7746_read_raw. Fix
this by setting ret to IIO_VAL_INT for this specific case.
Signed-off-by: Colin Ian King
---
drivers/staging/iio/cdc/ad7746.c | 1 +
1 file changed, 1 inserti
On Tue, Oct 25, 2016 at 10:06:48PM +0530, Souptick Joarder wrote:
> Hi Greg,
>
>
> On Tue, Oct 25, 2016 at 2:33 PM, Greg KH wrote:
> > On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote:
> >> This patch is added to free memory and return failure when kmalloc fails
> >
> > I'm sorry
On Tue, Oct 25, 2016 at 03:43:56PM +, Stuart Yoder wrote:
>
>
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Sent: Tuesday, October 25, 2016 2:50 AM
> > To: Stuart Yoder
> > Cc: German Rivera ; de...@driverdev.osuosl.org;
> > linux-ker...@vger.kerne
On 25/10/16 18:00, Lars-Peter Clausen wrote:
> On 10/25/2016 06:57 PM, Jonathan Cameron wrote:
>> On 24/10/16 16:22, Arnd Bergmann wrote:
>>> The ad5933_i2c_read function returns an error code to indicate
>>> whether it could read data or not. However ad5933_work() ignores
>>> this return code and
On 10/25/2016 06:57 PM, Jonathan Cameron wrote:
> On 24/10/16 16:22, Arnd Bergmann wrote:
>> The ad5933_i2c_read function returns an error code to indicate
>> whether it could read data or not. However ad5933_work() ignores
>> this return code and just accesses the data unconditionally,
>> which ge
On 24/10/16 16:22, Arnd Bergmann wrote:
> The ad5933_i2c_read function returns an error code to indicate
> whether it could read data or not. However ad5933_work() ignores
> this return code and just accesses the data unconditionally,
> which gets detected by gcc as a possible bug:
>
> drivers/sta
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> On Oct 17, 2016, at 15:46, Aya Mahfouz wrote:
> >
> > class_devno_max is an inline function that returns
> > MAX_OBD_DEVICES. Replace all calls to the function
> > by MAX_OBD_DEVICES.
>
> Thanks for your patch, but unfortunately
Hi Greg,
On Tue, Oct 25, 2016 at 2:33 PM, Greg KH wrote:
> On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote:
>> This patch is added to free memory and return failure when kmalloc fails
>
> I'm sorry, but I can not parse that sentance. Can you rephrase this a
> bit better? What
On Tue, 2016-10-25 at 09:16 -0700, Eric Anholt wrote:
> Michael Zoran writes:
>
> > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
> > > On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> > > > mzo...@crowfest.net writes:
> > > >
> > > > > */
> > > > >
> > > > > static int
> >
On 25/10/16 16:56, Arnd Bergmann wrote:
> As found by "gcc -Wmaybe-uninitialized", the latest change to the
> driver lacked an initalization for the return code in one of the
> added cases:
>
> drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’:
> drivers/staging/iio/cdc/ad7746.c:655:
Michael Zoran writes:
> On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
>> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
>> > mzo...@crowfest.net writes:
>> >
>> > > */
>> > >
>> > > static int
>> > > create_pagelist(char __user *buf, size_t count, unsigned short
>> > > type
As found by "gcc -Wmaybe-uninitialized", the latest change to the
driver lacked an initalization for the return code in one of the
added cases:
drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’:
drivers/staging/iio/cdc/ad7746.c:655:2: error: ‘ret’ may be used uninitialized
in this f
From: Andrey Shvetsov
This patch introduces the function start_sync_ep() and relocates the
triggers for synchronization to this function.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/hdm-usb/hdm_usb.c | 28 ++--
1 file changed,
From: Andrey Shvetsov
This patch puts the synchronization procedure trigger for asynchronous
channels into the function hdm_configure_channel. Likewise, it removes
triggering of hardware specific synchronization for other channel types
from the probe function as it is not required.
Signed-off-by
From: Andrey Shvetsov
This patch stops all started channels whenever the function most_nd_open
returns an error. Additionally, it renames variable wait_res to ret for
the consistency.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-network/networking
This patch set is needed to fix up issues of the USB module and the
networking module.
Andrey Shvetsov (3):
staging: most: aim-networking: keep channels closed if ndo_open fails
staging: most: hdm-usb: do h/w specific synchronization at
configuration time
staging: most: hdm-usb: introduc
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, October 25, 2016 2:50 AM
> To: Stuart Yoder
> Cc: German Rivera ; de...@driverdev.osuosl.org;
> linux-ker...@vger.kernel.org;
> ag...@suse.de; a...@arndb.de; Leo Li
> Subject: Re: [PATCH 00/14] st
On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> mzo...@crowfest.net writes:
>
> > */
> >
> > static int
> > create_pagelist(char __user *buf, size_t count, unsigned short
> > type,
> > - struct task_struct *task, PAGELIST_T ** ppagelist)
> > + struct task_struct *task, PAG
On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote:
> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote:
> > mzo...@crowfest.net writes:
> >
> > > */
> > >
> > > static int
> > > create_pagelist(char __user *buf, size_t count, unsigned short
> > > type,
> > > - struct task_struct *task
Hi Paul, Greg,
Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser:
> This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
>
> This is necessary to detect paz00 (ac100) touchpad properly as one
> speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
> work a
This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
This is necessary to detect paz00 (ac100) touchpad properly as one
speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
work as the touchpad is detected as an ImPS/2 mouse instead.
Commit ec6184b1c717b8768122e25fe6d312
Fixes checkpatch warning: line over 80 characters
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index 50e158f..5f3c1496 100644
---
Fixes checkpatch error: Macros with complex values should be enclosed in
parentheses
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
Fixes checkpatch warning: Missing a blank line after declarations
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index 5f3c1496..f1064c1 100644
---
Fixes checkpatch warning: space before tabs
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index 09202ad..50e158f 100644
--- a/
Fixes checkpatch errors: spacing errors
Signed-off-by: Jiong Du
---
drivers/staging/ks7010/michael_mic.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index 78ae2b8..fadc563 100644
Block comments should align the * on each line as reported by checkpatch.pl
Signed-off-by: Nadim Almas
---
Changes in v2:
- Made subject better
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers
On Wed, Oct 19, 2016 at 10:07:41PM +0700, Ivan Safonov wrote:
> These messages are redundant.
> Also break rtw_usb_if1_init function if HalData allocation failed.
>
> Signed-off-by: Ivan Safonov
Since you're redoing this anyway, please split this one into two
patches. We really frown on mixing
On Mon, Oct 24, 2016 at 09:18:04PM +0530, Nadim Almas wrote:
> Block comments should align the * on each line as reported by checkpatch.pl
>
> Signed-off-by: Nadim Almas
> ---
>
> drivers/staging/dgnc/dgnc_tty.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Your subject: does not
On Thu, Oct 20, 2016 at 07:16:20PM +0700, Ivan Safonov wrote:
> Andy,
> thank you for reviewing patches and tips.
Please redo this series based on these responses and resend.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://d
On Fri, Oct 21, 2016 at 06:12:32PM +0530, Nadim Almas wrote:
> Fixed coding style issue
>
> Signed-off-by: Nadim Almas
> ---
> drivers/staging/wlan-ng/hfa384x.h | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h
> b/drivers/stagin
On Mon, Oct 24, 2016 at 09:50:42PM +0800, Jiong Du wrote:
> Fixes all the checkpath errors/warnings for michael_mic.c:
> space required before the open brace
> no space before tabs
> line over 80 characters
> space required before the open brace '{'
> space required after that c
On Mon, Oct 17, 2016 at 01:42:09PM -0500, Stuart Yoder wrote:
> This patch does miscellaneous minor cleanup and uprevs the supported
> MC firmware version to 10.x.
>
> I believe with this series the TODO items on our list are complete,
> with the exception of "Add at least one device driver for a
On Mon, Oct 17, 2016 at 01:43:58PM -0500, Stuart Yoder wrote:
> From: Ioana Ciornei
>
> DPAA2 will not support MC firmware versions prior to MC v10.x.
> Update the MC interface code and drivers to reflect this.
>-update the object .h files and code that builds commands to include
> the ne
On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote:
> Cleanup and clarify messages
> -use "fsl-mc" prefix for all messages that don't come from dev_*
>functions
Nope, please use the proper pr_fmt() #define at the top of the file,
that way you don't have to put the string into all p
On Mon, Oct 17, 2016 at 01:43:16PM -0500, Stuart Yoder wrote:
> From: Ioana Ciornei
>
> Make whitespace consistent with other fsl-mc source files.
> -delete extraneous tabs
> -align start of function arguments properly
> -for structs and function definitions, separate type and
>variable
On Mon, Oct 17, 2016 at 01:42:47PM -0500, Stuart Yoder wrote:
> -German has moved on to other things and wished to be
> removed as a maintainer
> -cleanup the driver description to use the proper name
> of the driver (i.e. the fsl-mc bus driver) and remove incorrect
> references to Freescale
>
45 matches
Mail list logo
