On 19/10/16 11:32, Brian Masney wrote:
> taos_gain_store() and taos_als_calibrate() both have a code path where
> -1 was returned. This patch changes the code so that a proper error code
> is returned to make the code consistent with the error paths that are
> present within those same functions.
>
On 19/10/16 14:11, Dan Carpenter wrote:
> On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
>> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
>>> What does illuminance0_ mean? Can we remove that?
>>
>> I left the names of the existing sysfs attributes intact to not brea
On 19/10/16 11:32, Brian Masney wrote:
> taos_get_lux() calls mutex_trylock(). If the lock could not be acquired,
> then chip->als_cur_info.lux is returned. The issue is that this value
> is updated while the mutex is held and could cause a half written value
> to be returned to the caller. This pa
Eliminates all checkpatch.pl BLOCK_COMMENT_STYLE warnings in
sm750fb, and coincidentally eliminates some line-length (80)
warnings.
Signed-off-by: Eric S. Stone
---
drivers/staging/sm750fb/ddk750.h | 22 ++--
drivers/staging/sm750fb/ddk750_chip.c| 39
dri
On 19/10/16 12:37, Dan Carpenter wrote:
> I appologize for laughing, but I am still secretly amused in my heart.
>
> regards,
> dan carpenter
>
Fewer beers or less caffeine for Dan!
Key take away here is keep things simple. The gotos in my mind
would actually have made sense, but I wouldn't do
Trivial style fix to remove unnecessary errors in checkpatch.pl
Signed-off-by: Alex Briskin
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
b/drivers/staging/rtl8188eu
