This is Smatch stuff. Some of it requires that the database be built
and some is stuff I'm still working on and haven't released yet.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mai
From: Vitaly Kuznetsov
Date: Thu, 20 Oct 2016 10:51:04 +0200
> Stephen Hemminger writes:
>
>> Do we need ACCESS_ONCE() here to avoid check/use issues?
>>
>
> I think we don't: this is the only place in the function where we read
> the variable so we'll get normal read. We're not trying to sync
This patch corrects the spelling of 'initialize' in ks7010_sdio.c.
The issue was found by checkpatch.
Signed-off-by: Nick Rosbrook
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging
> On Oct 20, 2016, at 7:17 PM, Dan Carpenter wrote:
>
> Hello Jinshan Xiong,
>
> The patch 1e1db2a97be5: "staging: lustre: clio: Revise read ahead
> implementation" from Oct 2, 2016, leads to the following static
> checker warning:
>
> drivers/staging/lustre/lustre/lov/lov_io.c:611 lov_i
On 10/20/2016 04:18 PM, Dan Carpenter wrote:
I don't know exactly what the game plan is for the rtl8188eu driver but
these patches seem to be on the right path to me.
regards,
dan carpenter
If this driver has no future and will be removed, then what code is
better to invest my efforts?
Linu
On 10/20/2016 04:03 PM, Dan Carpenter wrote:
On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote:
To replace rx_data with pkt->data.
Now pkt->data is equal to rx_data.
I'm not smart enough to tell on my own... Is this a bugfix?
It is not bugfix, only variable replacement.
recv_fra
Replace direct comparisons to NULL i.e.
'x == NULL' with '!x'.
This problem was detected by checkpatch.
Signed-off-by: Maninder Singh
---
drivers/staging/xgifb/XGI_main_26.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/
Hello Bobi Jam,
The patch cbd4d4a8e319: "staging: lustre: llite: remove duplicate
fiemap defines" from Oct 2, 2016, leads to the following static
checker warning:
drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap()
warn: signed overflow undefined. 'fm_start + f
Andy,
thank you for reviewing patches and tips.
On 10/19/2016 11:59 PM, Andy Shevchenko wrote:
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote:
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
netdev_alloc_skb function
already set dev member of pkt_copy.
It might be one line.
Hello Jinshan Xiong,
The patch 1e1db2a97be5: "staging: lustre: clio: Revise read ahead
implementation" from Oct 2, 2016, leads to the following static
checker warning:
drivers/staging/lustre/lustre/lov/lov_io.c:611 lov_io_read_ahead()
error: 'sub' dereferencing possible ERR_PTR()
I don't know exactly what the game plan is for the rtl8188eu driver but
these patches seem to be on the right path to me.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
On Wed, Oct 19, 2016 at 10:07:57PM +0700, Ivan Safonov wrote:
> @@ -1733,6 +1729,13 @@ static int recv_indicatepkts_in_order(struct adapter
> *padapter, struct recv_reor
> return bPktInBuf;
> }
>
> +void strip_iv_icv(struct sk_buff *skb, uint header_len,
> + uint iv_len, uin
On Wed, Oct 19, 2016 at 10:07:45PM +0700, Ivan Safonov wrote:
> To replace rx_data with pkt->data.
> Now pkt->data is equal to rx_data.
>
I'm not smart enough to tell on my own... Is this a bugfix?
regards,
dan carpenter
___
devel mailing list
de...@
Stephen Hemminger writes:
> Do we need ACCESS_ONCE() here to avoid check/use issues?
>
I think we don't: this is the only place in the function where we read
the variable so we'll get normal read. We're not trying to syncronize
with netvsc_init_buf() as that would require locking, if we read sta
On Wed, Oct 19, 2016 at 10:07:30PM +0700, Ivan Safonov wrote:
> netdev_alloc_skb function
> already set dev member of pkt_copy.
>
I'm coming back to this one after sending a response to patch 3. Here
again, this patch was complicated for me to review because I mostly read
the body of the email a
On Wed, Oct 19, 2016 at 10:07:31PM +0700, Ivan Safonov wrote:
> In accordance with the KISS principle.
>
The changelog is not complete enough.
Some people are going to read only the subject, but other people are
only going to read the body of the changelog. They can be far apart
depending on ho
Do we need ACCESS_ONCE() here to avoid check/use issues?
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, October 19, 2016 2:53 PM
To: net...@vger.kernel.org
Cc: Stephen Hemminger ; de...@linuxdriverproject.org;
linux-ker...@vger.kernel.org; KY Srin
17 matches
Mail list logo
