RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

> -Original Message- > From: Kershner, David A > Sent: Wednesday, October 19, 2016 8:04 PM > To: Cathal Mullaney > Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor > locking code to be statically deterministic. > > > -Original Message- > > From: Cathal Mu

[PATCH] staging: ks7010: Add spaces around '*'

Added spaces around a '*' in ks7010_sdio.c. Issue found by checkpatch. Signed-off-by: Nick Rosbrook --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index b029

RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

> -Original Message- > From: Cathal Mullaney [mailto:chuckleberryf...@gmail.com] > Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking > code to be statically deterministic. > > This patch makes locking in visorchannel_signalempty statically > deterministic. > As

Re: [PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

On Wed, Oct 19, 2016 at 05:00:53PM +, Sell, Timothy C wrote: > On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote: > > This patch makes locking in visorchannel_signalempty statically > > deterministic. > > As a result this patch fixes the sparse warning: > > Context imbalance in 'vi

[PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

This patch makes locking in visorchannel_signalempty statically deterministic. As a result this patch fixes the sparse warning: Context imbalance in 'visorchannel_signalempty' - different lock contexts for basic block. The logic of the locking code doesn't change but the layout of the original cod

[PATCH 1/5] staging: rtl8188eu: os_dep: remove empty lines

Remove unnecessary empty lines (issue found by checkpatch) Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/drivers/staging/rtl8188eu/os_dep/osdep_servi

[PATCH 5/5] staging: rtl8188eu: os_dep: remove unnecessary alloc fail message

Remove redundant alloc fail message This patch fixes the warning found by checkpatch Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.

[PATCH 2/5] staging: rtl8188eu: os_dep: fix block comment alignment issue

Fix coding style issue in block comment in osdep_service.c found by checkpatch tool Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c

[PATCH 3/5] staging: rtl8188eu: os_dep: fix missing spaces around operators

Fix missing space around operators in rtw_alloc2d function in osdep_service.c Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/driver

[PATCH 4/5] staging: rtl8188eu: os_dep: remove unnecessary parentheses

Remove parentheses in _rtw_init_queue to fix checkpatch warning Signed-off-by: Pierre-Yves Kerbrat --- drivers/staging/rtl8188eu/os_dep/osdep_service.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c b/drivers/staging/rt

[PATCH 0/5] staging: rtl8188eu: os_dep: fix checkpatch issues

Hi all, This patchset fixes some of the checkpatch issues found in osdep_service.c file of rtl8188eu Pierre-Yves Kerbrat (5): staging: rtl8188eu: os_dep: remove empty lines staging: rtl8188eu: os_dep: fix block comment alignment issue staging: rtl8188eu: os_dep: fix missing spaces around op

RE: [PATCH] staging: unisys: visorbus: visorchannel: Refactor locking code to be statically deterministic.

On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote: > This patch makes locking in visorchannel_signalempty statically deterministic. > As a result this patch fixes the sparse warning: > Context imbalance in 'visorchannel_signalempty' - different lock contexts for > basic block. > > The

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote: > On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > > > > netdev_alloc_skb function > > already set dev member of pkt_copy. > > It might be one line. > > Some special references: > functions: function() > structs: struct my_struct

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote: > netdev_alloc_skb function > already set dev member of pkt_copy. It might be one line. Some special references: functions: function() structs: struct my_struct P.S. Entire series lacks of cover letter. > > Signed-off-by: Ivan Safonov > -

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On 19 October 2016 11:32:06 BST, Brian Masney wrote: >Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO >macros to create the device attributes. > >Signed-off-by: Brian Masney Hi Brian, One very quick comment. Driver should be using an iio_chan_spec array and relevant inf

[PATCH RESEND 12/12] staging: wlan-ng: avoid CamelCase: hfa384x_KeyIDChanged

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 11/12] staging: wlan-ng: avoid CamelCase: hfa384x_PSUserCount

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 07/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 4 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH RESEND 09/12] staging: wlan-ng: avoid CamelCase: hfa384x_LinkStatus

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 06/12] staging: wlan-ng: avoid CamelCase: hfa384x_ChInfoResult

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/

[PATCH RESEND 08/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResult

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 04/12] staging: wlan-ng: avoid CamelCase in fields of struct hfa384x_dbmcommsquality

Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/stag

[PATCH RESEND 03/12] staging: wlan-ng: avoid CamelCase: hfa384x_WPAData

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH RESEND 01/12] staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint

Replace CamelCase define to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 2 +- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x

[PATCH RESEND 10/12] staging: wlan-ng: avoid CamelCase: hfa384x_AuthRequest

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH RESEND 05/12] staging: wlan-ng: avoid CamelCase: hfa384x_CommTallies16

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 5/5] staging: wlan-ng: Replace data type declaration with variable of same type in prism2sta.c

sizeof(*var) instead of sizeof(struct XXX) is preferred. Fix them in prism2sta.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-

[PATCH 10/12] staging: wlan-ng: avoid CamelCase: hfa384x_AuthRequest

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 07/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 4 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH 03/12] staging: wlan-ng: avoid CamelCase: hfa384x_WPAData

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH 08/12] staging: wlan-ng: avoid CamelCase: hfa384x_HScanResult

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 4/5] staging: wlan-ng: Replace data type declaration with variable of same type in p80211netdev.c

sizeof(var) instead of sizeof(struct XXX) is preferred. Fix them in p80211netdev.c Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/stag

[PATCH 04/12] staging: wlan-ng: avoid CamelCase in fields of struct hfa384x_dbmcommsquality

Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/stag

[PATCH 3/5] staging: wlan-ng: Replace data type declaration with variable of same type in p80211conv.c

sizeof(*var) instead of sizeof(struct XXX) is preferred. Fix it in p80211conv.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p8

[PATCH RESEND 02/12] staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data

Replace CamelCase struct name and fields with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 6 +++--- drivers/staging/wlan-ng/prism2mgmt.c | 8 2 files changed, 7 insertions(+), 7 deletions(-)

[PATCH 00/12] Avoid CamelCases in hfa384x.h

This patchset fix CamelCases in hfa384x.h header file. This file is free of CamelCases now. Sergio Paracuellos (12): staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data staging: wlan-ng: avoid CamelCase: hfa384x_WPAData

[PATCH RESEND 00/12] Avoid CamelCases in hfa384x.h

This patchset fix CamelCases in hfa384x.h header file. This file is free of CamelCases now. This patch series are resent because an mix error in the previous sent. Sergio Paracuellos (12): staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint staging: wlan-ng: avoid CamelCase: hfa384x_H

[PATCH] staging: wlan-ng: Replace data type declaration with variable of same type in prism2mgmt.c

sizeof(var) instead of sizeof(struct XXX) is preferred. It also fix the following checkpatch.pl script warning: WARNING: line over 80 characters Fix this two in prism2mgmt.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 11/12] staging: wlan-ng: avoid CamelCase: hfa384x_PSUserCount

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 09/12] staging: wlan-ng: avoid CamelCase: hfa384x_LinkStatus

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 12/12] staging: wlan-ng: avoid CamelCase: hfa384x_KeyIDChanged

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 06/12] staging: wlan-ng: avoid CamelCase: hfa384x_ChInfoResult

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/

[PATCH 05/12] staging: wlan-ng: avoid CamelCase: hfa384x_CommTallies16

Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wl

[PATCH 01/12] staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint

Replace CamelCase define to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 2 +- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x

[PATCH 2/5] staging: wlan-ng: Replace data type declaration with variable of same type in hfa384x_usb.c

sizeof(var) instead of sizeof(struct XXX) is preferred. Fix it in hfa384x_usb.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/h

[PATCH 1/5] staging: wlan-ng: Replace data type declaration with variable of same type in cfg80211.c

sizeof(var) instead of sizeof(struct XXX) is preferred. Fix it in cfg80211.c file. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.

[PATCH 02/12] staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data

Replace CamelCase struct name and fields with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h| 6 +++--- drivers/staging/wlan-ng/prism2mgmt.c | 8 2 files changed, 7 insertions(+), 7 deletions(-)

[PATCH 11/37] staging:r8188eu: remove is_(multicast|broadcast)_mac_addr

is_multicast_ether_addr used instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 3 +-- drivers/staging/rtl8188eu/include/ieee80211.h | 11 --- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH 31/37] staging:r8188eu: remove pscanned member of mlme_priv structure

This member used only as local variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 -- drivers/staging/rtl8188eu/core/rtw_mlme.c | 11 +-- drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 - drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

[PATCH 30/37] staging:r8188eu: remove eth_type member of rx_pkt_attrib structure

Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023. Calculate it locally. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 26 -- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 -- 2 files changed, 20 insertions(+), 8 deletio

[PATCH 21/37] staging:r8188eu: change recvframe_pull_tail last argument type

uint instead of int used. This function always called with positive sz argument. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl818

[PATCH 37/37] staging:r8188eu: remove P2P_* enumerations.

Driver does not use this definitions. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/wifi.h | 73 1 file changed, 73 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h index 9e08e68..

[PATCH 06/37] staging:r8188eu: refactor rtl88eu_phy_iq_calibrate function

is2t local variable always is false. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 57 + 1 file changed, 1 insertion(+), 56 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c index 8462

[PATCH 27/37] staging:r8188eu: remove recvframe_put function

skb_put used instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 17 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 2 +- 3 files changed, 2 insertions(+), 19 deletions(-) di

[PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

netdev_alloc_skb function already set dev member of pkt_copy. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c i

[PATCH 12/37] staging:r8188eu: remove ieee80211_get_hdrlen function

This function does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 27 -- drivers/staging/rtl8188eu/include/ieee80211.h | 1 - 2 files changed, 28 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/dri

[PATCH 29/37] staging:r8188eu: take out stripping of iv and icv space from wlanhdr_to_ethhdr function

Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023. This stripping procedure placed into new strip_iv_icv function. Also strip_iv_icv used inside unprotect_frame. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 27 +++ drivers/

[PATCH 19/37] staging:r8188eu: remove rx_end member of recv_frame structure

rx_end replaced with pkt->end. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 3 +-- drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++-- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 09/37] staging:r8188eu: remove is2t argument of phy_lc_calibrate function

is2t is constant. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c index 6b70d09..93dbb395 100644 --- a/drivers

[PATCH 08/37] staging:r8188eu: refactor path_adda_on function

Remove is_path_a_on and is2t arguments. These argument always are constant. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal

[PATCH 34/37] staging:r8188eu: remove update_bcn member of mlme_priv structure

Value of this member does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c | 7 --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 - drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 - 3 files changed, 9 deletions(-) diff --git a/drivers/staging/r

[PATCH 07/37] staging:r8188eu: remove is2t argument if the phy_iq_calibrate function

is2t argument of this function is constant. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 101 +++- 1 file changed, 6 insertions(+), 95 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c in

[PATCH 15/37] staging:r8188eu: remove rx_head member of recv_frame structure

Value of rx_head used only to produce debug output. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++-- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 3 files changed, 2 insertions(+), 4 delet

[PATCH 28/37] staging:r8188eu: remove recvframe_pull_tail function

skb_trim used instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 8 +--- drivers/staging/rtl8188eu/include/rtw_recv.h | 16 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/driv

[PATCH 35/37] staging:r8188eu: remove clr_fwstate* functions

These functions are unused. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h b/drivers/staging/rtl8188eu/include/rtw_mlme.h index 47a3f2d..d27b2ad 100

[PATCH 20/37] staging:r8188eu: change recvframe_put last argument type

uint instead of int used. This function always called with positive sz argument. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl818

[PATCH 18/37] staging:r8188eu: remove rx_data member of recv_frame structure

rx_data replaced with pkt->data. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 38 - drivers/staging/rtl8188eu/core/rtw_recv.c| 54 drivers/staging/rtl8188eu/core/rtw_security.c| 6 +-- drivers/staging/rtl

[PATCH 17/37] staging:r8188eu: update pkt->data synchronously with rx_data

To replace rx_data with pkt->data. Now pkt->data is equal to rx_data. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h inde

[PATCH 25/37] staging:r8188eu: remove len member of recv_frame structure

len replaced with pkt->len. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 14 +++--- drivers/staging/rtl8188eu/core/rtw_recv.c| 23 +-- drivers/staging/rtl8188eu/core/rtw_security.c| 6 +++--- drivers/staging/rtl8188eu

[PATCH 04/37] staging:r8188eu: remove WIFI_MP_* definitions and all corresponding code

fw_state member of mlme_priv never obtain WIFI_MP_STATE value. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 5 --- drivers/staging/rtl8188eu/core/rtw_recv.c | 42 +- drivers

[PATCH 36/37] staging:r8188eu: remove unused structures from include/rtw_mlme.h

Also SCAN_RESULT_TYPE enum removed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 188 --- 1 file changed, 188 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h b/drivers/staging/rtl8188eu/include/rtw_mlme.h index d2

[PATCH 22/37] staging:r8188eu: change recvframe_pull_tail type to void

Return value of this function does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 05/37] staging:r8188eu: remove mp_mode member of odm_dm_struct and odm_dm_struct structures

Value of this variable always is 0. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +--- drivers/staging/rtl8188eu/hal/odm.c| 3 +-- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 19 --- drivers/staging/rtl8188eu/hal/phy.c

[PATCH 16/37] staging:r8188eu: change recvframe_pull last argument type

uint instead of int used. This function always called with positive sz argument. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl818

[PATCH 14/37] staging:r8188eu: remove ieee80211_is_empty_essid function

This function is unused. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 17 - drivers/staging/rtl8188eu/include/ieee80211.h | 3 --- 2 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/stagin

[PATCH 13/37] staging:r8188eu: remove debug messages after memory allocation failed

These messages are redundant. Also break rtw_usb_if1_init function if HalData allocation failed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 +--- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 4 +--- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c

[PATCH 03/37] staging:r8188eu: remove skb cloning after netdev_alloc_skb fail

In accordance with the KISS principle. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/us

[PATCH 33/37] staging:r8188eu: remove rtw_calculate_wlan_pkt_size_by_attribue function

This function does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_xmit.c| 18 -- drivers/staging/rtl8188eu/include/rtw_xmit.h | 1 - 2 files changed, 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8

[PATCH 23/37] staging:r8188eu: update rx_tail and pkt->tail synchronously

To replace rx_tail with pkt->tail. Now pkt->tail is equal to rx_tail and pkt->len is equal to len. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_recv.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/inc

[PATCH 24/37] staging:r8188eu: remove rx_tail member of recv_frame structure

rx_end replaced with pkt->tail. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 3 --- drivers/staging/rtl8188eu/os_dep/recv_linux.c| 2 +- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 - 4 fi

[PATCH 10/37] staging:r8188eu: remove type cast for first argument of memset

Typecasting here is unnecessary. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +- drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme.c | 10 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++-

[PATCH 26/37] staging:r8188eu: remove recvframe_pull function

skb_pull used instead. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 8 drivers/staging/rtl8188eu/include/rtw_recv.h | 17 - 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/dri

[PATCH 32/37] staging:r8188eu: remove SET_EARLYMODE_* definitions

These definitions does not used. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h b/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h index 662

[PATCH 01/37] staging:r8188eu: remove get_rxmem function

This simple one-line function used only once, and precvframe always not NULL. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +- drivers/staging/rtl8188eu/include/rtw_recv.h | 8 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/stag

RE: [PATCH] tools: hv: clean up code, remove unnecessary header files and link flags

> -Original Message- > From: Weibing Zhang [mailto:atheism.zh...@gmail.com] > Sent: Tuesday, October 18, 2016 8:43 PM > To: KY Srinivasan ; Haiyang Zhang > > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Weibing > Zhang > Subject: [PATCH] tools: hv: clean up code, remo

Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the es2_arpc_in_enable() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for > APBridgeA

[PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

Fix in commit 880988348270 ("hv_netvsc: set nvdev link after populating chn_table") turns out to be incomplete. A crash in netvsc_get_next_send_section() is observed on mtu change when the device is under load. The race I identified is: if we get to netvsc_send() after we set net_device_ctx->nvdev

Re: [PATCH] staging: greybus: es2: fix arpc request size

On 19-10-16, 13:44, Rui Miguel Silva wrote: > Fix size field of arpc message request by using the header size and not > the pointer size. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/greybus/es2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/st

Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

On Wed, Oct 19, 2016 at 01:17:53PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the es2_arpc_in_enable() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for >

[PATCH -next] greybus: es2: fix error return code in ap_probe()

From: Wei Yongjun Fix to return a negative error code from the es2_arpc_in_enable() error handling case instead of 0, as done elsewhere in this function. Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for APBridgeA RPC") Signed-off-by: Wei Yongjun --- drivers/staging/greybus/es

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote: > On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: > > What does illuminance0_ mean? Can we remove that? > > I left the names of the existing sysfs attributes intact to not break > any existing users of the driver. I'm no

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote: > What does illuminance0_ mean? Can we remove that? I left the names of the existing sysfs attributes intact to not break any existing users of the driver. I'm not sure why the original author named it that way. Brian __

Re: [PATCH 3/7] iio: light: tsl2583: use DEVICE_ATTR_{RO, RW, WO} macros

On Wed, Oct 19, 2016 at 12:47:13PM +0200, Peter Meerwald-Stadler wrote: > > > Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO > > macros to create the device attributes. > > great that you work on cleaning this up! > > the patch does a bit more than is claimed, it also renames

Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

On Wed, Oct 19, 2016 at 03:54:23PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote: > > Ok, I'll rework my patch series to stick with the direct returns. I > > personally prefer that approach. I was using the gotos since I thought > > that was standard con

[PATCH v2 7/7] selftest: sync: stress test for merges

This test is based on the libsync test suite from Android. This commit includes a test to stress merge operations. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile| 1 + tools/testing/selftests/sync/sync_stress_merge.c | 115 +++ tools/testi

[PATCH v2 6/7] selftest: sync: stress consumer/producer test

This test is based on the libsync test suite from Android. This commit includes a stress test that replicates a consumer/producer pattern. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + .../testing/selftests/sync/sync_stress_consumer.c | 185

[PATCH v2 4/7] selftest: sync: wait tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for waiting on fences. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile| 1 + tools/testing/selftests/sync/sync_test.c | 1 + tools/testing/selftests/sync/sync_wait.c | 91

Re: [PATCH 5/7] iio: light: tsl2583: check return values from taos_chip_{on, off}

On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote: > Ok, I'll rework my patch series to stick with the direct returns. I > personally prefer that approach. I was using the gotos since I thought > that was standard convention in the kernel. > It *should* but "goto unlock;" When you can

[PATCH v2 5/7] selftest: sync: stress test for parallelism

This test is based on the libsync test suite from Android. This commit includes a stress test that invokes operations in parallel. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + .../selftests/sync/sync_stress_parallelism.c | 111

[PATCH v2 3/7] selftest: sync: merge tests for sw_sync framework

These tests are based on the libsync test suite from Android. This commit includes tests for basic merge operations. Signed-off-by: Emilio López --- tools/testing/selftests/sync/Makefile | 1 + tools/testing/selftests/sync/sync_merge.c | 60 +++ tools/testing/sel

  1   2   >