Re: [patch] greybus: fix a leak on error in gb_module_create()

2016-10-16 Thread Viresh Kumar
On Sat, Oct 15, 2016 at 12:48 AM, Dan Carpenter wrote: > We should release ->interfaces[0] as well. > > Fixes: b15d97d77017 ("greybus: core: add module abstraction") > Signed-off-by: Dan Carpenter Acked-by: Viresh Kumar ___ devel mailing list de...@li

Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

2016-10-16 Thread Viresh Kumar
On Sun, Oct 16, 2016 at 3:29 PM, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion. > > Signed-off

Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

2016-10-16 Thread Vaibhav Agarwal
On Sun, Oct 16, 2016 at 3:29 PM, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion. > > Signed-off

[PATCH] staging: dgnc: dgnc_tty: Add missing static keyword.

2016-10-16 Thread Cathal Mullaney
Fixed sparse warning; function not declared static. Signed-off-by: Cathal Mullaney --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 953d931..ef9a45b 100644 --- a/drivers

URGENT REPLY FOR MORE DETAILS

2016-10-16 Thread Wilfred Kabore
Hello Dear, Greetings and hope this email finds you well? I am Dr. Wilfred Kabore, the chief Medical consultant at a reputable clinic here in Ouagadougou, Burkina Faso and I have a Patient who hails from the Republic of Philippines but unfortunately is in coma right now due to complications

[PATCH 3/3] staging: ks7010: add missing blank lines

2016-10-16 Thread Carlos Maiolino
Use blank lines to separate variable declarations from statements, fixing the following checkpatch.pl issue: WARNING: Missing a blank line after declarations Signed-off-by: Carlos Maiolino --- drivers/staging/ks7010/ks_hostif.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/s

[PATCH 2/3] staging: ks7010: Fix coding style spacing issues

2016-10-16 Thread Carlos Maiolino
Fix the following checkpatch.pl spacing errors/warnings: CHECK: No space is necessary after a cast WARNING: please, no spaces at the start of a line WARNING: please, no spaces at the start of a line ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close p

[PATCH 1/3] staging: ks7010: Fix conditional statements coding style

2016-10-16 Thread Carlos Maiolino
Fix coding style issues in if statements braces, specifically: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Carlos Maiolino --- dri

[PATCH 0/3] staging: ks7010: Coding style fixes

2016-10-16 Thread Carlos Maiolino
A small patchset fixing some coding style errors identified by checkpatch.pl Greg. I splitted the single patch into 3 different patches now, hope I set it right now :) Also added a blank line before the signed-off. Cheers Carlos Maiolino (3): staging: ks7010: Fix conditional statements coding

[PATCH] staging: dgnc: Replace CamelCase namings with underscores.

2016-10-16 Thread Pankaj Bharadiya
Replace CamelCase names with underscores to comply with the standard kernel coding style. Signed-off-by: Pankaj Bharadiya --- drivers/staging/dgnc/dgnc_tty.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/stagi

Re: [PATCH 0/5] Replace data type declarations with variables of same types in several source files.

2016-10-16 Thread Sergio Paracuellos
El 2016年10月16日 a las 10:24, Alexander Alemayhu escribió: On Mon, Oct 10, 2016 at 04:02:17PM +0200, Sergio Paracuellos wrote: This patch series replaces several sizeof(struct XXX) stuff in favour of sizeof(var) which is the preferred one. Why not squash this series into one patch? The commit

Re: [PATCH 57/80] staging: lustre: osc: revise unstable pages accounting

2016-10-16 Thread Oleg Drokin
On Oct 16, 2016, at 11:14 AM, Greg Kroah-Hartman wrote: > Digging up an old email... > > On Tue, Aug 16, 2016 at 04:19:10PM -0400, James Simmons wrote: >> From: Jinshan Xiong >> >> A few changes are made in this patch for unstable pages tracking: >> >> 1. Remove kernel NFS unstable pages trac

[PATCH] staging/lustre/llite: Move unstable_stats from sysfs to debugfs

2016-10-16 Thread Oleg Drokin
It's multiple values per file, so it has no business being in sysfs, besides it was assuming seqfile anyway. Introduced by commit d806f30e639b ("staging: lustre: osc: revise unstable pages accounting") Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 34 +++

[PATCH 2/2] staging: ks7010: Remove braces around single statement blocks

2016-10-16 Thread Sabitha George
Fixes checkpatch warning: braces{} are not necessary for single statment blocks Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/

[PATCH 1/2] staging: ks7010: Add blank line after declarations

2016-10-16 Thread Sabitha George
Fixes checkpatch.pl warning :Missing a blank line after declarations Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 1f9f63e..ad840f9 1006

Re: [PATCH] Staging: media: omap4iss: fixed coding style issues

2016-10-16 Thread Greg KH
On Sun, Oct 16, 2016 at 05:18:56PM +0200, Hector Roussille wrote: > Fixed coding style issues You need to be a lot more specific please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

Re: [PATCH] staging: ks7010: Fix coding style errors

2016-10-16 Thread Greg KH
On Sun, Oct 16, 2016 at 05:23:51PM +0200, Carlos Maiolino wrote: > Fixes the following checkpatch.pl errors/warnings: > > WARNING: please, no spaces at the start of a line > ERROR: space prohibited after that open parenthesis '(' > ERROR: space prohibited before that close parenthesis ')' > ERROR:

Re: [PATCH 57/80] staging: lustre: osc: revise unstable pages accounting

2016-10-16 Thread Greg Kroah-Hartman
Digging up an old email... On Tue, Aug 16, 2016 at 04:19:10PM -0400, James Simmons wrote: > From: Jinshan Xiong > > A few changes are made in this patch for unstable pages tracking: > > 1. Remove kernel NFS unstable pages tracking because it killed >performance > 2. Track unstable pages as

Re: [PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Greg KH
On Sun, Oct 16, 2016 at 06:12:32PM +0530, Siddhi Dave wrote: > Fix checkpatch warning: Macros with flow control statements should be avoided > > Because Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Signed-off-by: Siddhi

Re: [PATCH] Staging: media: omap4iss: fixed coding style issues

2016-10-16 Thread Laurent Pinchart
Hi Hector, Thank you for the patch. On Sunday 16 Oct 2016 17:18:56 Hector Roussille wrote: > Fixed coding style issues What coding style issues ? > > Signed-off-by: Hector Roussille > --- > drivers/staging/media/omap4iss/iss_video.c | 11 +++ > 1 file changed, 7 insertions(+), 4 dele

[PATCH] staging: ks7010: Fix coding style errors

2016-10-16 Thread Carlos Maiolino
Fixes the following checkpatch.pl errors/warnings: WARNING: please, no spaces at the start of a line ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' ERROR: space required before the open brace '{' ERROR: exactly one space required a

[PATCH] Staging: media: omap4iss: fixed coding style issues

2016-10-16 Thread Hector Roussille
Fixed coding style issues Signed-off-by: Hector Roussille --- drivers/staging/media/omap4iss/iss_video.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c16927a..8f2d374

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Julia Lawall
On Sun, 16 Oct 2016, Siddhi Dave wrote: > Fix checkpatch warning: Macros with flow control statements should be avoided > > Because Macros with flow control statements (goto and return) are > not very nice to read as any flow movement is unexpected. > > Signed-off-by: Siddhi Dave > --- > drive

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1

[PATCH] Staging: dgnc: Clean up Macros

2016-10-16 Thread Siddhi Dave
Fix checkpatch warning: Macros with flow control statements should be avoided Because Macros with flow control statements (goto and return) are not very nice to read as any flow movement is unexpected. Signed-off-by: Siddhi Dave --- drivers/staging/dgnc/dgnc_sysfs.c | 20 ++-- 1

[PATCH] staging: greybus: audio: Rename cport with intf_id

2016-10-16 Thread Pankaj Bharadiya
gb_audio_manager_module_descriptor's cport field is actually used to manage and pass interface id to user space. Thus rename gb_audio_manager_module_descriptor's 'cport' field and few other things to avoid confusion. Signed-off-by: Pankaj Bharadiya --- drivers/staging/greybus/audio_manager.h

Re: [staging:staging-testing 275/275] /tmp/ccbrt8LJ.s:560: Error: missing immediate expression at operand 1 -- `dsb '

2016-10-16 Thread Greg Kroah-Hartman
On Sun, Oct 16, 2016 at 09:25:54AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 07823993a309809c5107de94a892274bc984b92b > commit: 07823993a309809c5107de94a892274bc984b92b [275/275] staging/vchi: > Remove

Re: [PATCH 0/5] Replace data type declarations with variables of same types in several source files.

2016-10-16 Thread Alexander Alemayhu
On Mon, Oct 10, 2016 at 04:02:17PM +0200, Sergio Paracuellos wrote: > This patch series replaces several sizeof(struct XXX) stuff in favour > of sizeof(var) which is the preferred one. > Why not squash this series into one patch? The commit messages are fairly similar and the changes are focused