[PATCH V4] staging: ks7010: use netdev_* instead of printk()

1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 22 +- 1 file changed, 9 insertions(+), 13

Re: [PATCH V3] staging: ks7010: use netdev_* instead of printk()

On Mon, 2016-10-10 at 11:14 +0530, Sabitha George wrote: > 1. Fixes checkpatch warning on printk usage in ks_hostif.c > 2. Dropped "ks_wlan" prefix from the messages > 3. Removed the "Memory squeeze,dropping packet" messages [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/

[PATCH V3] staging: ks7010: use netdev_* instead of printk()

1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 23 ++- 1 file changed, 10 insertions(+), 1

Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()

On Sun, Oct 09, 2016 at 10:46:26AM -0700, Joe Perches wrote: > On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote: > > Fixes checkpatch warning on printk usage in ks_hostif.c > [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c > > b/drivers/staging/ks7010/ks_hostif.c > [] > > @@ -465,8 +

[PATCH] Staging: rtl8188eu: fix Block comments warning found by checkpatch.

WARNING: Block comments use * on subsequent lines Signed-off-by: victor carvajal --- drivers/staging/rtl8188eu/include/rtw_event.h | 39 +-- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_event.h b/drivers/staging/rt

[PATCH] RFC: staging: greybus: shape up greybus GPIO

Greybus GPIO seems to reimplement the already existing generic gpiolib irqchip. Also use gpiochip_get_data(). Also use devm_gpiochip_add_data(). Cc: Viresh Kumar Cc: Axel Haslam Cc: Johan Hovold Cc: Sandeep Patil Cc: Rui Miguel Silva Cc: Greg Kroah-Hartman Signed-off-by: Linus Walleij --- G

[PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues

Added braces to else statement where checkpatch complained. Signed-off-by: Chase Metzger --- drivers/staging/greybus/audio_codec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 8a0744b..

[PATCH 2/3] staging: ks7010: fix block comment style in ks7010_stdio.c

This fixes the following checkpatch warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate lines Signed-off-by: Akshay Mariyanna --- drivers/staging/ks7010/ks7010_sdio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 3/3] staging: ks7010: fix space related style issues in ks7010_sdio.c

This fixes the following checkpatch warnings: WARNING: Unnecessary space before function pointer arguments WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Akshay Mariyanna --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/3] staging: ks7010: fix indent style in ks7010_sdio.c

This patch fixes the following checkpatch error: ERROR: code indent should use tabs where possible Signed-off-by: Akshay Mariyanna --- drivers/staging/ks7010/ks7010_sdio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/dri

Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()

On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote: > Fixes checkpatch warning on printk usage in ks_hostif.c [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv) >

[PATCH V2] staging: ks7010: use netdev_* instead of printk()

Fixes checkpatch warning on printk usage in ks_hostif.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c in

[PATCH v2 9/9] staging: wlan-ng: fix block comments style in prism2mgmt.h

This patch fixes the following checkpatch.pl warning in prism2mgmt.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mgmt.h | 122 ++- 1 file changed, 62 insertions(+), 60 deletions(-) diff --git

[PATCH v2 2/9] staging: wlan-ng: fix block comments style in p80211hdr.h

This patch fixes the following checkpatch.pl warning in p80211hdr.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211hdr.h | 114 ++-- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git

[PATCH v2 6/9] staging: wlan-ng: fix block comments style in p80211msg.h

This patch fixes the following checkpatch.pl warning in p80211msg.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211msg.h | 90 ++--- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a

[PATCH v2 8/9] staging: wlan-ng: fix block comments style in p80211req.h

This patch fixes the following checkpatch.pl warning in p80211req.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.h | 90 ++--- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a

[PATCH v2 5/9] staging: wlan-ng: fix block comments style in p80211mgmt.h

This patch fixes the following checkpatch.pl warning in p80211mgmt.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211mgmt.h | 194 +-- 1 file changed, 97 insertions(+), 97 deletions(-) diff --g

[PATCH v2 7/9] staging: wlan-ng: fix block comments style in p80211netdev.h

This patch fixes the following checkpatch.pl warning in p80211netdev.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.h | 100 - 1 file changed, 50 insertions(+), 50 deletions(-) diff --gi

[PATCH v2 4/9] staging: wlan-ng: fix block comments style in p80211metadef.h

This patch fixes the following checkpatch.pl warning in p80211metadef.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211metadef.h | 88 - 1 file changed, 44 insertions(+), 44 deletions(-) diff --g

[PATCH v2 0/9] staging: wlan-ng: fix block comments style warning in header files

This patch series fix checkpatch.pl script reported warning Block comments should align the * on each line Changes v2: * Fix commit subject from wlang-ng to wlan-ng Sergio Paracuellos (9): staging: wlan-ng: fix block comments style in p80211conv.h staging: wlan-ng: fix block comments style in

[PATCH v2 1/9] staging: wlan-ng: fix block comments style in p80211conv.h

This patch fixes the following checkpatch.pl warning in p80211conv.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.h | 100 +-- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[PATCH v2 3/9] staging: wlan-ng: fix block comments style in p80211ioctl.h

This patch fixes the following checkpatch.pl warning in p80211ioctl.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211ioctl.h | 120 +- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git

Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

This warnings seems to be fixed in the new tree, so I don't resend anything. El 2016年10月09日 a las 17:23, Greg KH escribió: On Sun, Oct 09, 2016 at 05:10:31PM +0200, Sergio Paracuellos wrote: This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: line over 80 characters Si

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

Just sitting in front of my laptop :) Thanks to you for code review! Cheers, Sergio Paracuello El 2016年10月09日 a las 17:36, Greg KH escribió: On Sun, Oct 09, 2016 at 05:29:22PM +0200, Sergio Paracuellos wrote: This patch fix the following sparse warnings in prism2fw.c: warning: memset w

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

On Sun, Oct 09, 2016 at 05:29:22PM +0200, Sergio Paracuellos wrote: > This patch fix the following sparse warnings in prism2fw.c: > warning: memset with byte count of 12 > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/prism2fw.c | 11 --- > 1 file changed, 8 ins

[PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error

This patch resolves the following error caught by checkpatch.pl: ERROR: that open brace { should be on the previous line Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/

[PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk

This patch replaces call to printk with appropriate pr_* function thus addressing the following warning generated by the checkpatch script: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by: Harman Kalra

[PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error

This patch resolves the following error caught by checkpatch.pl: ERROR: that open brace { should be on the previous line Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/

[PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

This patch fix the following sparse warnings in prism2fw.c: warning: memset with byte count of 12 Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/dri

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

On Sun, Oct 09, 2016 at 05:14:52PM +0200, Sergio Paracuellos wrote: > This patch fix the following sparse warnings in prism2fw.c: > warning: memset with byte count of 12 > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/prism2fw.c | 11 --- > 1 file changed, 8 ins

Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

On Sun, Oct 09, 2016 at 05:10:31PM +0200, Sergio Paracuellos wrote: > This patch fix the following checkpatch.pl warnings in prism2sta.c: > WARNING: line over 80 characters > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/prism2sta.c | 9 ++--- > 1 file changed, 6 insert

Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

On Sun, Oct 09, 2016 at 08:29:11PM +0530, Harman Kalra wrote: > This patch replaces calls to the "printk" with appropriate "pr_*" > function thus addressing the following warning generated by the > checkpatch script: > > Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then > dev_wa

[PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drive

[PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c

This patch fix the following checkpatch.pl warnings in prism2mib.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mib.c | 100 ++-- 1 file changed, 50 insertions(+), 50 deletions(-) dif

[PATCH] staging: wlan-ng: avoid new typedef CTLX_STATE

This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef CTLX_STATE Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x.h | 3 +-- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 2 files changed, 2 insertions(

[PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c

This patch fix the following checkpatch.pl warnings in prism2fw.c WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 485 +++---

[PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c

This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2sta.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff

[PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

This patch fix the following sparse warnings in prism2fw.c: warning: memset with byte count of 12 Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/dri

[PATCH 10/15] staging: wlan-ng: fix line style warnings in p80211wep.c

This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/st

[PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c

This patch fix the following checkpatch.pl warnings in prism2mgmt.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2mgmt.c | 518 ++---

[PATCH 02/15] staging: wlan-ng: fix block comment warnings in hfa384x_usb.c

This patch fix the following checkpatch.pl warnings in hfa384x_usb.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 2370 +--

[PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c

This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 90 ++--- 1 file changed, 45 insertions(+), 45 deletions(-) dif

[PATCH 08/15] staging: wlan-ng: fix line style warnings in p80211req.c

This patch fix the following checkpatch.pl warnings in p80211req.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/

[PATCH 05/15] staging: wlan-ng: fix block comment warnings in p80211netdev.c

This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c | 613 +

[PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c

This patch fix the following checkpatch.pl warnings in p80211req.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 166 ++-

[PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c

This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c

[PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c

This patch fix the following checkpatch.pl warnings in p80211conv.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.c | 318 +-- 1 file changed, 159 insertions(+), 159 deletions(-)

[PATCH 06/15] staging: wlan-ng: do not return -ENOSYS

Fixed coding style issue by replacing ENOSYS with EINVAL. This patch fix the following checkpatch.pl warnings in p80211netdev.c: WARNING: ENOSYS means 'invalid syscall nr' and nothing else Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211netdev.c | 6 +++--- 1 file changed, 3

[PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c

This patch fix the following checkpatch.pl warnings in hfa384x_usb.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 71 +++ 1 file changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/sta

[PATCH 00/15] staging: wlan-ng: Fix several style issues in several source files.

This patch series fix some of the following checkpatch.pl reported warnings: WARNING: line over 80 characters WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line WARNING: ENOSYS means 'invalid syscall nr' and nothing else Sergio Para

Re: [PATCH 00/13] staging: unisys: Convert client_bus_info to debugfs

On Tue, Oct 04, 2016 at 10:16:38AM -0400, David Kershner wrote: > Move /sys/bus/visorbus/devices/visorbus/client_bus_info to debugfs > > In a 9/28/2016 patch inspection that fixed code within the function that > emits this client_bus_info sysfs entry, GregKH pointed out that this > shouldn't actua

Re: [PATCH 05/13] staging: unisys: visorbus: remove unused initializations

On Tue, Oct 04, 2016 at 10:16:43AM -0400, David Kershner wrote: > From: sameer wadgaonkar lower-case name? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 04/13] staging: unisys: include: include.h remove unused pound defines

On Tue, Oct 04, 2016 at 10:16:42AM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch removes all the unused pound defines currently in > include.h. But does the hardware think they might be needed? If so, leave them. And again, wrap at 72. thanks, greg k-h __

Re: [PATCH 03/13] staging: unisys: visorbus: controlvmchannel.h fix spacing

On Tue, Oct 04, 2016 at 10:16:41AM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch fixes space and tab aligned comments in > controlvmchannel.h. It does? > > Signed-off-by: Erik Arfvidson > Signed-off-by: David Kershner > --- > drivers/staging/unisys/visorbus/controlvmcha

Re: [PATCH 02/13] staging: unisys: visorbus: controlvmchannel.h fix comments

On Tue, Oct 04, 2016 at 10:16:40AM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch simply fixes comments to mantain a more consistent > and shorter comments. Any reason you don't wrap your changelog comment lines at 72 columns like git asks you to? > > githubissue: What doe

Re: [PATCH 01/13] staging: unisys: visorbus: controlvmchannel.h remove unused pound defines

On Tue, Oct 04, 2016 at 10:16:39AM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch removes all unused pound defines in controlvmchannel.h. > Adds a comment on the now unused error codes for our spar firmware > to avoid new error messages conflicting with previously defined > me

Re: [PATCH 2/3] Staging: i4l: Error "open brace { should be on the previous line" fixed.

On Fri, Oct 07, 2016 at 10:27:55PM +0530, Harman Kalra wrote: > Errors "open brace { should be on the previous line" caught by checkpatch.pl > fixed. Why two ' ' characters? > Signed-off-by: Harman Kalra Same blank line needed. thanks, greg k-h __

Re: [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed.

On Fri, Oct 07, 2016 at 10:27:56PM +0530, Harman Kalra wrote: > Error "open brace { should be on the previous line" caught by checkpatch.pl > fixed. > Signed-off-by: Harman Kalra Please put a blank line before the signed-off-by: line. As examples, look at all other commits in the tree :) thank

[PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

This patch replaces calls to the "printk" with appropriate "pr_*" function thus addressing the following warning generated by the checkpatch script: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...:w Signed-off-by:

Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed

On Fri, Oct 07, 2016 at 10:27:54PM +0530, Harman Kalra wrote: > Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than > 80 character" fixed That is two different things again :( I can't take this as is... greg k-h ___ devel mai

Re: [PATCH 1/8] staging: rts5208: Fix CamelCase found by checkpatch

On Mon, Oct 03, 2016 at 11:16:22PM +, Wayne Porter wrote: > Convert CamelCase to recommended style. > > Signed-off-by: Wayne Porter > --- > drivers/staging/rts5208/xd.c | 8 > drivers/staging/rts5208/xd.h | 8 > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --g

Re: [PATCH 2/3] staging: ks7010: use netdev_* instead of printk()

On Sun, Oct 09, 2016 at 11:23:25AM +0530, Sabitha George wrote: > Fixes checkpatch warning on printk usage in ks_hostif.c > > Signed-off-by: Sabitha George > --- > drivers/staging/ks7010/ks_hostif.c | 31 +++ > 1 file changed, 15 insertions(+), 16 deletions(-) Due to

Re: [PATCH 1/3] staging: ks7010: use __packed instead of __attribute__((packed))

On Sun, Oct 09, 2016 at 11:22:32AM +0530, Sabitha George wrote: > This patch fixes the below checkpatch warning in ks_hostif.c: > __packed is preferred over __attribute__((packed)) > > Signed-off-by: Sabitha George > --- > drivers/staging/ks7010/ks_hostif.c | 8 > 1 file changed, 4 ins

[PATCH] Staging: fbtft: Fixed open parenthesis alignment check

This patch resolves all the following CHECKs caught by checkpatch.pl CHECK: Alignment should match open parenthesis Signed-off-by: Harman Kalra --- drivers/staging/fbtft/fb_ili9325.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fbtft/fb_ili9325.

Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

On Sun, Oct 09, 2016 at 07:58:00PM +0530, Harman Kalra wrote: > This patch replaces calls to the "printk" with appropriate "pr_*" > function thus addressing the following warning generated by the > checkpatch script: > > Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then > dev_warn

Re: [PATCH] Staging: rtl8188eu: fix code indention error and block comments found by checkpatch.

On Sun, Oct 02, 2016 at 04:55:55PM -0700, victor carvajal wrote: > ERROR: code indent should use tabs where possible > +^I^Iuint in_len, uint initial_out_len);$ > > WARNING: Block comments use * on subsequent lines That is two different things, you need to have two different patches. tha

Re: [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE

On Mon, Oct 03, 2016 at 06:07:03PM +0200, Sergio Paracuellos wrote: > This patch fixes the following checkpatch.pl warning in hfa384x.h: > WARNING: do not add new typedefs > > It applies for typedef CTLX_STATE > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/hfa384x.h |

Re: [PATCH] staging: wlang-ng: get memory from kernel allocators instead of big static buffer

On Mon, Oct 03, 2016 at 06:05:44PM +0200, Sergio Paracuellos wrote: > This patch fix the following sparse warnings in prism2fw.c: > warning: memset with byte count of 12 > > Signed-off-by: Sergio Paracuellos > --- > drivers/staging/wlan-ng/prism2fw.c | 11 --- > 1 file changed, 8 ins

Re: [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files.

On Mon, Oct 03, 2016 at 06:04:00PM +0200, Sergio Paracuellos wrote: > This patch series fix some of the following checkpatch.pl reported warnings: > WARNING: line over 80 characters > WARNING: Block comments should align the * on each line > WARNING: Block comments use a trailing */ on a separate l

[PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

This patch replaces calls to the "printk" with appropriate "pr_*" function thus addressing the following warning generated by the checkpatch script: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... Signed-off-by: H

Re: [PATCH 35/41] staging: lustre: hsm: Use file lease to implement migration

On Sun, Oct 02, 2016 at 10:28:31PM -0400, James Simmons wrote: > From: Henri Doreau > > Implement non-blocking migration based on exclusive open instead of > group lock. Implemented exclusive close operation to atomically put > a lease, swap two layouts and close a file. This allows race-free > m

Re: [PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

On Sun, Oct 02, 2016 at 10:28:28PM -0400, James Simmons wrote: > From: Bobi Jam > > If normal IO got short read/write, we'd restart the IO from where > we've accomplished until we meet EOF or error happens. > > Signed-off-by: Bobi Jam > Signed-off-by: Jinshan Xiong > Intel-bug-id: https://jira

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

On Fri, Oct 07, 2016 at 05:04:16PM -0700, Chase Metzger wrote: > Added braces to else statements where checkpatch complained. > > Signed-off-by: Chase Metzger You used the same subject here as your last patch, which implies it did the same thing, yet it did not :( So please make the subject uni

Re: [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

On Fri, Oct 07, 2016 at 02:05:13PM -0700, Nadim Almas wrote: > Fixed coding style issue Your subject is huge, please don't make it so long. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mai

[PATCH] staging: net: netlogic: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/staging/netlogic/xlr_net.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.

Re: [patch] staging: ion: use two separate locks for heaps and clients in ion_device

On Fri, Oct 07, 2016 at 04:27:49PM +0800, YiPing Xu wrote: > > > On 2016/10/5 2:02, Laura Abbott wrote: > > On 09/30/2016 01:18 AM, Xu YiPing wrote: > > > ion_alloc may get into slow path to get free page, > > > the call stack: > > > > > > __alloc_pages_slowpath > > > ion_page_pool_alloc_pages >

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

On 09/10/16 11:35, Brian Masney wrote: > On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote: >> On 07/10/16 01:48, Brian Masney wrote: >>> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. >>> >>> Signed-off-by: Brian Masney >> Time for a nitpick tastic review ;) >

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote: > On 07/10/16 01:48, Brian Masney wrote: > > Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. > > > > Signed-off-by: Brian Masney > Time for a nitpick tastic review ;) > > The nature of a move out of staging pa

Re: [PATCH 3/4] staging: iio: isl29018: rename Kconfig variable to match existing light drivers in mainline.

On 07/10/16 01:48, Brian Masney wrote: > Rename CONFIG_SENSORS_ISL29018 to CONFIG_ISL29018 for consistency with > the other light drivers in mainline. > > Signed-off-by: Brian Masney I'm always a bit split on these. It would be lovely to tidy it up, but it may cause unnecessary breakage to peopl

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

On 07/10/16 01:48, Brian Masney wrote: > Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline. > > Signed-off-by: Brian Masney Time for a nitpick tastic review ;) The nature of a move out of staging patch is that we'll go over it with the level of fine toothed comb we apply to a n

Re: [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression

On 09/10/16 09:43, Jonathan Cameron wrote: > On 07/10/16 01:48, Brian Masney wrote: >> Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) >> about the infrared suppression that can be controlled >> with the proximity_on_chip_ambient_infrared_suppression sysfs attribute. >> >> Si

Re: [PATCH 2/4] staging: iio: isl29018: document device tree bindings

On 07/10/16 01:48, Brian Masney wrote: > Fix the following warnings from checkpatch: > > WARNING: DT compatible string "isil,isl29018" appears un-documented -- > check ./Documentation/devicetree/bindings/ > WARNING: DT compatible string "isil,isl29023" appears un-documented -- > check ./Documentat

Re: [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression

On 07/10/16 01:48, Brian Masney wrote: > Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) > about the infrared suppression that can be controlled > with the proximity_on_chip_ambient_infrared_suppression sysfs attribute. > > Signed-off-by: Brian Masney > --- > drivers/stagi