[staging:staging-next 800/1248] drivers/staging/lustre/lustre/llite/llite_lib.c:2525:9-16: WARNING opportunity for memdup_user

2016-10-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: fc1e2c8ea85e109acf09e74789e9b852f6eed251 commit: dbf789ce9d45721f990a993c7b1e61b998470a90 [800/1248] staging: lustre: llite: allow setting stripes to specify OSTs coccinelle warnings: (new ones prefi

[staging:staging-next 761/1248] drivers/staging/lustre/lustre/osc/osc_request.c:1045:5-24: WARNING: Unsigned expression compared with zero: cli -> cl_avail_grant < 0

2016-10-02 Thread Julia Lawall
cli->cl_avail_grant has type unsigned long, so the code in line 1039-1045 will have to be handled in some other way. julia -- Forwarded message -- Date: Mon, 3 Oct 2016 13:20:40 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [staging:staging-next 761/

Re: [lustre-devel] [PATCH] staging: lustre: ko2iblbd: handle ib_dereg_mr removal

2016-10-02 Thread Dilger, Andreas
On Oct 2, 2016, at 20:22, James Simmons wrote: > > In the rdma-next tree to be merged for 4.9-rc1 removes > the IB core function ib_get_dma_mr. This patch migrates > us way from this former function. > > Signed-off-by: James Simmons > --- > .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c|

Re: [PATCH] staging: greybus: light: check the correct value of delay_on

2016-10-02 Thread Viresh Kumar
On Fri, Sep 30, 2016 at 10:56 PM, Rui Miguel Silva wrote: > When checking the value of delay_on to set the channel as active, it was > checked the pointer and not the value, as it should be. > > Fixes: cc43368a3c ("greybus: lights: Control runtime pm suspend/resume on AP > side") > > Signed-off-b

[PATCH 29/41] staging: lustre: ptlrpc: Move NRS structures out of lustre_net.h

2016-10-02 Thread James Simmons
From: Chris Horn NRS specific structures are not needed in the rest of the PtlRPC code. It is more appropriate for these structures to be defined in a separate header. This commit creates a lustre_nrs.h header for the generic NRS structures, and policy-specific headers for the various NRS policie

[PATCH 31/41] staging: lustre: obd: remove destroy cookie handling

2016-10-02 Thread James Simmons
From: John L. Hammond Clients no longer need to track the max and default MDS cookiesizes so remove the obsolete obod o_valid flag OBD_MD_FLCOOKIE, the struct client_obd members cl_{default,max}_mds_cookiesize, the struct obd_trans_info and parameters of this type, the cookiesize parameters f

[PATCH 07/41] staging: lustre: llite: remove duplicate fiemap defines

2016-10-02 Thread James Simmons
From: Bobi Jam * replace struct ll_user_fiemap with struct fiemap * replace struct ll_fiemap_extent with struct fiemap_extent * remove kernel defined FIEMAP_EXTENT_* constants * remove kernel defined FIEMAP_FLAG_* flags * add member prefix for struct ll_fiemap_info_key * Add cl_object_oper

[PATCH 40/41] staging: lustre: lov: move LSM to LOV layer

2016-10-02 Thread James Simmons
From: John L. Hammond Move the definition of struct lov_stripe_md along with supporting functions from obd.h to lov_internal.h. Remove the unused functions obd_packmd() and obd_free_diskmd(). Simplify lov_obd_packmd() according to the reduced use cases and rename it lov_packmd(). Signed-off-by:

[PATCH 39/41] staging: lustre: osc: remove remaining bits for capa support

2016-10-02 Thread James Simmons
From: John L. Hammond With capa support removed from the OSC layer a few more bits can be cleaned up. Convert the OBD getattr and setattr paths to use struct obdo rather than struct obd_info. Remove the oi_policy, oi_oa, and oi_capa members from struct obd_info. Signed-off-by: John L. Hammond I

[PATCH 03/41] staging: lustre: llite: remove client Size on MDS support

2016-10-02 Thread James Simmons
From: John L. Hammond Size on MDS support have been in preview since at least 2.0.0. Remove support for it from lustre/llite/. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6047 Reviewed-on: http://review.whamcloud.com/13126 Reviewed-by: Andreas Dilger Revi

[PATCH 41/41] staging: lustre: echo: request pages in batches

2016-10-02 Thread James Simmons
From: Alex Zhuravlev rather than fetch them one by one. Signed-off-by: Alex Zhuravlev Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5278 Reviewed-on: http://review.whamcloud.com/13612 Reviewed-by: Nathaniel Clark Reviewed-by: Andreas Dilger Signed-off-by: James Simmons --- .../staging

[PATCH 35/41] staging: lustre: hsm: Use file lease to implement migration

2016-10-02 Thread James Simmons
From: Henri Doreau Implement non-blocking migration based on exclusive open instead of group lock. Implemented exclusive close operation to atomically put a lease, swap two layouts and close a file. This allows race-free migrations. Make the caller responsible for retrying on failure (EBUSY, EAG

[PATCH 30/41] staging: lustre: quota: remove obsolete quota code

2016-10-02 Thread James Simmons
From: Niu Yawei Remove the obsolete quotacheck, quotaon and quotaoff, which were retained for the interoperability with old (< 2.4) client and server. Some other obsolete quota code related to LL_IOC_QUOTACTL_18, Q_INVLIDATE and Q_FINVALIDATE are removed as well. Signed-off-by: Niu Yawei Intel

[PATCH 28/41] staging: lustre: hsm: make HSM modification requests replayable

2016-10-02 Thread James Simmons
From: Mikhail Pershin There are several HSM requests which modify data on server and reply on Lustre recovery, e.g. they should replay changes in case of recovery. Patch allows such requests to be replayed in recovery time and they are issued from client using mdc_rpc_lock to serialize them and

[PATCH 37/41] staging: lustre: lov: copy_to_user uses wrong casting

2016-10-02 Thread James Simmons
With certain version of gcc lov_obd.c failes to compile with the following warning. In function copy_to_user, inlined from lov_iocontrol at lustre/lustre/lov/lov_obd.c:1168: ./arch/x86/include/asm/uaccess.h:735: error: call to __copy_to_user_overflow declared with attribute warning: copy_to_user()

[PATCH 34/41] staging: lustre: ldlm: cancel aged locks for LRUR

2016-10-02 Thread James Simmons
From: Niu Yawei It doesn't make sense to keep the very aged lock even with the LRUR policy. This patch decreased the default ns_max_age from 10 hours to 65 minutes and changed LRUR policy to cancel very aged locks. Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-652

[PATCH 36/41] staging: lustre: ldlm: interval tree search in ldlm_lock_match()

2016-10-02 Thread James Simmons
From: Vitaly Fertman replace the linear search by interval_tree one for granted list in ldlm_lock_match() Signed-off-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5739 Xyratex-bug-id: MRP-2089 Reviewed-on: http://review.whamcloud.com/12294 Reviewed-by: Andreas Dilger R

[PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

2016-10-02 Thread James Simmons
From: Bobi Jam If normal IO got short read/write, we'd restart the IO from where we've accomplished until we meet EOF or error happens. Signed-off-by: Bobi Jam Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6389 Reviewed-on: http://review.whamcloud.com/14123 R

[PATCH 24/41] staging: lustre: clio: add CIT_DATA_VERSION and remove IOC_LOV_GETINFO

2016-10-02 Thread James Simmons
From: John L. Hammond During development a new api, cl_object_obd_info_get() and cl_object_data_version() which then were later replaced by a better solution CIT_DATA_VERSION. For the case of the upstream client their is no point in introducing a API to only have it removed later. Due to the way

[PATCH 38/41] staging: lustre: mdc: add max modify RPCs in flight variable

2016-10-02 Thread James Simmons
From: Gregoire Pichon This patch introduces the maximum modify RPCs in flight variable of a mdc client obd device. Its value is set from connection flag and and connection data. It can later be tuned through the max_mod_rpcs_in_flight procfs file. Signed-off-by: Gregoire Pichon Intel-bug-id: ht

[PATCH 27/41] staging: lustre: llite: add cl_object_maxbytes()

2016-10-02 Thread James Simmons
From: John L. Hammond Add cl_object_maxbytes() to return the maximum supported size of a cl_object. Remove the lli_maxbytes member from struct ll_inode_info. Change the lsm_maxbytes member of struct lov_stripe_md from __u64 to loff_t. Correct the computation of lsm_maxbytes in the released layout

[PATCH 25/41] staging: lustre: lov: add cl_object_layout_get()

2016-10-02 Thread James Simmons
From: John L. Hammond Add cl_object_layout_get() to return the layout and generation of an object. Replace some direct accesses to object LSM with calls to this function. In ll_getxattr() factor out the LOV xattr specific handling into a new function ll_getxattr_lov() which calls cl_object_layou

[PATCH 26/41] staging: lustre: llite: remove lli_has_smd

2016-10-02 Thread James Simmons
From: Jinshan Xiong Remove the lli_has_smd flag from struct ll_inode_info. The empty layout case will be handled by the LOV layer. Remove the unused function cl_local_size(). Signed-off-by: Jinshan Xiong Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5814 Re

[PATCH 33/41] staging: lustre: lov: use obd_get_info() to get def/max LOV EA sizes

2016-10-02 Thread James Simmons
From: John L. Hammond Use obd_get_info() to get the default and maximum LOV EA sizes (along with maximum cookiesize) from LOV. Remove the then unused function obd_size_diskmd() and the unused get info key KEY_LOVDESC. When computing the maximum LOV EA size use the active OST count (ld_active_tgt_

[PATCH 21/41] staging: lustre: mdc: Removed unneeded NULL check

2016-10-02 Thread James Simmons
From: Henri Doreau Do not bother checking the return value of changelog_kuc_hdr() against NULL since this value was dereferenced earlier. Signed-off-by: Henri Doreau Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4189 Reviewed-on: http://review.whamcloud.com/12919 Reviewed-by: John L. Hamm

[PATCH 15/41] staging: lustre: osc: fix bug when setting max_pages_per_rpc

2016-10-02 Thread James Simmons
From: Wu Libin After setting like "lctl set_param -P osc.*.max_pages_per_rpc", it is possible that the function osc_obd_max_pages_per_rpc_seq_write will be called before ocd_brw_size has been set when mount. ocd_brw_size is meaningless when it is zero. So it should not be the limit at that time.

[PATCH 04/41] staging: lustre: obd: remove client Size on MDS support

2016-10-02 Thread James Simmons
From: John L. Hammond Remove the unused OBD MD API method md_done_writing(). Remove the unused logcookie and struct md_open_data ** parameters from md_setattr(). Remove the unused functions iattr_from_obdo(), md_from_obdo(), and obdo_refresh_inode(). Signed-off-by: John L. Hammond Intel-bug-id:

[PATCH 22/41] staging: lustre: obd: remove unused LSM parameters

2016-10-02 Thread James Simmons
From: John L. Hammond Remove unused struct lov_stripe_md * parameters from obd_get_info(), mgc_enqueue(), and osc_brw_prep_request(). Signed-off-by: John L. Hammond Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5814 Reviewed-on: http://review.whamcloud.com/13

[PATCH 08/41] staging: lustre: ptlrpc: ret -ECONNREFUSED if not context found in req

2016-10-02 Thread James Simmons
From: Sebastien Buisson Return -ECONNREFUSED instead of -ENOMEM in sptlrpc_req_get_ctx() if no context is found in req. It is more graceful. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6356 Reviewed-on: http://review.whamcloud.com/14043 Reviewed-by: Dmit

[PATCH 14/41] staging: lustre: ptlrpc: Add a tag field to ptlrpc messages

2016-10-02 Thread James Simmons
From: Gregoire Pichon The new tag field is used as a virtual index for multiple modifying RPCs management. It is set by the client and allows the target to release in-memory reply data when the tag is reused by a new RPC. The tag field replaces the unused last_seen field of ptlrpcd_body structur

[PATCH 09/41] staging: lustre: llite: default dir stripe index only for mkdir

2016-10-02 Thread James Simmons
From: wang di Default dir stripe index should only work during mkdir, otherwise it will cause other open/create request being sent to the wrong MDT. Signed-off-by: wang di Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6373 Reviewed-on: http://review.whamcloud.com/14096 Reviewed-by: Alex Z

[PATCH 05/41] staging: lustre: clio: Revise read ahead implementation

2016-10-02 Thread James Simmons
From: Jinshan Xiong In this implementation, read ahead will hold the underlying DLM lock to add read ahead pages. A new cl_io operation cio_read_ahead() is added for this purpose. It takes parameter cl_read_ahead{} so that each layer can adjust it by their own requirements. For example, at OSC la

[PATCH 06/41] staging: lustre: ldlm: remove unnecessary EXPORT_SYMBOL

2016-10-02 Thread James Simmons
From: frank zago A lot of symbols don't need to be exported at all because they are only used in the module they belong to. Signed-off-by: frank zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5829 Reviewed-on: http://review.whamcloud.com/13324 Reviewed-by: James Simmons Reviewed-by:

[PATCH 13/41] staging: lustre: clio: use CIT_SETATTR for FSFILT_IOC_SETFLAGS

2016-10-02 Thread James Simmons
From: John L. Hammond Add handling of inode flags to the handlers of CIT_SETATTR in lov and osc. In the FSFILT_IOC_SETFLAGS case of ll_iocontrol() use cl_setattr_ost() rather than obd_setattr_rqset() to set inode flags on OST objects. Remove the then unused OBD API methods obd_setattr_rqset() and

[PATCH 20/41] staging: lustre: remove Size on MDS support

2016-10-02 Thread James Simmons
From: John L. Hammond Remove unused definitions related to Size on MDS support from lustre/include/lustre/lustre_idl.h. Remove unused code from several places in lustre/. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6047 Reviewed-on: http://review.whamcloud

[PATCH 11/41] staging: lustre: ptlrpc: Add OBD_CONNECT_MULTIMODRPCS flag

2016-10-02 Thread James Simmons
From: Gregoire Pichon The new OBD_CONNECT_MULTIMODRPCS connection flag indicates the support of multiple modify RPCs in parallel. It can be specified by the client within the connection request and by the server within the connection reply. The new ocd_maxmodrpcs connection data specifies the max

[PATCH 23/41] staging: lustre: mgc: MGC should retry for invalid import

2016-10-02 Thread James Simmons
From: wang di After http://review.whamcloud.com/#/c/9967/ is landed, mgc does not wait the import connected(state = FULL), then enqueue and retrieve config log, which will cause the mount process to fail, especially if the mgc is shared by multiple targets. So once mgc enqueue is failed, it will

[PATCH 18/41] staging: lustre: llite: Report first encountered error

2016-10-02 Thread James Simmons
From: Henri Doreau Failures in ll_ioc_copy_{start,end} are reported to coordinator. The return code delivered to the caller should indicate what this error was, not whether coordinator was successfully notified. Signed-off-by: Henri Doreau Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-568

[PATCH 16/41] staging: lustre: ldlm: Do not use cbpending for group locks

2016-10-02 Thread James Simmons
From: Patrick Farrell Currently, the CBPENDING flag is set on group locks when the osc lock above them is released (osc_cancel_base). This results in a situation where a new group lock request on a resource does not match an existing group lock because LDLM_FL_CBPENDING is set on the existing lo

[PATCH 17/41] staging: lustre: ptlrpc: remove old protocol compatibility

2016-10-02 Thread James Simmons
From: Andreas Dilger Some old protocol compatibility workarounds are still present in master that should have been removed when LUSTRE_MSG_MAGIC_V1 was. In particular, the process for upgrading LUSTRE_MSG_MAGIC_V1 to LUSTRE_MSG_MAGIC_V2 had the client to connect to the server with the V1 protoco

[PATCH 10/41] staging: lustre: libcfs: shortcut to create CPT from NUMA topology

2016-10-02 Thread James Simmons
From: Liang Zhen If user wants to create CPT table that can match numa topology, she has to query cpu & numa topology, then provide a pattern string to describe the topology, this is inconvenient. To improve it, this patch can support shortcut expression "N" or "n" to create CPT table from NUMA

[PATCH 19/41] staging: lustre: ptlrpc: dont take unwrap in req_waittime calculation

2016-10-02 Thread James Simmons
From: Sebastien Buisson Do not take unwrap time in req_waittime calculation on client part as decryption is not related to request service time. Signed-off-by: Sebastien Buisson Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6356 Reviewed-on: http://review.whamcloud.com/14404 Reviewed-by:

[PATCH 12/41] staging: lustre: clio: get rid of lov_stripe_md reference

2016-10-02 Thread James Simmons
From: Bobi Jam Get rid of lov_stripe_md reference in setting file's stripe info. Signed-off-by: Bobi Jam Signed-off-by: Jinshan Xiong Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5823 Reviewed-on: http://review.whamcloud.com/12639 Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin

[PATCH 00/41] missing patches for lustre 2.7.50 to 2.7.55

2016-10-02 Thread James Simmons
Another batch of cleanups and fixes missing up to Lustre version 2.7.55. Alex Zhuravlev (1): staging: lustre: echo: request pages in batches Andreas Dilger (1): staging: lustre: ptlrpc: remove old protocol compatibility Bobi Jam (3): staging: lustre: llite: remove duplicate fiemap defines

[PATCH 02/41] staging: lustre: obdclass: Add synchro in lu_context_key_degister()

2016-10-02 Thread James Simmons
From: Patrick Valentin When unloading a module, it may happen that lu_context_key_degister() removes a key while a thread is either registering it in a new context (lu_context_init(), lu_context_refill()), or using it when exiting from a context (lu_context__exit(), lu_context__fini()). In these

[PATCH 01/41] staging: lustre: obdclass: fix race during key quiescency

2016-10-02 Thread James Simmons
From: Bruno Faccini Upon umount, presumably of last device using same OSD back-end, to prepare for module unload, lu_context_key_quiesce() is run to remove all module's key reference in any context linked on lu_context_remembered list. Threads must protect against such transversal processing when

[PATCH] staging: lustre: ko2iblbd: handle ib_dereg_mr removal

2016-10-02 Thread James Simmons
In the rdma-next tree to be merged for 4.9-rc1 removes the IB core function ib_get_dma_mr. This patch migrates us way from this former function. Signed-off-by: James Simmons --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 19 --- .../staging/lustre/lnet/klnds/o2iblnd/o

[PATCH 4/4] staging: ks7010: fix checkpatch "space after #ifdef" error

2016-10-02 Thread Philipp Hoefflin
Fix checkpatch "ERROR: exactly one space required after that #ifdef" error in ks_hostif.c. Signed-off-by: Philipp Hoefflin --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_ho

[PATCH 3/4] staging: ks7010: reformat makro ps_confirm_wait_inc()

2016-10-02 Thread Philipp Hoefflin
Reformat the makro ps_confirm_wait_inc() to fix several checkpatch errors and warnings: - ERROR: space required before the open brace '{' - ERROR: space required before the open parenthesis '(' - ERROR: code indent should use tabs where possible - ERROR: space required after that close brac

[PATCH 1/4] staging: ks7010: fix "prohibited space" errors reported by checkpatch

2016-10-02 Thread Philipp Hoefflin
Fix all occurences of the following checkpatch errors in ks_hostif.c: - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Philipp Hoefflin --- drivers/staging

[PATCH 2/4] staging: ks7010: use tabs for indentation

2016-10-02 Thread Philipp Hoefflin
Fix all occurences of checkpatch "ERROR: code indent should use tabs where possible" errors in ks_hostif.c. Signed-off-by: Philipp Hoefflin --- drivers/staging/ks7010/ks_hostif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drive

[PATCH] Staging: rtl8188eu: fix code indention error and block comments found by checkpatch.

2016-10-02 Thread victor carvajal
ERROR: code indent should use tabs where possible +^I^Iuint in_len, uint initial_out_len);$ WARNING: Block comments use * on subsequent lines Signed-off-by: victor carvajal --- drivers/staging/rtl8188eu/include/rtw_mlme.h | 24 1 file changed, 12 insertions(+),

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: printk() should include KERN_ facility level > > Signed-off-by: Edward Lipinsky > --- > drivers/staging/sm750fb/ddk750_help.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 2/2] staging: wlan-ng: fix block comment

2016-10-02 Thread Greg KH
On Mon, Oct 03, 2016 at 12:41:04AM +0900, Hisao Tanabe wrote: > This patch fix the coding style problem of block comment detected by the > checkpach.pl. > > WARNING: Block comments use a trailing */ on a separate line > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Hisao Ta

Re: [PATCH 1/2] staging: wlan-ng: fix line over 80 characters

2016-10-02 Thread Greg KH
On Mon, Oct 03, 2016 at 12:41:03AM +0900, Hisao Tanabe wrote: > Fix checkpatch warning "line over 80 characters" to conform to linux > kernel coding style. > > Signed-off-by: Hisao Tanabe > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH] staging: sm750fb: Fix printk() style warning

2016-10-02 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Edward Lipinsky --- drivers/staging/sm750fb/ddk750_help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-10-02 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, Oct 02, 2016 at 10:

Re: [PATCH 00/87] Fix some style warnings in hfa384x.h

2016-10-02 Thread Sergio Paracuellos
El 2016年10月02日 a las 17:07, Greg KH escribió: On Wed, Sep 28, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote: This patch series fix some warnings reported by checkpatch.pl script in hfa384x.h: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-10-02 Thread Nadim Almas
So my first patch is correct? On Sun, Oct 2, 2016 at 9:39 PM, Greg KH wrote: > On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote: >> sir i am new in linux kernel hacking so I just want to start with >> something very simple ,so for sake of simplicity and learning I fixed >> only one of

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 09:37:17PM +0530, Shyam Saini wrote: > On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote: > > On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > > > > > > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > > > > > > > On Wed, Sep 28, 2016 at 08:58:51PM +0530,

Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote: > sir i am new in linux kernel hacking so I just want to start with > something very simple ,so for sake of simplicity and learning I fixed > only one of these warning That's great, but next time try to do a little bit more, just fixing

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

2016-10-02 Thread Shyam Saini
On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > > > > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > > > > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > > > > > > > > > Remove the explicit NULL co

Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-10-02 Thread Nadim Almas
sir i am new in linux kernel hacking so I just want to start with something very simple ,so for sake of simplicity and learning I fixed only one of these warning ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/

[PATCH v2] Staging: fbtft: Fix bug in fbtft-core

2016-10-02 Thread Ksenija Stanojevic
Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug in fbtft-core where fps is always 0, this is because variable update_time is not assigned correctly. Signed-off-by: Ksenija Stanojevic Fixes: 367e8560e8d7 ("Staging: fbtbt: Replace timespec with ktime_t") --- Changes in v2: - add F

[PATCH 2/2] staging: wlan-ng: fix block comment

2016-10-02 Thread Hisao Tanabe
This patch fix the coding style problem of block comment detected by the checkpach.pl. WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Hisao Tanabe --- drivers/staging/wlan-ng/hfa384x_usb.c | 2209 +---

[PATCH 1/2] staging: wlan-ng: fix line over 80 characters

2016-10-02 Thread Hisao Tanabe
Fix checkpatch warning "line over 80 characters" to conform to linux kernel coding style. Signed-off-by: Hisao Tanabe --- drivers/staging/wlan-ng/hfa384x_usb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > > > Remove the explicit NULL comparison and rewrite in a compact form. > > > > > > Signed-off-by: shyam saini

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-10-02 Thread Greg KH
On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote: > Fixed coding style issue. > > Signed-off-by: Nadim Almas > --- > drivers/staging/dgnc/dgnc_neo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

2016-10-02 Thread Shyam Saini
On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > Remove the explicit NULL comparison and rewrite in a compact form. > > > > Signed-off-by: shyam saini > > --- > >  drivers/staging/android/ion/ion_of.c | 2 +- > >  1 file chan

Re: [PATCH] Staging: fbtft: Fix bug in fbtft-core

2016-10-02 Thread Greg KH
On Sat, Oct 01, 2016 at 11:40:52AM +0200, Ksenija Stanojevic wrote: > Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug > in fbtft-core where fps is always 0, this is because variable > update_time is not assigned correctly. > > Signed-off-by: Ksenija Stanojevic Can you add a "Fix

Re: [PATCH] Staging : fbtft: Removed "line over 80 characters" Warnings

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 02:27:37PM -0700, Joe Perches wrote: > On Thu, 2016-09-29 at 02:01 +0530, Harman Kalra wrote: > > Removed "line over 80 characters" Warnings using checkpatch.pl > [] > > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h > [] > > @@ -402,7 +407,9 @@ s

Re: [PATCH 00/87] Fix some style warnings in hfa384x.h

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote: > This patch series fix some warnings reported by checkpatch.pl script in > hfa384x.h: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments use a trailing */ on a separate line > WARNING: do not add new ty

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form. > > Signed-off-by: shyam saini > --- > drivers/staging/android/ion/ion_of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does not apply to my tree :(

Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 10:21:16PM +0530, shyam saini wrote: > Fixed switch case indentation issue and void function return statement > issue That's two different things in one patch, please break this up into two different patches (which will let me reject one of them, see the archives for why...

Re: [PATCH -next] staging: media: stih-cec: remove unused including

2016-10-02 Thread Greg Kroah-Hartman
On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun > Acked-by: Benjamin Gaignard > --- > drivers/staging/media/st-cec/stih-cec.c | 1 - This file isn't in my tree, maybe it needs to go throu

Re: [PATCH] Staging: sm750fb: Fix block comments

2016-10-02 Thread Greg KH
On Thu, Sep 29, 2016 at 11:26:31AM +0100, Ramiro Oliveira wrote: > Correct the styling of some block comments as reported by checkpatch. > > Signed-off-by: Ramiro Oliveira > --- > drivers/staging/sm750fb/ddk750_swi2c.c | 36 > +- > 1 file changed, 18 insertions(+

Re: [PATCH v3] staging: greybus: Fix a comment coding style issue

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 10:19:31PM +0530, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta > --- > > Changes since v2: > * Wrapped commit comment message at 72 characters. > * Edited word in subject

Re: [staging:staging-testing 1122/1122] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1476:7: error: too many arguments to function 'get_user_pages'

2016-10-02 Thread Greg Kroah-Hartman
On Sun, Oct 02, 2016 at 07:28:05PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 36c3c6ecedac0e96207e9454d77231b5b1857a3f > commit: 36c3c6ecedac0e96207e9454d77231b5b1857a3f [1122/1122] staging: add > bcm270

[staging:staging-testing 1122/1122] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_killable.h:67:0: warning: "mutex_lock_interruptible" redefined

2016-10-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 36c3c6ecedac0e96207e9454d77231b5b1857a3f commit: 36c3c6ecedac0e96207e9454d77231b5b1857a3f [1122/1122] staging: add bcm2708 vchiq driver config: arm-allmodconfig (attached as .config) compiler: arm-l

[staging:staging-testing 1122/1122] drivers/staging/vc04_services//interface/vchiq_arm/vchiq_2835_arm.c:48:25: error: '__glue' declared as function returning a function

2016-10-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 36c3c6ecedac0e96207e9454d77231b5b1857a3f commit: 36c3c6ecedac0e96207e9454d77231b5b1857a3f [1122/1122] staging: add bcm2708 vchiq driver config: arm64-allmodconfig (attached as .config) compiler: aar

[staging:staging-testing 1122/1122] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1476:7: error: too many arguments to function 'get_user_pages'

2016-10-02 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 36c3c6ecedac0e96207e9454d77231b5b1857a3f commit: 36c3c6ecedac0e96207e9454d77231b5b1857a3f [1122/1122] staging: add bcm2708 vchiq driver config: arm-multi_v7_defconfig (attached as .config) compiler:

[PATCH] staging: sm750fb: replace roundedDiv with DIV_ROUND_CLOSEST

2016-10-02 Thread Moshe Green
Replace local implementation of rounded division (roundedDiv macro) with the in-kernel implementation (DIV_ROUND_CLOSEST macro) in ddk750_chip.c Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/

Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c

2016-10-02 Thread Moshe Green
On Sun, Oct 02, 2016 at 11:47:47AM +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > > Rename CamelCased macro roundedDiv to rounded_div. > > > > This issue was found by checkpatch.pl > > > > Signed-off-by: Moshe Green > > --- > > drivers/staging/sm750fb/ddk

Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c

2016-10-02 Thread Greg KH
On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote: > Rename CamelCased macro roundedDiv to rounded_div. > > This issue was found by checkpatch.pl > > Signed-off-by: Moshe Green > --- > drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)