[PATCH] android: binder: use VM_ALLOC to get vm area.

2016-08-31 Thread Ganesh Mahendran
VM_IOREMAP is used to access hardware through a mechanism called I/O mapped memory. Android binder is a IPC machanism which will not access I/O memory. Also VM_IOREMAP has alignment requiement which may not needed in binder. __get_vm_area_node() { ... if (flags & VM_IOREMAP) align

Re: [PATCH v2] android: binder: fix dangling pointer comparison

2016-08-31 Thread Arve Hjønnevåg
On Wed, Aug 31, 2016 at 6:22 AM, Greg Kroah-Hartman wrote: > On Thu, Aug 18, 2016 at 08:00:59PM -0700, Arve Hjønnevåg wrote: >> On Thu, Aug 18, 2016 at 7:30 PM, ZhaoJunmin Zhao(Junmin) >> wrote: >> > >> > >> > 在 2016/8/18 23:23, Greg Kroah-Hartman 写道: >> >> >> >> On Tue, Aug 16, 2016 at 07:44:59P

Re: [PATCH v2 00/11] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Ed Swierk
On 8/31/16 13:57, Aaro Koskinen wrote: > This series implements multiple RX group support that should improve > the networking performance on multi-core OCTEONs. Basically we register > IRQ and NAPI for each group, and ask the HW to select the group for > the incoming packets based on hash. > > Te

Re: [PATCH 2/2] staging: lustre: hide unused variable

2016-08-31 Thread James Simmons
> After a code cleanup, we get a harmless warning about a variable > that is unused when CONFIG_FS_POSIX_ACL is disabled: > > drivers/staging/lustre/lustre/llite/xattr.c: In function > 'll_xattr_get_common': > drivers/staging/lustre/lustre/llite/xattr.c:312:24: error: unused variable > 'lli' [-

Re: [PATCH 1/2] staging: lustre: fix unstable pages tracking

2016-08-31 Thread James Simmons
> A patch to change to page accounting code (in v4.8-rc1) conflicts with > a change to lustre (in staging-next for v4.9), and fortunately gets > detected using a gcc warning: > > In file included from /git/arm-soc/include/linux/mm.h:1001:0, > from /git/arm-soc/include/linux/highm

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Ed Swierk
On 8/31/16 14:20, Aaro Koskinen wrote: > On Wed, Aug 31, 2016 at 09:20:07AM -0700, Ed Swierk wrote: >> Here's my workaround: > > [...] > >> -static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) >> +static int cvm_oct_poll(int group, int budget) >> { >> const int coreid =

[PATCH] staging:ks7010:Fix warning about coding style spacing issue around asterisk in ks_wlan_net.c

2016-08-31 Thread Nicholas Krause
This fixes warning around a asterisk used in ks_wlan_net.c for the define statement used for this driver's transmit queue timeout value as defined by the marco, TX_TIMEOUT. Signed-off-by: Nicholas Krause --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 0/5] constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Constify ethtool_ops structures. --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |2 +- drivers/net/ethernet/synopsys/dwc_eth_qos.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c |2 +- drivers/net/usb/r8152.c |2 +- drivers/staging

[PATCH 2/5] staging: netlogic: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The s

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Wed, Aug 31, 2016 at 09:20:07AM -0700, Ed Swierk wrote: > I'm not using CONFIG_NET_POLL_CONTROLLER either; the problem is in the > normal cvm_oct_napi_poll() path. > > Here's my workaround: [...] > -static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) > +static int cvm_oct_

[PATCH v2 10/11] staging: octeon: set up pknd for all interfaces

2016-08-31 Thread Aaro Koskinen
RX path uses pknd to find the correct device, and we maintain 1:1 port to pknd mapping. However, this is only set for XAUI interfaces (in the arch code). But it should be set for all interface types. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 2 ++ 1 file changed, 2 ins

[PATCH v2 11/11] staging: octeon: prevent poll during rx init

2016-08-31 Thread Aaro Koskinen
Prevent poll before the RX init has been completed. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 4f32fa3..ce1e2a3 100644 --- a/dri

[PATCH v2 05/11] staging: octeon: create a struct for rx group specific data

2016-08-31 Thread Aaro Koskinen
Create a struct for RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 140e8af..65f601

[PATCH v2 09/11] staging: octeon: enable taking multiple rx groups into use

2016-08-31 Thread Aaro Koskinen
Enable taking multiple RX groups into use. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet.c | 49 +-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index

[PATCH v2 00/11] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, This series implements multiple RX group support that should improve the networking performance on multi-core OCTEONs. Basically we register IRQ and NAPI for each group, and ask the HW to select the group for the incoming packets based on hash. Tested on EdgeRouter Lite with a simple forwardi

[PATCH v2 07/11] staging: octeon: move group number into rx group data

2016-08-31 Thread Aaro Koskinen
Move group number into RX group data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 776003c..80d5f2

[PATCH v2 06/11] staging: octeon: move irq into rx group specific data

2016-08-31 Thread Aaro Koskinen
Move IRQ number into RX group specific data. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 65f6013..77

[PATCH v2 08/11] staging: octeon: support enabling multiple rx groups

2016-08-31 Thread Aaro Koskinen
Support enabling multiple RX groups. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 126 ++- drivers/staging/octeon/ethernet.c| 6 +- drivers/staging/octeon/octeon-ethernet.h | 2 +- 3 files changed, 81 insertions(+), 53 deleti

[PATCH v2 01/11] staging: octeon: disable rx interrupts in oct_rx_shutdown

2016-08-31 Thread Aaro Koskinen
Disable RX interrupts in oct_rx_shutdown(). This way we don't need to expose the RX IRQ numbers outside the RX module. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 9 + drivers/staging/octeon/ethernet.c| 9 - 2 files changed, 9 insertions(+), 9 dele

[PATCH v2 04/11] staging: octeon: move common poll code into a separate function

2016-08-31 Thread Aaro Koskinen
Move common poll code into a separate function. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c i

[PATCH v2 03/11] staging: octeon: pass the NAPI instance reference to irq handler

2016-08-31 Thread Aaro Koskinen
Pass the NAPI instance reference to the interrupt handler. This is preparation for having multiple NAPI instances. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.

[PATCH v2 02/11] staging: octeon: use passed interrupt number in the handler

2016-08-31 Thread Aaro Koskinen
Use passed interrupt number in the handler, so we can avoid using the global variable. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/et

Re: [PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
On Wed, 31 Aug 2016, Stephen Hemminger wrote: > On Wed, 31 Aug 2016 09:30:42 +0200 > Julia Lawall wrote: > > > Constify ethtool_ops structures. > > > > --- > > > > drivers/net/ethernet/agere/et131x.c |2 +- > > drivers/net/ethernet/broadcom/bcmsysport.c |2 +- > > dr

Re: [PATCH] drivers: staging: rtl823au: hal: Remove pointless test

2016-08-31 Thread Matthias Beyer
Pinging here as nobody responded yet. Maybe this was overlooked. On 23-08-2016 21:44:16, Matthias Beyer wrote: > As reported by David Binderman, this test is useless as of > > if (a < 3) { > /* ... */ > } else if (a >= 3) { > /* ... */ > } > > so this patch removes t

RE: [PATCH 1/2] Drivers: hv: utils: Continue to poll VSS channel after handling requests.

2016-08-31 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, August 31, 2016 4:16 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

RE: [PATCH 1/1] Drivers: hv: Introduce a policy for controlling channel affinity

2016-08-31 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, August 31, 2016 4:14 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

RE: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

2016-08-31 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, August 31, 2016 4:13 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread David Daney
On 08/31/2016 08:06 AM, Aaro Koskinen wrote: Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: This series implements multiple RX group support that should improve the networking performance on multi-core OCTEONs. Basically w

Re: [PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Wed, 31 Aug 2016 09:30:42 +0200 > Constify ethtool_ops structures. Patches 2-6 applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Ed Swierk
Aaro Koskinen wrote: > Oops, looks like I tested without CONFIG_NET_POLL_CONTROLLER enabled > and that seems to be broken. Sorry. I'm not using CONFIG_NET_POLL_CONTROLLER either; the problem is in the normal cvm_oct_napi_poll() path. Here's my workaround: --- a/drivers/staging/octeon/ethernet-rx

Re: [PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread Stephen Hemminger
On Wed, 31 Aug 2016 09:30:42 +0200 Julia Lawall wrote: > Constify ethtool_ops structures. > > --- > > drivers/net/ethernet/agere/et131x.c |2 +- > drivers/net/ethernet/broadcom/bcmsysport.c |2 +- > drivers/net/ethernet/broadcom/genet/bcmgenet.c |2 +- > driver

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > > IRQ and NAPI for each gr

[PATCH] [media] s5p_cec: Fix memory allocation failure check

2016-08-31 Thread Christophe JAILLET
It is likely that checking the result of the memory allocation just above is expected here. Signed-off-by: Christophe JAILLET --- drivers/staging/media/s5p-cec/s5p_cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c b/drivers/staging

Re: [PATCH v2] android: binder: fix dangling pointer comparison

2016-08-31 Thread Greg Kroah-Hartman
On Thu, Aug 18, 2016 at 08:00:59PM -0700, Arve Hjønnevåg wrote: > On Thu, Aug 18, 2016 at 7:30 PM, ZhaoJunmin Zhao(Junmin) > wrote: > > > > > > 在 2016/8/18 23:23, Greg Kroah-Hartman 写道: > >> > >> On Tue, Aug 16, 2016 at 07:44:59PM -0700, Arve Hjønnevåg wrote: > >>> > >>> On Mon, Aug 15, 2016 at 7:

Re: [PATCH 1/2] Drivers: hv: utils: Continue to poll VSS channel after handling requests.

2016-08-31 Thread Greg KH
On Thu, Aug 18, 2016 at 11:16:54AM -0700, k...@exchange.microsoft.com wrote: > From: Alex Ng > > Multiple VSS_OP_HOT_BACKUP requests may arrive in quick succession, even > though the host only signals once. The driver wass handling the first > request while ignoring the others in the ring buffer.

Re: [PATCH 1/1] Drivers: hv: Introduce a policy for controlling channel affinity

2016-08-31 Thread Greg KH
On Wed, Jul 06, 2016 at 06:02:15PM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > Introduce a mechanism to control how channels will be affinitized. We will > support two policies: > > 1. HV_BALANCED: All performance critical channels will be dstributed > evenly amongst a

Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

2016-08-31 Thread Greg KH
On Wed, Jul 06, 2016 at 05:25:02PM -0700, k...@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > In preparation for doing wrap around mappings for ring buffers cleanup > vmbus_open() function: > - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel > drivers now); >

[PATCH 1/6] staging: slicoss: constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The s

[PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread Julia Lawall
Constify ethtool_ops structures. --- drivers/net/ethernet/agere/et131x.c |2 +- drivers/net/ethernet/broadcom/bcmsysport.c |2 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c |2 +- drivers/net/ethernet/hisilicon/hip04_eth.c |2 +- drivers/net/etherne

Re: [PATCH] staging: i4l: act2000: Fix checkpatch warning

2016-08-31 Thread Greg KH
On Tue, Aug 30, 2016 at 07:04:55PM -0400, Anson Jacob wrote: > Fix checkpatch.pl warning: > braces {} are not necessary for single statement blocks > Missing a blank line after declarations > > Signed-off-by: Anson Jacob > --- > drivers/staging/i4l/act2000/act2000_isa.c | 5 +++-- > 1 file chang