Actually, please do not apply this one, there was a testing error
that made me not noticing there's a bug in this one that insta-crashes
everything on access.
I tested the rest nd the rest are good without this one too.
Sorry about this.
On Aug 23, 2016, at 5:11 PM, Oleg Drokin wrote:
> From:
On 08/23/2016 03:01 PM, Johanna Abrahamsson wrote:
This is a small cleanup of the ion_free_nolock() method. They are in a patchset
because they depend lightly on each other, as in that patch 2 won't apply due
to changes in the context. Since this is my first patchset please let me know
if I am
On 08/23/2016 03:41 PM, Johanna Abrahamsson wrote:
It is not necessary to save the return value of kref_put since it is directly
returned.
Acked-by: Laura Abbott
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 6 +-
1 file changed, 1 insertion(+), 5 deletion
On 08/23/2016 03:42 PM, Johanna Abrahamsson wrote:
Remove the function ion_handle_buffer since it is not used anywhere.
Acked-by: Laura Abbott
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 5 -
drivers/staging/android/ion/ion_priv.h | 2 --
2 files ch
move definitions private to the allocator out of mc-bus.h and into
allocator.c
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 5 +
drivers/staging/fsl-mc/include/mc-bus.h | 5 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/
The mc- prefix on the source files names of some internal components
of the fsl-mc bus driver makes things less clear that they could be.
The string "mc" generally refers to hardware-- the physical DPAA
'management complex'. Names like "mc-allocator.c" have nothing to
with the "MC" hardware per se
Remove the function ion_handle_buffer since it is not used anywhere.
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 5 -
drivers/staging/android/ion/ion_priv.h | 2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/
It is not necessary to save the return value of kref_put since it is directly
returned.
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/i
Instead of relying on mc-sys.h to include misc system headers, have
the source files that need them explicitly do it themselves.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 +
drivers/staging/fsl-mc/bus/mc-io.c | 2 ++
drivers/staging/fsl-mc/bus/mc-sys.c
Over time we've accumulated some includes that are no longer
needed. Remove them.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 2 --
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 2 --
drivers/staging/fsl-mc/include/mc-bus.h
An mc-io is a software abstraction of a dpmcp object (an MC portal).
Routines to create/initialize/reset this portal abstraction were split
between the allocator and mc-sys.c (MC command interface). Move
mc-io/portal related definitions into one source file.
Signed-off-by: Stuart Yoder
---
driv
Move definitions that are private to dprc-driver.c out of the
public mc-bus.h header.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 6 ++
drivers/staging/fsl-mc/include/mc-bus.h | 6 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/s
fsl_mc_get_root_dprc is needed by other components (e.g. vfio) to find
the root dprc
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 5 +++--
drivers/staging/fsl-mc/include/mc.h | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/
There are 3 kinds of headers included in the bus driver components--
misc linux/include files, public bus driver includes, and includes
private to the bus driver.
Cleanup the order and formatting of includes in the bus driver to be
consistent:
#include
#include ../include/[file].h // pub
The definitions in mc-private.h are not strictly speaking
'private', they are bus-related definitions expected to be
referenced by bus driver components as well as system components
(gic, smmu, vfio). Rename mc-private.h to mc-bus.h to more
accurately reflect expected use.
Signed-off-by: Stuart Y
In preparation for moving this driver out of staging a review of the
.h files intended to be public in include/linux/fsl turned up some
needed cleanup. This patch series makes no functional changes to
the driver, but does some restructuring to put public/private
definitions in the right places an
The mc-bus.h header file is intended to be public for system related
drivers that may need to make fsl-mc bus specific calls-- gic its,
smmu, vfio. But, currently it contains definitions private/internal
to the fsl-mc bus itself. Split those definitions out into a new
fsl-mc bus private header.
Move definitions that are private to fsl-mc-bus.c out of the
public mc-bus.h and mc.h headers.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 33 +
drivers/staging/fsl-mc/include/mc-bus.h | 28
drivers/stagin
Remove unneeded and duplicated forward declarations.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/include/mc-bus.h | 4
drivers/staging/fsl-mc/include/mc.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/mc-bus.h
b/drivers/staging/fsl-mc/in
move public bus-related definitions to the proper mc-bus.h header.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/include/mc-bus.h | 16
drivers/staging/fsl-mc/include/mc.h | 16
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/driver
The resource pool init/cleanup functions logically belong in the
allocator. Move them to the allocator and rename to reflect the
move out of the dprc-driver.
Signed-off-by: Stuart Yoder
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 55 ++-
drivers/staging/fsl-mc/bu
It is not neccessary to save the value of ion_handle_validate since it
is only used once.
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android
This is a small cleanup of the ion_free_nolock() method. They are in a patchset
because they depend lightly on each other, as in that patch 2 won't apply due
to changes in the context. Since this is my first patchset please let me know
if I am doing it wrong.
v2: Kept the BUG_ON in ion_free as
The ion_free_nolock() function should not BUG on a handle client mismatch.
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/ion/ion.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 291d5b8..575407d 1
The auto incremented counter is not being used anymore, get rid of it.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel_mgmt.c | 2 --
include/linux/hyperv.h| 3 ---
2 files changed, 5 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index b6c1211..4b4a4
Some tools use bus ids to identify devices and they count on the fact
that these ids are persistent across reboot. This may be not true for
VMBus as we use auto incremented counter from alloc_channel() as such
id. Switch to using if_instance from channel offer, this id is supposed
to be persistent.
Bus ids for VMBus devices in /sys/bus/vmbus/devices/ are not guaranteed
to be persistent across reboot or kernel restart and this causes problems
for some tools. E.g. kexec tools use these ids to identify NIC on kdump.
Fix the issue by using if_instance from channel offer as the unique id
instead o
From: James Simmons
Currently it is not possible to send LNet traffic between
two nodes using infiniband hardware that have different
page sizes for the case when RDMA fragments are used.
When two nodes establish a connection they tell the other
node the maximum number of RDMA fragments they supp
On Tue, Aug 23, 2016 at 02:00:06PM -0700, Laura Abbott wrote:
> It's pretty harsh because the users of Ion need a less than subtle hint
> that something is broken. From experience, warning and leaking memory
> just leads to a system that limps along and warnings that get ignored.
> At long as Ion i
Fix checkpatch.pl warning about "Alignment should match open parenthesis".
---
drivers/staging/android/ion/ion.c | 42 +++
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
inde
From: Alexander Boyko
Assertion was happened for open request when rq_replay is set
to 1.
ASSERTION(mod->mod_open_req->rq_replay == 0)
But this situation is not fatal for client, and could happened
when mdc_close() failed.
The fix allow to free such requests. If mdc_close fail, MDS doesn`t
re
From: "John L. Hammond"
In lustre_fill_super() if lustre_start_mgc() fails then call
lustre_common_put_super() to release a reference on the MGC device
attached to the LSI.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/20851
Intel-bug-id: https://jira.hpdd.intel.com/br
From: "John L. Hammond"
Change the __u64 *cookie parameter of md_ops->set_lock_data() to
const struct lustre_handle *lockh.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/17072
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7403
Reviewed-by: Frank Zago
Reviewed-by
From: Andrew Perepechko
The patch removes find_cbdata callbacks and clear_nlink
from dentry_iput path, since this piece of code makes
a few races possible.
The test case reproduces one of the possible races
described in LU-7925:
1) two hard links are created for the same file
2) the test calls
From: Lokesh Nagappa Jaliminche
ll_find_alias is responsible for getting alias for inode
which can be reused. Directories are assumed to have unique
alias, where in case of non-directories there can be multiple
aliases. In case of lustre there can be two type of aliases
i.e. discon_alias and inva
From: Dmitry Eremin
Remove useless LASSERT(vma->vm_file) because of if it's NULL it
will crash early in file_inode(vma->vm_file).
Signed-off-by: Dmitry Eremin
Reviewed-on: http://review.whamcloud.com/21171
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8372
Reviewed-by: John L. Hammond
Re
From: Yang Sheng
The return value is ignored in client_common_fill_super.
Restore to check it and error out.
Signed-off-by: Yang Sheng
Reviewed-on: http://review.whamcloud.com/21125
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8360
Reviewed-by: Emoly Liu
Reviewed-by: Bob Glossman
Signe
HEre are some more recent Lustre fixes and a cleanup.
Alexander Boyko (1):
staging/lustre/mdc: fix panic at mdc_free_open()
Andrew Perepechko (1):
staging/lustre: avoid clearing i_nlink for inodes in use
Dmitry Eremin (1):
staging/lustre/llite: Fix suspicious dereference of pointer
'vm
On 08/23/2016 11:43 AM, Johanna Abrahamsson wrote:
On Mon, Aug 22, 2016 at 09:58:40AM -0700, Laura Abbott wrote:
The validate and BUG_ON are checking two slightly different things.
The BUG_ON is trying to catch blatantly wrong kernel users while the
validate is designed to catch races.
I still
-next-20160823.orig/drivers/staging/octeon-usb/Kconfig
+++ linux-next-20160823/drivers/staging/octeon-usb/Kconfig
@@ -6,5 +6,5 @@ config OCTEON_USB
Networks' products in the Octeon family.
To compile this driver as a module, choose M here. The module
- will be c
This patch removes the pointless `else if` test.
Signed-off-by: Matthias Beyer
Reported-by: David Binderman
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers/
As reported by David Binderman, this test is useless as of
if (a < 3) {
/* ... */
} else if (a >= 3) {
/* ... */
}
so this patch removes the second check.
Matthias Beyer (1):
drivers: staging: rtl8723au: hal: Remove pointless test
drivers/staging/rtl8723au/hal/rtl
On Mon, Aug 22, 2016 at 09:58:40AM -0700, Laura Abbott wrote:
> The validate and BUG_ON are checking two slightly different things.
> The BUG_ON is trying to catch blatantly wrong kernel users while the
> validate is designed to catch races.
I still think BUG is a fairly harsh way to "catch" blata
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/d
On failure we were jumping to error_out0 where we were trying
sdio_release_host() but at this point of execution we still have not
done sdio_claim_host() and as a result host->claimed can still be 0.
And if host->claimed is 0 then WARN_ON(!host->claimed) will give
a warning.
Moreover, if it is stil
This patch improves code from p80211req_mibset_mibget() function by
taking into account that every
DIDmib_dot11smt_dot11WEPDefaultKeysTable_dot11WEPDefaultKeyX with
X in {0, 1, 2, 3} is a bit mask where the (P80211DID_MASK_ITEM <<
P80211DID_LSB_ITEM) mask aka 0x0x0003f000 mask keeps bits representi
On Tue, Aug 23, 2016 at 03:02:21PM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> drivers/staging/comedi/drivers/dt2811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2811.c
> b/drivers/staging/comedi/drivers/dt2811.c
> index
From: Wei Yongjun
Fixes the following sparse warnings:
drivers/staging/comedi/drivers/dt2811.c:99:20: warning:
symbol 'dt2811_clk_dividers' was not declared. Should it be static?
drivers/staging/comedi/drivers/dt2811.c:103:20: warning:
symbol 'dt2811_clk_multipliers' was not declared. Should i
Its better to use memdup_user which does the same thing which this
code has implemented. Also removed a related warning as we will be
warned if allocation fails.
Suggested-by: Fengguang Wu
Signed-off-by: Sudip Mukherjee
---
v2: removed type change done in v1, and removed a warning.
drivers/st
On Tue, Aug 23, 2016 at 04:28:12PM +0530, Sudip Mukherjee wrote:
> On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote:
> > On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote:
> > > Its better to use memdup_user which does the same thing which this
> > > code has impleme
On Mon, Aug 22, 2016 at 09:19:36PM -0400, Greg KH wrote:
On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote:
drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user
Use memdup_user rather than duplicating its implementation
This is a little bit restricted t
On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote:
> On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote:
> > Its better to use memdup_user which does the same thing which this
> > code has implemented.
> >
> > Suggested-by: Fengguang Wu
> > Signed-off-by: Sudip Mukhe
On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote:
> Its better to use memdup_user which does the same thing which this
> code has implemented.
>
> Suggested-by: Fengguang Wu
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/i4l/icn/icn.c | 16 +---
> 1 file cha
Its better to use memdup_user which does the same thing which this
code has implemented.
Suggested-by: Fengguang Wu
Signed-off-by: Sudip Mukherjee
---
drivers/staging/i4l/icn/icn.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/i4l/icn/icn.
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang
> ---
> drivers/staging/xgifb/vb_setmode.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/xgifb/v
The variable data is assigned but never used in rest code.
Signed-off-by: Ding Xiang
---
drivers/staging/xgifb/vb_setmode.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..71bb9ca 100
On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang
> ---
The subject should have been [Patch v2] not resend.
regards
sudip
___
devel mailing list
de...
The variable data is assigned but never used in rest code.
Signed-off-by: Ding Xiang
---
drivers/staging/xgifb/vb_setmode.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..71bb9ca 100
On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote:
> The variable data is assigned but never used in rest code.
>
> Signed-off-by: Ding Xiang
> ---
Your name in Signed-off-by: and From: doesnot match.
> drivers/staging/xgifb/vb_setmode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff
On Mon, Aug 22, 2016 at 07:27:22PM -0400, Brijesh Singh wrote:
> The driver to communicate with Secure Encrypted Virtualization (SEV)
> firmware running within the AMD secure processor providing a secure key
> management interface for SEV guests.
>
> Signed-off-by: Tom Lendacky
> Signed-off-by: B
The variable data is assigned but never used in rest code.
Signed-off-by: Ding Xiang
---
drivers/staging/xgifb/vb_setmode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4..71bb9ca 100644
--- a/drivers/sta
61 matches
Mail list logo
