On Sat, Aug 13, 2016 at 10:16:24PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue is being used to run deferred work for the android binder.
>
> The "binder_deferred_workqueue" queues only a single work item and hence
> does not require ordering. Also, this workqueue is not being used on a
> m
On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote:
Hi Michal.
> > Perhaps making a specific directory should also walk up
> > any parent directory Makefiles looking for subdir flags.
> >
> > Is that unreasonable? Any suggestions?
> I suggest to do make drivers/staging/lustre/. If building t
> @@ -676,35 +686,63 @@ static void hv_mem_hot_add(unsigned long start,
> unsigned long size,
>
> static void hv_online_page(struct page *pg) {
> - struct list_head *cur;
> struct hv_hotadd_state *has;
> + struct hv_hotadd_gap *gap;
> unsigned long cur_start_pgp;
> unsi
Dne 15.8.2016 v 23:29 Joe Perches napsal(a):
> On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote:
>> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
>>> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
Start to rationalize include paths in source code files.
>> []
>
> > From: wang di
> >
> > Pass in struct md_op_data for ll_get_dir_page function.
> >
> > Signed-off-by: wang di
> > Reviewed-on: http://review.whamcloud.com/7043
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
> > Reviewed-by: John L. Hammond
> > Reviewed-by: Jinshan Xiong
> >
On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
[]
> > diff --git a/drivers/staging/lustre/Makefile
> > b/drivers/staging/lustre/Makefile
[]
> > @@ -1,2 +1,5 @@
On Mon, 2016-08-15 at 14:14 -0700, Joe Perches wrote:
> On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > > Start to rationalize include paths in source code files.
> []
> > > diff --git a/drivers/staging/lustre/Makefil
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
> >
> > Signed-off-by: Joe Perches
> > ---
> > drivers/staging/lustre/Makefile | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/staging/lustre/Ma
On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> Start to rationalize include paths in source code files.
>
> Signed-off-by: Joe Perches
> ---
> drivers/staging/lustre/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/lustre/Makefile b/drivers/st
Make it a bit easier to grep and help a future move out of staging.
Joe Perches (2):
staging: lustre: Add include path to Makefile
staging: lustre: Remove .. paths from '#include "' uses
drivers/staging/lustre/Makefile | 3 +++
drivers/staging/lustre/lnet/klnds/o
From: Vitaly Kuznetsov
Date: Mon, 15 Aug 2016 17:48:38 +0200
> Kernel crash is reported after VF is removed and detached from netvsc
> device. Turns out we have multiple different (but related) issues on the
> VF removal path which I'm trying to address with PATCHes 2-5 of this
> series. PATCH1 i
Make the include paths a bit easier to find and more
compatible to a future move out of the staging tree.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 6 +++---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 8
drivers/sta
Start to rationalize include paths in source code files.
Signed-off-by: Joe Perches
---
drivers/staging/lustre/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
index 95ffe33..9d00237 100644
--- a/drivers/staging/lus
On Mon, Jul 18, 2016 at 05:25:28PM +0200, Christian Gromm wrote:
> The "broken in pipe" handler of the USB-HDM calls most_stop_enqueue() to
> stop the MBO traffic before returning all MBOs back to the Mostcore. As
> the enqueue() call from the Mostcore may run in parallel with the
> most_stop_enqu
From: Stephen Hemminger
This fixes a sparse warning because hyperv_mmio resources
are only used in this one file and should be static.
Signed-off-by: Stephen Hemminger
--- a/drivers/hv/vmbus_drv.c2016-08-05 15:19:55.0 -0700
+++ b/drivers/hv/vmbus_drv.c2016-08-15 10:39:30.436494
On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
> The dgnc_block_til_ready() is only used in dgnc_tty_open().
> The unit data(struct un_t) was stored into tty->driver_data in
> dgnc_tty_open().
> And also tty and un were tested about NULL so these variables doesn't
> need to check fo
On Sat, Jul 23, 2016 at 02:37:04AM -0400, Oleg Drokin wrote:
> From: Al Viro
>
> Signed-off-by: Al Viro
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> b/drivers/stagi
On Mon, 15 Aug 2016 09:11:38 -0700
Kees Cook wrote:
> On Mon, Aug 15, 2016 at 8:41 AM, Stephen Hemminger
> wrote:
> > On Fri, 12 Aug 2016 20:05:27 -0700
> > Kees Cook wrote:
> >
> >> On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger
> >> wrote:
> >> >
> >> > For hardening, the driver stru
On Thu, Jul 21, 2016 at 10:44:12PM -0400, James Simmons wrote:
> From: wang di
>
> Pass in struct md_op_data for ll_get_dir_page function.
>
> Signed-off-by: wang di
> Reviewed-on: http://review.whamcloud.com/7043
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
> Reviewed-by: John L.
On Mon, Aug 15, 2016 at 8:41 AM, Stephen Hemminger
wrote:
> On Fri, 12 Aug 2016 20:05:27 -0700
> Kees Cook wrote:
>
>> On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger
>> wrote:
>> >
>> > For hardening, the driver structure containing function pointers can
>> > be marked read only after initia
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Thursday, August 11, 2016 2:17 AM
>> To: KY Srinivasan
>> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang Zhang
>>
>> Subject: Re: [PATCH 0/2] Drivers: hv:
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Monday, August 15, 2016 11:49 AM
> To: net...@vger.kernel.org
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Haiyang
> Zhang ; KY Srinivasan ;
> Stephen Hemminger
> Subject: [PATCH net v
From: Colin Ian King
The current check for associatedsta being set to -1 to indicate it has
not been found is not working because associatedsta is initialized to
zero and will never be -1. Fix this by initializing it to ~0 and checking
for ~0 instead.
Signed-off-by: Colin Ian King
---
drivers
Bonding driver sets IFF_BONDING on both master (the bonding device) and
slave (the real NIC) devices and in netvsc_netdev_event() we want to skip
master devices only. Currently, there is an uncertainty when a slave
interface is removed: if bonding module comes first in netdev_chain it
clears IFF_BO
Kernel crash is reported after VF is removed and detached from netvsc
device. Turns out we have multiple different (but related) issues on the
VF removal path which I'm trying to address with PATCHes 2-5 of this
series. PATCH1 is required to support the change.
Changes since v1:
- Re-arrange patch
We're not guaranteed to see NETDEV_REGISTER/NETDEV_UNREGISTER notifications
only once per VF but we increase/decrease module refcount unconditionally.
Check vf_netdev to make sure we don't take/release it twice. We presume
that only one VF per netvsc device may exist.
Signed-off-by: Vitaly Kuznets
We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on
VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while
vf_netdev is already NULL and we're trying to inject packets into NULL
net device in netvsc_recv_callback() causing kernel to crash.
Signed-off-by: Vitaly Kuzn
struct netvsc_device is not suitable for storing VF information as this
structure is being destroyed on MTU change / set channel operation (see
rndis_filter_device_remove()). Move all VF related stuff to struct
net_device_context which is persistent.
Signed-off-by: Vitaly Kuznetsov
Acked-by: Haiy
Here is a deadlock scenario:
- netvsc_vf_up() schedules netvsc_notify_peers() work and quits.
- netvsc_vf_down() runs before netvsc_notify_peers() gets executed. As it
is being executed from netdev notifier chain we hold rtnl lock when we
get here.
- we enter while (atomic_read(&net_device_ctx-
On Fri, 12 Aug 2016 20:05:27 -0700
Kees Cook wrote:
> On Fri, Aug 12, 2016 at 4:35 PM, Stephen Hemminger
> wrote:
> >
> > For hardening, the driver structure containing function pointers can
> > be marked read only after initial registration is done.
>
> Yay more __ro_after_init! (Minor nit b
Hi Laura,
On 14 August 2016 at 14:17, Benjamin Gaignard
wrote:
> This series of patches look good for me, thanks for the clean up
>
> Reviewed-by: Benjamin Gaignard
>
> 2016-08-08 18:52 GMT+02:00 Laura Abbott :
>> I never saw any feedback or action on these patches so this is a resend.
>> Probab
On Thu, Jun 16, 2016 at 12:45:33AM +0200, Jann Horn wrote:
> If /dev/binder is opened and the opener process then e.g. calls execve,
> proc->vma_vm_mm will still point to the location of the now-freed
> mm_struct. If the process then calls ioctl(binder_fd, ...), the dangling
> proc->vma_vm_mm point
On Mon, Jun 06, 2016 at 08:34:36AM -0700, Akshay Shipurkar wrote:
> Fixed a coding style issue.
What coding style issue was fixed here?
be specific please.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriv
On Sat, Jun 18, 2016 at 02:12:32PM +0200, Jann Horn wrote:
> On Sat, Jun 18, 2016 at 11:19 AM, ZhaoJunmin Zhao(Junmin)
> wrote:
> > 在 2016/6/16 6:39, Jann Horn 写道:
> >> On Thu, Jun 16, 2016 at 12:31 AM, Arve Hjønnevåg wrote:
> >>> On Wed, Jun 15, 2016 at 3:09 PM, Jann Horn wrote:
> If /dev/
On Sat, Jul 30, 2016 at 03:13:38PM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
I can't take patches without any changelog comments in them :(
Please put the info you put in the 0/1 email in here.
And for a single patch, you never need a 0/1 email.
thanks,
greg k-h
___
On Wed, Aug 10, 2016 at 09:16:12PM +0200, Johanna Abrahamsson wrote:
> This patch fixes the checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Johanna Abrahamsson
> ---
> drivers/staging/android/sw_sync.c | 6 +++---
This file has now moved in the tree :(
On Mon, Aug 01, 2016 at 08:50:27PM +0530, ksourav wrote:
> This is a patch to fix alignment should match open paranthesis
> warning given by checkpatch.pl in files sw_sync.c and sync_debug.c
>
> Signed-off-by: ksourav
I need a "full" name for a signed-off-by line, please.
thanks,
greg k-h
On Thu, May 26, 2016 at 01:31:14PM +0530, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
What coding style issue was fixed?
Be specific please.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
On Sun, May 22, 2016 at 08:37:02PM +0200, Ben Marsh wrote:
> Modify memory allocation style in ion_cma_heap.c in order to silence a
> checkpatch.pl warning
What warning? Be specific please.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproj
On Sun, May 22, 2016 at 10:52:15PM -0500, Jaime Arrocha wrote:
> From: Jaime Arrocha
>
> Fixed checkpatch.pl warning about 'line over 80 characters'.
>
> Signed-off-by: Jaime Arrocha
> ---
> drivers/staging/android/ion/ion.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Someon
On Sun, May 15, 2016 at 06:56:05AM +0530, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
>
> Signed-off-by: Shubham Bansal
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Doesn't apply to the tree :(
___
From: Colin Ian King
A null pointer dereference will occur when skb is null and
skb->dev->name is printed. Replace the skb->dev->name with
plain text "ks_wlan" to fix this.
Signed-off-by: Colin Ian King
---
drivers/staging/ks7010/ks_hostif.c | 6 ++
1 file changed, 2 insertions(+), 4 dele
On Mon, Aug 08, 2016 at 09:52:53AM -0700, Laura Abbott wrote:
> I never saw any feedback or action on these patches so this is a resend.
> Probably hit the window when everyone was busy/traveling.
Yes, sorry about that, the old ones are still in my queue, but I'll take
these now!
greg k-h
___
This patch fixes a minor checkpatch warning:
"WARNING: Prefer 'unsigned int' to bare use of 'unsigned'"
Signed-off-by: Louie Lu
---
drivers/staging/rts5208/rtsx_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
b/drivers/staging/rts5
Stephen Hemminger writes:
> Rather than keeping a pointer, a flag, and reference count, use RCU and
> existing
> device reference count to protect the synthetic to VF relationship.
Thanks! I like the idea. Some nitpicks below ...
>
> One other change is that injected packets must be accounted
45 matches
Mail list logo
