From: Markus Elfring
Date: Wed, 10 Aug 2016 22:33:52 +0200
Three variables will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
It was omitted to
From: Markus Elfring
Date: Wed, 10 Aug 2016 22:10:20 +0200
The local variable "rc" was assigned a zero at one place.
But it was not read within this function. Thus delete it.
Signed-off-by: Markus Elfring
Reviewed-by: Wolfram Sang
---
v2: Rebased on the source files from Linux next-20160809.
From: Markus Elfring
Date: Wed, 10 Aug 2016 21:56:15 +0200
Prefer usage of the macro "pr_err" over the interface "printk".
Fix a typo in an error message.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
drivers/staging/ks7010/ks7010_sdio.c | 7 +++--
From: Markus Elfring
Date: Wed, 10 Aug 2016 20:45:11 +0200
Add a definition for the macro "pr_fmt" so that its information can be used
for consistent message output.
Suggested-by: Joe Perches
Signed-off-by: Markus Elfring
---
v2: Addition from source code review
drivers/staging/ks7010/ks7010
From: Markus Elfring
Date: Wed, 10 Aug 2016 19:57:01 +0200
Do not use curly brackets at some source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
Touched less source code places.
driv
From: Markus Elfring
Date: Wed, 10 Aug 2016 18:56:31 +0200
A few return values can also be directly used for condition checks.
Thus remove a local variable for intermediate assignments.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
Touched less
From: Markus Elfring
Date: Wed, 10 Aug 2016 17:57:50 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
Touched four source code places less.
drivers/staging/ks7010/ks7010_s
From: Markus Elfring
Date: Wed, 10 Aug 2016 17:34:12 +0200
Return directly after a memory allocation failed at the beginning.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
drivers/staging/ks7010/ks7010_sdio.c | 19 +++
1 file chang
From: Markus Elfring
Date: Wed, 10 Aug 2016 17:26:01 +0200
A few variables were assigned a null pointer despite of the detail
that they were immediately reassigned by the following statement.
Thus remove such unnecessary assignments.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source f
From: Markus Elfring
Date: Wed, 10 Aug 2016 17:15:15 +0200
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/st
From: Markus Elfring
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (10):
Delete unnecessary checks before the function call "kfree"
Delete unnecessary assignments for buffer variables
Return directly after a fa
On Mon, Aug 08, 2016 at 10:49:34AM -0700, Laura Abbott wrote:
> +/*
> + * Make an area consistent for devices.
> + * Note: Drivers should NOT use this function directly, as it will break
> + * platforms with CONFIG_DMABOUNCE.
> + * Use the driver DMA support - see dma-mapping.h (dma_sync_*)
> + */
After introducing generic strltolower() and strtolower(), spk_strlwr()
is no longer needed.
Signed-off-by: Markus Mayer
Acked-by: Samuel Thibault
Acked-by: Chris Brannon
---
drivers/staging/speakup/kobjects.c| 3 +--
drivers/staging/speakup/main.c| 3 ++-
drivers/staging/speakup/
Add a collection of generic functions to convert strings to lowercase
or uppercase.
Changing the case of a string (with or without copying it first) seems
to be a recurring requirement in the kernel that is currently being
solved by several duplicated implementations doing the same thing. This
cha
This series introduces a family of generic string case conversion
functions. This kind of functionality is needed in several places in
the kernel. Right now, everybody seems to be implementing their own
copy of this functionality.
Based on the discussion of the previous version of this series[1] a
On Tue 2016-08-09 08:04:54, Daniel Vetter wrote:
> On Sun, Jul 24, 2016 at 05:00:31PM +0200, Pavel Machek wrote:
> > On Mon 2016-08-08 16:08:12, Gustavo Padovan wrote:
> > > 2016-08-07 Pavel Machek :
> > >
> > > > On Sun 2016-07-24 15:21:11, Greg Kroah-Hartman wrote:
> > > > > On Mon, Jul 18, 2016
>> Please and and use pr_fmt
>
> Can't we use dev_* on the SDIO device?
How should a connection be constructed from the data structure "sdio_device_id"
to the corresponding device information for such an use case?
Regards,
Markus
___
devel mailing list
This patch fixes the checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Johanna Abrahamsson
---
drivers/staging/android/sw_sync.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/androi
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, August 9, 2016 1:46 AM
> To: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org; Haiyang Zhang ;
> KY Srinivasan
> Subject: [PATCH 0/2] Drivers: hv: vmbus: make bus ids in sysfs persi
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, August 5, 2016 3:49 AM
> To: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org; Haiyang Zhang ; KY
> Srinivasan ; Alex Ng (LIS)
> Subject: [PATCH 3/4] Drivers: hv: balloon: get rid on o
On Mon 2016-08-08 18:24:17, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> SW_SYNC should never be used by other pieces of the kernel apart from
> sync_debug as it is only a Sync File Validation Framework, so hide any
> info to avoid confuse this with a standard kernel internal API.
> Signed
21 matches
Mail list logo
