On Tue, Jul 26, 2016 at 07:05:37PM -0700, k...@exchange.microsoft.com wrote:
> +/*
> + * Create a char device that can support read/write for passing
> + * the payload.
> + */
That sounds "interesting"...
> +
> +static struct completion ip_event;
> +static bool opened;
> +
> +char hvnd_ip_addr[4]
On Tue, Jul 26, 2016 at 07:05:37PM -0700, k...@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan
>
> This driver is a bridge driver that surfaces a Mellanox device in the Linux
> guest and plugs into
> the "NetworkDirect" RDMA infrastructure on the Windows host. Only a subset of
> the ibve
Hi,
[auto build test WARNING on rdma/master]
[also build test WARNING on v4.7 next-20160726]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/kys-exchange-microsoft-com/Drivers-infiniband-hw
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote:
>> But kobject_put() already checks for NULL, right?
>
> Yes. - Such an input parameter validation is performed by the
> function implementation.
>
>
>> you just submitted another batch about that in other area.
>
> I sent update suggestio
> NAK.
> when you do this, the next statement below breaks:
I wonder about this conclusion.
>> type = kzalloc(sizeof(*type), GFP_NOFS);
>> if (!type)
>> -return rc;
>> +return -ENOMEM;
>>
>> type->typ_dt_ops = kzalloc(sizeof(*type->typ_dt_ops), GFP_NOFS);
>
> But kobject_put() already checks for NULL, right?
Yes. - Such an input parameter validation is performed by the
function implementation.
> you just submitted another batch about that in other area.
I sent update suggestions because of this function property for two
Linux software modules in t
On Jul 26, 2016, at 3:11 PM, Oleg Drokin wrote:
>
> On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote:
>
>> From: Markus Elfring
>> Date: Tue, 26 Jul 2016 14:23:23 +0200
>>
>> Return a constant error code without storing it in the local variable "rc"
>> after a failed memory allocation at
On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 26 Jul 2016 13:40:47 +0200
>
> The kobject_put() function was called in a few cases by the
> class_register_type() function during error handling even if the passed
> data structure element did not contain
From: Markus Elfring
Date: Tue, 26 Jul 2016 19:50:40 +0200
The variable "req" will eventually be set to an appropriate pointer
from a call of the ptlrpc_request_alloc() function.
Thus omit the explicit initialisation which became unnecessary with
a previous update step.
Signed-off-by: Markus Elf
From: Markus Elfring
Date: Tue, 26 Jul 2016 19:40:28 +0200
Move the assignment for the local variable "eof" behind the source code
for memory allocations by this function.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 ++-
1 file changed, 2 insertions(+)
From: Markus Elfring
Date: Tue, 26 Jul 2016 14:23:23 +0200
Return a constant error code without storing it in the local variable "rc"
after a failed memory allocation at the beginning of this function.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/obdclass/genops.c | 3 +--
1
From: Markus Elfring
Date: Tue, 26 Jul 2016 19:29:11 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --gi
On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 26 Jul 2016 14:23:23 +0200
>
> Return a constant error code without storing it in the local variable "rc"
> after a failed memory allocation at the beginning of this function.
>
> Signed-off-by: Markus El
From: Markus Elfring
Date: Tue, 26 Jul 2016 17:56:49 +0200
Delete a check for the local variable "req" which became unnecessary with
the previous update step.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
From: Markus Elfring
Date: Tue, 26 Jul 2016 17:54:24 +0200
Release memory directly after a call of the function
"ptlrpc_request_alloc" failed.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
From: Markus Elfring
Date: Tue, 26 Jul 2016 17:12:51 +0200
Release memory directly after a page allocation failed at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --gi
From: Markus Elfring
Date: Tue, 26 Jul 2016 16:32:31 +0200
Return directly after a memory allocation failed at the beginning.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stag
From: Markus Elfring
Date: Tue, 26 Jul 2016 14:10:55 +0200
The kfree() function was called in up to three cases by the
class_register_type() function during error handling even if
the passed data structure element contained a null pointer.
* Split a condition check for memory allocation failures
From: Markus Elfring
Date: Tue, 26 Jul 2016 13:40:47 +0200
The kobject_put() function was called in a few cases by the
class_register_type() function during error handling even if the passed
data structure element did not contain a pointer for a valid data item.
Adjust jump targets according to
From: Markus Elfring
Date: Tue, 26 Jul 2016 13:00:32 +0200
The kobject_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driv
From: Markus Elfring
Date: Tue, 26 Jul 2016 11:33:43 +0200
The kset_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (12):
ldlm: Delete unnecessary checks before the function call "kset_unregister"
Delete unnecessary checks before the function call "kobject_put"
> On Tue, 2016-07-26 at 12:36 -0400, James Simmons wrote:
> > From: wang di
> >
> > 1. client send create request to the master MDT, which
> > will allocate FIDs and create slaves. for all of slaves.
> >
> > 2. Client needs to revalidate slaves during intent getattr
> > and open request.
>
From: Dexuan Cui
Date: Tue, 26 Jul 2016 07:09:41 +
> I googled "S390 hypervisor socket" but didn't find anything related (I think).
That would be net/iucv/
There's also VMWare's stuff under net/vmw_vsock
It's just absolutely rediculous to make a new hypervisor socket
interface over and ove
On Tue, 2016-07-26 at 12:36 -0400, James Simmons wrote:
> From: wang di
>
> 1. client send create request to the master MDT, which
> will allocate FIDs and create slaves. for all of slaves.
>
> 2. Client needs to revalidate slaves during intent getattr
> and open request.
>
> 3. lmv_stripe
From: wang di
1. client send create request to the master MDT, which
will allocate FIDs and create slaves. for all of slaves.
2. Client needs to revalidate slaves during intent getattr
and open request.
3. lmv_stripe_md will include attributes(size, nlink etc)
from all of stripe, which
On Mon, Jul 25, 2016 at 04:54:00PM +1000, Stephen Rothwell wrote:
> Hi Linus,
>
> I have been using the following patch as a merge resolution in the
> merge of the usb tree for a while now. Greg seems to have missed it
> when asking you to merge his tree ... It now applies cleanly to your
> tree
> From: Michal Kubecek [mailto:mkube...@suse.cz]
> Sent: Tuesday, July 26, 2016 17:57
> ...
> On Tue, Jul 26, 2016 at 07:09:41AM +, Dexuan Cui wrote:
> > ... I don't think Michal
> > Kubecek was suggesting I build my code using the existing AF_VSOCK
> > code(?) I think he was only asking me t
On Tue, Jul 26, 2016 at 07:09:41AM +, Dexuan Cui wrote:
> If you meant https://lkml.org/lkml/2016/7/13/382, I don't think Michal
> Kubecek was suggesting I build my code using the existing AF_VSOCK
> code(?) I think he was only asking me to clarify the way I used to write
> the text to explain
On 25/07/16 23:25, Colin King wrote:
From: Colin Ian King
We need to add parentheses around ternary operations because currently
the expression SDF_READABLE | (it->options[2] == 1) always evaluates to
true, meaning s->subdev_flags is always assigned SDF_DIFF. Putting the
parentheses around the
> I have a lot of other things to work on, of much greater interest (to me.)
This is fine.
Thanks for your feedback.
>>> Personally I see no value in such statistics.
>>
>> Do they indicate any code smells eventually?
>
> I have no idea what you mean, sorry.
How do you think about to take ano
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of Dexuan Cui
> ...
> > From: David Miller [mailto:da...@davemloft.net]
> > ...
> > From: Dexuan Cui
> > Date: Tue, 26 Jul 2016 03:09:16 +
> >
> > > BTW, during the past month, at least 7 other people also review
32 matches
Mail list logo
