> Do you find such a source code transformation useful?
No. I already gave that answer by agreeing to Julia's viewpoint.
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
From: Fan Yong
Since all the LOV_MAGIC_* definitions have the same
postfix values break that value out into its own
definition. With this we can check whether the magic's
postfix match the LOV_MAGIC_MAGIC or not: if yes,
then it is quite possible that the clients has
encountered an newer LOV magi
From: John L. Hammond
Move ioctl definitions and related functions from lustre_dlm.h,
lustre_lib.h, obd.h, to lustre_ioctl.h. Replace the definitions of
retired ioctls with comment.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4961
Reviewed-on: http://revie
From: wang di
Add error handler during inode inialization, so inode will
become bad inode if something bad happens during inode prepare
phase, otherwise the striped directory will not get its layout
and being mis-regarded as normal directory.
Signed-off-by: wang di
Intel-bug-id: https://jira.hp
From: Chris Horn
When determining whether an early reply can be sent the server will
calculate the new deadline based on an offset from the request
arrival time. However, when actually setting the new deadline
the server offsets the current time. This can result in deadlines
being extended more t
From: Vitaly Fertman
Move checks for FAILED, DESTROYED flags under ldlm spinlock,
destroy flock atomically with the check it is not destroyed yet.
Do not put the granted flock into the resource if this is
UNLOCK, TEST, or DEADLOCK'ed flock.
Later a regression for this patch was reported under LU
From: John L. Hammond
Rename request to preq.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4826
Reviewed-on: http://review.whamcloud.com/9863
Reviewed-by: Nathaniel Clark
Reviewed-by: Bob Glossman
Reviewed-by: Oleg Drokin
Signed-off-by: James Simmons
--
From: John L. Hammond
In lmv_getattr_name() don't return a freed request in the error path.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4826
Reviewed-on: http://review.whamcloud.com/9863
Reviewed-by: Nathaniel Clark
Reviewed-by: Bob Glossman
Reviewed-by:
From: Nathaniel Clark
Ensure there aren't invalid pointers hanging around after
ptlrpc_req_finished is called.
Signed-off-by: Nathaniel Clark
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4826
Reviewed-on: http://review.whamcloud.com/9841
Reviewed-by: John L. Hammond
Reviewed-by: Bob Glo
From: Fan Yong
Unify the flow control interfaces for MDC RPC and FLD RPC.
We allow to adjust the maximum inflight RPCs count via /sys
interface.
Signed-off-by: Fan Yong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4687
Reviewed-on: http://review.whamcloud.com/9562
Reviewed-by: Niu Yawei
From: wang di
If remote object is being found in a migrating directory,
it should continue to lookup the object in remote MDT,
instead of return.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4805
Reviewed-on: http://review.whamcloud.com/9806
Reviewed-by: John L. Ha
From: John L. Hammond
Several inline functions return a structure that was passed in.
Their is no need for this so just make these function void.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-on: http://review.whamcloud.com/8641
Reviewed-by: wa
From: Jinshan Xiong
Calculate the end of current stripe correctly when the stripe size
is not power 2.
Signed-off-by: Jinshan Xiong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4860
Reviewed-on: http://review.whamcloud.com/9882
Reviewed-by: Bobi Jam
Reviewed-by: Oleg Drokin
Signed-off-
From: John L. Hammond
Remove the const for the __u64 parameters for inline functions
in lustre_idl.h.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-on: http://review.whamcloud.com/8641
Reviewed-by: wangdi
Reviewed-by: Fan Yong
Reviewed-by: Ol
From: Jinshan Xiong
For a partial page write, it will have to issue a READ RPC firstly
to get a full uptodate page. If another page is already locked by
this thread it can easily cause deadlock.
Signed-off-by: Jinshan Xiong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4873
Reviewed-on: h
From: John L. Hammond
By the time that a struct lmv_user_md reaches lmv_placement_policy()
it has already been converted to little endian. Therefore use the
appropriate macros around accesses to this this field. This issue was
found by rewriting the definition of struct lmv_user_md to use the
__l
From: Ryan Haasken
Since the log file name contains the current time in seconds, dumping
the logs more than once per second causes EEXIST errors to be emitted.
Add a static variable to libcfs_debug_dumplog_internal that records
the time of the last Lustre log dump. If the current time in seconds
From: John L. Hammond
Change the return type of several predicate functions from int to bool.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-on: http://review.whamcloud.com/8641
Reviewed-by: wangdi
Reviewed-by: Fan Yong
Reviewed-by: Oleg Droki
From: Jinshan Xiong
Sometimes the rq_commit_cb of BRW RPC can be called twice if that RPC
has already committed at reply time. This will cause inaccuracy of
unstable pages accounting and then assertion.
Signed-off-by: Jinshan Xiong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3274
Review
From: John L. Hammond
Add a const qualifier wherever possible to the pointer parameters of
the inline helper functions in lustre_idl.h and lustre_fid.h.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-on: http://review.whamcloud.com/8641
Reviewed
From: John L. Hammond
In mdc_ioc_swap_layouts() cancel *any* unused locks with LAYOUT or
XATTR IBITS set on the two files. (This matches the locks acquired in
mdt_swap_layouts(). Previously only locks that conflicted with a CR
LAYOUT lock were cancelled.)
Signed-off-by: John L. Hammond
Intel-bu
From: wang di
1. Clear the client dentry cache before migrating file/directory
to the remote MDT.
2. Do not return stripe information to client, if it did not get
the layout lock.
Signed-off-by: wang di
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4682
Reviewed-on: http://review.w
From: Jian Yu
This patch handles the upgrade situation that old mountdata already
contains comma-separated NIDs. The correct way to fix the original
issue is to parse comma-separated NIDs in lmd_parse().
Signed-off-by: Jian Yu
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4460
Reviewed-o
From: wang di
Add client support to migrate the individual inodes
from one MDT to another MDT, and this functionality
will only migrate inode layout on MDT but not touch
data object on OST.
The directory will be migrated from top to the bottom,
i.e. migrating parent first, then migrating the chi
From: wang di
Add delete striped directory, it includes
1. enable sync log between MDTs, so slave objects will
be delete by unlink log, which is similar as deleting ost
object.
2. retrieve layout information of striped directory on MDT,
then lock all of the slave objects before unlink.
From: Fan Yong
This enables the client to inject an error by altering
the parent FID in order to test if the server side file
system checker behaves properly.
Signed-off-by: Fan Yong
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3951
Reviewed-on: http://review.whamcloud.com/7667
Reviewed-
From: Dmitry Eremin
'plock.cookie' might be used uninitialized in this function.
sscanf format specification '%d' expects type 'int *' for 'd',
but parameter 3 has a different type '__u32*'
Signed-off-by: Dmitry Eremin
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-on: http:
From: wang di
Fix "lfs getdirstripe", so it can show layout information
of striped directory
[root@testnode tests]# ../utils/lfs getdirstripe /mnt/lustre/test1
/mnt/lustre/test1
lmv_stripe_count: 2
lmv_stripe_offset: 0
mdtidx FID[seq:oid:ver]
0 [0x28400:0x1:0
From: Fan Yong
There was no protection when inc/dec lu_device_type::ldt_device_nr,
which may caused the ldt_device_nr to be wrong and trigger assert.
This patch redefine lu_device_type::ldt_device_nr as atomic type.
There was no protection when add/del lu_device_type::ldt_linkage
into/from the g
From: wang di
1. client send create request to the master MDT, which
will allocate FIDs and create slaves. for all of slaves.
2. Client needs to revalidate slaves during intent getattr
and open request.
3. lmv_stripe_md will include attributes(size, nlink etc)
from all of stripe, which
From: wang di
Use lmv_free_memmd for proper cleanup instead of
the generic obd_free_memmd.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas
From: wang di
The lmv_[un]pack_md function are used to calculate the
size of the data used to represent the LMV striping data.
The original code was straight forward in its calculate
with lmv_get_easize since only one type of data format
could exist. We want to be able to support different
versio
From: wang di
Add a inode parameter to ll_release_page. This will be
used in the future.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas D
From: wang di
Remove comment about fixing swabbing that is not needed.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Reviewed-by
From: wang di
Completely replace lmv_get_easize with lmv_mds_md_size.
With this change we can delete lmv_get_easize.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan X
From: wang di
The MAX_HASH_* macros already exist in obd.h. Remove
the duplicated defines in lustre_idl.h.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Revi
From: wang di
Increase the post-work for the statahead thread in the readdir
case since it can become very busy.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilg
From: wang di
Pass in struct md_op_data for ll_get_dir_page function.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Reviewed-by:
From: wang di
The function lmv_get_mea() is not used so remove it.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Reviewed-by: Ol
From: wang di
Invert the done flag test to reduce the code indentation.
If done is true release the page and break out of the
while loop.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
From: wang di
If the operation is IT_READDIR don't need to handle the
mdc RPC lock.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
From: wang di
Some cases we want to preserve the ctx->pos value or use
a different value altogther. So allow the passing in of
a position offset to ll_dir_read.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewe
From: wang di
Change the 3rd parameter remove to a bool for ll_release_page
function.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilg
From: wang di
Group function prototypes together related to dir.c. Move
ll_release_page to be with function declarations.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jins
From: wang di
We have if (1) conditionals which is pointless so remove
it and the next code block is never called so remove that
as well.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
R
From: wang di
The variable next needs only to be set when done is false.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
Signed-off
From: wang di
Change the done flag from integer to bool.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
Signed-off-by: James Simmo
From: wang di
Make some of the error reporting more clear for the statahead
thread startup and is_first_dirent() function.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jin
From: wang di
Add struct md_op_data as a parameter to ll_dir_read.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Reviewed-by: Ol
From: wang di
The readdir operations lock was incomplete. This
patch fills in the missing pieces.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by:
From: wang di
The variables api32 and hash64 was renamed to is_api32 and
is_hash64.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
From: wang di
Instead of making a large chunk of code conditional
based on if a page is valid we reverse the page
validity test and exit the loop if the page is invalid
instead. This allows a section of code to reduce its
indentation one level.
Signed-off-by: wang di
Reviewed-on: http://review.
From: wang di
Cache directory striping information that the clients receive
from the metadata servers.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed
From: wang di
Remove the wiretest check for this data structure.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg
From: wang di
Add new flags for metadata handling. These flags are
related to DNE2 handling.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andre
Here is the next batch of fixes and cleanups that went into
Lustre from versions 2.5.56 up to 2.5.58. Besides those changes
the patches for LU-3531/LU-4906 were broken into several smaller
patches as required for the staging tree. The rest of the patches
here are minor fixes and some removal of dea
From: wang di
We report the inode size but never print in the debug
message that the number reported is the size.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xion
From: wang di
Newer lustre version on metadata servers support different
version of lmv magic. This add the new data structures
to handle these new lmv magic versions.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
R
From: wang di
Rename struct lmv_stripe_md in struct lustre_md from mea
to lmv.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/7043
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3531
Reviewed-by: John L. Hammond
Reviewed-by: Jinshan Xiong
Reviewed-by: Andreas Dilger
Rev
From: wang di
Remove debug message and struct ll_inode_info.
Signed-off-by: wang di
Reviewed-on: http://review.whamcloud.com/10761
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4906
Reviewed-by: John L. Hammond
Reviewed-by: Andreas Dilger
Reviewed-by: Oleg Drokin
Signed-off-by: James S
Hi
On 2016-07-20, Arnd Bergmann wrote:
> On Wednesday, July 20, 2016 11:33:43 AM CEST Jes Sorensen wrote:
> > Arnd Bergmann writes:
> > > On Wednesday, July 20, 2016 7:25:19 AM CEST Jes Sorensen wrote:
> > >> Arnd Bergmann writes:
[...]
> Yes, I was just agreeing here that it's not worth doi
>> Can you follow expectations around the proposed refactoring of any
>> function implementations?
>
> I don't understand both questions. Maybe you need to give examples?
I suggest to try the following script (semantic patch for working with
the Coccinelle software) out on the discussed source fi
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326
>
> "#goto labels aren't indented, allow a single space however"
>
> Can't be clearer :-)
Should such information from a comment in this script be also
Hi Markus,
On Thu, 21 Jul 2016 17:37:52 +0200, SF Markus Elfring wrote:
> > That being said... checkpatch does not complain about leading space
> > before labels. Not even with --strict. So why are you mentioning it here?
>
> I remembered a warning like "INDENTED_LABEL" instead.
> https://git.ker
On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote:
> Fixed coding style issue:
> Enclose multiple statements macros definition in a do while loop.
> Use one space around binary operators.
>
> Signed-off-by: Bing Sun
Reviewed-by: Wolfram Sang
_
On Thu, Jul 21, 2016 at 03:35:03PM +0200, SF Markus Elfring wrote:
> > if (atomic_read(&priv->sleepstatus.status) == 0) {
> > rw_data = GCR_B_DOZE;
> > - retval =
> > - ks7010_sdio_write(priv, GCR_B, &rw_data,
> > sizeof(r
> > * Do you really want to assign every return value from a function call
> > to an extra variable before it is used again?
>
> If it's a choice between 1) function call on many lines, 2) function call
> over 80 characters, and 3) extra variable, I definitely prefer the extra
> variable.
+1
> That being said... checkpatch does not complain about leading space
> before labels. Not even with --strict. So why are you mentioning it here?
I remembered a warning like "INDENTED_LABEL" instead.
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d2
The 'break' statement after calling ad5933_cmd only breaks out of the
'for' loop, which then unconditionally sets the return value to -EINVAL.
Move the initialisation of 'ret' so we return the correct value.
Signed-off-by: Phil Turnbull
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 2 +-
彭�L健681357803469024791
劳动者主张入职以来的加班费如何应对
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
yahoo.com可否单独签订试用期协议.xls
Description: Binary data
___
devel mailing list
de...@linuxdriverproject
>> * Do you occasionally care for a refactoring like "Reduce scope of variable"?
>>
>> http://refactoring.com/catalog/reduceScopeOfVariable.html
>
> Probably not. Certainly not in this case.
In which use cases would the suggested change pattern be more interesting
for you?
Regards,
Markus
___
On Thu, 21 Jul 2016, SF Markus Elfring wrote:
> >> @@ -323,14 +323,14 @@ static void tx_device_task(void *dev)
> >> {
> >>struct ks_wlan_private *priv = (struct ks_wlan_private *)dev;
> >>struct tx_device_buffer *sp;
> >> - int rc = 0;
> >>
> >>DPRINTK(4, "\n");
> >>if (cnt_txq
>> @@ -323,14 +323,14 @@ static void tx_device_task(void *dev)
>> {
>> struct ks_wlan_private *priv = (struct ks_wlan_private *)dev;
>> struct tx_device_buffer *sp;
>> -int rc = 0;
>>
>> DPRINTK(4, "\n");
>> if (cnt_txqbody(priv) > 0
>> && atomic_read(&priv->psstat
> if (atomic_read(&priv->sleepstatus.status) == 0) {
> rw_data = GCR_B_DOZE;
> - retval =
> - ks7010_sdio_write(priv, GCR_B, &rw_data, sizeof(rw_data));
> - if (retval) {
> + if (ks7010_sdio_write(priv,
> +
On Thu, 21 Jul 2016, SF Markus Elfring wrote:
> > I think the original code was fine.
>
> I suggest to reconsider involved implementation details once more.
>
>
> > x = blah(); if (x) ... is a perfectly familiar kernel coding pattern.
>
> I can agree to such a general information.
>
>
> > There
> I think the original code was fine.
I suggest to reconsider involved implementation details once more.
> x = blah(); if (x) ... is a perfectly familiar kernel coding pattern.
I can agree to such a general information.
> There is no benefit in terms of performance
It might be possible that
Fix incorrect usage of completion interface by replacing
'wait_for_completion' with 'complete'. This error was introduced
accidentally while replacing semaphores with mutexes.
Reported-by: Jiri Slaby
Signed-off-by: Binoy Jayan
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
1 file changed, 1
> > How do you think about information from the chapter "7: Centralized exiting
> > of functions"?
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle?id=47ef4ad2684d380dd6d596140fb79395115c3950#n389
>
> I'm not impressed by this piece of documentati
On Thu, Jul 21, 2016 at 09:26:33AM +0200, Julia Lawall wrote:
>
>
> On Thu, 21 Jul 2016, Wolfram Sang wrote:
>
> >
> > > >>> if (atomic_read(&priv->sleepstatus.status) == 0) {
> > > >>> rw_data = GCR_B_DOZE;
> > > >>> - retval =
> > > >>> - ks7010_
On Thu, 21 Jul 2016, Wolfram Sang wrote:
>
> > >>> if (atomic_read(&priv->sleepstatus.status) == 0) {
> > >>> rw_data = GCR_B_DOZE;
> > >>> - retval =
> > >>> - ks7010_sdio_write(priv, GCR_B, &rw_data,
> > >>> sizeof(rw_data));
> > >>> -
80 matches
Mail list logo
